Christophe CURISandCarlos R. Mafra 1c1909d5fe wmaker: took as much assignation as possible outside 'if' statements ...

It is generally considered bad practice to place an assignation inside the
expression for an "if" statement because it is often a source of bug,
because of possible typos and because it makes reviewing code more
complicated.

This patch fixes as much cases as possible to make the code easier to read.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>

2015-05-08 18:53:29 +01:00

..

actions.c

wmaker: fix warnings from compiler when animations are disabled

2015-05-08 18:53:29 +01:00

actions.h

added new maximize positions, top and bottom

2013-05-21 11:24:35 +01:00

appicon.c

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

appicon.h

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

application.c

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

application.h

Icon functions moved to appicon.c

2012-06-18 22:25:57 +01:00

appmenu.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

appmenu.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

balloon.c

Renamed "apercu" to "minipreview" in the source code

2014-12-31 11:10:30 +00:00

balloon.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

client.c

wmaker: check return value for XGetWindowAttributes (Coverity #50032)

2015-04-25 07:53:06 -04:00

client.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

colormap.c

wmaker: Cleaned dangerous function prototype usage

2013-05-12 01:01:20 +01:00

colormap.h

New colormap header file and remove unused functions

2012-06-25 23:49:10 +01:00

cycling.c

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

cycling.h

New header file cycling.h

2013-05-26 19:48:00 +01:00

def_pixmaps.h

New titlebar button style

2010-09-11 17:32:57 +02:00

defaults.c

wmaker: remove non-necessary allocation (Coverity #109609)

2015-04-25 07:53:06 -04:00

defaults.h

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

dialog.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

dialog.h

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

dock.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

dock.h

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

dockedapp.c

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

dockedapp.h

Address unprototyped call in dock.c

2012-06-23 12:09:41 +01:00

event.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

event.h

wmaker: Moved function prototype to the appropriate header

2013-06-30 15:10:09 +01:00

extend_pixmaps.h

New titlebar button style

2010-09-11 17:32:57 +02:00

framewin.c

wmaker: removed unused macro DBLCLICK_TIME

2014-12-10 10:19:19 +00:00

framewin.h

Allow setting separate border color for focused windows

2014-05-19 21:37:26 +01:00

geomview.c

Fixed structure declaration syntax

2013-06-10 22:34:59 +01:00

geomview.h

Added missing include guards in a few headers

2013-05-10 19:37:47 +01:00

GNUstep.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

icon.c

Renamed "apercu" to "minipreview" in the source code

2014-12-31 11:10:30 +00:00

icon.h

Renamed "apercu" to "minipreview" in the source code

2014-12-31 11:10:30 +00:00

keybind.h

wmaker: add workspace pager underlying configuration

2014-12-10 10:19:18 +00:00

main.c

WMaker: trivial fixes in text strings

2015-04-28 09:06:33 -04:00

main.h

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

Makefile.am

wmaker: add script to check the call-back function used when loading configuration

2015-05-08 18:53:29 +01:00

menu.c

wmaker: fix incorrect size for memory allocation (Coverity #50207)

2015-04-25 07:53:06 -04:00

menu.h

wmaker: Removed unused argument to function 'wMenuScroll'

2013-11-01 15:27:11 -02:00

misc.c

wmaker: fix warnings from compiler when animations are disabled

2015-05-08 18:53:29 +01:00

misc.h

wmaker: moved the code for the bg helper to a dedicated function

2014-11-23 22:43:37 +00:00

monitor.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

monitor.h

New header file monitor.h

2013-05-26 19:48:00 +01:00

motif.c

configure: Added option to disable Motif WM Hints support

2015-04-18 23:29:37 +01:00

motif.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

moveres.c

wmaker: remove constants HORIZONTAL and VERTICAL from moveres.c

2014-12-10 10:19:19 +00:00

osdep_bsd.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

osdep_darwin.c

funcs.h removed

2013-05-26 19:48:00 +01:00

osdep_linux.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

osdep_stub.c

funcs.h removed

2013-05-26 19:48:00 +01:00

osdep.h

funcs.h removed

2013-05-26 19:48:00 +01:00

pixmap.c

Removed unused WScreen argument in Pixmap function

2013-10-12 15:18:06 +01:00

pixmap.h

Removed unused WScreen argument in Pixmap function

2013-10-12 15:18:06 +01:00

placement.c

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

placement.h

wmaker: Cleaned dangerous function prototype usage

2013-05-12 01:01:20 +01:00

properties.c

wmaker: Moved definition of WMaker-specific XAtoms into the global variables structure

2013-09-30 00:53:10 +02:00

properties.h

Remove unused functions

2012-04-04 19:44:40 +01:00

resources.c

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

resources.h

wmaker: Added 'const' attribute to most global functions

2013-06-16 19:32:23 +01:00

rootmenu.c

wmaker: update error message to have only one string to be translated

2014-11-23 22:43:38 +00:00

rootmenu.h

rootmenu header file updated

2012-06-24 12:30:17 +01:00

screen.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

screen.h

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

session.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

session.h

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

shutdown.c

wmaker: Moved variables for Inotify into the global namespace

2013-10-11 21:58:13 +01:00

shutdown.h

Added missing include guards in a few headers

2013-05-10 19:37:47 +01:00

stacking.c

wmaker: Moved definition of X Contexts into the global variables structure

2013-09-30 00:53:10 +02:00

stacking.h

stacking.h removed white lines

2012-11-19 00:12:46 +01:00

startup.c

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

startup.h

New header file startup.h

2013-05-26 19:48:00 +01:00

superfluous.c

wmaker: superfluous.c possible null pointer dereference

2014-07-27 09:45:03 -06:00

superfluous.h

Real-time dock left-right swapping

2013-04-12 02:14:10 +01:00

switchmenu.c

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

switchmenu.h

New header file switchmenu.h

2013-05-26 19:48:00 +01:00

switchpanel.c

wmaker: removed unused constant SCROLL_STEPS in the switchpanel code

2014-12-10 10:19:19 +00:00

switchpanel.h

Support for same-class cycling in open switchpanel.

2013-05-02 20:41:07 +01:00

texture.c

wmaker: removed case from switch that is unreachable (Coverity #50043)

2014-11-23 22:43:38 +00:00

texture.h

wmaker: Added 'const' attribute to remaining functions

2013-06-16 19:32:23 +01:00

usermenu.c

src/usermenu.c: updated wUserMenuRefreshInstances

2014-05-18 23:00:16 +01:00

usermenu.h

Update local copy of GPLv2 and FSF address in copyrights

2010-10-08 18:13:56 +02:00

wconfig.h.in

configure: Added option to disable animations

2015-05-08 18:53:29 +01:00

wcore.c

wmaker: Moved definition of X Contexts into the global variables structure

2013-09-30 00:53:10 +02:00

wcore.h

Window attributes moved to wCoreCreateTopLevel

2013-03-21 10:01:04 +00:00

wdefaults.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

wdefaults.h

switchpanel: Add skip_switchpanel advanced option

2011-02-17 19:29:15 +01:00

window.c

wmaker: converted macro 'SAME' into a static function

2015-04-25 07:53:06 -04:00

window.h

wmaker: add next and previous window focus functions

2014-11-02 12:50:03 +01:00

WindowMaker.h

wmaker: fix incorrect type for variable in the global preference structure

2015-05-08 18:53:29 +01:00

winmenu.c

wmaker: Restore multi screen functionality by reverting wrong commits

2014-11-02 13:04:14 +01:00

winmenu.h

New header file winmenu.h

2013-05-26 19:48:00 +01:00

winspector.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

winspector.h

Added explicit 'void' to function that takes no argument

2013-05-12 01:01:20 +01:00

wmspec.c

wmaker: rewrote the update of _NET_WORKAREA property

2014-12-16 09:37:48 +00:00

wmspec.h

wmaker: implement EWMH _NET_WORKAREA

2014-08-29 12:43:50 +01:00

workspace.c

wmaker: took as much assignation as possible outside 'if' statements

2015-05-08 18:53:29 +01:00

workspace.h

wmaker: add core workspace pager functions

2014-12-10 10:19:18 +00:00

wsmap.c

wmaker: fix memory leak in the Workspace Map if there is no workspace (Coverity #109608)

2015-04-25 07:53:06 -04:00

wsmap.h

wmaker: moved the variable 'process_workspacemap_event' to the global namespace

2014-12-10 10:19:18 +00:00

xdnd.c

Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

2015-04-18 23:29:37 +01:00

xdnd.h

wmaker: Improve drag-nd-drop support

2014-08-15 01:08:23 +01:00

xinerama.c

wmaker: fix maximizing window in multiple screens env

2014-11-02 13:04:14 +01:00

xinerama.h

AppIcon helper functions.

2012-10-30 15:26:52 +00:00

xmodifier.c

wmaker: add missing source files for translation

2015-01-20 21:29:24 +00:00

xmodifier.h

wmaker: improve key shortcut labelling

2014-11-02 12:50:02 +01:00

xutil.c

wmaker: Added missing const attribute

2013-12-30 18:11:06 +00:00

xutil.h

Added proper legal notice at beginning of header files

2013-05-10 19:37:47 +01:00