thac0/vim
1
0
Fork 0
forked from aniani/vim
Code
17,566 Commits 1 Branch 1,905 Tags
Commit Graph

102 Commits

Author SHA1 Message Date
Yegappan Lakshmanan
f2e30d0c44 patch 9.0.1262: the did_set_string_option function is too long 
Problem:    The did_set_string_option function is too long.
Solution:   Split off functionality to individual functions.  (Yegappan
            Lakshmanan, Lewis Russell, closes #11904)
 2023-01-30 13:04:42 +00:00
Bram Moolenaar
ebfec1c531 patch 9.0.1234: the code style has to be checked manually 
Problem:    The code style has to be checked manually.
Solution:   Add basic code style checks in a test.  Fix or avoid uncovered
            problems.
 2023-01-22 21:14:53 +00:00
Bram Moolenaar
b53a190e9f patch 9.0.0885: informational message has an error message number 
Problem:    Informational message has an error message number.
Solution:   Use a message without an error number. (closes #11530)
 2022-11-15 13:57:38 +00:00
=?UTF-8?q?Bj=C3=B6rn=20Linse?=
91ccbad5de patch 9.0.0738: cannot suppress completion "scanning" messages 
Problem:    Cannot suppress completion "scanning" messages.
Solution:   Add the "C" flag in 'shortmess'. (Bjorn Linse, closes #11354)
 2022-10-13 12:51:13 +01:00
Martin Tournoij
7904fa420e patch 9.0.0657: too many #ifdefs 
Problem:    Too many #ifdefs.
Solution:   Graduate the +cmdwin feature.  Now the tiny and small builds are
            equal, drop the small build.  (Martin Tournoij, closes #11268)
 2022-10-04 16:28:45 +01:00
Bram Moolenaar
0ff01835a4 patch 9.0.0579: using freed memory when 'tagfunc' wipes out buffer 
Problem:    Using freed memory when 'tagfunc' wipes out buffer that holds
            'complete'.
Solution:   Make a copy of the option.  Make sure cursor position is valid.
 2022-09-24 19:20:30 +01:00
bfredl
87af60c915 patch 9.0.0567: 'completeopt' "longest" is not used for complete() 
Problem:    'completeopt' "longest" is not used for complete().
Solution:   Also use "longest" for complete(). (Bjorn Linse, closes #11206)
 2022-09-24 11:17:51 +01:00
Yegappan Lakshmanan
6b085b9d73 patch 9.0.0376: clang warns for dead assignments 
Problem:    Clang warns for dead assignments.
Solution:   Adjust the code. (Yegappan Lakshmanan, closes #11048)
 2022-09-04 12:47:21 +01:00
Bram Moolenaar
d83392a43a patch 9.0.0345: error message for list argument could be clearer 
Problem:    Error message for list argument could be clearer.
Solution:   Include the argument number. (Yegappan Lakshmanan, closes #11027)
 2022-09-01 12:22:46 +01:00
zeertzjq
5fb3aabc2b patch 9.0.0254: typo in function name 
Problem:    Typo in function name.
Solution:   Rename the function. (closes #10971)
 2022-08-24 16:48:23 +01:00
Bram Moolenaar
a6f9e30016 patch 9.0.0102: reading past end of line with insert mode completion 
Problem:    Reading past end of line with insert mode completion.
Solution:   Check text length.
 2022-07-28 21:51:37 +01:00
Bram Moolenaar
d61efa50f8 patch 9.0.0063: too many type casts for dict_get functions 
Problem:    Too many type casts for dict_get functions.
Solution:   Change the key argument from "char_u *" to "char *".
 2022-07-23 09:52:04 +01:00
Bram Moolenaar
b9e717367c patch 9.0.0060: accessing uninitialized memory when completing long line 
Problem:    Accessing uninitialized memory when completing long line.
Solution:   Terminate string with NUL.
 2022-07-23 06:53:08 +01:00
Bram Moolenaar
c7bd2f08e5 patch 9.0.0054: compiler warning for size_t to int conversion 
Problem:    Compiler warning for size_t to int conversion.
Solution:   Add type cast. (Mike Williams, closes #10741)
 2022-07-15 20:45:20 +01:00
Bram Moolenaar
baefde1455 patch 9.0.0046: reading past end of completion with duplicate match 
Problem:    Reading past end of completion with duplicate match.
Solution:   Check string length
 2022-07-07 19:59:49 +01:00
Bram Moolenaar
caea66442d patch 9.0.0045: reading past end of completion with a long line 
Problem:    Reading past end of completion with a long line and 'infercase'
            set.
Solution:   Allocate the string if needed.
 2022-07-07 19:42:04 +01:00
Bram Moolenaar
f12129f171 patch 9.0.0020: with some completion reading past end of string 
Problem:    With some completion reading past end of string.
Solution:   Check the length of the string.
 2022-07-01 19:58:30 +01:00
Bram Moolenaar
93a1096fe4 patch 8.2.5107: some callers of rettv_list_alloc() check for not OK 
Problem:    Some callers of rettv_list_alloc() check for not OK. (Christ van
            Willegen)
Solution:   Use "==" instead of "!=" when checking the return value.
 2022-06-16 11:42:09 +01:00
zeertzjq
cfe456543e patch 8.2.5029: "textlock" is always zero 
Problem:    "textlock" is always zero.
Solution:   Remove "textlock" and rename "textwinlock" to "textlock".
            (closes #10489)
 2022-05-27 17:26:55 +01:00
LemonBoy
9bcb9ca9c7 patch 8.2.5022: 'completefunc'/'omnifunc' error does not end completion 
Problem:    'completefunc'/'omnifunc' error does not end completion.
Solution:   Check if there was an error or exception. (closes #10486,
            closes #4218)
 2022-05-26 15:23:26 +01:00
Bram Moolenaar
8e145b8246 patch 8.2.4993: smart/C/lisp indenting is optional 
Problem:    smart/C/lisp indenting is optional, which makes the code more
            complex, while it only reduces the executable size a bit.
Solution:   Graduate FEAT_CINDENT, FEAT_SMARTINDENT and FEAT_LISP.
 2022-05-21 20:17:31 +01:00
Bram Moolenaar
6ed545e797 patch 8.2.4928: various white space and cosmetic mistakes 
Problem:    Various white space and cosmetic mistakes.
Solution:   Change spaces to tabs, improve comments.
 2022-05-09 20:09:23 +01:00
Bram Moolenaar
249591057b patch 8.2.4911: the mode #defines are not clearly named 
Problem:    The mode #defines are not clearly named.
Solution:   Prepend MODE_.  Renumber them to put the mapped modes first.
 2022-05-07 20:01:16 +01:00
LemonBoy
2bf52dd065 patch 8.2.4723: the ModeChanged autocmd event is inefficient 
Problem:    The ModeChanged autocmd event is inefficient.
Solution:   Avoid allocating memory. (closes #10134)  Rename
            trigger_modechanged() to may_trigger_modechanged().
 2022-04-09 18:17:34 +01:00
Bram Moolenaar
e32c3c462c patch 8.2.4099: Vim9: cannot use Vim9 syntax in mapping 
Problem:    Vim9: cannot use Vim9 syntax in mapping.
Solution:   Add <ScriptCmd> to use the script context for a command.
 2022-01-15 18:26:04 +00:00
Dominique Pelle
748b308eeb patch 8.2.4038: various code not used when features are disabled 
Problem:    Various code not used when features are disabled.
Solution:   Add #ifdefs. (Dominique Pellé, closes #9491)
 2022-01-08 12:41:16 +00:00
Yegappan Lakshmanan
370791465e patch 8.2.4037: Insert mode completion is insufficiently tested 
Problem:    Insert mode completion is insufficiently tested.
Solution:   Add more tests.  Fix uncovered memory leak. (Yegappan Lakshmanan,
            closes #9489)
 2022-01-08 10:38:48 +00:00
Bram Moolenaar
9d00e4a814 patch 8.2.4010: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-05 17:49:15 +00:00
Bram Moolenaar
677658ae49 patch 8.2.4008: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-05 16:09:06 +00:00
Yegappan Lakshmanan
d94fbfc74a patch 8.2.4001: insert complete code uses global variables 
Problem:    Insert complete code uses global variables.
Solution:   Make variables local to the file and use accessor functions.
            (Yegappan Lakshmanan, closes #9470)
 2022-01-04 17:01:44 +00:00
Yegappan Lakshmanan
e982586f8e patch 8.2.3989: some insert completion code is not tested 
Problem:    Some insert completion code is not tested.
Solution:   Add a few tests.  Refactor thesaurus completion. (Yegappan
            Lakshmanan, closes #9460)
 2022-01-03 11:03:48 +00:00
Bram Moolenaar
74409f6279 patch 8.2.3970: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more errors to errors.h.
 2022-01-01 15:58:22 +00:00
Bram Moolenaar
460ae5dfca patch 8.2.3967: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more errors to errors.h.
 2022-01-01 14:19:49 +00:00
Bram Moolenaar
436b5adc97 patch 8.2.3961: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more errors to errors.h.
 2021-12-31 22:49:24 +00:00
Yegappan Lakshmanan
6ad84ab3e4 patch 8.2.3953: insert completion code is too complicated 
Problem:    Insert completion code is too complicated.
Solution:   More refactoring.  Move function arguments into a struct.
            (Yegappan Lakshmanan, closes #9437)
 2021-12-31 12:59:53 +00:00
Yegappan Lakshmanan
5d2e007ccb patch 8.2.3944: insert mode completion functions are too long 
Problem:    Insert mode completion functions are too long.
Solution:   Split up into multiple functions. (Yegappan Lakshmanan,
            closes #9431)
 2021-12-30 11:40:53 +00:00
Bram Moolenaar
8e7cc6b920 patch 8.2.3942: Coverity reports a possible memory leak 
Problem:    Coverity reports a possible memory leak.
Solution:   Free the array if allocation fails.
 2021-12-30 10:32:25 +00:00
Yegappan Lakshmanan
edc6f10390 patch 8.2.3937: Insert mode completion function is too long 
Problem:    Insert mode completion function is too long.
Solution:   Refactor into multiple functions. (Yegappan Lakshmanan,
            closes #9423)
 2021-12-29 17:38:46 +00:00
Bram Moolenaar
4b28ba3245 patch 8.2.3915: illegal memory access when completing with invalid bytes 
Problem:    illegal memory access when completing with invalid bytes.
Solution:   Avoid going over the end of the completion text.
 2021-12-27 19:28:37 +00:00
Bram Moolenaar
bf7ff61af4 patch 8.2.3912: the ins_complete() function is much too long 
Problem:    The ins_complete() function is much too long.
Solution:   Split it up into multiple functions. (Yegappan Lakshmanan,
            closes #9414)
 2021-12-27 12:52:07 +00:00
Yegappan Lakshmanan
6ae8fae869 patch 8.2.3788: lambda for option that is a function may be freed 
Problem:    Lambda for option that is a function may be garbage collected.
Solution:   Set a reference in the funcref. (Yegappan Lakshmanan,
            closes #9330)
 2021-12-12 16:26:44 +00:00
Yegappan Lakshmanan
4dc24eb5ad patch 8.2.3756: might crash when callback is not valid 
Problem:    might crash when callback is not valid.
Solution:   Check for valid callback. (Yegappan Lakshmanan, closes #9293)
 2021-12-07 12:23:57 +00:00
Yegappan Lakshmanan
8658c759f0 patch 8.2.3725: cannot use a lambda for 'completefunc' and 'omnifunc' 
Problem:    Cannot use a lambda for 'completefunc' and 'omnifunc'.
Solution:   Implement lambda support. (Yegappan Lakshmanan, closes #9257)
 2021-12-03 11:09:29 +00:00
Yegappan Lakshmanan
05e59e3a9f patch 8.2.3712: cannot use Vim9 lambda for 'tagfunc' 
Problem:    Cannot use Vim9 lambda for 'tagfunc'.
Solution:   Make it work, add more tests. (Yegappan Lakshmanan, closes #9250)
 2021-12-01 10:30:07 +00:00
Bram Moolenaar
3075a45592 patch 8.2.3609: internal error when ModeChanged is triggered recursively 
Problem:    Internal error when ModeChanged is triggered when v:event is
            already in use.
Solution:   Save and restore v:event if needed.
 2021-11-17 15:51:52 +00:00
=?UTF-8?q?Magnus=20Gro=C3=9F?=
25def2c8b8 patch 8.2.3555: ModeChanged is not triggered on every mode change 
Problem:    ModeChanged is not triggered on every mode change.
Solution:   Also trigger on minor mode changes. (Maguns Gross, closes #8999)
 2021-10-22 18:56:39 +01:00
Bram Moolenaar
f4d8b76d30 patch 8.2.3528: 'thesaurus' and 'thesaurusfunc' do not have the same scope 
Problem:    'thesaurus' and 'thesaurusfunc' do not have the same scope.
Solution:   Make 'thesaurusfunc' global-local.
 2021-10-17 14:13:09 +01:00
Bram Moolenaar
d4c4bfa007 patch 8.2.3525: option variable name does not match option name 
Problem:    Option variable name does not match option name. (Christ van
            Willigen)
Solution:   Rename the variable.
 2021-10-16 21:14:11 +01:00
Yegappan Lakshmanan
160e994d76 patch 8.2.3520: cannot define a function for thesaurus completion 
Problem:    Cannot define a function for thesaurus completion.
Solution:   Add 'thesaurusfunc'. (Yegappan Lakshmanan, closes #8987,
            closes 8950)
 2021-10-16 15:41:29 +01:00
zeertzjq
27fef59dd1 patch 8.2.3465: cannot detect insert scroll mode 
Problem:    Cannot detect insert scroll mode.
Solution:   Add "scroll" to complete_info(). (closes #8943)
 2021-10-03 12:01:27 +01:00