thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity
19,281 Commits 1 Branch 1,905 Tags
f1750ca0c2ef91c6e4857655ca8fdf8dd8f5abb8
Commit Graph

93 Commits

Author SHA1 Message Date
zeertzjq
8ede7a0694 patch 9.1.0218: Unnecessary multiplications in backspace code 
Problem:  Unnecessary multiplications in backspace code, as
          "col / ts * ts" is the same as "col - col % ts".
Solution: Change "col / ts * ts" to "col - col % ts".  Adjust the loop
          and the comments ins_bs() to be easier to understand.  Update
          tests to reset 'smarttab' properly.
          (zeertzjq)

closes: #14308

Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-03-28 10:30:08 +01:00
Luuk van Baal
5a2e3ec9ac patch 9.1.0215: Half-page scrolling does not support smooth-scrolling 
Problem:  Page-wise scrolling with Ctrl-D/Ctrl-U implements
          it's own logic to change the topline and cursor.
          More logic than necessary for scrolling with Ctrl-F/Ctrl-B
          was removed in patch 9.1.0211.
Solution: Re-use the logic from Ctrl-E/Ctrl-Y/Ctrl-F/Ctrl-B while
          staying backward compatible as much as possible.
          Restore some of the logic that determined how many lines will
          be scrolled (Luuk van Baal)

closes: #14316

Signed-off-by: Luuk van Baal <luukvbaal@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-03-28 10:10:40 +01:00
Luuk van Baal
b9f5b95b7b patch 9.1.0211: page-wise scrolling does not support smooth-scrolling 
Problem:  Page-wise scrolling with Ctrl-F/Ctrl-B implements
          it's own logic to change the topline and cursor.
          In doing so, skipcol is not handled properly for
          'smoothscroll', and virtual lines.
Solution: Re-use the logic from Ctrl-E/Ctrl-Y while staying
          backward compatible as much as possible.

closes: #14268

Signed-off-by: Luuk van Baal <luukvbaal@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-03-26 18:53:24 +01:00
zeertzjq
0185c77014 patch 9.1.0204: Backspace inserts spaces with virtual text and 'smarttab' 
Problem:  Backspace inserts spaces with virtual text and 'smarttab'.
Solution: Ignore virtual text and wrapping when backspacing.
          (zeertzjq)

related: neovim/neovim#28005
closes: #14296

Co-authored-by: VanaIgr <vanaigranov@gmail.com>
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-03-25 16:34:51 +01:00
altermo
7d711fe209 patch 9.1.0035: i_CTRL-] triggers InsertCharPre 
Problem:  i_CTRL-] triggers InsertCharPre
Solution: Return if CTRL-] is received. InsertCharPre
          is supposed to be only used for chars to be inserted
          but i_CTRL-] triggers expansion and is not inserted
          into the buffer (altermo)

closes: #13853
closes: #13864

Signed-off-by: altermo
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-01-16 17:25:17 +01:00
Christian Brabandt
ee17b6f70d patch 9.0.1886: Various Typos 
Problem:  Various Typos
Solution: Fix Typos

This is a collection of typo related commits.

closes: #12753
closes: #13016

Co-authored-by: Adri Verhoef <a3@a3.xs4all.nl>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Co-authored-by: nuid64 <lvkuzvesov@proton.me>
Co-authored-by: Meng Xiangzhuo <aumo@foxmail.com>
Co-authored-by: Dominique Pellé <dominique.pelle@gmail.com>

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-09 11:31:38 +02:00
Bram Moolenaar
c174c2e58c patch 9.0.1428: cursor in wrong position when leaving insert mode 
Problem:    Cursor in wrong position when leaving insert mode.
Solution:   Update the w_valid flags.  Position the cursor also when not
            redrawing. (closes #12137)
 2023-03-25 20:06:49 +00:00
zeertzjq
4f026ea9f1 patch 9.0.1356: cannot cancel "gr" with Esc 
Problem:    Cannot cancel "gr" with Esc.
Solution:   Make "gr<Esc>" do nothing. (closes #12064)
 2023-02-26 14:47:24 +00:00
Bram Moolenaar
d6a4ea3aa0 patch 9.0.1354: "gr CTRL-G" stays in virtual replace mode 
Problem:    "gr CTRL-G" stays in virtual replace mode. (Pierre Ganty)
Solution:   Prepend CTRL-V before control characters. (closes #12045)
 2023-02-25 14:24:44 +00:00
Bram Moolenaar
2824d1ee32 patch 9.0.1347: "gr CTRL-O" stays in Insert mode 
Problem:    "gr CTRL-O" stays in Insert mode. (Pierre Ganty)
Solution:   Do not set restart_edit when "cmdchar" is 'v'. (closes #12045)
 2023-02-23 20:13:04 +00:00
Bram Moolenaar
94722c5107 patch 9.0.1257: code style is not check in test scripts 
Problem:    Code style is not check in test scripts.
Solution:   Add basic code style check for test files.
 2023-01-28 19:19:03 +00:00
zeertzjq
01d4efe2e8 patch 9.0.1243: :setglobal cannot use script-local function for "expr" option 
Problem:    :setglobal cannot use script-local function for "expr" option.
Solution:   Use the pointer to the option value properly. (closes #11883)
 2023-01-25 15:31:28 +00:00
Bram Moolenaar
14f91765c0 patch 9.0.0532: edit test is flaky when run under valgrind 
Problem:    Edit test is flaky when run under valgrind.
Solution:   Send some text to the terminal to trigger a redraw.
 2022-09-21 15:13:52 +01:00
Bram Moolenaar
61abe7d8f8 patch 9.0.0336: tests are flaky because of using a common file name 
Problem:    Tests are flaky because of using a common file name.
Solution:   Rename files and directories to be more unique.
 2022-08-30 21:46:08 +01:00
Bram Moolenaar
3b0d70f4ff patch 9.0.0323: using common name in tests leads to flaky tests 
Problem:    Using common name in tests leads to flaky tests.
Solution:   Rename files and directories to be more specific.
 2022-08-29 22:31:20 +01:00
zeertzjq
c9e8fd6fc7 patch 9.0.0083: ModeChanged event not triggered when leaving cmdline window 
Problem:    ModeChanged event not triggered when leaving the cmdline window.
Solution:   Call may_trigger_modechanged(). (closes #10791)
 2022-07-26 18:12:38 +01:00
Bram Moolenaar
fa4873ccfc patch 9.0.0013: reproducing memory access errors can be difficult 
Problem:    Reproducing memory access errors can be difficult.
Solution:   When testing, copy each line to allocated memory, so that valgrind
            can detect accessing memory before and/or after it.  Fix uncovered
            problems.
 2022-06-30 22:13:59 +01:00
Bram Moolenaar
c5382b667a patch 8.2.5130: edit test for mode message fails when using valgrind 
Problem:    Edit test for mode message fails when using valgrind.
Solution:   Use WaitForAssert().  Run beep test later.
 2022-06-19 15:22:36 +01:00
zeertzjq
cfe456543e patch 8.2.5029: "textlock" is always zero 
Problem:    "textlock" is always zero.
Solution:   Remove "textlock" and rename "textwinlock" to "textlock".
            (closes #10489)
 2022-05-27 17:26:55 +01:00
Bram Moolenaar
8e145b8246 patch 8.2.4993: smart/C/lisp indenting is optional 
Problem:    smart/C/lisp indenting is optional, which makes the code more
            complex, while it only reduces the executable size a bit.
Solution:   Graduate FEAT_CINDENT, FEAT_SMARTINDENT and FEAT_LISP.
 2022-05-21 20:17:31 +01:00
Bram Moolenaar
b370771bff patch 8.2.4922: mouse test fails on MS-Windows 
Problem:    Mouse test fails on MS-Windows.
Solution:   Set 'mousemodel' to "extend".
 2022-05-08 22:49:43 +01:00
Bram Moolenaar
8e8dc9b323 patch 8.2.4916: mouse in Insert mode test fails 
Problem:    Mouse in Insert mode test fails.
Solution:   Fix the text and check relevant positions.
 2022-05-08 20:38:06 +01:00
Christian Brabandt
dfbdadce44 patch 8.2.4876: MS-Windows: Shift-BS results in strange char in powershell 
Problem:    MS-Windows: Shift-BS results in strange character in powershell.
Solution:   Add K_S_BS. (Christian Brabandt, closes #10283, closes #10279)
 2022-05-05 20:46:47 +01:00
zeertzjq
3a56b6d405 patch 8.2.4711: when 'insermode' is set :edit from <Cmd> mapping misbehaves 
Problem:    When 'insermode' is set :edit from <Cmd> mapping misbehaves.
Solution:   Don't set "need_start_insertmode" when already in Insert mode.
            (closes #10116)
 2022-04-08 11:56:14 +01:00
Bram Moolenaar
0b962e5685 patch 8.2.4677: the Athena GUI support is outdated 
Problem:    The Athena GUI support is outdated.
Solution:   Remove the Athena GUI code.
 2022-04-03 18:02:37 +01:00
Bram Moolenaar
424bcae1fb patch 8.2.4273: the EBCDIC support is outdated 
Problem:    The EBCDIC support is outdated.
Solution:   Remove the EBCDIC support.
 2022-01-31 14:59:41 +00:00
zeertzjq
502d8ae3e8 patch 8.2.4203: entering a character with CTRL-V may include modifiers 
Problem:    Entering a character with CTRL-V may include modifiers.
Solution:   Reset "mod_mask" when entering a character with digits after
            CTRL-V. (closes #9610)
 2022-01-24 15:27:50 +00:00
Bram Moolenaar
de05bb2573 patch 8.2.4074: going over the end of NameBuff 
Problem:    Going over the end of NameBuff.
Solution:   Check length when appending a space.
 2022-01-13 13:08:14 +00:00
Yegappan Lakshmanan
e982586f8e patch 8.2.3989: some insert completion code is not tested 
Problem:    Some insert completion code is not tested.
Solution:   Add a few tests.  Refactor thesaurus completion. (Yegappan
            Lakshmanan, closes #9460)
 2022-01-03 11:03:48 +00:00
Yegappan Lakshmanan
8bb65f230d patch 8.2.3900: it is not easy to use a script-local function for an option 
Problem:    It is not easy to use a script-local function for an option.
Solution:   recognize s: and <SID> at the start of the expression. (Yegappan
            Lakshmanan, closes #9401)
 2021-12-26 10:51:39 +00:00
Bram Moolenaar
52797bae17 patch 8.2.3825: various comments could be improved 
Problem:    Various comments could be improved.
Solution:   Improve the comments.
 2021-12-16 14:45:13 +00:00
Dominique Pelle
923dce2b07 patch 8.2.3637: typos in test files 
Problem:    Typos in test files.
Solution:   Correct the typos. (Dominique Pellé, closes #9175)
 2021-11-21 11:36:04 +00:00
Bram Moolenaar
a062006b9d patch 8.2.3610: crash when ModeChanged triggered too early 
Problem:    Crash when ModeChanged triggered too early.
Solution:   Trigger ModeChanged after setting VIsual.
 2021-11-17 16:52:40 +00:00
Bram Moolenaar
3075a45592 patch 8.2.3609: internal error when ModeChanged is triggered recursively 
Problem:    Internal error when ModeChanged is triggered when v:event is
            already in use.
Solution:   Save and restore v:event if needed.
 2021-11-17 15:51:52 +00:00
Dominique Pelle
8753c1dd2c patch 8.2.3568: ctrl-hat test fails with Athena and Motif 
Problem:    Ctrl-hat test fails with Athena and Motif. (Elimar Riesebieter)
Solution:   Run the test only with GTK. (Dominique Pellé, closes #9069)
 2021-10-31 20:19:17 +00:00
Dominique Pelle
9cd063e319 patch 8.2.3567: CTRL-I in Insert mode is not tested 
Problem:    CTRL-I in Insert mode is not tested
Solution:   Add a test case. (Dominique Pellé, closes #8866)
 2021-10-28 21:06:05 +01:00
=?UTF-8?q?Magnus=20Gro=C3=9F?=
25def2c8b8 patch 8.2.3555: ModeChanged is not triggered on every mode change 
Problem:    ModeChanged is not triggered on every mode change.
Solution:   Also trigger on minor mode changes. (Maguns Gross, closes #8999)
 2021-10-22 18:56:39 +01:00
Bram Moolenaar
f4d8b76d30 patch 8.2.3528: 'thesaurus' and 'thesaurusfunc' do not have the same scope 
Problem:    'thesaurus' and 'thesaurusfunc' do not have the same scope.
Solution:   Make 'thesaurusfunc' global-local.
 2021-10-17 14:13:09 +01:00
Yegappan Lakshmanan
160e994d76 patch 8.2.3520: cannot define a function for thesaurus completion 
Problem:    Cannot define a function for thesaurus completion.
Solution:   Add 'thesaurusfunc'. (Yegappan Lakshmanan, closes #8987,
            closes 8950)
 2021-10-16 15:41:29 +01:00
Bram Moolenaar
72d2fa69e5 patch 8.2.3463: pattern matching with ModeChanged not tested 
Problem:    Pattern matching with ModeChanged not tested.
Solution:   Add a few more test lines. (issue #8856)
 2021-10-02 21:48:15 +01:00
Bram Moolenaar
d85931e673 patch 8.2.3462: ModeChanged only uses one character for new_mode and old_mode 
Problem:    The ModeChanged event only uses one character for the new_mode and
            old_mode values.
Solution:   Pass one as first argument to mode(). (issue #8856)
 2021-10-02 16:55:39 +01:00
=?UTF-8?q?Magnus=20Gro=C3=9F?=
f1e8876fa2 patch 8.2.3430: no generic way to trigger an autocommand on mode change 
Problem:    No generic way to trigger an autocommand on mode change.
Solution:   Add the ModeChanged autocommand event. (Magnus Gross, closes #8856)
 2021-09-12 13:39:55 +02:00
Bram Moolenaar
35a9a00afc patch 8.2.3428: using freed memory when replacing 
Problem:    Using freed memory when replacing. (Dhiraj Mishra)
Solution:   Get the line pointer after calling ins_copychar().
 2021-09-11 21:14:20 +02:00
Yegappan Lakshmanan
5958549760 patch 8.2.2979: not all options code is covered by tests 
Problem:    Not all options code is covered by tests.
Solution:   Add more tests for options. (Yegappan Lakshmanan, closes #8369)
 2021-06-12 13:46:41 +02:00
Bram Moolenaar
1f448d906b patch 8.2.2643: various code not covered by tests 
Problem:    Various code not covered by tests.
Solution:   Add a few more test. (Yegappan Lakshmanan, closes #7995)
 2021-03-22 19:37:06 +01:00
Bram Moolenaar
17709e280a patch 8.2.2623: some tests fail when run as root 
Problem:    Some tests fail when run as root.
Solution:   Use CheckNotRoot.
 2021-03-19 14:38:12 +01:00
Bram Moolenaar
f9a65505d1 patch 8.2.2570: tests fail when run as root 
Problem:    Tests fail when run as root.
Solution:   Add a comment mentioning the expected failure. (issue #7919)
 2021-03-05 20:47:44 +01:00
Bram Moolenaar
a1070eae77 patch 8.2.2534: missing test coverage 
Problem:    Missing test coverage.
Solution:   Improve test coverage for completion with different encodings,
            mapset(), and term function failures. (Dominique Pellé,
            closes #7877)
 2021-02-20 19:21:36 +01:00
Bram Moolenaar
caf73dcfad patch 8.2.1910: reading past the end of the command line 
Problem:    Reading past the end of the command line.
Solution:   Check for NUL. (closes #7204)
 2020-10-26 21:39:13 +01:00
Bram Moolenaar
b53e13a91a patch 8.2.1874: can't do something just before leaving Insert mode 
Problem:    Can't do something just before leaving Insert mode.
Solution:   Add the InsertLeavePre autocommand event. (closes #7177)
 2020-10-21 12:19:53 +02:00