thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity
20,263 Commits 1 Branch 1,905 Tags
7c3f9af0ed5dd7035f8a3fbb2f0bf965a453e359
Commit Graph

39 Commits

Author SHA1 Message Date
zeertzjq
ec54af4e26 patch 9.0.2159: screenpos() may crash with neg. column 
Problem:  screenpos() may crash with neg. column
Solution: validate and correct column

closes: #13669

Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-12-12 16:43:44 +01:00
zeertzjq
b583eda703 patch 9.0.2022: getmousepos() returns wrong index for TAB char 
Problem:  When clicking in the middle of a TAB, getmousepos() returns
          the column of the next char instead of the TAB.
Solution: Break out of the loop when the vcol to find is inside current
          char. Fix invalid memory access when calling virtcol2col() on
          an empty line.

closes: #13321

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-10-14 11:32:28 +02:00
zeertzjq
bfe377b8f2 patch 9.0.1729: screenpos() wrong when w_skipcol and cpoptions+=n 
Problem:    screenpos() wrong result with w_skipcol and cpoptions+=n
Solution:   Use adjust_plines_for_skipcol() instead of subtracting
            w_skipcol.

closes: #12625

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-08-17 22:58:53 +02:00
zeertzjq
825cf813fa patch 9.0.1728: missing winid argument for virtcol() 
Problem: missing winid argument for virtcol()
Solution: Add a {winid} argument to virtcol()

Other functions col(), charcol() and virtcol2col() support a {winid}
argument, so it makes sense for virtcol() to also support than.

Also add test for virtcol2col() with 'showbreak' and {winid}.

closes: #12633

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-08-17 22:55:25 +02:00
Yegappan Lakshmanan
b209b86e66 patch 9.0.1717: virtcol2col returns last byte of a multi-byte char 
Problem: virtcol2col returns last byte of a multi-byte char
Solution: Make it return the first byte for a multi-byte char

closes: #12786
closes: #12799

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
 2023-08-15 23:01:44 +02:00
zeertzjq
55daae3921 patch 9.0.1607: screenpos() returns wrong row with diff filler lines 
Problem:    screenpos() returns wrong row with diff filler lines.
Solution:   Only add filler lines when appropriate.  Also don't add the
            'smoothscroll' marker when w_skipcol is zero. (closes #12485,
            closes #12484)
 2023-06-04 19:29:22 +01:00
zeertzjq
f0e68c0e2a patch 9.0.1600: screenpos() does not take w_skipcol into account 
Problem:    screenpos() does not take w_skipcol into account.
Solution:   Subtract w_skipcol from column. (closes #12486, closes #12476)
 2023-06-03 17:11:47 +01:00
zeertzjq
ba2d191932 patch 9.0.1072: screenpos() column result in fold may be too small 
Problem:    screenpos() column result in fold may be too small.
Solution:   Add space of 'number', sign column, etc. (closes #11715)
 2022-12-18 12:28:59 +00:00
Bram Moolenaar
1cb16c3a20 patch 9.0.1016: screenpos() does not count filler lines for diff mode 
Problem:    screenpos() does not count filler lines for diff mode.
Solution:   Add filler lines. (closes 11658)
 2022-12-05 22:26:44 +00:00
Bram Moolenaar
99d19438ca patch 9.0.1011: ml_get error when using screenpos() 
Problem:    ml_get error when using screenpos().
Solution:   Give an error for the line number. (closes #11661)
 2022-12-05 16:23:24 +00:00
Yegappan Lakshmanan
4c8d2f02b3 patch 9.0.0863: col() and charcol() only work for the current window 
Problem:    col() and charcol() only work for the current window.
Solution:   Add an optional winid argument. (Yegappan Lakshmanan,
            closes #11466, closes #11461)
 2022-11-12 16:07:47 +00:00
Bram Moolenaar
79f234499b patch 9.0.0712: wrong column when calling setcursorcharpos() with zero lnum 
Problem:    Wrong column when calling setcursorcharpos() with zero lnum.
Solution:   Set the line number before calling buf_charidx_to_byteidx().
            (closes #11329)
 2022-10-10 12:42:57 +01:00
Bram Moolenaar
5a6ec10cc8 patch 8.2.5034: there is no way to get the byte index from a virtual column 
Problem:    There is no way to get the byte index from a virtual column.
Solution:   Add virtcol2col(). (Yegappan Lakshmanan, closes #10477,
            closes #10098)
 2022-05-27 21:58:00 +01:00
Bram Moolenaar
3caf1cce2b patch 8.2.4734: getcharpos() may change a mark position 
Problem:    getcharpos() may change a mark position.
Solution:   Copy the mark position. (closes #10148)
 2022-04-11 13:05:16 +01:00
Bram Moolenaar
4556a2e868 patch 8.2.4389: screenpos() does not handle a position in a closed fold 
Problem:    screenpos() does not handle a position in a closed fold.
Solution:   Check if the position is inside a closed fold. (closes #9778)
 2022-02-15 13:40:17 +00:00
Bram Moolenaar
7924a17791 patch 8.2.4204: screenpos() has non-zero row for invisible text 
Problem:    screenpos() has non-zero row for invisible text.
Solution:   Only add the window row when the text is visible. (closes #9618)
 2022-01-24 16:15:15 +00:00
naohiro ono
56200eed62 patch 8.2.3969: value of MAXCOL not available in Vim script 
Problem:    Value of MAXCOL not available in Vim script.
Solution:   Add v:maxcol. (Naohiro Ono, closes #9451)
 2022-01-01 14:59:44 +00:00
Bram Moolenaar
189663bdac patch 8.2.3193: screenpos() is wrong when 'display' is "lastline" 
Problem:    screenpos() is wrong when the last line is partially visible and
            'display' is "lastline".
Solution:   Also compute the position for a partially visible line.
            (closes #8599)
 2021-07-21 18:04:56 +02:00
Bram Moolenaar
9ebcf231bd patch 8.2.2363: curpos() does not accept a string argument as before 
Problem:    curpos() does not accept a string argument as before.
solution:   Make a string argument work again. (Yegappan Lakshmanan,
            closes #7690
 2021-01-16 16:52:49 +01:00
Bram Moolenaar
9145846b6a patch 8.2.2342: "char" functions may return wrong column in Insert mode 
Problem:    "char" functions return the wront column in Insert mode when the
            cursor is beyond the end of the line.
Solution:   Compute the column correctly. (Yegappan Lakshmanan, closes #7669)
 2021-01-13 20:08:38 +01:00
Bram Moolenaar
6f02b00bb0 patch 8.2.2324: not easy to get mark en cursor posotion by character count 
Problem:    Not easy to get mark en cursor posotion by character count.
Solution:   Add functions that use character index. (Yegappan Lakshmanan,
            closes #7648)
 2021-01-10 20:22:54 +01:00
Bram Moolenaar
9a963377b4 patch 8.2.2184: Vim9: no error when using "2" for a line number 
Problem:    Vim9: no error when using "2" for a line number.
Solution:   Give an error message if the line number is invalid. (closes #7492)
 2020-12-21 21:58:46 +01:00
Bram Moolenaar
8dd46e72cf patch 8.2.2152: screenpos() does not include the WinBar offset 
Problem:    screenpos() does not include the WinBar offset.
Solution:   Use W_WINROW() instead of directly using w_window. (closes #7487)
 2020-12-17 21:35:29 +01:00
Bram Moolenaar
bdd2c290d3 patch 8.2.1040: not enough testing for movement commands 
Problem:    Not enough testing for movement commands.
Solution:   Add more tests. (Yegappan Lakshmanan, closes #6313)
 2020-06-22 21:34:30 +02:00
Bram Moolenaar
92b83ccfda patch 8.2.0634: crash with null partial and blob 
Problem:    Crash with null partial and blob.
Solution:   Check for NULL pointer.  Add more tests. (Yegappan Lakshmanan,
            closes #5984)
 2020-04-25 15:24:44 +02:00
Bram Moolenaar
08f4157c5c patch 8.2.0610: some tests are still old style 
Problem:    Some tests are still old style.
Solution:   Convert to new style tests. (Yegappan Lakshmanan, closes #5957)
 2020-04-20 16:50:00 +02:00
Bram Moolenaar
38ba4dce4a patch 8.1.2228: screenpos() returns wrong values when 'number' is set 
Problem:    screenpos() returns wrong values when 'number' is set. (Ben
            Jackson)
Solution:   Compare the column with the window width. (closes #5133)
 2019-10-27 21:39:09 +01:00
Bram Moolenaar
f92e58cadb patch 8.1.2013: more functions can be used as methods 
Problem:    More functions can be used as methods.
Solution:   Make various functions usable as a method.
 2019-09-08 21:51:41 +02:00
Bram Moolenaar
aad222c9c9 patch 8.1.1996: more functions can be used as methods 
Problem:    More functions can be used as methods.
Solution:   Make various functions usable as a method.
 2019-09-06 22:46:09 +02:00
Bram Moolenaar
196b466443 patch 8.1.1993: more functions can be used as methods 
Problem:    More functions can be used as methods.
Solution:   Make various functions usable as a method.
 2019-09-06 21:34:30 +02:00
Bram Moolenaar
1a3a89168d patch 8.1.1915: more functions can be used as methods 
Problem:    More functions can be used as methods.
Solution:   Make various functions usable as a method.
 2019-08-23 22:31:37 +02:00
Bram Moolenaar
b3d17a20d2 patch 8.1.1645: cannot use a popup window for a balloon 
Problem:    Cannot use a popup window for a balloon.
Solution:   Add popup_beval().  Add the "mousemoved" property.  Add the
            screenpos() function.
 2019-07-07 18:28:14 +02:00
Bram Moolenaar
17aca707f9 patch 8.1.1336: some eval functionality is not covered by tests 
Problem:    Some eval functionality is not covered by tests.
Solution:   Add a few more test cases. (Masato Nishihata, closes #4374)
 2019-05-16 22:24:55 +02:00
Bram Moolenaar
177ab9e026 patch 8.1.0754: preferred column is lost when setting 'cursorcolumn' 
Problem:    Preferred column is lost when setting 'cursorcolumn'.
Solution:   Change option flag to P_RWINONLY. (Takayuki Kurosawa,
            closes #3806)
 2019-01-15 21:12:57 +01:00
Bram Moolenaar
37175409d7 patch 8.0.0478: tests use assert_true(0) and assert_false(1) to report errors 
Problem:    Tests use assert_true(0) and assert_false(1) to report errors.
Solution:   Use assert_report().
 2017-03-18 20:18:45 +01:00
Bram Moolenaar
eb992cb90f patch 8.0.0440: not enough test coverage in Insert mode 
Problem:    Not enough test coverage in Insert mode.
Solution:   Add lots of tests.  Add test_override(). (Christian Brabandt,
            closes #1521)
 2017-03-09 18:20:16 +01:00
Bram Moolenaar
8e8df251bf patch 7.4.1844 
Problem:    Using old function name in comment.  More functions should start
            with test_.
Solution:   Rename function in comment. (Higashi Higashi) Rename
            disable_char_avail_for_testing() to test_disable_char_avail().
            And alloc_fail() to test_alloc_fail().
 2016-05-25 21:23:21 +02:00
Bram Moolenaar
2ab375e54e patch 7.4.1300 
Problem:    Cannot test CursorMovedI because there is typeahead.
Solution:   Add disable_char_avail_for_testing().
 2016-02-10 22:23:06 +01:00
Bram Moolenaar
5a46a58eb6 Add missing test file. 2016-01-15 15:56:58 +01:00