zeertzjq
94b7c3233e
patch 9.1.0172: More code can use ml_get_buf_len() instead of STRLEN()
...
Problem: More code can use ml_get_buf_len() instead of STRLEN().
Solution: Change more STRLEN() calls to ml_get_buf_len(). Also do not
set ml_line_textlen in ml_replace_len() if "has_props" is set,
because "len_arg" also includes the size of text properties in
that case. (zeertzjq)
closes : #14183
Signed-off-by: zeertzjq <zeertzjq@outlook.com >
Signed-off-by: Christian Brabandt <cb@256bit.org >
2024-03-12 21:50:32 +01:00
John Marriott
bfcc895482
patch 9.1.0168: too many STRLEN() calls
...
Problem: too many STRLEN() calls
Solution: Make use of ml_get_len() calls instead
(John Marriott)
closes : #14123
Signed-off-by: John Marriott <basilisk@internode.on.net >
Signed-off-by: Christian Brabandt <cb@256bit.org >
2024-03-11 22:04:45 +01:00
zeertzjq
82e079df81
patch 9.1.0163: Calling STRLEN() to compute ml_line_textlen when not needed
...
Problem: Calling STRLEN() to compute ml_line_textlen when not needed.
Solution: Use 0 when STRLEN() will be required and call STRLEN() later.
(zeertzjq)
closes : #14155
Signed-off-by: zeertzjq <zeertzjq@outlook.com >
Signed-off-by: Christian Brabandt <cb@256bit.org >
2024-03-10 08:55:42 +01:00
Christian Brabandt
a72d1be5a9
patch 9.1.0151: ml_get_buf_len() does not consider text properties
...
Problem: ml_get_buf_len() does not consider text properties
(zeertzj)
Solution: Store text length excluding text properties length
in addition in the memline
related #14123
closes : #14133
Signed-off-by: Christian Brabandt <cb@256bit.org >
2024-03-05 20:43:25 +01:00
John Marriott
02d7a6c6cf
patch 9.1.0138: too many STRLEN calls when getting a memline
...
Problem: too many STRLEN calls when getting a memline
Solution: Optimize calls to STRLEN(), add a few functions in memline.c
that return the byte length instead of relying on STRLEN()
(John Marriott)
closes : #14052
Signed-off-by: John Marriott <basilisk@internode.on.net >
Signed-off-by: Christian Brabandt <cb@256bit.org >
2024-02-26 21:25:03 +01:00
Christian Brabandt
19e6c4fd2d
patch 9.0.1669: Crash syncing swapfile in new buffer when using sodium crypt
...
Problem: Crash syncing swapfile in new buffer when using sodium crypt.
(James McCoy)
Solution: Add checks for sodium encryption. (Christian Brabandt,
closes #12591 , closes #12585 )
2023-06-27 18:57:10 +01:00
Christian Brabandt
a2a90d5e20
patch 9.0.1666: compiler may warn for uninitialized variable
...
Problem: Compiler may warn for uninitialized variable.
Solution: Initialize this_props_len. (Christian Brabandt, closes #12599 )
2023-06-26 18:48:09 +01:00
RestorerZ
68ebcee023
patch 9.0.1594: some internal error messages are translated
...
Problem: Some internal error messages are translated.
Solution: Consistently do not translate internal error messages.
(closes #12459 )
2023-05-31 17:12:14 +01:00
Bram Moolenaar
3a2a60ce4a
patch 9.0.1583: get E304 when using 'cryptmethod' "xchacha20v2"
...
Problem: Get E304 when using 'cryptmethod' "xchacha20v2". (Steve Mynott)
Solution: Add 4th crypt method to block zero ID check. Avoid syncing a swap
file before reading the file. (closes #12433 )
2023-05-27 18:02:55 +01:00
Bram Moolenaar
bf1b713202
patch 9.0.1494: crash when recovering from corrupted swap file
...
Problem: Crash when recovering from corrupted swap file.
Solution: Bail out when the line index looks wrong. (closes #12276 )
2023-04-27 21:13:12 +01:00
Bram Moolenaar
e1b4822137
patch 9.0.1484: Coverity warns for using invalid array index
...
Problem: Coverity warns for using invalid array index.
Solution: Add entry for Xchacha, even though it is not used.
2023-04-24 18:11:35 +01:00
Christian Brabandt
aae583441b
patch 9.0.1481: decrypting with libsodium may fail if the library changes
...
Problem: Decrypting with libsodium may fail if the library changes.
Solution: Add parameters used to the encrypted file header. (Christian
Brabandt, closes #12279 )
2023-04-23 17:50:22 +01:00
Bram Moolenaar
b67ba03d3e
patch 9.0.1477: crash when recovering from corrupted swap file
...
Problem: Crash when recovering from corrupted swap file.
Solution: Check for a valid page count. (closes #12275 )
2023-04-22 21:14:26 +01:00
zeertzjq
1b438a8228
patch 9.0.1271: using sizeof() and subtract array size is tricky
...
Problem: Using sizeof() and subtract array size is tricky.
Solution: Use offsetof() instead. (closes #11926 )
2023-02-01 13:11:15 +00:00
Yegappan Lakshmanan
e857598896
patch 9.0.1196: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11813 )
2023-01-14 12:32:28 +00:00
Luuk van Baal
c53e7904b9
patch 9.0.1089: unnessary assignment
...
Problem: unnessary assignment
Solution: Remove the assignment. (Luuk van Baal, closes #1136 )
2022-12-23 12:17:33 +00:00
Bram Moolenaar
c216a7a21a
patch 9.0.1007: there is no way to get a list of swap file names
...
Problem: There is no way to get a list of swap file names.
Solution: Add the swapfilelist() function. Use it in the test script to
clean up. Remove deleting individual swap files.
2022-12-05 13:50:55 +00:00
Bram Moolenaar
a2a8973e51
patch 9.0.0340: the 'cmdheight' zero support causes too much trouble
...
Problem: The 'cmdheight' zero support causes too much trouble.
Solution: Revert support for 'cmdheight' being zero.
2022-08-31 14:46:18 +01:00
Bram Moolenaar
13608d851a
patch 9.0.0318: clearing screen causes flicker
...
Problem: Clearing screen causes flicker.
Solution: Do not clear but redraw in more cases. Add () to "wait_return".
2022-08-29 15:06:50 +01:00
Bram Moolenaar
33a5dd8b23
patch 9.0.0308: when cmdheight is zero the attention prompt doesn't show
...
Problem: When cmdheight is zero the attention prompt doesn't show.
Solution: Do not use the message window for a prompt.
2022-08-28 22:17:50 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Bram Moolenaar
e5a0e8c1d7
patch 9.0.0181: textprop test with line2byte() fails on MS-Windows
...
Problem: Textprop test with line2byte() fails on MS-Windows.
Solution: Fix updating chuncks in ml_delete_int().
2022-08-09 21:37:55 +01:00
Bram Moolenaar
50652b0c5c
patch 9.0.0166: when using text properties line text length computed twice
...
Problem: When using text properties the line text length is computed twice.
Solution: If the text lenght was already computed don't do it again.
2022-08-07 21:48:37 +01:00
Bram Moolenaar
fa4873ccfc
patch 9.0.0013: reproducing memory access errors can be difficult
...
Problem: Reproducing memory access errors can be difficult.
Solution: When testing, copy each line to allocated memory, so that valgrind
can detect accessing memory before and/or after it. Fix uncovered
problems.
2022-06-30 22:13:59 +01:00
Paul Ollis
4c3d21acaa
patch 8.2.5014: byte offsets are wrong when using text properties
...
Problem: Byte offsets are wrong when using text properties.
Solution: Make sure text properties do not affect the byte counts.
(Paul Ollis, closes #10474 )
2022-05-24 21:26:37 +01:00
Bram Moolenaar
9f28eeb694
patch 8.2.4961: build error with a certain combination of features
...
Problem: Build error with a certain combination of features.
Solution: Adjust #if. (John Marriott)
2022-05-16 10:04:51 +01:00
Paul Ollis
1bdc60eb91
patch 8.2.4960: text properties that cross lines not updated for deleted line
...
Problem: Text properties that cross line boundary are not correctly updated
for a deleted line.
Solution: Correct computing location of text property entry. (Paul Ollis,
closes #10431 , closes #10430 )
2022-05-15 22:24:55 +01:00
Bram Moolenaar
31e5c60a68
patch 8.2.4753: error from setting an option is silently ignored
...
Problem: Error from setting an option is silently ignored.
Solution: Handle option value errors better. Fix uses of N_().
2022-04-15 13:53:33 +01:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
f26c16144d
patch 8.2.4704: using "else" after return or break increases indent
...
Problem: Using "else" after return or break increases indent.
Solution: Remove "else" and reduce indent. (Goc Dundar, closes #10099 )
2022-04-07 13:26:34 +01:00
Bram Moolenaar
188639d75c
patch 8.2.4685: when a swap file is found for a popup there is no dialog
...
Problem: When a swap file is found for a popup there is no dialog and the
buffer is loaded anyway.
Solution: Silently load the buffer read-only. (closes #10073 )
2022-04-04 16:57:21 +01:00
zeertzjq
3c5999e53d
patch 8.2.4613: return type of swapfile_unchanged() is wrong
...
Problem: Return type of swapfile_unchanged() is wrong.
Solution: Use "int". (closes #10000 Yeah!)
2022-03-23 13:54:51 +00:00
kylo252
ae6f1d8b14
patch 8.2.4402: missing parenthesis may cause unexpected problems
...
Problem: Missing parenthesis may cause unexpected problems.
Solution: Add more parenthesis is macros. (closes #9788 )
2022-02-16 19:24:07 +00:00
Bram Moolenaar
f9435e49ef
patch 8.2.4399: crash after ml_get error
...
Problem: Crash after ml_get error.
Solution: When returning "???" flush the line and set ml_line_lnum.
2022-02-16 16:33:28 +00:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
d5cec1f1f0
patch 8.2.4255: theoretical computation overflow
...
Problem: Theoretical computation overflow.
Solution: Perform multiplication in a wider type. (closes #9657 )
2022-01-29 15:19:23 +00:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
420fabcd4f
patch 8.2.4241: some type casts are redundant
...
Problem: Some type casts are redundant.
Solution: Remove the type casts. (closes #9643 )
2022-01-28 15:28:04 +00:00
K.Takata
1a8825d7a3
patch 8.2.4144: cannot load libsodium dynamically
...
Problem: Cannot load libsodium dynamically.
Solution: Support dynamic loading on MS-Windows. (Ken Takata, closes #9554 )
2022-01-19 13:32:57 +00:00
Bram Moolenaar
9d00e4a814
patch 8.2.4010: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-05 17:49:15 +00:00
Bram Moolenaar
677658ae49
patch 8.2.4008: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-05 16:09:06 +00:00
Bram Moolenaar
eaaac014a0
patch 8.2.3983: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 17:00:40 +00:00
Bram Moolenaar
9a846fbaa5
patch 8.2.3977: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-01 21:59:18 +00:00
Dominique Pelle
af4a61a85d
patch 8.2.3914: various spelling mistakes in comments
...
Problem: Various spelling mistakes in comments.
Solution: Fix the mistakes. (Dominique Pellé, closes #9416 )
2021-12-27 17:21:41 +00:00
Bram Moolenaar
96e7a5928e
patch 8.2.3674: when ml_get_buf() fails it messes up IObuff
...
Problem: When ml_get_buf() fails it messes up IObuff.
Solution: Return a local pointer. (closes #9214 )
2021-11-25 13:52:37 +00:00
Bram Moolenaar
8b0e62c93b
patch 8.2.3543: swapname has double slash when 'directory' ends in it
...
Problem: Swapname has double slash when 'directory' ends in double slash.
(Shane Smith)
Solution: Remove the superfluous slash. (closes #8876 )
2021-10-19 22:12:25 +01:00
Leah Neukirchen
0a7984af56
patch 8.2.3510: changes are only detected with one second accuracy
...
Problem: Changes are only detected with one second accuracy.
Solution: Use the nanosecond time if possible. (Leah Neukirchen,
closes #8873 , closes #8875 )
2021-10-14 21:27:55 +01:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
3826c0513b
patch 8.2.3490: superfluous return statements
...
Problem: Superfluous return statements.
Solution: Remove superfluous return statements from void functions.
(closes #8977 )
2021-10-09 15:39:25 +01:00
Bram Moolenaar
e2982d6911
patch 8.2.3483: #ifdef for using sysinfo() is incomplete
...
Problem: #ifdef for using sysinfo() is incomplete.
Solution: Also check for HAVE_SYSINFO. Make autoconf check use TRY_LINK.
(closes #8952 )
2021-10-06 11:27:21 +01:00
Bram Moolenaar
df9070e300
patch 8.2.3375: using uninitialized memory
...
Problem: Using uninitialized memory.
Solution: Initialize textprop_save_len.
2021-08-25 17:31:37 +02:00
Bram Moolenaar
cdd8a5e6fe
patch 8.2.3372: line2byte() value wrong when adding a text property
...
Problem: line2byte() value wrong when adding a text property. (Yuto Kimura)
Solution: Adjust length for text property. (closes #8772 ) Also fix it for
deleting a line.
2021-08-25 16:40:03 +02:00
Bram Moolenaar
434df7a401
patch 8.2.3355: MS-Windows: compiler warning for 64-32 bit conversion
...
Problem: MS-Windows: compiler warning for 64-32 bit conversion.
Solution: Add type casts.
2021-08-16 21:15:32 +02:00
Bram Moolenaar
92755bba30
patch 8.2.3354: build failure with +byte_offset but without +textprop
...
Problem: Build failure with +byte_offset but without +textprop. (John
Marriott)
Solution: Adjust the #ifdef.
2021-08-15 22:18:04 +02:00