1
0
forked from aniani/vim

patch 8.1.0531: flaky tests often fail with a common error message

Problem:    Flaky tests often fail with a common error message.
Solution:   Add a pattern to match an error message indicating a flaky test.
This commit is contained in:
Bram Moolenaar
2018-11-16 18:22:45 +01:00
parent c0f05d0bd1
commit dbc0d2163a
2 changed files with 9 additions and 2 deletions

View File

@@ -273,7 +273,7 @@ else
endif
" Names of flaky tests.
let s:flaky = [
let s:flaky_tests = [
\ 'Test_call()',
\ 'Test_channel_handler()',
\ 'Test_client_server()',
@@ -329,6 +329,9 @@ let s:flaky = [
\ 'Test_zz1_terminal_in_gui()',
\ ]
" Pattern indicating a common flaky test failure.
let s:flaky_errors_re = 'StopVimInTerminal'
" Locate Test_ functions and execute them.
redir @q
silent function /^Test_
@@ -353,7 +356,9 @@ for s:test in sort(s:tests)
" Repeat a flaky test. Give up when:
" - it fails again with the same message
" - it fails five times (with a different mesage)
if len(v:errors) > 0 && index(s:flaky, s:test) >= 0
if len(v:errors) > 0
\ && (index(s:flaky_tests, s:test) >= 0
\ || v:errors[0] =~ s:flaky_errors_re)
while 1
call add(s:messages, 'Found errors in ' . s:test . ':')
call extend(s:messages, v:errors)

View File

@@ -792,6 +792,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
531,
/**/
530,
/**/