forked from aniani/vim
patch 8.1.0531: flaky tests often fail with a common error message
Problem: Flaky tests often fail with a common error message. Solution: Add a pattern to match an error message indicating a flaky test.
This commit is contained in:
@@ -273,7 +273,7 @@ else
|
|||||||
endif
|
endif
|
||||||
|
|
||||||
" Names of flaky tests.
|
" Names of flaky tests.
|
||||||
let s:flaky = [
|
let s:flaky_tests = [
|
||||||
\ 'Test_call()',
|
\ 'Test_call()',
|
||||||
\ 'Test_channel_handler()',
|
\ 'Test_channel_handler()',
|
||||||
\ 'Test_client_server()',
|
\ 'Test_client_server()',
|
||||||
@@ -329,6 +329,9 @@ let s:flaky = [
|
|||||||
\ 'Test_zz1_terminal_in_gui()',
|
\ 'Test_zz1_terminal_in_gui()',
|
||||||
\ ]
|
\ ]
|
||||||
|
|
||||||
|
" Pattern indicating a common flaky test failure.
|
||||||
|
let s:flaky_errors_re = 'StopVimInTerminal'
|
||||||
|
|
||||||
" Locate Test_ functions and execute them.
|
" Locate Test_ functions and execute them.
|
||||||
redir @q
|
redir @q
|
||||||
silent function /^Test_
|
silent function /^Test_
|
||||||
@@ -353,7 +356,9 @@ for s:test in sort(s:tests)
|
|||||||
" Repeat a flaky test. Give up when:
|
" Repeat a flaky test. Give up when:
|
||||||
" - it fails again with the same message
|
" - it fails again with the same message
|
||||||
" - it fails five times (with a different mesage)
|
" - it fails five times (with a different mesage)
|
||||||
if len(v:errors) > 0 && index(s:flaky, s:test) >= 0
|
if len(v:errors) > 0
|
||||||
|
\ && (index(s:flaky_tests, s:test) >= 0
|
||||||
|
\ || v:errors[0] =~ s:flaky_errors_re)
|
||||||
while 1
|
while 1
|
||||||
call add(s:messages, 'Found errors in ' . s:test . ':')
|
call add(s:messages, 'Found errors in ' . s:test . ':')
|
||||||
call extend(s:messages, v:errors)
|
call extend(s:messages, v:errors)
|
||||||
|
@@ -792,6 +792,8 @@ static char *(features[]) =
|
|||||||
|
|
||||||
static int included_patches[] =
|
static int included_patches[] =
|
||||||
{ /* Add new patch number below this line */
|
{ /* Add new patch number below this line */
|
||||||
|
/**/
|
||||||
|
531,
|
||||||
/**/
|
/**/
|
||||||
530,
|
530,
|
||||||
/**/
|
/**/
|
||||||
|
Reference in New Issue
Block a user