thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 9.1.0648: [security] double-free in dialog_changed()

Browse Source 
Problem:  [security] double-free in dialog_changed()
          (SuyueGuo)
Solution: Only clear pointer b_sfname pointer, if it is different
          than the b_ffname pointer.  Don't try to free b_fname,
          set it to NULL instead.

fixes: #15403

Github Advisory:
https://github.com/vim/vim/security/advisories/GHSA-46pw-v7qw-xc2f

Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Christian Brabandt
2024-08-01 22:10:28 +02:00
parent 8a0bbe7b8a
commit b29f4abcd4
4 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ex_cmds2.c
View File

@@ -197,9 +197,11 @@ dialog_changed(
// restore to empty when write failed
if (empty_bufname)
{
VIM_CLEAR(buf->b_fname);
// prevent double free
if (buf->b_sfname != buf->b_ffname)
VIM_CLEAR(buf->b_sfname);
buf->b_fname = NULL;
VIM_CLEAR(buf->b_ffname);
VIM_CLEAR(buf->b_sfname);
unchanged(buf, TRUE, FALSE);
}
}