thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 8.2.0170: Coverity warning for ignoring return value

Browse Source 
Problem:    Coverity warning for ignoring return value.
Solution:   Check the return value and return if failed.
This commit is contained in:
Bram Moolenaar
2020-01-28 23:04:06 +01:00
parent 8cbd6dfc0c
commit a6d536829a
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/version.c
View File

@@ -742,6 +742,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
170,
/**/ /**/
169, 169,
/**/ /**/

7
src/vim9compile.c
View File

@@ -2917,7 +2917,8 @@ compile_expr1(char_u **arg, cctx_T *cctx)
// evaluate the second expression; any type is accepted // evaluate the second expression; any type is accepted
*arg = skipwhite(p + 1); *arg = skipwhite(p + 1);
compile_expr1(arg, cctx); if (compile_expr1(arg, cctx) == FAIL)
return FAIL;
// remember the type and drop it // remember the type and drop it
--stack->ga_len; --stack->ga_len;
@@ -2942,7 +2943,8 @@ compile_expr1(char_u **arg, cctx_T *cctx)
// evaluate the third expression // evaluate the third expression
*arg = skipwhite(p + 1); *arg = skipwhite(p + 1);
compile_expr1(arg, cctx); if (compile_expr1(arg, cctx) == FAIL)
return FAIL;
// If the types differ, the result has a more generic type. // If the types differ, the result has a more generic type.
type2 = ((type_T **)stack->ga_data)[stack->ga_len - 1]; type2 = ((type_T **)stack->ga_data)[stack->ga_len - 1];
@@ -3265,6 +3267,7 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx)
if (*op != '=') if (*op != '=')
{ {
if (option) if (option)
// TODO: check the option exists
generate_LOAD(cctx, ISN_LOADOPT, 0, name + 1, type); generate_LOAD(cctx, ISN_LOADOPT, 0, name + 1, type);
else if (global) else if (global)
generate_LOAD(cctx, ISN_LOADG, 0, name + 2, type); generate_LOAD(cctx, ISN_LOADG, 0, name + 2, type);