thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 9.0.2068: [security] overflow in :history

Browse Source 
Problem:  [security] overflow in :history
Solution: Check that value fits into int

The get_list_range() function, used to parse numbers for the :history
and :clist command internally uses long variables to store the numbers.
However function arguments are integer pointers, which can then
overflow.

Check that the return value from the vim_str2nr() function is not larger
than INT_MAX and if yes, bail out with an error. I guess nobody uses a
cmdline/clist history that needs so many entries... (famous last words).

It is only a moderate vulnerability, so impact should be low.

Github Advisory:
https://github.com/vim/vim/security/advisories/GHSA-q22m-h7m2-9mgm

Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Christian Brabandt
2023-10-26 21:29:32 +02:00
parent 5f5131d775
commit 9198c1f2b1
5 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/cmdhist.c
View File

@@ -742,7 +742,10 @@ ex_history(exarg_T *eap)
end = arg;
if (!get_list_range(&end, &hisidx1, &hisidx2) || *end != NUL)
{
semsg(_(e_trailing_characters_str), end);
if (*end != NUL)
semsg(_(e_trailing_characters_str), end);
else
semsg(_(e_val_too_large), arg);
return;
}