thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 8.1.0750: when the last sign is deleted the signcolumn may remain

Browse Source 
Problem:    When the last sign is deleted the signcolumn may not be removed
            even though 'signcolumn' is "auto".
Solution:   When deleting the last sign redraw the buffer. (Dominique Pelle,
            closes #3803, closes #3804)
This commit is contained in:
Bram Moolenaar
2019-01-14 23:08:18 +01:00
parent 6acc79f5d4
commit 8144acbec3
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sign.c
View File

@@ -374,8 +374,8 @@ buf_change_sign_type(
/* /*
* Return the type number of the sign at line number 'lnum' in buffer 'buf' * Return the type number of the sign at line number 'lnum' in buffer 'buf'
* which has the attribute specifed by 'type'. Returns 0 if a sign is not found * which has the attribute specified by 'type'. Returns 0 if a sign is not
* at the line number or it doesn't have the specified attribute. * found at the line number or it doesn't have the specified attribute.
*/ */
int int
buf_getsigntype( buf_getsigntype(
@@ -442,7 +442,7 @@ buf_delsign(
redraw_buf_line_later(buf, lnum); redraw_buf_line_later(buf, lnum);
// Check whether only one sign needs to be deleted // Check whether only one sign needs to be deleted
// If deleting a sign with a specific identifer in a particular // If deleting a sign with a specific identifier in a particular
// group or deleting any sign at a particular line number, delete // group or deleting any sign at a particular line number, delete
// only one sign. // only one sign.
if (group == NULL if (group == NULL
@@ -455,9 +455,12 @@ buf_delsign(
} }
// When deleting the last sign the cursor position may change, because the // When deleting the last sign the cursor position may change, because the
// sign columns no longer shows. // sign columns no longer shows. And the 'signcolumn' may be hidden.
if (buf->b_signlist == NULL) if (buf->b_signlist == NULL)
{
redraw_buf_later(buf, NOT_VALID);
changed_cline_bef_curs(); changed_cline_bef_curs();
}
return lnum; return lnum;
} }
@@ -894,7 +897,7 @@ sign_list_by_name(char_u *name)
} }
/* /*
* Place a sign at the specifed file location or update a sign. * Place a sign at the specified file location or update a sign.
*/ */
int int
sign_place( sign_place(

2
src/version.c
View File

@@ -795,6 +795,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
750,
/**/ /**/
749, 749,
/**/ /**/