thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 9.0.2180: POSIX function name in exarg causes issues

Browse Source 
Problem:  POSIX function name in exarg struct causes issues
          on OpenVMS
Solution: Rename getline member in exarg struct to ea_getline,
          remove isinf() workaround for VMS

There are compilers that do not treat well POSIX functions - like
getline - usage in the structs.

Older VMS compilers could digest this... but the newer OpenVMS compilers
( like VSI C x86-64 X7.4-843 (GEM 50XB9) ) cannot deal with these
structs. This could be limited to getline() that is defined via
getdelim() and might not affect all POSIX functions in general - but
avoiding POSIX function names usage in the structs is a "safe side"
practice without compromising the functionality or the code readability.

The previous OpenVMS X86 port used a workaround limiting the compiler
capabilities using __CRTL_VER_OVERRIDE=80400000
In order to make the OpenVMS port future proof, this pull request
proposes a possible solution.

closes: #13704

Signed-off-by: Zoltan Arpadffy <zoltan.arpadffy@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Zoltan Arpadffy
2023-12-19 20:53:07 +01:00
committed by Christian Brabandt
parent 63210c214a
commit 6fdb628082
17 changed files with 45 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/scriptfile.c
View File

@@ -2469,7 +2469,7 @@ getsourceline(
int
sourcing_a_script(exarg_T *eap)
{
return (getline_equal(eap->getline, eap->cookie, getsourceline));
return (getline_equal(eap->ea_getline, eap->cookie, getsourceline));
}
/*
@@ -2497,7 +2497,7 @@ ex_scriptencoding(exarg_T *eap)
name = eap->arg;
// Setup for conversion from the specified encoding to 'encoding'.
sp = (source_cookie_T *)getline_cookie(eap->getline, eap->cookie);
sp = (source_cookie_T *)getline_cookie(eap->ea_getline, eap->cookie);
convert_setup(&sp->conv, name, p_enc);
if (name != eap->arg)
@@ -2561,7 +2561,7 @@ do_finish(exarg_T *eap, int reanimate)
int idx;
if (reanimate)
((source_cookie_T *)getline_cookie(eap->getline,
((source_cookie_T *)getline_cookie(eap->ea_getline,
eap->cookie))->finished = FALSE;
// Cleanup (and inactivate) conditionals, but stop when a try conditional
@@ -2575,7 +2575,7 @@ do_finish(exarg_T *eap, int reanimate)
report_make_pending(CSTP_FINISH, NULL);
}
else
((source_cookie_T *)getline_cookie(eap->getline,
((source_cookie_T *)getline_cookie(eap->ea_getline,
eap->cookie))->finished = TRUE;
}