thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 8.2.0036: not enough test coverage for match functions

Browse Source 
Problem:    Not enough test coverage for match functions.
Solution:   Add a few more test cases.  (Dominique Pelle, closes #5394)
            Add error number.
This commit is contained in:
Bram Moolenaar
2019-12-24 15:17:00 +01:00
parent 53989554a4
commit 49d68bf5e4
2 changed files with 33 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/testdir/test_match.vim
View File

@@ -150,6 +150,21 @@ function Test_match()
highlight MyGroup3 NONE highlight MyGroup3 NONE
endfunc endfunc
func Test_match_error()
call assert_fails('match Error', 'E475:')
call assert_fails('match Error /', 'E475:')
call assert_fails('4match Error /x/', 'E476:')
call assert_fails('match Error /x/ x', 'E488:')
endfunc
func Test_matchadd_error()
call assert_fails("call matchadd('GroupDoesNotExist', 'X')", 'E28:')
call assert_fails("call matchadd('Search', '\\(')", 'E475:')
call assert_fails("call matchadd('Search', 'XXX', 1, 123, 1)", 'E715:')
call assert_fails("call matchadd('Error', 'XXX', 1, 3)", 'E798:')
call assert_fails("call matchadd('Error', 'XXX', 1, 0)", 'E799:')
endfunc
func Test_matchaddpos() func Test_matchaddpos()
syntax on syntax on
set hlsearch set hlsearch
@@ -254,6 +269,17 @@ func Test_matchaddpos_using_negative_priority()
set hlsearch& set hlsearch&
endfunc endfunc
func Test_matchaddpos_error()
call assert_fails("call matchaddpos('Error', 1)", 'E686:')
call assert_fails("call matchaddpos('Error', [1], 1, 1)", 'E798:')
call assert_fails("call matchaddpos('Error', [1], 1, 2)", 'E798:')
call assert_fails("call matchaddpos('Error', [1], 1, 0)", 'E799:')
call assert_fails("call matchaddpos('Error', [1], 1, 123, 1)", 'E715:')
call assert_fails("call matchaddpos('Error', [1], 1, 5, {'window':12345})", 'E957:')
" Why doesn't the following error have an error code E...?
call assert_fails("call matchaddpos('Error', [{}])", 'E290:')
endfunc
func OtherWindowCommon() func OtherWindowCommon()
let lines =<< trim END let lines =<< trim END
call setline(1, 'Hello Vim world') call setline(1, 'Hello Vim world')
@@ -278,6 +304,11 @@ func Test_matchdelete_other_window()
call delete('XscriptMatchCommon') call delete('XscriptMatchCommon')
endfunc endfunc
func Test_matchdelete_error()
call assert_fails("call matchdelete(0)", 'E802:')
call assert_fails("call matchdelete(1, -1)", 'E957:')
endfunc
func Test_matchclear_other_window() func Test_matchclear_other_window()
if !CanRunVimInTerminal() if !CanRunVimInTerminal()
throw 'Skipped: cannot make screendumps' throw 'Skipped: cannot make screendumps'

2
src/version.c
View File

@@ -742,6 +742,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
36,
/**/ /**/
35, 35,
/**/ /**/