thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 8.2.0400: not all tests using a terminal are in the list of flaky tests

Browse Source 
Problem:    Not all tests using a terminal are in the list of flaky tests.
Solution:   Introduce the test_is_flaky flag.
This commit is contained in:
Bram Moolenaar
2020-03-18 19:18:10 +01:00
parent 292b90d4fa
commit 3cdcb090a6
5 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/testdir/runtest.vim
View File

@@ -379,9 +379,6 @@ let s:flaky_tests = [
\ 'Test_zz1_terminal_in_gui()',
\ ]
" Pattern indicating a common flaky test failure.
let s:flaky_errors_re = 'StopVimInTerminal\|VerifyScreenDump'
" Locate Test_ functions and execute them.
redir @q
silent function /^Test_
@@ -410,6 +407,9 @@ for s:test in sort(s:tests)
let total_errors = []
let run_nr = 1
" A test can set test_is_flaky to retry running the test.
let test_is_flaky = 0
call RunTheTest(s:test)
" Repeat a flaky test. Give up when:
@@ -417,7 +417,7 @@ for s:test in sort(s:tests)
" - it fails five times (with a different message)
if len(v:errors) > 0
\ && (index(s:flaky_tests, s:test) >= 0
\ || v:errors[0] =~ s:flaky_errors_re)
\ || test_is_flaky)
while 1
call add(s:messages, 'Found errors in ' . s:test . ':')
call extend(s:messages, v:errors)