mirror of
https://github.com/Pathduck/gallery3.git
synced 2026-05-20 03:19:13 -04:00
0b97cfd6f0
view permission on the parent. Added a whitelist of allowable owner permissions. If the requested permission is view and the user requesting access is the owner, check that they have view permission to the parent.
443 lines
16 KiB
PHP
443 lines
16 KiB
PHP
<?php defined("SYSPATH") or die("No direct script access.");
|
|
/**
|
|
* Gallery - a web based photo album viewer and editor
|
|
* Copyright (C) 2000-2009 Bharat Mediratta
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or (at
|
|
* your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*/
|
|
class Access_Helper_Test extends Unit_Test_Case {
|
|
private $_group;
|
|
|
|
public function teardown() {
|
|
try {
|
|
$group = ORM::factory("group")->where("name", "access_test")->find();
|
|
if ($group->loaded) {
|
|
$group->delete();
|
|
}
|
|
} catch (Exception $e) { }
|
|
|
|
try {
|
|
access::delete_permission("access_test");
|
|
} catch (Exception $e) { }
|
|
|
|
try {
|
|
$user = ORM::factory("user")->where("name", "access_test")->find();
|
|
if ($user->loaded) {
|
|
$user->delete();
|
|
}
|
|
} catch (Exception $e) { }
|
|
|
|
// Reset some permissions that we mangle below
|
|
$root = ORM::factory("item", 1);
|
|
access::allow(group::everybody(), "view", $root);
|
|
}
|
|
|
|
public function setup() {
|
|
user::set_active(user::guest());
|
|
}
|
|
|
|
public function groups_and_permissions_are_bound_to_columns_test() {
|
|
access::register_permission("access_test", "Access Test");
|
|
$group = group::create("access_test");
|
|
|
|
// We have a new column for this perm / group combo
|
|
$fields = Database::instance()->list_fields("access_caches");
|
|
$this->assert_true(array_key_exists("access_test_{$group->id}", $fields));
|
|
|
|
access::delete_permission("access_test");
|
|
$group->delete();
|
|
|
|
// Now the column has gone away
|
|
$fields = Database::instance()->list_fields("access_caches");
|
|
$this->assert_false(array_key_exists("access_test_{$group->id}", $fields));
|
|
}
|
|
|
|
public function user_can_access_test() {
|
|
$access_test = group::create("access_test");
|
|
|
|
$root = ORM::factory("item", 1);
|
|
access::allow($access_test, "view", $root);
|
|
|
|
$item = album::create($root, rand(), "test album");
|
|
|
|
access::deny(group::everybody(), "view", $item);
|
|
access::deny(group::registered_users(), "view", $item);
|
|
|
|
$user = user::create("access_test", "Access Test", "");
|
|
foreach ($user->groups as $group) {
|
|
$user->remove($group);
|
|
}
|
|
$user->add($access_test);
|
|
$user->save();
|
|
|
|
$this->assert_true(access::user_can($user, "view", $item), "Should be able to view");
|
|
}
|
|
|
|
public function user_can_no_access_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$item = album::create($root, rand(), "test album");
|
|
|
|
access::deny(group::everybody(), "view", $item);
|
|
access::deny(group::registered_users(), "view", $item);
|
|
|
|
$user = user::create("access_test", "Access Test", "");
|
|
foreach ($user->groups as $group) {
|
|
$user->remove($group);
|
|
}
|
|
$user->save();
|
|
|
|
$this->assert_false(access::user_can($user, "view", $item), "Should be unable to view");
|
|
}
|
|
|
|
public function owner_can_view_album_test() {
|
|
$user = user::create("access_test", "Access Test", "");
|
|
foreach ($user->groups as $group) {
|
|
$user->remove($group);
|
|
}
|
|
$user->save();
|
|
|
|
$root = ORM::factory("item", 1);
|
|
$item = album::create($root, rand(), "test album", $user->id);
|
|
|
|
$this->assert_true(access::user_can($user, "view", $item), "Should be able to view");
|
|
}
|
|
|
|
public function owner_can_view_photo_test() {
|
|
$user = user::create("access_test", "Access Test", "");
|
|
foreach ($user->groups as $group) {
|
|
$user->remove($group);
|
|
}
|
|
$user->save();
|
|
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album", $user->id);
|
|
$item = photo::create($album, MODPATH . "gallery/images/gallery.png", "", "", null, $user->id);
|
|
|
|
$this->assert_true(access::user_can($user, "view", $item), "Should be able to view");
|
|
}
|
|
|
|
public function owner_cant_view_photo_test() {
|
|
$user = user::create("access_test", "Access Test", "");
|
|
foreach ($user->groups as $group) {
|
|
$user->remove($group);
|
|
}
|
|
$user->save();
|
|
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
access::deny(group::everybody(), "view", $album);
|
|
$item = photo::create($album, MODPATH . "gallery/images/gallery.png", "", "", null, $user->id);
|
|
|
|
$this->assert_false(access::user_can($user, "view", $item), "Should not be able to view");
|
|
}
|
|
|
|
public function adding_and_removing_items_adds_ands_removes_rows_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$item = album::create($root, rand(), "test album");
|
|
|
|
// New rows exist
|
|
$this->assert_true(ORM::factory("access_cache")->where("item_id", $item->id)->find()->loaded);
|
|
$this->assert_true(ORM::factory("access_intent")->where("item_id", $item->id)->find()->loaded);
|
|
|
|
// Delete the item
|
|
$item->delete();
|
|
|
|
// Rows are gone
|
|
$this->assert_false(ORM::factory("access_cache")->where("item_id", $item->id)->find()->loaded);
|
|
$this->assert_false(ORM::factory("access_intent")->where("item_id", $item->id)->find()->loaded);
|
|
}
|
|
|
|
public function new_photos_inherit_parent_permissions_test() {
|
|
$root = ORM::factory("item", 1);
|
|
|
|
$album = album::create($root, rand(), "test album");
|
|
access::allow(group::everybody(), "view", $album);
|
|
|
|
$photo = ORM::factory("item");
|
|
$photo->type = "photo";
|
|
$photo->add_to_parent($album);
|
|
access::add_item($photo);
|
|
|
|
$this->assert_true($photo->__get("view_" . group::everybody()->id));
|
|
}
|
|
|
|
public function can_allow_deny_and_reset_intent_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
$intent = ORM::factory("access_intent")->where("item_id", $album)->find();
|
|
|
|
// Allow
|
|
access::allow(group::everybody(), "view", $album);
|
|
$this->assert_same(access::ALLOW, $intent->reload()->view_1);
|
|
|
|
// Deny
|
|
access::deny(group::everybody(), "view", $album);
|
|
$this->assert_same(
|
|
access::DENY,
|
|
ORM::factory("access_intent")->where("item_id", $album)->find()->view_1);
|
|
|
|
// Allow again. If the initial value was allow, then the first Allow clause above may not
|
|
// have actually changed any values.
|
|
access::allow(group::everybody(), "view", $album);
|
|
$this->assert_same(
|
|
access::ALLOW,
|
|
ORM::factory("access_intent")->where("item_id", $album)->find()->view_1);
|
|
|
|
access::reset(group::everybody(), "view", $album);
|
|
$this->assert_same(
|
|
null,
|
|
ORM::factory("access_intent")->where("item_id", $album)->find()->view_1);
|
|
}
|
|
|
|
public function cant_reset_root_item_test() {
|
|
try {
|
|
access::reset(group::everybody(), "view", ORM::factory("item", 1));
|
|
} catch (Exception $e) {
|
|
return;
|
|
}
|
|
$this->assert_true(false, "Should not be able to reset root intent");
|
|
}
|
|
|
|
public function can_view_item_test() {
|
|
$root = ORM::factory("item", 1);
|
|
access::allow(group::everybody(), "view", $root);
|
|
$this->assert_true(access::group_can(group::everybody(), "view", $root));
|
|
}
|
|
|
|
public function can_always_fails_on_unloaded_items_test() {
|
|
$root = ORM::factory("item", 1);
|
|
access::allow(group::everybody(), "view", $root);
|
|
$this->assert_true(access::group_can(group::everybody(), "view", $root));
|
|
|
|
$bogus = ORM::factory("item", -1);
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $bogus));
|
|
}
|
|
|
|
public function cant_view_child_of_hidden_parent_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
|
|
$root->reload();
|
|
access::deny(group::everybody(), "view", $root);
|
|
access::reset(group::everybody(), "view", $album);
|
|
|
|
$album->reload();
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $album));
|
|
}
|
|
|
|
public function view_permissions_propagate_down_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
|
|
access::allow(group::everybody(), "view", $root);
|
|
access::reset(group::everybody(), "view", $album);
|
|
$album->reload();
|
|
$this->assert_true(access::group_can(group::everybody(), "view", $album));
|
|
}
|
|
|
|
public function can_toggle_view_permissions_propagate_down_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album1 = album::create($root, rand(), "test album");
|
|
$album2 = album::create($album1, rand(), "test album");
|
|
$album3 = album::create($album2, rand(), "test album");
|
|
$album4 = album::create($album3, rand(), "test album");
|
|
|
|
$album1->reload();
|
|
$album2->reload();
|
|
$album3->reload();
|
|
$album4->reload();
|
|
|
|
access::allow(group::everybody(), "view", $root);
|
|
access::deny(group::everybody(), "view", $album1);
|
|
access::reset(group::everybody(), "view", $album2);
|
|
access::reset(group::everybody(), "view", $album3);
|
|
access::reset(group::everybody(), "view", $album4);
|
|
|
|
$album4->reload();
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $album4));
|
|
|
|
access::allow(group::everybody(), "view", $album1);
|
|
$album4->reload();
|
|
$this->assert_true(access::group_can(group::everybody(), "view", $album4));
|
|
}
|
|
|
|
public function revoked_view_permissions_cant_be_allowed_lower_down_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album1 = album::create($root, rand(), "test album");
|
|
$album2 = album::create($album1, rand(), "test album");
|
|
|
|
$root->reload();
|
|
access::deny(group::everybody(), "view", $root);
|
|
access::allow(group::everybody(), "view", $album2);
|
|
|
|
$album1->reload();
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $album1));
|
|
|
|
$album2->reload();
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $album2));
|
|
}
|
|
|
|
public function can_edit_item_test() {
|
|
$root = ORM::factory("item", 1);
|
|
access::allow(group::everybody(), "edit", $root);
|
|
$this->assert_true(access::group_can(group::everybody(), "edit", $root));
|
|
}
|
|
|
|
public function non_view_permissions_propagate_down_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
|
|
access::allow(group::everybody(), "edit", $root);
|
|
access::reset(group::everybody(), "edit", $album);
|
|
$this->assert_true(access::group_can(group::everybody(), "edit", $album));
|
|
}
|
|
|
|
public function non_view_permissions_can_be_revoked_lower_down_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$outer = album::create($root, rand(), "test album");
|
|
$outer_photo = ORM::factory("item");
|
|
$outer_photo->type = "photo";
|
|
$outer_photo->add_to_parent($outer);
|
|
access::add_item($outer_photo);
|
|
|
|
$inner = album::create($outer, rand(), "test album");
|
|
$inner_photo = ORM::factory("item");
|
|
$inner_photo->type = "photo";
|
|
$inner_photo->add_to_parent($inner);
|
|
access::add_item($inner_photo);
|
|
|
|
$outer->reload();
|
|
$inner->reload();
|
|
|
|
access::allow(group::everybody(), "edit", $root);
|
|
access::deny(group::everybody(), "edit", $outer);
|
|
access::allow(group::everybody(), "edit", $inner);
|
|
|
|
// Outer album is not editable, inner one is.
|
|
$this->assert_false(access::group_can(group::everybody(), "edit", $outer_photo));
|
|
$this->assert_true(access::group_can(group::everybody(), "edit", $inner_photo));
|
|
}
|
|
|
|
public function i_can_edit_test() {
|
|
// Create a new user that belongs to no groups
|
|
$user = user::create("access_test", "Access Test", "");
|
|
foreach ($user->groups as $group) {
|
|
$user->remove($group);
|
|
}
|
|
$user->save();
|
|
user::set_active($user);
|
|
|
|
// This user can't edit anything
|
|
$root = ORM::factory("item", 1);
|
|
$this->assert_false(access::can("edit", $root));
|
|
|
|
// Now add them to a group that has edit permission
|
|
$group = group::create("access_test");
|
|
$group->add($user);
|
|
$group->save();
|
|
access::allow($group, "edit", $root);
|
|
|
|
$user = ORM::factory("user", $user->id); // reload() does not flush related columns
|
|
user::set_active($user);
|
|
|
|
// And verify that the user can edit.
|
|
$this->assert_true(access::can("edit", $root));
|
|
}
|
|
|
|
public function everybody_view_permission_maintains_htaccess_files_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
|
|
$this->assert_false(file_exists($album->file_path() . "/.htaccess"));
|
|
|
|
access::deny(group::everybody(), "view", $album);
|
|
$this->assert_true(file_exists($album->file_path() . "/.htaccess"));
|
|
|
|
access::allow(group::everybody(), "view", $album);
|
|
$this->assert_false(file_exists($album->file_path() . "/.htaccess"));
|
|
|
|
access::deny(group::everybody(), "view", $album);
|
|
$this->assert_true(file_exists($album->file_path() . "/.htaccess"));
|
|
|
|
access::reset(group::everybody(), "view", $album);
|
|
$this->assert_false(file_exists($album->file_path() . "/.htaccess"));
|
|
}
|
|
|
|
public function everybody_view_full_permission_maintains_htaccess_files_test() {
|
|
$root = ORM::factory("item", 1);
|
|
$album = album::create($root, rand(), "test album");
|
|
|
|
$this->assert_false(file_exists($album->file_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->resize_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->thumb_path() . "/.htaccess"));
|
|
|
|
access::deny(group::everybody(), "view_full", $album);
|
|
$this->assert_true(file_exists($album->file_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->resize_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->thumb_path() . "/.htaccess"));
|
|
|
|
access::allow(group::everybody(), "view_full", $album);
|
|
$this->assert_false(file_exists($album->file_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->resize_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->thumb_path() . "/.htaccess"));
|
|
|
|
access::deny(group::everybody(), "view_full", $album);
|
|
$this->assert_true(file_exists($album->file_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->resize_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->thumb_path() . "/.htaccess"));
|
|
|
|
access::reset(group::everybody(), "view_full", $album);
|
|
$this->assert_false(file_exists($album->file_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->resize_path() . "/.htaccess"));
|
|
$this->assert_false(file_exists($album->thumb_path() . "/.htaccess"));
|
|
}
|
|
|
|
public function moved_items_inherit_new_permissions_test() {
|
|
user::set_active(user::lookup_by_name("admin"));
|
|
|
|
$root = ORM::factory("item", 1);
|
|
$public_album = album::create($root, rand(), "public album");
|
|
$public_photo = photo::create($public_album, MODPATH . "gallery/images/gallery.png", "", "");
|
|
access::allow(group::everybody(), "view", $public_album);
|
|
|
|
$root->reload(); // Account for MPTT changes
|
|
|
|
$private_album = album::create($root, rand(), "private album");
|
|
access::deny(group::everybody(), "view", $private_album);
|
|
$private_photo = photo::create($private_album, MODPATH . "gallery/images/gallery.png", "", "");
|
|
|
|
// Make sure that we now have a public photo and private photo.
|
|
$this->assert_true(access::group_can(group::everybody(), "view", $public_photo));
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $private_photo));
|
|
|
|
// Swap the photos
|
|
item::move($public_photo, $private_album);
|
|
$private_album->reload(); // Reload to get new MPTT pointers and cached perms.
|
|
$public_album->reload();
|
|
$private_photo->reload();
|
|
$public_photo->reload();
|
|
|
|
item::move($private_photo, $public_album);
|
|
$private_album->reload(); // Reload to get new MPTT pointers and cached perms.
|
|
$public_album->reload();
|
|
$private_photo->reload();
|
|
$public_photo->reload();
|
|
|
|
// Make sure that the public_photo is now private, and the private_photo is now public.
|
|
$this->assert_false(access::group_can(group::everybody(), "view", $public_photo));
|
|
$this->assert_true(access::group_can(group::everybody(), "view", $private_photo));
|
|
}
|
|
}
|