Commit Graph
566 Commits
Author SHA1 Message Date
Felix Rabinovich fb93722e9e moved erro page from unit_test to gallery_unit_test 2008-12-08 08:27:13 +00:00
Felix Rabinovich 0a0852328a moved erro page from unit_test to gallery_unit_test 2008-12-08 08:24:01 +00:00
Bharat Mediratta b878ed174d Refactor Menu code to create allow you to create menus using a
chainable factory interface and retrieve them by ids.  Streamlined the
HTML creation code a little bit in the process, moved the basic menu
functionality into Theme_View and created the option to have different
menus other than site_navigation().
2008-12-08 06:14:34 +00:00
Felix Rabinovich 655581f3c9 Show unit test errors as text; not as html 2008-12-08 05:19:21 +00:00
Bharat Mediratta 8592aad2bb Replace protected array and __get() with just class variables. This is faster and tighter. 2008-12-08 04:55:39 +00:00
Bharat Mediratta 736829490a Minor cleanups. 2008-12-08 04:50:56 +00:00
Bharat Mediratta 528a48a96e Minor cleanups. 2008-12-08 04:47:31 +00:00
Bharat Mediratta 73496de94f Tighten up head() 2008-12-08 04:39:21 +00:00
Tim Almdal ee2299d6d0 Restructure Menu processing to respect the differnent types of menu items (Menu's, Menu_Link, Menu_Dialog) 2008-12-08 00:23:33 +00:00
Tim Almdal bd033cda8f Move form.html.php from themes/default/views to core/views 2008-12-07 23:05:00 +00:00
Tim Almdal ba2b39624b correct menu processing such that urls=# aren't given class gDialogLink 2008-12-07 22:19:26 +00:00
Tim Almdal 3449827c5a Change the menu processing to add the gDialogLink class if the url starts with a #. this results in a modal dialog box being opened. At this point the url is not retrieved and the text just shows up in the dialog box... need to look at that 2008-12-07 22:10:23 +00:00
Tim Almdal eaffc5e085 Changed how drawForms handles hidden fields. I make the assumption that hidden fields will never have an error or label so rather then recursing to draw the hidden fields, we just render them. Also moved the hidden fields outside the <ul>. 2008-12-07 21:52:06 +00:00
Tim Almdal 5f9e35bf93 Remove debugging code 2008-12-07 21:34:19 +00:00
Tim Almdal e518dafb19 1) Revert the changes to Form_Upload and Form_Textarea, so we don't have to change third party code.
2) Change drawForm to check for a non empty $input->class in order to determime if the element should be wrapped in <li>...</li>.  If $input->class is empty then treat as a hidden field.
2008-12-07 21:24:50 +00:00
Tim Almdal 954fcf0342 Merge gallery3/branches/menus back into gallery3/trunk 2008-12-07 19:45:46 +00:00
Tim Almdal b409a376f3 1) Change the photo description field to a text area
2) Added a 'type' data element to both forge/Form_Textarea and forge/Form_Upload

The second change allows the drawForm to correctly render both of these elements enclosed in a <li>...</li> html blocl
2008-12-07 17:09:21 +00:00
Bharat Mediratta 5d23a6515d Finish writing unit tests for Access. No bugs found! 2008-12-07 10:56:44 +00:00
Bharat Mediratta fef188d787 Leave all locking in ORM_MPTT::move_to, don't worry about it in
Item_Model::move_to, unless it turns out that we really need to.
2008-12-07 09:25:40 +00:00
Bharat Mediratta bf7ab8904a Change ORM_MPTT::add_to_parent() to take an ORM instead of an id so
that it's consistent with ORM_MPTT::move_to()
2008-12-07 08:46:44 +00:00
Bharat Mediratta e40b54a468 Adjust exception text to our normal form. 2008-12-07 08:32:30 +00:00
Bharat Mediratta c9cc6ffd1a fix a couple of typos. 2008-12-07 08:30:08 +00:00
Bharat Mediratta 055aa04497 Rename moveTo to move_to and extend the test a bit. 2008-12-07 08:23:22 +00:00
Bharat Mediratta d086f31ea4 Style cleanups to make File_Structure_Test pass. 2008-12-07 07:42:02 +00:00
Chad Kieffer ba18542527 Yay! Working item upload dialog from the album page! 2008-12-07 07:04:58 +00:00
Chad Kieffer c65ae12032 Let dialogs be draggable for now. 2008-12-07 04:58:07 +00:00
Bharat Mediratta f0a1950597 Fix a bug in the redirect after adding photos. 2008-12-07 04:56:39 +00:00
Chad Kieffer 36cda412f4 First go around at reusable modal dialogs. Moved jQuery UI CSS into screen.css, moved default theme JS to js folder. Named jQuery UI files to match the file names as they distribute them. Removed accordion, it's not used yet. 2008-12-07 04:49:26 +00:00
Chad Kieffer 9bfeb413ab Added title attribute. 2008-12-07 01:28:37 +00:00
Bharat Mediratta 2aa84796f3 * Don't call _getadd_photo_html() when we don't have an items table.
* Guard against errors when uninstalling modules that don't have any code left (eg: carousel)
* Create the var/uploads dir automatically.
2008-12-07 01:24:44 +00:00
Chad Kieffer adfe664d96 Removed tabs, todo, added description 2008-12-06 23:28:26 +00:00
Tim Almdal fb6e22e145 Implemented photo::_get_photo_add(). You need to create the var/uploads directory and make it writable by the server. The location of the temporary upload directory is specified in config/upload.php 2008-12-06 21:14:36 +00:00
Tim Almdal 64c380a60d Correct @todo's in Item_Controller 2008-12-06 20:27:55 +00:00
Chad Kieffer dca3cd2e8d Switch the slideshow link from text to icon. 2008-12-06 17:18:55 +00:00
Tim Almdal 611b8f44ed Add firing comment_added and comment_updated events 2008-12-06 06:10:15 +00:00
Bharat Mediratta bda84d71eb Fix a bug where any uninstall removed the entire database. 2008-12-05 06:27:02 +00:00
Chad Kieffer 89787fa8ab Make sure the pager clears the album grid. 2008-12-05 06:26:33 +00:00
Chad Kieffer 69f48d37c3 Removing carousel. Slideshow and planned album views should cover this functionality 2008-12-05 06:22:51 +00:00
Chad Kieffer bfd3a21dfd Added album and item view icons (album, hybrid, slideshow, full size). Added "Options" menu placeholder to display item options (add, edit, subscribe, permissions, etc.). Renamed gAlbumHeaderMenu to gItemMenu which can be used on both album and item views. 2008-12-05 06:06:02 +00:00
Chad Kieffer 0d1c040605 Don't need to pass the event, it's not used. 2008-12-05 06:01:44 +00:00
Chad Kieffer 2e908ec6e5 Read that $("#Selector").length was a good way to check whether an element exists in the DOM/jQuery object. 2008-12-05 05:59:50 +00:00
Tim Almdal 8d1790a0b4 * Add a moveTo unit test
* Pass the module::event(..., $data) by reference to the handlers
2008-12-05 04:56:33 +00:00
Chad Kieffer 362f43169c Removed right border off of #Content container, don't need the separation between it and the Sidebar. 2008-12-05 04:24:54 +00:00
Tim Almdal 6ea063bc4c Tweak some issues with the moveTo Processing 2008-12-04 21:33:25 +00:00
Tim Almdal 0f103b1c06 Moving albums around with a drag and drop interface seems to work and preserve the left right pointers.
* changed _lock and _unlock to protected methods lock and lock respectively
* added a moveTo method on the Item_Model
* Corrected the hole closure  on delete.
* added moveTo on the ORM_MTPP class
* Changed the rearrange javascript to do moves with ajax
2008-12-04 20:05:58 +00:00
Bharat Mediratta 80a7db61c9 Fix up the test framework to work now that we're only loading installed modules
via the autoloader.
2008-12-04 08:17:57 +00:00
Bharat Mediratta 9ba9f7bf27 Change the startup code to only put installed modules on the autoload
path.  This breaks a bunch of places where we had hardcoded
dependencies, so guard all of those cases.  Restructure
module::available() a bit and the way that we do install/uninstall in
the scaffolding.
2008-12-04 07:44:28 +00:00
Tim Almdal deafa2f912 remove unused ->root 2008-12-04 06:43:16 +00:00
Bharat Mediratta bae905a4cb Improvements to access helper.
o Rename access::remove_group() to access::delete_group() for
  consistency.

o Wrote more unit tests

o Tests found a bug in access::remove_item() .. yay!
2008-12-04 06:40:35 +00:00
Tim Almdal 1ae3ed7e3b Get rid of the rearrange helper as the code could be inlined 2008-12-04 06:36:14 +00:00