Commit Graph
2893 Commits
Author SHA1 Message Date
Bharat Mediratta e0d31add9f Merge branch 'master' of git@github.com:gallery/gallery3 2010-01-26 13:26:26 -08:00
Bharat Mediratta e315ce348b Added view_permissions_propagate_down_to_photos_test(). 2010-01-26 13:26:03 -08:00
Tim Almdal accd00464e Add a maintenance task that will clear the expired files (older than 2 weeks) from var/logs and var/tmp. Fixes ticket #982 2010-01-26 07:03:14 -08:00
Andy Staudacher 119297e2ad Apply html::clean() to UI visible strings, and show language names instead of locale tags to be consistent with the user edit form. 2010-01-25 23:05:41 -08:00
Bharat Mediratta f8b8103c24 Make only one attempt to restore the old identity provider in case of
failure.  Else, we can get into an infinite recursion.
2010-01-25 19:50:56 -08:00
Tim Almdal 6023f2bb46 Remove the return url and change the return button on the user profile page to use javascript to return to the previous page. 2010-01-25 08:10:28 -08:00
Tim Almdal 445295a1ed Insure that if original() is called and no original has been created, then create it before returning. Fixes ticket #989. 2010-01-24 22:08:59 -08:00
Tim Almdal 865995305c Add the active notifications and rest api key to user profile page. 2010-01-24 20:14:01 -08:00
Tim Almdal 26eb000637 add CSRF protection to the user profile send method. 2010-01-24 15:49:02 -08:00
Tim Almdal c9ea1a64de Remove the one last remaining reference to "no_module_admin". 2010-01-24 15:40:56 -08:00
Tim Almdal 2cb28d46f8 Merge branch 'master' of git@github.com:gallery/gallery3 2010-01-24 15:27:41 -08:00
Tim Almdal 7c06e21ec4 Refactor creating the user profile page content into the the event module. The show_user_profile is used to provide content to the user profile page. Add the list of the users comments to the profile page. 2010-01-24 15:27:33 -08:00
Tim Almdal 3b16d0662b Merge branch 'master' of git@github.com:gallery/gallery3 2010-01-23 23:58:53 -08:00
Tim Almdal 3b8636e529 Update the Xss_Security_Test and the Controller_Auth_Test. 2010-01-23 23:53:16 -08:00
Tim Almdal c39437a192 Change the hover text to just display 'Your profile'. 2010-01-23 23:52:29 -08:00
Tim Almdal ed5b07b335 Create a user profile page that is used as a landing page when referencing a user in messages or pages.
Partial fix for ticket #889 and a fix for #931.
2010-01-23 21:38:01 -08:00
Bharat Mediratta 61e31b6f77 Fix typo: change $entryr to $entry->user 2010-01-23 16:45:10 -08:00
Andy Staudacher c9b775c21a Fix for bug 984, consistently interpret installed / available locales as array.
On the current hostgater setup (PHP 5.2.12), locales::available() was returning an array and isset($locales->$code) would always (silently) return false.

Choosing array over stdClass since count($someStdClass) will always return 1, and not the number of object members.
2010-01-23 15:46:01 -08:00
Tim Almdal a1a3d4f595 Correct the javascript so it will find the "Continue" button in other languages than english. 2010-01-23 14:57:10 -08:00
Tim Almdal abdeb21ccb Add a user_menu method to the Admin_View and then use this method to get the
user menu.  Since the information displayed is identical in both admin and
theme views, it makes sense to combine the generation to it is done in a common
location.
2010-01-23 13:29:49 -08:00
Tim Almdal 06ef3885b3 Increase the size of the 'select photos' button so that it doesn't wrap and set the size of the underlying flash object. 2010-01-23 09:23:08 -08:00
Tim Almdal ece403877f If the userid/password combination, render the full page instead of just printing the form. Fixes ticket #980. 2010-01-22 18:12:30 -08:00
Tim Almdal ff5ccf0fb3 Specify the height and overflow-y on l10n-client translation element. fixes ticket #899. 2010-01-22 14:38:58 -08:00
Tim Almdal b01fce613b Remove the g-right class on groups element on the manage user/groups page. fixes ticket #911 2010-01-22 14:16:41 -08:00
Tim Almdal 79bcfc93c3 Merge branch 'master' of git@github.com:gallery/gallery3 2010-01-22 13:38:23 -08:00
Tim Almdal eabeeeb126 Trap any errors that may occur when trying to install a new identity provider and then reinstall the current one. 2010-01-22 13:38:05 -08:00
Tim Almdal df313cac56 Change the check_environment method in the module helper and the module installers to can_activate to reflect that it is doing more than just checking the environment. 2010-01-22 12:30:17 -08:00
Tim Almdal dabd5b84b2 Remove the identity manager screens and controller as alterntive identity providers are installed in the admin module screen. 2010-01-22 12:22:31 -08:00
Tim Almdal 1175783123 Disable the continue button after clicking so it can only clicked once. 2010-01-22 12:16:36 -08:00
Tim Almdal ae568b6182 Refactor the identity provider installation in to a common helper method (change_provider) with an initialization callback. 2010-01-22 12:09:11 -08:00
Tim Almdal 603c3049a1 Treat identity providers just like other modules and use the admin_module to
install and switch to a different identity provider.
2010-01-22 09:39:29 -08:00
Andy Staudacher 120c9c749e Change "fetch translations" task to fetch them in batches.
The request limit was in place already, but the client didn't respect it before, leading to unhappy users in case they had lots of 3rd party modules installed, or more than 2-3 locales enabled. This is all taken care of now.
2010-01-22 01:16:16 -08:00
Andy Staudacher 07ba5fe43a Use Unicode instead of HTML entity (since the l10n server normalizes this way and rejects submissions that change under the normalization step) 2010-01-21 23:53:21 -08:00
Tim Almdal 0da5d9e606 Internationalize all strings in admin_modules.hmtl and corrected comments. 2010-01-21 20:33:26 -08:00
Tim Almdal ff2d81b7c3 Convert the slideshow module to use the new check environment and pre_deactivate api methods. 2010-01-21 13:03:58 -08:00
Tim Almdal d59c6ed4f1 The admin module controller allows modules to provide a check_environment method
which is called prior to installation.  The method allows the module to provide
an error message or warnings if the module can not be installed or activated
without issues.  The admin module controller also will fire a pre_deactivate
event, which allows modules to indicate issues that may arise be deactivating the
specified module.

These messages are displayed in a dialog box prior to installation in order to
allow the gallery administrator to determine the appropriate action before proceeding.

Lays the foundation for implementing a fix for ticket #937
2010-01-21 12:57:45 -08:00
Andy Staudacher 6dd92cfa1c Fix maintenance tasks / language admin for bug introduced earlier by no longer casting in ORM.
Task->done is now a string, boolean false is stored as integer 0 and loaded as string "0". On the client side that's interpreted as truthy in JavaScript.
Fix: cast "0" to (bool) before encoding to JSON.
2010-01-20 23:12:36 -08:00
Bharat Mediratta 9384f987bb Coerce some integers to strings now that ORM isn't typecasting anymore. 2010-01-18 12:52:52 -08:00
Bharat Mediratta 06cabecd76 Coerce some integers to strings now that ORM isn't typecasting anymore. 2010-01-18 12:49:58 -08:00
Bharat Mediratta a9f07986f6 The root parent id is 0, not null (this deviation exposed by the new lack of typecasting in ORM). 2010-01-18 12:39:42 -08:00
Bharat Mediratta cf236a228a Don't assert_same() now that typecasting is gone from ORM. 2010-01-18 12:37:20 -08:00
Bharat Mediratta cac4692510 Don't use rand() as the name. Now that ORM::load_types() is gone, it
won't get coerced to a string, and then we wind up comparing:

  12345 != 12345-12321

In the old approach, they'd both be strings so they'd be inequal.  But
in the new approach the first value is an integer (sinced it came from
rand()) so the second value is typecast to an integer which drops
everything after the - sign so they appear equal.
2010-01-18 12:35:26 -08:00
Bharat Mediratta b27907fff7 Merge branch 'master' into kohana_update 2010-01-18 12:22:18 -08:00
Bharat Mediratta 51427d5404 Verified 2010-01-18 12:21:57 -08:00
Bharat Mediratta 284788d964 Switch from stdClass to arrays which works around issues caused in
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but
the solutions are equivalent so I'm not going to dig too far.
2010-01-18 12:08:39 -08:00
Bharat Mediratta 41a392611c Change DENY and ALLOW to "0" and "1" to match the fact that ORM no
longer typecasts values as of http://dev.kohanaphp.com/issues/2459
2010-01-18 12:08:05 -08:00
Bharat Mediratta 4eafe97b48 Reload $item after removing view permissions. 2010-01-18 11:57:23 -08:00
Bharat Mediratta 0dc184e99f Overload url::current() and url::merge() to make the current url XSS
safe.  Add tests to make sure that it doesn't relapse with future
Kohana changes.  Fixes ticket #983.

Ref: http://gallery.menalto.com/node/93738
2010-01-18 11:10:37 -08:00
Bharat Mediratta 2c2c77ea39 Remove debug code. 2010-01-16 00:19:35 -08:00
Bharat Mediratta dcf4b5e71a Don't pass MY_ORM::original() to update event handlers, since after
parent::save() it'll be reset.  Clone it first.

This is an alternate fix for #978.
2010-01-16 00:13:28 -08:00