stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-16 10:22:47 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,217 Commits 4 Branches 0 Tags
f2477703faa7cd05ff1aa16da3ecef7b666bef40
Commit Graph
4063 Commits
Author SHA1 Message Date
Joe7 f2477703fa Fix against ticket #1581 - based on https://github.com/Joe7/gallery3/commit/0d36b97aca3b5ed53ea3ea398ce28b0f6198e577 2011-01-07 17:33:37 +01:00
Bharat Mediratta d74aad072d Some small follow on fixes for #1559 and #1568: 
1) Make database changes in gallery_installer::install() instead of
   in installer/install.ql
2) Bump the version number in modules/gallery/module.info
 2011-01-03 12:25:51 -08:00
Bharat Mediratta 4a88210825 Follow on to cfaa62370e to fix indentation. 
Fixes #1569.
 2011-01-03 11:41:25 -08:00
Joe7andBharat Mediratta f364e8a96b Using array support introduced in 8295201adf948ea35f21f75801b7a8bf36c27569 2011-01-03 11:38:21 -08:00
Joe7andBharat Mediratta cfaa62370e Reimplemented Kohana 2.3's View::set_global() with array support. 
Allows for cleaner code and fewer function calls.
 2011-01-03 11:38:13 -08:00
Joe7andBharat Mediratta e6a5f39b91 case fix 2011-01-03 11:10:31 -08:00
Joe7andBharat Mediratta b26eff7f23 Bugfix: input validation validates description up to length of 65535 chars, but DB trimmed data over 2048 chars. Converting column into TEXT type. 
Note: The effective maximum length of a VARCHAR in MySQL 5.0.3 and later is subject to the maximum row size (65,535 bytes, which is shared among all columns) and the character set used.
In contrast to CHAR, VARCHAR values are stored as a one-byte or two-byte length prefix plus data. The length prefix indicates the number of bytes in the value. A column uses one length byte if values require no more than 255 bytes, two length bytes if values may require more than 255 bytes.
 2011-01-03 11:08:21 -08:00
Joe7andBharat Mediratta 7ce902d373 Removed accidental whitespace 2011-01-03 11:01:09 -08:00
Joe7andBharat Mediratta 336632fea0 Keep view counters of all item types accurate 
Added common increment_view_count() func in item model for reuse
 2011-01-03 11:01:02 -08:00
Bharat Mediratta a8b0254e4a Improve the solution for #1545 by sorting the settings menu properly 
to be naturally ordered and case insensitive.
 2010-12-29 17:31:28 -08:00
Bharat Mediratta 3e117fc2b4 Remove a stray comma at the end of a JSON array which was breakig IE. Fixes #1561. 2010-12-29 11:33:08 -08:00
Joe7andBharat Mediratta 17700b805f Coding style fixes: identation on line 48+removed trailing whitespaces, added spaces around =s 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 869bba5e13 Truncating table first againt collides when converting INDEX into Unique 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 440597356d Added changes to installer and upgrader scripts to support INSERT ON DUPLICATE KEY UPDATE SYNTAX in cache lib 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 66fd8c7518 Using ON DUPLICATE KEY UPDATE instead of SELECT+UPDATE/INSERT style method (that does 2 trips to Database server and is less optimal). 
exists() method is not needed anymore thus got removed
 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta fda9250796 Added limit on select as for the outcome it doesn't matter if there are 20 rows or just 1. Is sufficient to return straight after reading 1 row. 2010-12-28 23:14:04 -08:00
Bharat Mediratta b42fcb9cda Use db::expr instead of "new Database_Expression". Resolves #1560. 2010-12-28 23:10:05 -08:00
Bharat Mediratta 9f3c6e4bee Update test to match change in Item_Model::as_restful_array made in 
7e31f97b4c for #1536.
 2010-12-28 22:00:25 -08:00
Bharat Mediratta 5d37d529b0 Update golden file to reflect the change in 
c989981041 for #1520.
 2010-12-28 21:56:31 -08:00
Bharat Mediratta d0e78fc5cf Fix capitalization to be sentence case. 2010-12-26 23:06:09 -08:00
dmolavi 2d4d613318 Correct image block plurality, fixes 1506 2010-12-25 16:09:42 -05:00
Bharat Mediratta 11df9f204f Added Croatian as hr_HR. Fixes #1514. 2010-12-24 01:10:17 -08:00
Bharat Mediratta b5ba61fc53 Create a way for controllers to exempty themselves from maintenance 
mode and private gallery mode by setting the following constants in
the controller to true.

  ALLOW_MAINTENANCE_MODE
  ALLOW_PRIVATE_GALLERY

Fixes #1411 and the subsequent refactoring fixes #1551 as well.
 2010-12-23 23:34:04 -08:00
Bharat Mediratta 2b83918efd Fix PHPDoc for composite(). 2010-12-23 23:16:30 -08:00
Bharat Mediratta 032e6fde5f Change MY_url::parse_url to use item::find_by_relative_url. 2010-12-21 20:47:14 -08:00
Bharat Mediratta 98fd1e9957 Implement item::find_by_relative_url with tests. 2010-12-21 20:47:07 -08:00
Bharat Mediratta c5ede5881b Updated to use the new item::find_by_path() API. 2010-12-21 19:36:23 -08:00
Bharat Mediratta d9299f3b3f Change item::find_by_path() to check the relative_path_cache first, 
and only fall back the name/level comparison if there's no cached
entry.  Update tests accordingly.
 2010-12-21 19:33:47 -08:00
Bharat Mediratta 2a08cbf76d Return an empty Item_Model when item::find_by_path fails 2010-12-21 16:58:54 -08:00
Bharat Mediratta f493130e59 Tighten up item::find_by_path slightly. Augment the tests to cover 
special characters in the file name ("+" is an edge case differentiator
between rawurlencode and urlencode).
 2010-12-21 16:55:01 -08:00
Bharat Mediratta c7096cc9eb Fix assertion order to be (expected,actual) 
Change strinct concatenation to be variable interpolation to tighten it up.
 2010-12-21 16:32:02 -08:00
Kriss AndstenandBharat Mediratta addd384bbd Minor changes to satisfy the G3 code standards. 2010-12-22 08:22:25 +08:00
Kriss AndstenandBharat Mediratta 48640005a4 Packaging + tests of Bharat's find_by_path routine. 2010-12-22 08:22:25 +08:00
Bharat Mediratta 612ddd7050 Warn admins after login if their PHP install has the 
session.use_trans_sid feature enabled, since this will cause random
logouts.  Partial fix for #1316.
 2010-12-18 11:55:04 -08:00
Bharat Mediratta dbb9b8b1c8 Sort the Admin > Settings menu instead of relying on module activation order. 
Requires making Menu::get() return a reference.  Fixes #1545.
 2010-12-17 22:19:46 -08:00
Bharat Mediratta e60edcdeba Include the root in the tree output. 2010-12-17 17:30:00 -08:00
Bharat Mediratta b6c202d572 Swap the order of the CSS and JS for performance. Fixes #1540. 2010-12-16 22:18:04 -08:00
Bharat Mediratta 6e58fced20 Follow on to 16555935ee to clean up the 
style a bit.  Tracked in #1539.
 2010-12-16 21:01:51 -08:00
Kriss AndstenandBharat Mediratta 16555935ee Fetch permissions for non-albumbs by parent rather than by item, allowing the result to be cached. 2010-12-17 12:50:51 +08:00
Bharat Mediratta 7eaf49a6ca Create a "tree" rest resource that can return the entire album tree in 
a single fast request, among other operations.  Fixes #1538.
 2010-12-16 20:38:01 -08:00
Bharat Mediratta 161a85d3f5 Enable profiling output in the HTML output for REST. Fixes #1535. 2010-12-16 20:37:44 -08:00
Bharat Mediratta 7e31f97b4c Improve Item_Model::as_restful_array() to take an array of fields so 
that we only return the fields we care about.  This improves
performance when retrieving large numbers of items.  Fixes #1536.
 2010-12-16 20:37:00 -08:00
Bharat Mediratta 53a2652fd6 Create url::merge_querystring() which merges a query string into an 
existing url.  Fixes #1537.
 2010-12-16 20:36:00 -08:00
Bharat Mediratta 8a5bbc896b Follow on to 1057436b7c -- cache the 
users and groups as an array so that multiple calls will not call
ORM_Iterator->current() repeatedly.
 2010-12-15 19:57:09 -08:00
Bharat Mediratta 1057436b7c Cache the result of User_Model::groups() and Group_Model::users() and 
invalidate it on save/delete for efficiency.  Fixes #1529.
 2010-12-15 16:28:18 -08:00
Bharat Mediratta b9e11a6f93 Don't show the "can't find ffmpeg" message to non-admins. Fixes #1528. 2010-12-15 15:16:00 -08:00
Bharat Mediratta cd48b89f31 Consolidate all the random code into a random helper that offers: 
random::hash()
  random::string()
  random::percent()
  random::int()

So that we don't have lots of different ways to get random values all
over the code.  Follow-on to #1527.
 2010-12-15 14:57:00 -08:00
Bharat Mediratta 45c63f4d11 Use mt_rand() instead of rand() since it provides better portability. 
Fixes #1527.
 2010-12-15 12:48:56 -08:00
Bharat Mediratta 6fb0eb4e97 Follow on to d2be26e407 to update the 
unit tests to reflect the proper type filtering for #1503.
 2010-12-15 12:24:31 -08:00
Bharat Mediratta ff4c930338 Clean up golden file as a follow-on to 
3c523bcac6 for #1499.
 2010-12-15 12:08:56 -08:00