Tim Almdal
ece403877f
If the userid/password combination, render the full page instead of just printing the form. Fixes ticket #980 .
2010-01-22 18:12:30 -08:00
Tim Almdal
ff5ccf0fb3
Specify the height and overflow-y on l10n-client translation element. fixes ticket #899 .
2010-01-22 14:38:58 -08:00
Tim Almdal
b01fce613b
Remove the g-right class on groups element on the manage user/groups page. fixes ticket #911
2010-01-22 14:16:41 -08:00
Tim Almdal
79bcfc93c3
Merge branch 'master' of git@github.com:gallery/gallery3
2010-01-22 13:38:23 -08:00
Tim Almdal
eabeeeb126
Trap any errors that may occur when trying to install a new identity provider and then reinstall the current one.
2010-01-22 13:38:05 -08:00
Tim Almdal
df313cac56
Change the check_environment method in the module helper and the module installers to can_activate to reflect that it is doing more than just checking the environment.
2010-01-22 12:30:17 -08:00
Tim Almdal
dabd5b84b2
Remove the identity manager screens and controller as alterntive identity providers are installed in the admin module screen.
2010-01-22 12:22:31 -08:00
Tim Almdal
1175783123
Disable the continue button after clicking so it can only clicked once.
2010-01-22 12:16:36 -08:00
Tim Almdal
ae568b6182
Refactor the identity provider installation in to a common helper method (change_provider) with an initialization callback.
2010-01-22 12:09:11 -08:00
Tim Almdal
603c3049a1
Treat identity providers just like other modules and use the admin_module to
...
install and switch to a different identity provider.
2010-01-22 09:39:29 -08:00
Andy Staudacher
120c9c749e
Change "fetch translations" task to fetch them in batches.
...
The request limit was in place already, but the client didn't respect it before, leading to unhappy users in case they had lots of 3rd party modules installed, or more than 2-3 locales enabled. This is all taken care of now.
2010-01-22 01:16:16 -08:00
Andy Staudacher
07ba5fe43a
Use Unicode instead of HTML entity (since the l10n server normalizes this way and rejects submissions that change under the normalization step)
2010-01-21 23:53:21 -08:00
Tim Almdal
0da5d9e606
Internationalize all strings in admin_modules.hmtl and corrected comments.
2010-01-21 20:33:26 -08:00
Tim Almdal
ff2d81b7c3
Convert the slideshow module to use the new check environment and pre_deactivate api methods.
2010-01-21 13:03:58 -08:00
Tim Almdal
d59c6ed4f1
The admin module controller allows modules to provide a check_environment method
...
which is called prior to installation. The method allows the module to provide
an error message or warnings if the module can not be installed or activated
without issues. The admin module controller also will fire a pre_deactivate
event, which allows modules to indicate issues that may arise be deactivating the
specified module.
These messages are displayed in a dialog box prior to installation in order to
allow the gallery administrator to determine the appropriate action before proceeding.
Lays the foundation for implementing a fix for ticket #937
2010-01-21 12:57:45 -08:00
Andy Staudacher
6dd92cfa1c
Fix maintenance tasks / language admin for bug introduced earlier by no longer casting in ORM.
...
Task->done is now a string, boolean false is stored as integer 0 and loaded as string "0". On the client side that's interpreted as truthy in JavaScript.
Fix: cast "0" to (bool) before encoding to JSON.
2010-01-20 23:12:36 -08:00
Bharat Mediratta
9384f987bb
Coerce some integers to strings now that ORM isn't typecasting anymore.
2010-01-18 12:52:52 -08:00
Bharat Mediratta
06cabecd76
Coerce some integers to strings now that ORM isn't typecasting anymore.
2010-01-18 12:49:58 -08:00
Bharat Mediratta
a9f07986f6
The root parent id is 0, not null (this deviation exposed by the new lack of typecasting in ORM).
2010-01-18 12:39:42 -08:00
Bharat Mediratta
cf236a228a
Don't assert_same() now that typecasting is gone from ORM.
2010-01-18 12:37:20 -08:00
Bharat Mediratta
cac4692510
Don't use rand() as the name. Now that ORM::load_types() is gone, it
...
won't get coerced to a string, and then we wind up comparing:
12345 != 12345-12321
In the old approach, they'd both be strings so they'd be inequal. But
in the new approach the first value is an integer (sinced it came from
rand()) so the second value is typecast to an integer which drops
everything after the - sign so they appear equal.
2010-01-18 12:35:26 -08:00
Bharat Mediratta
b27907fff7
Merge branch 'master' into kohana_update
2010-01-18 12:22:18 -08:00
Bharat Mediratta
51427d5404
Verified
2010-01-18 12:21:57 -08:00
Bharat Mediratta
284788d964
Switch from stdClass to arrays which works around issues caused in
...
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but
the solutions are equivalent so I'm not going to dig too far.
2010-01-18 12:08:39 -08:00
Bharat Mediratta
41a392611c
Change DENY and ALLOW to "0" and "1" to match the fact that ORM no
...
longer typecasts values as of http://dev.kohanaphp.com/issues/2459
2010-01-18 12:08:05 -08:00
Bharat Mediratta
4eafe97b48
Reload $item after removing view permissions.
2010-01-18 11:57:23 -08:00
Bharat Mediratta
0dc184e99f
Overload url::current() and url::merge() to make the current url XSS
...
safe. Add tests to make sure that it doesn't relapse with future
Kohana changes. Fixes ticket #983 .
Ref: http://gallery.menalto.com/node/93738
2010-01-18 11:10:37 -08:00
Bharat Mediratta
2c2c77ea39
Remove debug code.
2010-01-16 00:19:35 -08:00
Bharat Mediratta
dcf4b5e71a
Don't pass MY_ORM::original() to update event handlers, since after
...
parent::save() it'll be reset. Clone it first.
This is an alternate fix for #978 .
2010-01-16 00:13:28 -08:00
Bharat Mediratta
9f03d36d6e
Don't use MY_ORM::original() here since the values may not have
...
changed since the last save. Instead, use the original ORM passed in.
2010-01-16 00:10:55 -08:00
Bharat Mediratta
00c73a4b07
Revert "Fix for ticket #978 . Don't reset the original property as part of the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original."
...
This reverts commit daeaca110d
2010-01-15 23:53:43 -08:00
Bharat Mediratta
99073c3e20
Revert "Did the old commit then save trick"
...
This reverts commit e41ad23a8e
2010-01-15 23:53:35 -08:00
Tim Almdal
260660b2f6
Somemore K24 migration holdovers. need to specify the where statement with operands. '=' is no longer assumed. Fixes ticket #979
2010-01-13 12:08:56 -08:00
Tim Almdal
e41ad23a8e
Did the old commit then save trick
2010-01-13 11:47:27 -08:00
Tim Almdal
daeaca110d
Fix for ticket #978 . Don't reset the original property as part of the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original.
2010-01-13 11:27:09 -08:00
Tim Almdal
639f1e741a
Put quotes around the item titles in all the messages and more importantly actually display the original's title properly. Fixes ticket #966 , but does now show us ticket #978
2010-01-12 11:42:31 -08:00
Tim Almdal
e81acce985
If the user hits enter in the search text field, then cancel the submission, because the search is done in the browser and the the enter will unexpectedly reload the root directory.
2010-01-12 09:42:06 -08:00
Tim Almdal
42d7c9590e
Correct the "l10n_client_data[index] is undefined" error.
2010-01-12 08:58:49 -08:00
Tim Almdal
9ff9d70fe2
Some whitespace and syntax corrects
2010-01-12 08:32:33 -08:00
Tim Almdal
3dfac5884f
Add a css id attribute to the i10n-edit-translation element. Fixes ticket #969 .
2010-01-12 08:31:28 -08:00
Tim Almdal
3b26d87f3a
Reformat the string list so that the search box does not get push off the end of the page.
2010-01-11 14:22:16 -08:00
Tim Almdal
2b283f4d01
Remove the translation submit button from translation search form. Fixes ticket #975
2010-01-11 13:26:10 -08:00
Tim Almdal
284e14d50e
Remove the automatically marking the resizes dirty line as this could cause alot of pain to some installations
2010-01-11 10:48:27 -08:00
Tim Almdal
3ab6c4915a
Fixes ticket #671 .
...
In the graphics_rules table height and width set the maximum height and width
values and should be equal. Initially, the height on the resize target rule was
less than the height, which artificially constrained images in portrait mode.
**Note"" this fix requires an upgrade to version 22. All the resizes will be flagged
dirty.
2010-01-11 10:42:39 -08:00
Tim Almdal
a11bf29507
Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any where
...
clauses and deletes all the entries in the table unless an array of id's are
passed as the parameter. This fix used the Database_builder to specify any where
conditions. Thanks psvo for find the first one. :-)
2010-01-09 23:57:16 -08:00
Tim Almdal
bd9f945e3f
Remove the display of the "body_attributes" div when in debug mode. debug mode is by default set up to add new div's to display the location of the content. "body_attributes" are attributes on the body tag and trying to add content introduces an extra > in the html stream.
2010-01-08 12:49:16 -08:00
Tim Almdal
2ab6eda728
Change file proxy to url encode the path components instead of the entire path. Otherwise, we will encode the slashes and won't find the item.
2010-01-08 12:18:46 -08:00
Tim Almdal
46e33f1bbe
Fix for ticket #933 . Move the inclusion of the piclens script from the theme::header callback to the theme::page_bottom callback.
2010-01-08 11:06:54 -08:00
Tim Almdal
58620c5faa
Use rawurlencode to remove any encoding that the browser may have added. Fixes ticket #954 .
2010-01-07 10:55:43 -08:00
Bharat Mediratta
10c05c855a
Merge branch 'master' of git@github.com:gallery/gallery3
2010-01-06 17:05:00 -08:00
