Commit Graph
5668 Commits
Author SHA1 Message Date
Bharat Mediratta 2925a1c797 Require "add" permission to show the add form. 2009-05-29 17:54:20 -07:00
Bharat Mediratta 381dd0574a Don't show the add photo/album options to users who don't have the
permission.  This isn't a security hole, since they can't actually add
stuff.. but they can try and fail which is a bad user experience.

Also fix it up so that we show the option menu only if there's stuff
to show, and cache some of the permissions for performance (which I'm
guessing at-- didn't benchmark it).
2009-05-29 17:53:33 -07:00
Bharat Mediratta 055e0a7dc5 Remove a completed @todo 2009-05-29 17:42:31 -07:00
Bharat Mediratta 34da188e81 Revert test code inserted in 88a3d43ba9
which showed stack traces to non-admins.
2009-05-29 17:40:23 -07:00
Bharat Mediratta b0cb3c7402 Update Kohana to r4374 2009-05-29 12:00:49 -07:00
Bharat Mediratta 0097803efc Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 21:42:18 -07:00
Bharat Mediratta 356bac0db0 Restore calls to module::load_modules() after install/activate/deactivate/uninstall events. 2009-05-28 21:18:46 -07:00
Bharat Mediratta c4c70c537d Tweak path slightly 2009-05-28 21:18:31 -07:00
Bharat Mediratta 73f348b29e Protect get() against missing records. 2009-05-28 21:07:47 -07:00
Bharat Mediratta d088a41747 Load the gallery module in load_modules(), but put it at the end of
the module list (to match its location in the cascading filesystem)
2009-05-28 21:00:06 -07:00
Bharat Mediratta 20a2d9f9a8 Reset the cascading file path properly before reinstalling. 2009-05-28 20:59:23 -07:00
Bharat Mediratta 3da5ee2f4c Print out exception traces for most errors 2009-05-28 18:21:39 -07:00
Bharat Mediratta 7fd6fcaf9b Force modules/gallery to be at the end of the module load path, so
that all other modules can override the core code.
2009-05-28 17:46:17 -07:00
Bharat Mediratta d8f2c9f9f7 Revert "Change Kohana::include_path() to put APPPATH (core) at the end of the"
This reverts commit 7e37055408.

No longer necessary now that we're putting all the code into
modules/gallery, which we can force to be at the end of the module
path.
2009-05-28 17:42:06 -07:00
Bharat Mediratta f56e095aeb Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 02:36:36 -07:00
Bharat Mediratta 1a095fffe5 Prepend all code files we copy from Gallery2 and put into var with our
code preamble for security.

Update File_Structure_Test::code_files_start_with_preamble_test to
check all the php files in var, too.
2009-05-28 02:19:53 -07:00
Bharat Mediratta c8aa9ed440 Update tests to reflect cache-buster param on thumbnail urls. 2009-05-28 01:58:41 -07:00
Bharat Mediratta 534b8525ce Rename Core_Installer_Test -> Gallery_Installer_Test to match the
change from application -> modules/gallery.
2009-05-28 01:55:42 -07:00
Bharat Mediratta 8c3135ef72 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 01:46:19 -07:00
Bharat Mediratta 6fdc84f5de Get rid of entire gallery2 session id param from the urls that we use to alert
users about images that failed to import.
2009-05-28 01:45:39 -07:00
Bharat Mediratta c1e55e9593 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 00:49:41 -07:00
Bharat Mediratta 8d2782ad1d Flush the model cache as appropriate every time we call ORM::save().
Fixes ticket #301
2009-05-28 00:45:00 -07:00
Bharat Mediratta ebb0761b8d Label the tag input field according to the item type.
Fixes ticket #176.
2009-05-28 00:32:24 -07:00
Bharat Mediratta df51ea7fa4 Fix broken html::script() and url::file() references to the newly
moved gallery module.
2009-05-28 00:06:38 -07:00
Bharat Mediratta 1988d77039 Remove unnecessary (and broken) <form/> 2009-05-28 00:06:09 -07:00
Bharat Mediratta 93053cf831 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-27 23:15:09 -07:00
Bharat Mediratta 3870892018 Commit an egregious hack to work around the fact that both Gallery 2
and Gallery 3 have a class named Gallery.  Clone a subset of the
Gallery 2 files and munge them so that we can rename the Galery 2
version to G2_Gallery.

Also, update the disclaimer in Admin > Settings > Gallery 2 Import.
2009-05-27 22:57:38 -07:00
Bharat Mediratta 24dce5a85d Fix up another place where we were incorrectly referencing the gallery module. 2009-05-27 21:18:09 -07:00
Bharat Mediratta 993eecfee6 Rename index.local.php to local.php so that tab completion on i<tab> works.
Makes running tests easier.

Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-05-28 12:10:29 +08:00
Bharat Mediratta f64824b35c Remove extra line from a bad merge
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-05-28 12:10:29 +08:00
Bharat Mediratta 567c911fa3 Rename index.local.php to local.php so that tab completion on i<tab> works.
Makes running tests easier.
2009-05-27 21:05:35 -07:00
Bharat Mediratta 66b406ebcf Remove extra line from a bad merge 2009-05-27 20:40:44 -07:00
Bharat Mediratta bb8feb0318 Merge branch 'master' of git@github.com:gallery/gallery3 2009-05-27 20:39:07 -07:00
Bharat MedirattaandGallery Role Account bc9aeb4625 Normalize root update time in the installer
Rebuild install.sql

Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:12 +08:00
Bharat MedirattaandGallery Role Account 4dfe93d664 Fix a typo in the class name
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:11 +08:00
Bharat MedirattaandGallery Role Account 50ca9b9306 Manually updated to change 'core' to 'gallery'
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:11 +08:00
Bharat MedirattaandGallery Role Account c8f849b38f Convert a few more references of APPPATH to MODPATH/gallery
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:10 +08:00
Bharat MedirattaandGallery Role Account f89424bc85 Show the scaffolding link if the controller is around.
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:10 +08:00
Bharat MedirattaandGallery Role Account 4eedf804e1 Update all references to the core application to now point to the
gallery module.  This type of mass update is prone to some small bugs.

Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:09 +08:00
Bharat MedirattaandGallery Role Account 3413fe6bfd Rename 'kohana' to 'system' to conform to the Kohana filesystem layout. I'm comfortable with us not clearly drawing the distinction about the fact that it's Kohana.
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:08 +08:00
Bharat MedirattaandGallery Role Account b245e3475f Restructure things so that the application is now just another module.
Kohana makes this type of transition fairly straightforward in that
all controllers/helpers/etc are still located in the cascading
filesystem without any extra effort, except that I've temporarily
added a hack to force modules/gallery into the module path.

Rename what's left of "core" to be "application" so that it conforms
more closely to the Kohana standard (basically, just
application/config/config.php which is the minimal thing that you need
in the application directory)

There's still considerable work left to be done here.

Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:06 +08:00
Bharat Mediratta 84ce0cdefd Normalize root update time in the installer
Rebuild install.sql
2009-05-27 19:59:54 -07:00
Bharat Mediratta 23884f7968 Fix a typo in the class name 2009-05-27 19:59:34 -07:00
Bharat Mediratta 578c9f4e52 Merge branch 'master' of git@github.com:gallery/gallery3 2009-05-27 19:32:38 -07:00
tim almdal b7a193cc19 standardize the version check between installer/index.php and index.php 2009-05-27 17:11:27 -07:00
Bharat Mediratta e8cd6bd5e7 Manually updated to change 'core' to 'gallery' 2009-05-27 16:31:10 -07:00
Bharat Mediratta 5e7cc75a29 Convert a few more references of APPPATH to MODPATH/gallery 2009-05-27 16:29:33 -07:00
Bharat Mediratta 28b09a3046 Show the scaffolding link if the controller is around. 2009-05-27 16:23:05 -07:00
Bharat Mediratta 88a3d43ba9 Update all references to the core application to now point to the
gallery module.  This type of mass update is prone to some small bugs.
2009-05-27 16:17:29 -07:00
Bharat Mediratta 12fe58d997 Rename 'kohana' to 'system' to conform to the Kohana filesystem layout. I'm comfortable with us not clearly drawing the distinction about the fact that it's Kohana. 2009-05-27 15:11:53 -07:00