Bharat Mediratta
05d345e16d
Guests don't get access to the REST API.
2010-03-03 10:17:48 -08:00
Bharat Mediratta
c3c2b45280
Update the copyright to 2010. It's only 3 months into the year :-)
2010-03-03 10:15:34 -08:00
Tim Almdal
fd82bcfc0a
Merge branch 'master' into talmdal_dev
2010-03-03 08:47:54 -08:00
Andy Staudacher
109c390f25
Ignore fetchItemViewCount errors during import and default to 0. The error is still logged to the G3 syslog.
2010-03-02 13:53:09 -08:00
Romain LE DISEZ and Andy Staudacher
06d0ed57a7
Fix a typo.
2010-03-03 02:32:49 +08:00
Tim Almdal
d1b8589ea4
Merge branch 'master' into talmdal_dev
2010-03-02 07:10:22 -08:00
Florent Paterno
e4ed7e983d
Fix bug #1015 : repeated ids are prohibited
2010-03-01 17:23:56 +01:00
Chad Kieffer
aff40d2d78
Merge branch 'master' of github.com:gallery/gallery3
2010-02-28 22:10:30 -07:00
Chad Kieffer
dc00373404
Apply ui-helper-clearfix to the breadcrumb in the upload dialog to ensure it clears the upload canvas in webkit-based browsers.
2010-02-28 22:09:40 -07:00
Andy Staudacher
b0ef46b5fa
Merge commit 'upstream/master'
2010-02-28 19:31:55 -08:00
Andy Staudacher
1077477a90
G2 importer stability improvements:
...
- Log which validation rule was violated if there's an ORM validation error.
- Add more try / catch blocks to avoid abortion where possible.
2010-02-28 19:29:41 -08:00
Chad Kieffer
5f985b3e2a
Updates to upload CSS to make it themeable and RTL compatible. Use absolute positioning to handle upload button positioning. Remove color definitions to allow jQuery UI theme to set button colors. Consolidate upload dialog CSS to modules/css/gallery.css. Closes #885 .
2010-02-28 18:46:43 -07:00
Tim Almdal
835027bdb6
The vendor branch is being updated, so this reverts the revert of
...
commit c91408d4a8 .
2010-02-28 16:06:36 -08:00
Tim Almdal
c91408d4a8
Its not apppropriate to make changes to the Kohana system files. Please find another way.
...
Revert "Fix Kohana's internal cache for Gallery's usage pattern. Instead of deleting the whole find_files cache when ever include_paths (=core.modules) change, keep a separate find_files cache for each set of include_paths."
This reverts commit fd94f4bec2 .
2010-02-28 15:39:39 -08:00
Tim Almdal
e3e72ca4da
Merge branch 'master' into talmdal_dev
2010-02-28 15:38:39 -08:00
Andy Staudacher
fd94f4bec2
Fix Kohana's internal cache for Gallery's usage pattern. Instead of deleting the whole find_files cache when ever include_paths (=core.modules) change, keep a separate find_files cache for each set of include_paths.
...
Benefits for Gallery:
- There are about 3000 is_file() invocations for a photo / album page in a vanilla Gallery installation. These are mostly triggered by Kohana::find_file().
- Enabling internal_cache doesn't help at all (see explanation below). The number of is_file() invocations is about the same with or without this cache.
- With this patch, more than 95% of these invocations are gone. The cache works as intended.
Kohana's internal_cache for find_file wasn't working in Gallery because
the cache would be emptied on each request after reading it from disk and
before most lookups would run.
1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery.
2. Kohana::setup() loads find_file cache from disk.
3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense).
4. Request processing starts, and thus 80+% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache.
The patch doesn't have a significant impact on performance for Kohana applications which don't change their include paths at runtime (after Kohana::setup). And the patch should benefit all Kohana applications which have modules / extensions, i.e. which first need to bootstrap Kohana before they can load a list of all active modules from the database.
2010-02-28 13:51:18 -08:00
Andy Staudacher
a19b97f8d6
First step towards fixing ticket #1038 : Allowing for custom page <title> in admin pages, just like in non-admin pages.
...
TODO: Set $view->page_title in the many admin controllers we have. I just set it for admin_maintenance.php to show how it's intended to be used. I copied the title from views/admin_maintenance.html.php to the controller.
2010-02-28 13:35:58 -08:00
Andy Staudacher
107909043a
Fix profiler display: It looks like it was broken by an API change in the latest kohana upgrade.
2010-02-28 13:09:57 -08:00
Andy Staudacher
70837b5212
Fix for ticket #1035 : Make .htaccess access rules work for the case when index.php isn't part of generated URLs.
2010-02-27 21:26:38 -08:00
Andy Staudacher
74113f869a
Fix for ticket #1037 : Only show language drop-down when there's actually a choice.
2010-02-27 20:21:22 -08:00
Andy Staudacher
dacb58ceed
Additional fixes for plural handling when deleting translations / marking them as untranslated.
2010-02-27 20:06:37 -08:00
Andy Staudacher
caf9ae88ba
Fix l10n client, copy of existing plural translation to form fields.
...
I think this was broken in a recent jQuery update. It used to allow matching the HTML "name" attribute with #name_value, now you need to match by elementName[name=name_value].
2010-02-27 19:47:08 -08:00
Andy Staudacher
8366f58ef9
Client (UI) side fix for ticket #1042 , based on a patch from fpaterno (Florent Paterno). Mark message as untranslated if the translation is empty.
2010-02-27 19:13:22 -08:00
Andy Staudacher
48193371e4
Incremental fix for ticket #1042 : Delete translation from outgoing_translations when the user submits a form with an empty translation.
2010-02-27 18:54:36 -08:00
Andy Staudacher
a18ddd2fe9
Add more randomness to reset password mechanism.
2010-02-27 15:39:36 -08:00
Andy Staudacher
d9707ae749
Fix for ticket #1036 - Don't echo any sensitive information such as passwords, hashes or personally identifiable information.
2010-02-27 02:37:39 -08:00
Tim Almdal
7d2885fe94
Revert "Password value on installer must be hidden"
...
This reverts commit b4922f4d17 .
2010-02-26 09:59:49 -08:00
Tim Almdal
f28b80fcf4
Merge branch 'master' into talmdal_dev
2010-02-26 09:58:57 -08:00
fpaterno and Tim Almdal
b4922f4d17
Password value on installer must be hidden
2010-02-26 22:19:18 +08:00
Andy Staudacher
ed0f93a965
Fix typo, thanks cajun100 for reporting!
2010-02-25 18:26:20 -08:00
Andy Staudacher
39b8810c3b
Fix multi-column layout of language admin.
2010-02-24 16:39:18 -08:00
Andy Staudacher
c38bee203b
Add Faroese to the language list. Verified that it uses the default plural rules, thus no changes in Gallery_I18n.php or on the server side required.
2010-02-24 16:21:54 -08:00
Tim Almdal
7d7da6eb0a
Remove redundant print statement. rest::reply() does the print so having the extra print statement could lead to problems.
2010-02-24 11:49:53 -08:00
Andy Staudacher
1d8862d957
Fix for ticket #1034 : Fix db cache driver delete() call which was missed in a recent refactoring / fix.
2010-02-24 01:28:38 -08:00
Bharat Mediratta
2eea7b874a
Specify the type for movie Item_Models correctly. Fixes ticket #1033 .
2010-02-23 21:08:52 -08:00
Bharat Mediratta
d4423eb349
Reset the active user to admin in all test cases where we change the
...
user to something else.
2010-02-23 13:50:57 -08:00
Bharat Mediratta
de1785d9fa
Merge branch 'master' of github.com:gallery/gallery3
2010-02-23 12:58:30 -08:00
Andy Staudacher
212da35cdc
Fix Cache tests for recent Cache/Database.php driver fix.
...
Cache::delete($arg) allows for scalars and arrays, but Cache drivers' delete($arg) function always expects an array.
2010-02-23 12:48:03 -08:00
Bharat Mediratta
8ab580cec1
Verified
2010-02-23 11:50:39 -08:00
Bharat Mediratta
16bf1d18ad
Merge branch 'master' of github.com:gallery/gallery3
2010-02-23 11:11:11 -08:00
Bharat Mediratta
fb5503be09
Name this release "Santa Fe". Fixes ticket #683 .
2010-02-23 11:10:32 -08:00
Andy Staudacher
6afc5ccf5c
Fix translation cache for installations with 0 translations in the DB.
2010-02-23 10:02:27 -08:00
Andy Staudacher
5f97c12562
Merge commit 'upstream/master'
2010-02-22 22:01:38 -08:00
Andy Staudacher
adb1db6b7d
Fix typo in selector expression. The handling of view-only albums is still not great, but at least the code is closer to doing what it's supposed to.
2010-02-22 22:00:23 -08:00
Bharat Mediratta
ce39dc768c
Normalize invalid/missing G2 email addresses
2010-02-22 21:21:04 -08:00
Bharat Mediratta
a9f8b94793
Fix cut/paste typo
2010-02-22 21:08:59 -08:00
Andy Staudacher
f7b39e7db7
Fix server-add for German and other locales that use comma as decimal separator.
2010-02-22 12:31:46 -08:00
Andy Staudacher
6ce0132842
Fix for ticket #1027 : Add index on cache key column.
...
(and fix the packager to truncate the cache table before packaging)
2010-02-22 00:30:54 -08:00
Andy Staudacher
95374070db
Merge commit 'upstream/master'
2010-02-22 00:00:25 -08:00
Andy Staudacher
ff9129c598
Revert "Fix Kohana's internal cache for Gallery's usage pattern."
...
Waiting for feedback from Kohana devevelopers before applying the patch to Gallery 3.
This reverts commit 336c3bd264 .
2010-02-21 23:57:29 -08:00