stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-31 04:00:56 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,668 Commits 4 Branches 0 Tags
ec052d71301acbf519947897f8adda7fdcf7fefb
Commit Graph
5668 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Bharat Mediratta 66fbbab907 Add assert_array_equal_to_json(). 2010-01-20 00:06:36 -08:00
Bharat Mediratta b09450cf5d Let the Rest_Controller functions throw a Rest_Exception since 
the Kohana framework will handle it properly.
 2010-01-19 23:30:22 -08:00
Bharat Mediratta c65eca0607 Move rest::send_headers back into Rest_Exception. 2010-01-19 23:30:09 -08:00
Bharat Mediratta 92d96548e9 Make Rest_Exception extend Kohana_Exception so that we can let it 
bubble to the top and then in sendHeaders have it send the right
response code.
 2010-01-19 23:28:18 -08:00
Bharat Mediratta 76da85a1a0 Extend Gallery_Unit_Test_Case instead of Unit_Test_Case. 2010-01-19 22:38:19 -08:00
Bharat Mediratta a774dc5447 Don't send headers if they're already sent. 2010-01-19 22:38:03 -08:00
Bharat Mediratta fc4250f5d8 Use $input instead of Input::instance() 2010-01-19 22:37:38 -08:00
Bharat Mediratta 409c4dcc47 Do a better job of guarding against missing images. 2010-01-19 21:27:54 -08:00
Bharat Mediratta e39c8df19f Fix some validation checks to check to see if the original was loaded 
before deciding whether or not we changed a value.

Change valid_name to be cascading, not parallel.
 2010-01-19 21:20:36 -08:00
Bharat Mediratta 6aee6cde25 Move data initialization into the constructor so that it happens 
before validate() is called, which is important with our two phase web
controllers.

Make valid_parent smarter about moving existing items, vs new items.
 2010-01-19 20:53:21 -08:00
Bharat Mediratta b8c09b6d87 Use an appropriate json content type 2010-01-19 19:31:24 -08:00
Bharat Mediratta e02675b730 Change "filename" to "name" in the edit album form. I'd rather have 
consistency between field names than deal with underlying issues with
Forge bitching about the "name" property.
 2010-01-19 19:31:01 -08:00
Bharat Mediratta afe2128bb0 Make video/x-flv a valid movie mime_type 2010-01-19 19:30:18 -08:00
Bharat Mediratta 512910962d Change "dirname" to "name" in the edit album form. I'd rather have 
consistency between field names than deal with underlying issues with
Forge bitching about the "name" property.
 2010-01-19 19:24:46 -08:00
Bharat Mediratta c3ed64fc6c Use property_exists() on our stdClass instead of array_key_exists() 2010-01-19 01:46:45 -08:00
Bharat Mediratta 0b5ce9dbc1 Fix a typo: $item -> $tag. 2010-01-19 01:36:15 -08:00
Bharat Mediratta 549b88643a Fix a typo "tags" -> "tag" 2010-01-19 01:35:59 -08:00
Bharat Mediratta c590fed132 Change rest::url() to take a module name and a resource. The module 
does the rest.  This function is symmetrical to rest::resolve.
 2010-01-19 01:33:57 -08:00
Bharat Mediratta f95442c314 Rewrite the tests entirely to cover the new REST code. 2010-01-19 01:17:29 -08:00
Bharat Mediratta 069a23e811 Make scope default to direct. 
Add slug to the post params.
Fix minor output bug.
 2010-01-19 01:16:59 -08:00
Bharat Mediratta a587426cfd Don't try to set the album cover for the grandparent if we don't have edit permissions for it. 2010-01-19 01:12:09 -08:00
Bharat Mediratta cb7c263b47 Return arrays instead of calling rest::reply. 2010-01-19 00:36:40 -08:00
Bharat Mediratta eea9368777 Have the rest calls return an array and print it out in the 
controller.  This is a clearer workflow; controllers generate output,
not helpers.  It's also easier to test.
 2010-01-19 00:36:19 -08:00
Bharat Mediratta 2c0b0aaebc Add rest::url() for convenience. 2010-01-19 00:35:32 -08:00
Bharat Mediratta c23bf312c4 Our own version of Unit_Test_Case that adds useful functions like 
assert_equal_array().
 2010-01-19 00:34:48 -08:00
Bharat Mediratta c059a444c7 Updated for model based validation. Fixed 
change_photo_no_csrf_fails_test() which has been broken since we
deleted Rest_Controller.
 2010-01-18 23:49:00 -08:00
Bharat Mediratta 4418993db9 Add slug_is_url_safe_test() 2010-01-18 23:38:39 -08:00
Bharat Mediratta 2687762aec Update for model validation. Move the url safe tests into Item_Model_Test. 2010-01-18 23:38:18 -08:00
Bharat Mediratta e06ceebaa6 No longer necessary; all photo and movie helper code is now in the model. 2010-01-18 23:25:09 -08:00
Bharat Mediratta f021505208 No longer necessary; all relevant album helper code is now in the model. 2010-01-18 23:24:06 -08:00
Bharat Mediratta c6bd3c5b26 Updated for model based validation. 
change_album_no_csrf_fails_test() had been broken since we got rid of
REST_Controller, but was poorly written so we didn't realize it.  Boo.
 2010-01-18 23:23:31 -08:00
Bharat Mediratta cc61e7a3e0 Update for model based validation. Use test helper. Reduce the code size greatly! 2010-01-18 23:11:02 -08:00
Bharat Mediratta 9eedf5c207 switch to test::starts_with(). 2010-01-18 22:55:16 -08:00
Bharat Mediratta 71a8375554 Whitespace. 2010-01-18 22:52:58 -08:00
Bharat Mediratta dc570aaca9 Switch from ORM_MPTT::$db_builder to db::build(). 2010-01-18 22:52:23 -08:00
Bharat Mediratta f94fa25e08 Add starts_with(). 2010-01-18 22:51:52 -08:00
Bharat Mediratta cfc0f3d0c0 Minor test cleanup. 2010-01-18 22:51:40 -08:00
Bharat Mediratta 703882f4df Update valid_parent() to disallow moving an item inside its own hierarchy. 
Move move_to() inside save()
 2010-01-18 22:50:50 -08:00
Bharat Mediratta efa4e230da in move_to(), move the lock to before we do any calculations so that we have the latest data. 2010-01-18 21:40:00 -08:00
Bharat Mediratta b4e6834a28 Added move_album_fails_wrong_target_type_test() 2010-01-18 21:14:43 -08:00
Bharat Mediratta 677fb08002 Updated tests to match what the expected new API for moving items. 
Now to move an item, you just change its parent_id.
 2010-01-18 21:12:26 -08:00
Bharat Mediratta 38c13760af Switch to using test::random_name() to avoid integer names. 
Fix up rename_photo_test.
 2010-01-18 20:14:09 -08:00
Bharat Mediratta 0e2f4a7a37 Fix renaming in save() by moving the actual rename action under 
parent::save().  This is consistent with other changes because all
filesystem operations happen after the database change is committed.

Also, inline rename() since it's fairly simple now.
 2010-01-18 20:13:46 -08:00
Bharat Mediratta b93000c0ce Kohana ticket #2504 is resolved, so this test is no longer necessary. 2010-01-18 17:20:12 -08:00
Bharat Mediratta 1cfee16e38 In valid_name, don't query on the id if it's null. 2010-01-18 13:09:58 -08:00
Bharat Mediratta f492436317 Add random_name(). 2010-01-18 13:03:59 -08:00
Bharat Mediratta 92ed5d45e6 In item_rename_fails_with_existing_name_test switch validate() to 
save() now that Kohana ticket #2504 is resolved.
 2010-01-18 12:56:49 -08:00
Bharat Mediratta ebb909625c Merge branch 'master' into bharat_dev 2010-01-18 12:54:26 -08:00
Bharat Mediratta 9384f987bb Coerce some integers to strings now that ORM isn't typecasting anymore. 2010-01-18 12:52:52 -08:00
Bharat Mediratta 06cabecd76 Coerce some integers to strings now that ORM isn't typecasting anymore. 2010-01-18 12:49:58 -08:00