Bharat Mediratta
bae905a4cb
Improvements to access helper.
...
o Rename access::remove_group() to access::delete_group() for
consistency.
o Wrote more unit tests
o Tests found a bug in access::remove_item() .. yay!
2008-12-04 06:40:35 +00:00
Tim Almdal
1ae3ed7e3b
Get rid of the rearrange helper as the code could be inlined
2008-12-04 06:36:14 +00:00
Tim Almdal
b9a0843d86
Remove an resemblence to a RESTful controller from Rearrange_Controller
2008-12-04 06:28:42 +00:00
Bharat Mediratta
4d76351017
Fix indentation
2008-12-04 05:54:48 +00:00
Bharat Mediratta
c67a4f485d
style updates
2008-12-04 05:54:26 +00:00
Bharat Mediratta
375e7c675e
Implement ORM_MPTT::delete() properly.
...
Inline ORM_MPTT::_grow() for now
Rewrite ORM_MPTT tests to be domain specific; they no longer use album/photo helpers.
2008-12-04 05:47:05 +00:00
Bharat Mediratta
89a346c1e1
Rename Directory_Helper_Test to Dir_Helper_Test
2008-12-04 05:45:00 +00:00
Bharat Mediratta
24cbff29cc
Replace grow_test and constrict_test with add_hierarchy_test and
...
delete_hierarchy_test.
Our tests will be more robust if we test the public API and not the
internal private functions. If we get to the point where we have to
test the private functions, we should probably move those functions
into their own separate class with a public API.
2008-12-04 05:15:21 +00:00
Tim Almdal
5c095cbd78
Add unit tests to test growing and contracting the left and right pointers
...
Added a delete method to ORM_MPTT that contracts the tree when an item is deleted
2008-12-04 01:12:44 +00:00
Tim Almdal
9ae6acdc0a
Before deleting an item, save the path to the image in the var directory as once the item is deleted, the $item->file_path() is no longer valid.
2008-12-04 00:14:52 +00:00
Bharat Mediratta
e8cf2a3e67
Fix internationalized string.
2008-12-03 23:32:29 +00:00
Bharat Mediratta
ccee9854c2
Rename file::unlink() to dir::unlink(). This creates an API that is
...
clearer about its actions, otherwise we may accidentally blow away an
entire hierarchy when we think we're deleting a single file (there's a
reason why rm won't let you delete dirs that aren't empty!)
Name it "dir" instead of "directory" because apparently "directory" is
already reserved.
Move the delete call out of Items_Controller and into the model. The
model is responsible for keeping state integrity, not the controller.
2008-12-03 23:31:10 +00:00
Tim Almdal
76196be483
Remove @todo
2008-12-03 22:48:23 +00:00
Tim Almdal
7bb4b6029d
Add a MY_file class that extends the file helper by creating an unlink method that deletes a file or an album directory.
...
Modify Items_Controller::_delete to call this new helper method when deleting an item
2008-12-03 22:39:57 +00:00
Bharat Mediratta
d8511f2fde
Implement two tests
2008-12-03 19:10:23 +00:00
Bharat Mediratta
c3478675cd
Fix a bug where we weren't actually deleting permissions (hooray for unit tests!)
2008-12-03 19:09:56 +00:00
Bharat Mediratta
03bc3c281e
Make sure that we always run teardown, even when the test throws an exception
2008-12-03 19:09:16 +00:00
Tim Almdal
1e647c2a03
Drag and drop seems to work in the rearrange module
2008-12-03 18:14:15 +00:00
Tim Almdal
27a9c14d27
If the the post and get arrays don't contain a _method parameter, then use the request::method() to determine the actual request method (i.e. delete doesn't show up in either places)
2008-12-03 17:33:18 +00:00
Bharat Mediratta
efc6270295
Test stubs
2008-12-03 17:17:59 +00:00
Bharat Mediratta
53664787d4
Add a filter to unit tests. Now you can do 'php index.php Album_Helper_Test Photo_Helper_Test' to just run those two
2008-12-03 06:00:30 +00:00
Bharat Mediratta
f114814c03
Move the form html into the controller
2008-12-03 05:59:39 +00:00
Bharat Mediratta
39499cdf2e
Add /welcome/form/add/photos to give you the add photo form.
2008-12-03 05:40:59 +00:00
Bharat Mediratta
a4494b9f9a
Put the output in pretty ASCII boxes.
2008-12-03 05:15:03 +00:00
Bharat Mediratta
e03bb0f7c3
Re-enable access_cache propagation now that we've patched the MySQL driver.
2008-12-03 04:28:14 +00:00
Bharat Mediratta
dc35a005bc
Don't cache the table field definition when we're in test mode, else
...
all the table changing shenanigans we do to add permissions and groups
will fail to register.
2008-12-03 04:27:29 +00:00
Bharat Mediratta
718ac67a02
get rid of a stray space that was breaking the File_Structure_Test
2008-12-03 04:17:02 +00:00
Bharat Mediratta
c1886aab88
Temporarily disable some code to get tests to pass.
2008-12-03 04:05:24 +00:00
Bharat Mediratta
7f9b765571
Fix errors in the preamble
2008-12-03 03:53:46 +00:00
Bharat Mediratta
844e5573f0
Make sure that the dev is not using the same db for tests as they are for production (this one's for you, valiant!)
2008-12-03 03:49:45 +00:00
Bharat Mediratta
705698a425
Drop the database and rm -rf test/var instead of calling uninstall on
...
all modules. This guarantees a clean start w/out worrying about
weirdness in the uninstaller code.
2008-12-03 03:44:48 +00:00
Bharat Mediratta
37758d15de
Drop the right tables at uninstall time
2008-12-03 03:43:50 +00:00
Chad Kieffer
98ea31a86d
Grouped Ajax/Dom scripting related styles (gInPlaceEdit, gClose, etc.). Began gInPlaceEdit styles.
2008-12-03 03:24:45 +00:00
Bharat Mediratta
6f959deed9
Rename generic test.php to gallery_unit_test.php to make navigation to this file a little easier
2008-12-03 03:23:30 +00:00
Bharat Mediratta
db5bc20500
Fix a bad copy/pasted comment
2008-12-03 03:18:43 +00:00
Bharat Mediratta
0e752790a3
Removed per jozefs
2008-12-02 21:41:07 +00:00
Tim Almdal
2e42a5ea8c
Remove the variable from inside _()
2008-12-02 21:37:06 +00:00
Tim Almdal
3953dde2c6
The rearrange module will now add an album if you drag the "new album" onto the album tree. I haven't had a chance to figure out why the form does get any styling or why a textarea is no included as a list item.
2008-12-02 21:25:15 +00:00
Bharat Mediratta
ea11562e32
Oops, this was missing from the last fix.
2008-12-02 04:54:37 +00:00
Bharat Mediratta
ae4c828b06
Fix a problem in _update_access_cache() where if the intent is
...
default, we weren't properly propagating ALLOW where necessary.
2008-12-02 04:38:45 +00:00
Bharat Mediratta
52e63e7f75
Tighten up ul.permissions
2008-12-01 23:48:07 +00:00
Bharat Mediratta
9f1f10c4dd
Turn <div/> into <div></div> to make Chrome happy.
2008-12-01 23:46:43 +00:00
Bharat Mediratta
77f9e81fac
Add missing closing >
2008-12-01 23:44:14 +00:00
Tim Almdal
6459f167fd
Drag and Drop is starting to work. You can drag the New Album over any of the directorys and it will be allowed. Drag anything over New Album and it will return. You can drag an tree item except the root over the delete icon and it will be accepted. Now I need to build the ajax and server side functionality the at allows this to all work.
2008-12-01 23:14:26 +00:00
Tim Almdal
92563f813e
Fix the fact that the tree wouldn't show up... just a wee bit overly aggressive in cleaning up what i thought was unused files
2008-12-01 21:35:09 +00:00
Tim Almdal
0ebd4f6b28
New Rearrange gui based on jqueryFileTree ( http://www.abeautifulsite.net/notebook.php?article=58 ). I like the look of this one better. Still need to implement the drag and drop functionality.
2008-12-01 20:54:25 +00:00
Bharat Mediratta
ed2cb2a86d
Fix profiler settings in the scaffolding
2008-12-01 10:40:40 +00:00
Bharat Mediratta
2eed685883
style the permission tree a little tighter
2008-12-01 10:27:36 +00:00
Bharat Mediratta
5c303aa07b
Add access::reset() so that you can specify your intent to use the
...
parent's permissions.
Update scaffolding to demonstrate that it works.
2008-12-01 09:57:03 +00:00
Bharat Mediratta
88a70cbc04
Clean up styles a bit to make it more obvious what's going on. Show
...
edit permissions too to demonstrate that we're doing something
different for the different type of permissions.
2008-12-01 09:02:46 +00:00
Bharat Mediratta
Tim Almdal
Chad Kieffer