stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-06-07 03:59:12 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,668 Commits 4 Branches 0 Tags
ec052d71301acbf519947897f8adda7fdcf7fefb
Commit Graph

3624 Commits

Author SHA1 Message Date
Bharat Mediratta
0dc184e99f Overload url::current() and url::merge() to make the current url XSS 
safe.  Add tests to make sure that it doesn't relapse with future
Kohana changes.  Fixes ticket #983.

Ref: http://gallery.menalto.com/node/93738
 2010-01-18 11:10:37 -08:00
Bharat Mediratta
dc286cc2bd Add a test to verify that bug #2504 is still around. When this test 
starts failing, the bug is fixed and we can go fix our code that works
around it.
 2010-01-18 09:00:14 -08:00
Bharat Mediratta
53735f6b16 Convert a $root to item::root() to fix a test. 2010-01-17 23:50:42 -08:00
Bharat Mediratta
31ecb009ba Get rid of urls_are_rawurlencoded_test -- it's no longer necessary 
since we can't have unsafe slugs.

Add basic_validation_test.
 2010-01-17 23:47:16 -08:00
Bharat Mediratta
06541f0e2a Fix item_rename_fails_with_existing_name_test() -- broken because of 
http://dev.kohanaphp.com/issues/2504
 2010-01-17 21:49:48 -08:00
Bharat Mediratta
710e472edc Fix rename_album_test() 2010-01-17 21:03:15 -08:00
Bharat Mediratta
b35a3c8b81 Fix rename_photo_test(). 2010-01-17 20:54:08 -08:00
Bharat Mediratta
9ddb961a91 Partially updated for model based validation. 2010-01-17 20:53:32 -08:00
Bharat Mediratta
6e73b08595 Mostly conver to model based validation. Not all tests pass yet. 2010-01-17 20:37:57 -08:00
Bharat Mediratta
f20fa2cfed Change IdentityProvider::create_user() to take $email as well, since that's a required 
parameter for the Gallery driver.
 2010-01-17 20:37:25 -08:00
Bharat Mediratta
ab7be17b7f Switch to model based validation approach. 2010-01-17 20:17:50 -08:00
Bharat Mediratta
7d9d40c7d6 Use test::random_photo_unsaved() instead. 2010-01-17 20:06:34 -08:00
Bharat Mediratta
dd5f08b703 Create xxx_unsaved() versions for the case where you want to tinker with the item before it gets saved. 2010-01-17 20:06:28 -08:00
Bharat Mediratta
c0d0142552 Updated for model based validation. 2010-01-17 20:03:18 -08:00
Bharat Mediratta
39bb08db28 Make set_data_file() chainable. 2010-01-17 20:02:30 -08:00
Bharat Mediratta
afb7decb00 Make it work with model based validation. 
Refactor _get_proxy() out of setup() and into its own helper function.
 2010-01-17 19:57:42 -08:00
Bharat Mediratta
c9fd8d751d Add random_photo() 2010-01-17 19:57:24 -08:00
Bharat Mediratta
c5f9a466c8 Updated for model based validation. 2010-01-17 19:33:44 -08:00
Bharat Mediratta
c5c17eecc3 Updated for model based validation. 2010-01-17 19:32:05 -08:00
Bharat Mediratta
c863544ec3 Add validation for guest_email and guest_url. 2010-01-17 19:31:49 -08:00
Bharat Mediratta
f68862f4c9 Updated for model based validation. 2010-01-17 19:26:32 -08:00
Bharat Mediratta
53a17e3444 Add album title in random_album(). 2010-01-17 19:26:22 -08:00
Bharat Mediratta
c13d5c3513 Helper class for common test methods (like creating albums, photos, 
etc).
 2010-01-17 19:24:48 -08:00
Bharat Mediratta
05e8d560e4 Refactor to work with model based validation. 
While I'm at it, pull _make_comment() out of setup and only call it on
demand; this makes the tests run faster.
 2010-01-17 18:10:32 -08:00
Bharat Mediratta
3ef22d9d1a Add special output support for ORM_Validation_Exception 2010-01-17 18:09:31 -08:00
Bharat Mediratta
5162e35d49 Use an empty password for the guest user. 2010-01-17 17:54:14 -08:00
Bharat Mediratta
9e9c5397b7 Qualify the Bad Request output when the name is missing 2010-01-17 16:59:25 -08:00
Bharat Mediratta
4197ee39b9 Catch ORM_Validation_Exception and turn it into a 400 Bad Request with 
appropriate error output.
 2010-01-17 16:58:54 -08:00
Bharat Mediratta
afb3fa71b9 Get rid of internal_only designation -- it's too hard to enforce cleanly. 2010-01-17 16:58:47 -08:00
Bharat Mediratta
fafa7f277f Remove a @todo. 2010-01-17 16:55:48 -08:00
Bharat Mediratta
bb79a1455a Remove unnecessary comment. 2010-01-17 16:55:11 -08:00
Bharat Mediratta
f70130b820 Special case output for ORM_Validation_Exceptions 2010-01-17 13:30:06 -08:00
Bharat Mediratta
f0a290fc76 If we call original() and there's no $original yet, then consider this 
to be the original.  That should be safe because we're already
guarding __set, __unset and save.
 2010-01-17 13:29:36 -08:00
Bharat Mediratta
cfb27dde02 Adjust installers to work with model based validation. 2010-01-17 13:28:24 -08:00
Bharat Mediratta
9488684220 Move model rules down into their validate() function for consistency. 
Change "in_use" error to "conflict" for consistency.
 2010-01-17 12:30:24 -08:00
Bharat Mediratta
3789b85b7d Move rules down into validate() and improve valid_author(). 2010-01-17 12:19:24 -08:00
Bharat Mediratta
4f8c98a7bc Move rules entirely down into validate() so that we can be more 
sophisticated but keep all our rules in one place.

Add rules for most fields.
 2010-01-17 12:13:25 -08:00
Bharat Mediratta
5c49c041e7 Use "(string) $form" instead of "$form->__toString()" 2010-01-16 22:42:02 -08:00
Bharat Mediratta
1c85cf6397 Convert comment code over to model based validation. 2010-01-16 22:27:07 -08:00
Bharat Mediratta
39ad9fa9a0 Get rid of add_rules_from() -- it's no longer necessary now that we're doing model based validation. 2010-01-16 21:25:17 -08:00
Bharat Mediratta
4a2d5bc9e2 Convert Users_Controller to model based validation. 2010-01-16 21:24:18 -08:00
Bharat Mediratta
6a4dda9bde Convert Admin_Users_Controller, User_Model and Group_Model to use 
model based validation.
 2010-01-16 21:15:12 -08:00
Bharat Mediratta
a691dcc63c Convert Admin_Users::add_user() to use model based validation. Get 
the rules and business logic out of the form and user::create(), and
move it into User_Model::save().
 2010-01-16 19:58:55 -08:00
Bharat Mediratta
fdcb4a1f32 PHPdoc. 2010-01-16 18:16:47 -08:00
Bharat Mediratta
a5aacfa4a6 Don't forget to save when we make insignificant chagnes only. 2010-01-16 18:10:40 -08:00
Bharat Mediratta
7f20f66079 Whitespace. 2010-01-16 18:00:02 -08:00
Bharat Mediratta
ff728b3ccd Whitespace. 2010-01-16 17:51:57 -08:00
Bharat Mediratta
8ce11ac970 Convert Movies_Controller::update() over to model based validation. 2010-01-16 12:07:36 -08:00
Bharat Mediratta
efdb73cb98 Make movie creation use model based validation. Move movie related 
logic from movie::create() into Item_Model
 2010-01-16 12:00:50 -08:00
Bharat Mediratta
b5a6a6a5d5 Oops, log::failure() doesn't exist. Use log::error(). 2010-01-16 11:44:21 -08:00