shadlaws
031dd3bd6f
#1960 - Add unit test to look for extra spaces at end of line
...
- Added no_extra_spaces_at_end_of_line_test to File_Structure_Test.
- Updated Gallery_Filters to exclude testing code that isn't ours.
- Removed existing extra spaces. New test now passes.
2013-01-24 12:03:05 +01:00
Bharat Mediratta
aa8fffcd8f
Extract reweighting logic out of Organize_Controller into
...
item::reweight_all_children as an API and write a test for it. Work
in progress on #1914 .
2013-01-23 21:33:19 -05:00
Bharat Mediratta
34198e71d3
Add a cache buster to all data_rest urls, add caching headers to all
...
data_rest responses, and check cache validity. Fixes #1909 .
2013-01-23 20:50:54 -05:00
Bharat Mediratta
a1a6600457
Enable the profiler and debug output if var/PROFILE exists. This
...
provides a quick/easy way for server admins to provide profile output.
Fixes #1959 .
2013-01-23 18:03:09 -05:00
Bharat Mediratta
e8302ffce5
Merge pull request #98 from shadlaws/fix_1954
...
#1954 - Skip buffer calls for unit tests of file_proxy and data_rest.
2013-01-22 17:57:58 -08:00
Bharat Mediratta
49f6ce2d94
gallery.menalto.com -> galleryproject.org
...
codex.gallery2.org -> codex.galleryproject.org
Fixes #1957 .
2013-01-22 18:39:24 -05:00
shadlaws
8436e16b2f
#1954 - Skip buffer calls for unit tests of file_proxy and data_rest.
...
Moved the "if (TEST_MODE)" statement before the buffer calls in file_proxy and data_rest.
This has no impact on normal use, but will make the unit tests more compatible with different server/PHP configurations.
Note: We do not have to skip setting the headers, which means we can build unit tests around them if we wish.
2013-01-21 10:45:34 +01:00
Bharat Mediratta
d45a737779
Update copyright to 2013. Fixes #1953 .
2013-01-21 01:22:01 -05:00
Bharat Mediratta
8dc34dade8
Add unit tests for data_rest. While I'm in there, get rid of the
...
clause that returns nothing when the album has no album cover - we'll
fail before that if the album's thumbnail is missing, and if it's not
missing then we'll have something to serve even if it's out of date.
2013-01-21 00:52:52 -05:00
shadlaws
1927dd00e4
#1949 - Fix album thumb mime types given by data_rest and file_proxy
...
Correct result: always "image/jpeg"
Old data_rest result: mime of cover item
Old file_proxy result: mime of album item (null)
2013-01-20 08:34:12 +01:00
Bharat Mediratta
52ab0e9988
Merge pull request #89 from shadlaws/fix_1942
...
#1942 - Make data_rest and file_proxy more consistent
2013-01-19 22:26:34 -08:00
Bharat Mediratta
f215a417f1
Merge pull request #88 from shadlaws/fix_1941
...
#1941 , 1948 - Fix possible warnings in movie and graphics helpers, add functions to convert between seconds and hh:mm:ss.dd (and their unit tests).
2013-01-19 21:41:45 -08:00
shadlaws
592eff0e5a
#1942 - Make data_rest and file_proxy more consistent - several minor documentation/formatting changes.
...
No actual functionality changed here.
2013-01-19 08:40:19 +01:00
shadlaws
ea8219e1d4
#1941 , 1948 - Fix possible warnings in movie and graphics helpers, add functions to convert between seconds and hh:mm:ss.dd.
...
Also add unit tests for new movie helper functions.
2013-01-19 00:59:55 +01:00
shadlaws
e2a2a5ce81
#1944 - Fix possible warnings in legal_file::get_photo_types_by_extension and legal_file::get_movie_types_by_extension.
...
Added unit tests for these two functions, too.
2013-01-19 00:52:13 +01:00
shadlaws
3a9009492e
#1943 - Make legal_file::change_extension more robust.
...
Previously would fail with dots in the directory but no extension. Added unit tests to verify the new change works.
2013-01-18 20:06:05 +01:00
Bharat Mediratta
d04080c7be
Follow-on to 94b26e506c - make the new legal_file
...
functions more robust when passed an unknown extension. Fixes Item_Model_Test.
2013-01-17 15:05:46 -05:00
Bharat Mediratta
9d684b7b83
Fix up some indentation.
2013-01-14 12:52:47 -05:00
shadlaws
ff6688b48b
#1919 - change convert -v to convert -version
2013-01-01 15:47:04 +01:00
Bharat Mediratta
7910084224
Check for "add" instead of "edit" in item_rest::post. Fixes #1929 .
2012-12-18 13:56:28 -08:00
shadlaws
ce68177ba0
[ #1928 - Make thumbnail generation more flexible for movies (graphics and movie helpers)]
...
- graphics helper: add movie_extract_frame event to generate function
(allows modules to add to the options sent to movie::extract_frame or to
generate the thumbnail on their own without movie::extract_frame)
- movie helper: add extra optional argument to movie::extract_frame
(can add ffmpeg arguments and/or change the frame extract time)
- gallery_installer: add movie_extract_time module variable, update to v53
- module.info: update to v53
- install.sql: update to v53
2012-12-18 15:58:13 +01:00
shadlaws
94b26e506c
[ #1924 , #1925 , #1927 - enhance compatibility with movies (movie helper) and file types (legal_file helper)]
...
bug fix: modify movie.php helper to take DAR (display aspect ratio) into account in get_file_metadata
bug fix / enhancement: add duration to get_file_metadata output
bug fix: modify movie.php helper to use correct resolution and duration from get_file_metadata in extract_frame
bug fix: modify movie.php helper to be more robust against ffmpeg failures and limitations, including adding "-threads 1" argument if needed
enhancement: modified to include ordered maps of extensions to MIME types (get_photo_types_by_extension and get_movie_types_by_extension functions), modified get_file_metadata in movie and photo helpers to use them
gallery_installer, module.info, install.sql: updated to v52 with m4v mime correction code (was video/mp4)
2012-12-16 18:11:01 +01:00
Bharat Mediratta
a74e3aea6f
Eliminate the search context if we encounter an item that cannot be
...
found in the search results. Fixes #1923 .
2012-12-09 20:26:16 -08:00
chalbertgit
ce9199a955
[ #1907 ] Added code needed for the case when a user upgrades.
2012-11-13 13:17:45 -05:00
Bharat Mediratta
71a67ebb9f
Add locale for Thai. Fixes #1916 .
2012-09-28 11:44:46 -07:00
Bharat Mediratta
467a032f8e
Rename any files that have two dots in them to a legal name. This
...
fixes the bug where we made those files invalid in 3.0.4 without
providing a clean upgrade path. Bump gallery module to 50. Fixes
2012-07-21 15:11:27 -07:00
Bharat Mediratta
a98afdb32c
Refill the path and url caches in the item model at the end of this task. Fixes #1896 .
2012-07-21 11:12:51 -07:00
Bharat Mediratta
3e99c37c35
Fix comment typo.
2012-07-21 11:11:16 -07:00
Bharat Mediratta
f9e77c4c14
Fix the access_cache rebuilding code to not load all missing access caches into the stack, if you're missing
...
enough it'll blow the stack (like, if you truncate the access_caches table). Fixes #1895 .
2012-07-21 10:38:23 -07:00
Bharat Mediratta
e4daa42830
Rename the comparator to something that makes more sense (to me), and make it static.
...
Follow-on to 5d9e717417 for #1859 .
2012-06-11 14:02:23 -07:00
Bharat Mediratta
648d9a4de8
Remove accidental double encoding.
2012-05-19 11:51:10 -07:00
Bharat Mediratta
a9be0691d9
Create an ajax response framework that inserts <meta> tags to guard
...
against UTF-7, and create a $.gallery_autocomplete variant of jQuery's
autocomplete that expects the first line to be a <meta> tag and
discards it. More complete fix for #1871 .
2012-05-19 11:31:25 -07:00
Bharat Mediratta
9e2ea2ffed
Smash multiple extensions down into a single one when accepting file
...
uploads. Fixes #1872 .
2012-05-17 20:25:27 -07:00
Bharat Mediratta
aac18ef833
Don't allow new albums with a slug that matches a controller - put up a
...
message telling the user that it's a reserved address. Partial fix for #95 .
2012-05-15 15:53:38 -07:00
Bharat Mediratta
ffbaa7bf82
Follow on for #1845 - handle paths with dots in them properly.
2012-05-13 21:09:59 -07:00
Bharat Mediratta
5d9e717417
Sort modules by visible name, not id. Fixes #1859 .
2012-05-11 17:14:41 -07:00
Bharat Mediratta
a563dcdfb3
Convert the missing movie placeholder over to a JPG for consistency. Fixes #1828 .
2012-05-07 21:41:28 -07:00
Bharat Mediratta
2a4903c0e7
Fix typo in call to Kohana_Exception::getMessage, thanks to Serge.
...
Fixes #1780 .
2012-05-07 21:17:58 -07:00
Bharat Mediratta
e722e5d5d4
Fix missing date.timezone which results in a crash on startup in I18n
...
code. Fill in missing field and log it 25% of the time. Fixes #1853 .
2012-05-07 11:38:51 -07:00
Bharat Mediratta
3fe3c09ec3
Use html::anchor consistently. Fixes #1851 .
2012-05-06 09:45:04 -07:00
Bharat Mediratta
ef4dbd18af
Fix extension-swapping code for files that have extensions that are
...
not 3 characters long. Fixes #1845 .
2012-05-05 19:34:01 -07:00
Bharat Mediratta
d5a445b779
Improve the dimensions-detecting regex, thanks to cchiappa.
...
Fixes #1844 .
2012-05-05 19:19:04 -07:00
Bharat Mediratta
75492b9dd6
"public static" -> "static"
2012-04-01 14:09:08 -07:00
Bharat Mediratta
cd46dc479c
Beef up the random number generator by using Joomla's new implementation.
2012-04-01 12:39:48 -07:00
Bharat Mediratta
7ba0b1b75c
Restrict valid urls to having a http:// or https:// prefix. Fixes #1830 .
2012-04-01 11:36:16 -07:00
Bharat Mediratta
bf2bb3e1ea
Update copyright to 2012. #1822
2012-02-27 09:48:23 -08:00
Bharat Mediratta
cdbd9b5a9d
Don't support display contexts for robots. Fixes #1819 .
2012-02-06 20:02:32 -08:00
Bharat Mediratta
065dd32f31
Add tags for all Cache::instance()->set calls that don't have one.
...
Fixes #1818 .
2012-02-06 19:48:52 -08:00
Bharat Mediratta
2725d30c34
Use Albums_Controller::get_display_context as the default display context. Fixes #1812 .
2011-12-23 11:22:43 -08:00
Bharat Mediratta
5020f2184c
Better fix for dc21cf36b6 - let's just fix up
...
the root album thumbnail when the proportions change so that we avoid
this problem altogether.
2011-11-03 21:15:10 -07:00