stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-06-09 21:19:11 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,494 Commits 4 Branches 0 Tags
e8a3fe97a43dc257a70431defbcc6fb330cdfee2
Commit Graph

62 Commits

Author SHA1 Message Date
Tim Almdal
82edd2a37b This patch adds some security to the organize dialog. 
1) If images are dragged from the content pane and dropped on a branch in the
   tree that the user only has view priviledges, then the drop is cancelled
   and the images are reverted.
2) The user cannot click on a branch, to which they only have view priviledges,
   the content pane does not change to the new album
 2009-08-17 19:52:40 -07:00
Tim Almdal
dd9f4b6d7f The rearrange functionality works. but it is slower than shit. I've left the debug statements in until we can solve this issue. 2009-08-17 08:49:37 -07:00
Tim Almdal
5f546050d1 The progress bar appears during a move. Still having an issue with unable to do a single select after a drop operation. I think its related to needing to destroy the existing selectable before creating the new one. The error I get is "this._selection[i].data("selectabe-item") is undefined." 2009-08-16 16:20:43 -07:00
Tim Almdal
76f320ab3d In this patch, drag now works to the album tree, but the progress bar is not 
showing. As well fixed a problem where selectable single clink no longer
worked when the album was reloaded.
 2009-08-16 12:36:14 -07:00
Tim Almdal
eeae2dc56c Added javascript portion of the drop functionality. At this point you can drag selected images and drop them on the micro thumb grid in a different position or onto a branch in the gallery tree. No ajax call is made, it just writes the generated url and post data to the console, so it only works in ff right now. 2009-08-13 21:31:20 -07:00
Tim Almdal
d758266fab Add a visual indicator of the insertion point 2009-08-13 18:58:40 -07:00
Tim Almdal
5a84df9ac5 Vertical scrolling of the thumb grid seems to work better now. Wasn't able to get the draggable autoscrolling working, so this is a poor replacemment. 2009-08-13 10:56:50 -07:00
Tim Almdal
3823f65dfb Implement the first part of drag functionality. Having trouble getting visual feedback of the drop position between thumbnails, so this commit provides a checkpoint for trying various options 2009-08-12 21:55:25 -07:00
Tim Almdal
39d0098038 Enable microthumbnail selection 2009-08-09 09:00:10 -07:00
Tim Almdal
685b1ddf88 Enhance how the organize dialog degrades if the browser window is not optimal 2009-08-07 21:40:35 -07:00
Tim Almdal
7b0ea229b8 Make the organize dialog open properly in IE8, Chrome and FF. For some reason (probably a timing thing) the height of the contents was not being set correctly in FF. So we just hard code an estimate of the size of the Draw handle, and message areas. 2009-08-07 17:07:04 -07:00
Bharat Mediratta
a245c57400 Further streamline the code. 
Organize_Controller:
* Remove unnecessary constants
* Rename index() to dialog()
* Simplify _get_micro_thumb_grid

organize.js:
* Move sizing code in here from organize_dialog.html.php

organize_dialog.html.php:
* Move CSS and JS links in here so that we only load them when we need them.
* Move sizing code into organize.js

organize_thumb_grid.html.php:
* Move pagination logic in here, since it's view centric
* Collapse the css class determination code and inline it
 2009-08-06 21:52:23 -07:00
Bharat Mediratta
d3f4643699 * Rename setContents -> show_album to be consistent style wise (no camel 
caps) and more explicit about what it's doing.
* use toggleClass() to simplify the +/- css management.
 2009-08-06 21:02:22 -07:00
Bharat Mediratta
6e4023a720 Fix indentation. 2009-08-06 16:16:11 -07:00
Tim Almdal
794a7a5abf Leverage the gallery.dialog/js functionality in order to reduce duplicate code 2009-08-06 14:55:03 -07:00
Tim Almdal
7ed15ea481 Remove 6 more lines by removing the generalization of the close dialog processing 2009-08-06 10:03:38 -07:00
Tim Almdal
d7c7a06efe Remove the complicated calculation to determine the height of the 
micro thumb grid, by setting all the parent elements to 100% in the
css and then subtract the height of the button bar
 2009-08-06 09:46:39 -07:00
Tim Almdal
7bdf382e81 Revert "Revert "Revert "Allow a theme to override the page refresh mechanism. Create a new""" 
This reverts commit 7b1cca168c.

Basically remove it and Bharat and I will fight it out in SF for a resolution :-)
 2009-08-06 07:02:41 -07:00
Tim Almdal
8131e6fa38 Tighten up the code by loading all the albums in the tree at once, removing 
the events to populate the button bar.
 2009-08-06 06:33:17 -07:00
Tim Almdal
cab46cf038 Remove the resize dialog on window resize functionality 2009-08-05 22:28:37 -07:00
Tim Almdal
824a80b0d4 Change the content pane based on the selection in the album tree 2009-08-05 15:24:31 -07:00
Tim Almdal
63f3efef37 Revert "Revert "Enable the expand/collapse of branches by clicking on the plus/minus"" 
This reverts commit e37526f94d.
 2009-08-05 10:26:49 -07:00
Tim Almdal
65c850c393 Revert "Revert "Checkpoint the organize module rewrite. At this point, it doesn't really do"" 
This reverts commit 397468c47b.
 2009-08-05 10:26:11 -07:00
Tim Almdal
7b1cca168c Revert "Revert "Allow a theme to override the page refresh mechanism. Create a new"" 
This reverts commit 9f396178ce.
 2009-08-05 10:25:23 -07:00
Tim Almdal
9f396178ce Revert "Allow a theme to override the page refresh mechanism. Create a new" 
This reverts commit 1f014aae6c.
 2009-08-05 09:24:27 -07:00
Tim Almdal
397468c47b Revert "Checkpoint the organize module rewrite. At this point, it doesn't really do" 
This reverts commit a25f08d433.
 2009-08-05 09:23:32 -07:00
Tim Almdal
e37526f94d Revert "Enable the expand/collapse of branches by clicking on the plus/minus" 
This reverts commit 869c3de961.
 2009-08-05 09:23:01 -07:00
Tim Almdal
869c3de961 Enable the expand/collapse of branches by clicking on the plus/minus 
icons.  Branches with no albums, will not have an icon.
 2009-08-05 08:31:58 -07:00
Tim Almdal
a25f08d433 Checkpoint the organize module rewrite. At this point, it doesn't really do 
anything, but get the dialog up, populate the album tree and intelligently
populate the micro thumb grid.
Still to do:
1) get the microthumbs laided out ptoperly
2) expand and collapse functionality in the album tree
3) use the album tree to change the content of the micro thumb grid
4) Actually add some functionality

At the moment, it supports a callback "" to allow modules to add icons
to the organize drawer label.  The close button is added outside of this
framework as it will always be last.
 2009-08-03 09:19:17 -07:00
Tim Almdal
1f014aae6c Allow a theme to override the page refresh mechanism. Create a new 
javascript lib (gallery.reload.js) which defines the functions
gallery_reload() and gallery_location(new_location).  They just
do a window.location.reload() and window.location = new_location.

This change breaks the assumption that all themes will handle page reloads
the same and allows the theme to customize the page refresh.
 2009-07-27 12:39:12 -07:00
Tim Almdal
fcb031c2b6 Rename the get_url function in organize.js so that it doesn't collide with the 
one in server_add
 2009-07-04 22:47:43 -07:00
Tim Almdal
0451351f51 Set a minimum distance (10px) that the cursor has to move inorder for 
the draggable functionality to be activated
 2009-05-22 16:13:37 +00:00
Tim Almdal
09c8953af7 Provide delete confirmations in quick pane and organize features. If 
I've missed any spots let me know.
 2009-05-21 02:24:37 +00:00
Tim Almdal
a9e3692027 1) This provides the editting functionality for albums and photos in the 
organize feature.
2) Remove the tag functionality at this point
3) Added a callback to handle validating conflicting names (only used
by organize at this point.
4) Closes #231
 2009-05-21 01:31:29 +00:00
Tim Almdal
762ca22544 This takes us the next step closer to providing bulk edit. We still 
can't edit, but we are getting closer :-).
This change sets up a framework for modules to contribute edit panels
to the organize drawer. Currently implemented General (albums and
photos), Sort Order (albums only) and Manage Tags
 2009-05-18 19:34:03 +00:00
Tim Almdal
2c2839c13b Create a thumbnail stack of selected thumbnails for the organize 
drawer
 2009-05-07 17:39:34 +00:00
Tim Almdal
6a295dc93d 1) Leave an object selected if its clicked. 
2) And a 1em left margin to provide more spacing, so the lasso is less inclusive
 2009-05-07 05:16:56 +00:00
Tim Almdal
5305d1f569 Improve the selection/drag handling so that drag of a single item 
doesn't have to be selected first
 2009-05-07 04:56:08 +00:00
Tim Almdal
a8879cfe89 1) Improved selection processing. 
2) Drawer closes if no images or albums are selected
 2009-05-06 20:27:49 +00:00
Tim Almdal
88c0ede495 Add missing return statement 2009-05-02 03:23:55 +00:00
Tim Almdal
a12ed1de02 Move the drawer to the bottom of the page and compress the thumb grid 
when the drawer opens.  This way the drawer is never scrolled.
 2009-05-02 03:08:30 +00:00
Chad Kieffer
590eceaf93 Set organize messages to use existing gMessage, added album cover message. 2009-05-01 05:35:56 +00:00
Tim Almdal
33122e8968 Change album cover functionality added 2009-04-29 03:57:24 +00:00
Tim Almdal
89bdd6ca98 The delete button now deletes the selected items 2009-04-29 01:29:39 +00:00
Tim Almdal
12d976b94d 1) Refactor the ajax calls so that the code is reused across multipl 
request types.
2) Enable/Disable the drawer handle buttons depending on the number of
items selcted
3) Image rotation works.
 2009-04-28 21:29:14 +00:00
Tim Almdal
091fde3e00 Another iteration of the organize module: 
Rearrange the layout as per discussion with thumb, start the drawer
functionality. Still to do... 
1) Add the processing behind the buttons on the drawer handle
2) Enable the drawer buttons when something is selected
3) Create a copy of the thumbs for the drawer
4) Add the bulk editting functionality to the drawer
 2009-04-27 20:30:46 +00:00
Tim Almdal
465182e58f 1) Move the progress bar to a dialog 
2) Provide status and error messages back to the user
 2009-04-23 20:48:09 +00:00
Tim Almdal
b1a15f2130 Implement a cancel button so that if an organize task is paused, it 
can be cancelled.
 2009-04-23 04:53:48 +00:00
Tim Almdal
933770cf0e 1) Fix index overflow issue. 
2) Fix where the microthumb was removed even if the move was cancelled
 2009-04-22 23:23:15 +00:00
Tim Almdal
475b8fe9ff Dragging from the thumbgrid to an album in the tree now works. 
Refactored the javascript to minimize duplication.
 2009-04-22 16:09:57 +00:00