stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-23 00:04:03 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,121 Commits 4 Branches 0 Tags
e7c6861507ea7ca01d3d4ed7b4189c030c8d07b3
Commit Graph
1554 Commits
Author SHA1 Message Date
Bharat Mediratta e7c6861507 Don't send back the gzipped version if we're using 
zlib.output_compression in PHP, since that means that the stream is
already compressed.  Fixes ticket 555.
 2009-07-17 16:58:00 -07:00
Bharat Mediratta 8a6556b30b Fix a bug where moved items don't properly inherit permissions from 
their new target.  After each move, recalculate the permissions for
the new parent's hierarchy.

Fixes ticket #552
 2009-07-17 08:14:08 -07:00
Bharat Mediratta 0f766b149d Second non-trivial change to the event code. We now publish model 
related events from within the model handling code.  The only
exception to this currently is item_created which is challenging
because we have to save the item using ORM_MPTT::add_to_parent()
before the object itself is fully set up.  When we get that down to
one call to save() we can publish that event from within the model
also.
 2009-07-16 12:31:40 -07:00
Bharat Mediratta 43324fd12a Update golden file to match recent changes in event code. 2009-07-16 12:29:01 -07:00
Bharat Mediratta 5b3b675b6d Non-trivial changes to the event handling code: 
1) The item_updated event no longer takes the old and new items.
   Instead we overload ORM to track the original data and make
   that available via the item.  This will allow us to move event
   publishing down into the API methods which in turn will give us
   more stability since we won't require each controller to remember
   to do it.

2) ORM class now tracks the original values.  It doesn't track
   the original relationships (no need for that, yet)

3) Added new events:
     item_deleted
     group_deleted
     user_deleted
 2009-07-16 11:19:34 -07:00
Bharat Mediratta 2864aceb81 Add missing ) dropped in 8f9a943f. 2009-07-16 10:58:42 -07:00
Bharat Mediratta ec634c91a6 Stripped the trailing ?> without changing whitespace. 2009-07-16 10:45:06 -07:00
Bharat Mediratta 2cd0d6389c Revert "Remove trailing ?>." 
This reverts commit a333e01bd1.
 2009-07-16 10:44:23 -07:00
Bharat Mediratta a333e01bd1 Remove trailing ?>. 2009-07-16 10:32:18 -07:00
Bharat Mediratta d9f3e0bc0e Remove spurious blank line at the top of the file introduced in 09c9b1a755 2009-07-16 10:27:18 -07:00
Bharat Mediratta b46998e392 Update Xss_Security_Test to know about p::purify() and checkpoint the 
golden file.
 2009-07-16 10:24:10 -07:00
Kevin NehlsandBharat Mediratta 85b0f58029 move fix for backslashes on windows outside of loop per bharat's suggestion 
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
 2009-07-16 21:36:51 +08:00
Kevin NehlsandBharat Mediratta 5cb2f42628 Fix backslashes in relative URLs of combined css files. 
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
 2009-07-16 21:36:50 +08:00
Bharat Mediratta c4fce2cc68 Remove a completed @todo. 2009-07-15 20:32:53 -07:00
Tim Almdal 2cba5d9395 Fix 542 by changing the wording from you to your, thanks Floridave 
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-07-15 07:58:30 +08:00
Bharat Mediratta 7de339a676 Remove extra debug statements. 2009-07-14 16:10:37 -07:00
Bharat Mediratta 4720e45641 Don't use "else" clauses in upgrade() -- it prevents multiple version bumps at once. 2009-07-14 12:55:03 -07:00
Bharat Mediratta c4a3093011 3rd attempt to fix localization messages. Last time around I didn't 
dig deep enough, but now we form the complete message using t() style
semantics to replace % placeholders with __ style JS placeholders.
Also, stop appending the (completed) text to existing messages.. roll
it together.
 2009-07-14 12:36:57 -07:00
Bharat Mediratta 768a1485e1 Remove references to missing organize_edit_drawer.png 2009-07-14 12:07:29 -07:00
Bharat Mediratta 8cfb067709 Revert "Remove the reference to organize.css is it is no longer used and is" 
This reverts commit 31ffb82382.
 2009-07-14 12:03:31 -07:00
Bharat Mediratta c3f93957d7 Move the gallery version out of a module variable and into a constant 
in the gallery helper.  This will let us bump the version without
having to bump the gallery module number.
 2009-07-14 10:56:10 -07:00
Tim Almdal cc05d279ea Update HTMLPurifier to version 4.4.0 2009-07-14 07:55:30 -07:00
Tim Almdal 94e33c821f Removed unnecessary contructor from the HTMLPurifier.php library class 2009-07-14 06:42:50 -07:00
Bharat Mediratta 2a40f48d65 Add /opt/bin as a binary path. 2009-07-14 06:36:48 -07:00
Bharat Mediratta e2a9a1d284 Add quotes around all values that contain spaces in them, and add a 
test to make sure that we continue to do so.

This makes sure that we don't have problems with 5.3 which treats the
literal "on" as a boolean.
 2009-07-13 10:36:55 -07:00
Bharat Mediratta a944bf4259 Avoid using the bare word "on" in a value; it breaks PHP 5.3. 
Fixes ticket #540.
 2009-07-13 06:43:44 -07:00
Chad Kieffer 027f6b5221 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-12 22:54:04 -06:00
Chad Kieffer ff0b66a1a4 Put owner's url into user link. Seems better than displaying email until we have something like a user profile page. 2009-07-12 22:53:47 -06:00
Bharat Mediratta 9588e8604d Use %27 instead of &#039; (the latter is the wrong form of escaping for urls). 2009-07-12 20:08:02 -07:00
Bharat Mediratta ac181d6227 Whitespace fixes. 2009-07-11 20:12:32 -07:00
Bharat Mediratta 9809238399 Unescape &#039; also (single quote) 2009-07-11 19:17:12 -07:00
Bharat Mediratta 895fbfd95b Get the thumbnail menu working. 
1) Stop changing the menu classes in JS, instead allow us to specify
it in the Menu class itself and then set it to be gThumbMenu in Theme_View

2) Move the gThumbMenu init code to the bottom of the $(document).ready() block;
something in there was interfering with it.
 2009-07-11 17:59:55 -07:00
Bharat Mediratta b4c279ebb4 Fix whitespace typo. 2009-07-11 17:40:32 -07:00
Bharat Mediratta e2967aa1c1 Fix a problem in delete() where we were referencing $parent without 
saving its value before $item got deleted.  Further fix for #528.
 2009-07-11 07:45:41 -07:00
Bharat Mediratta cbd80b5ff9 Get rid of the form from server_add, we're not using it. 
Turn the cancel link into a themed close button which triggers a page
reload.

Add some padding to the left of the tree.
 2009-07-11 07:37:49 -07:00
Bharat Mediratta 171522bf23 Add a "close" button. 2009-07-11 07:23:31 -07:00
Bharat Mediratta 8c6c3801bb Fix a typo in the last commit. I left off a closing paren. 2009-07-11 07:12:29 -07:00
Bharat Mediratta f2a3fa46f5 Change 'completed' status message to be a full sentence with javascript placeholders. 2009-07-11 07:10:05 -07:00
Shai Ben-NaphtaliandTim Almdal 30346ec842 Fixed indentation of commit 2760e119bbfc3e2d436c404de194dbeea738a735 
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-07-12 14:11:15 +08:00
Shai Ben-NaphtaliandTim Almdal 245f4d39a7 This fixes ticket #513 
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-07-12 14:11:14 +08:00
Bharat Mediratta 214d977f4d Don't close the dialog window after we successfully complete an 
action.  The expectation is that we're going to reload the page (or
redirect to a new url).  If we close the dialog, then we can trigger
the onhover for items we've just deleted causing errors.

Simplify the API while we're at it by getting rid of the no-longer-used
on_success argument to openDialog()

This fixes #528.
 2009-07-11 06:51:21 -07:00
Bharat Mediratta 4d0099e716 Fix a bug where we're referring to $photo when we just uploaded a 
$movie, that causes the simpler uploader to throw an error for all
movies.
 2009-07-11 06:24:10 -07:00
Bharat Mediratta 6b013060aa Fix style: space after ) before {. 2009-07-11 06:15:44 -07:00
Bharat Mediratta ecc7d881e3 Fix bug introduced in e0e450d90f where 
it got rid of the 'img' var which is used when we set the click action
on buttons.

Partial fix for #528.
 2009-07-11 05:52:50 -07:00
Bharat Mediratta 6281ed03d5 Turn off extended inserts when creating install.sql so that it's 
easier to see what's changed.
 2009-07-11 05:36:31 -07:00
Bharat Mediratta 22fcb4c776 Forgot to bump the version up to 3 2009-07-11 05:14:02 -07:00
Bharat Mediratta 0098ef05c3 Merge branch 'master' of git@github.com:/gallery/gallery3 2009-07-11 05:07:41 -07:00
Tim Almdal 4132d6c55e Put quotes around the href param (href="#") 2009-07-11 15:47:04 -07:00
Bharat Mediratta 954ab5a505 Further simplify server_add (and bump it to version 3). 
Now we don't have checkboxes, but instead we restrict you to selecting
directories and albums from only one level in the hierarchy.  This
makes it easier for us to make sure that we properly create the
hierarchy that you want and avoid confusion about what's going to wind
up where.

Modify Server_Add_File_Model to have a parent_id and item_id and then
modify them as we go so that we can build up a tree structure there
*before* we create any items.  This makes it much easier to figure out
where a new item is going to go and get rid of a bunch of probably
buggy code in the main task.
 2009-07-11 05:03:36 -07:00
Tim Almdal f1b2a14f4f Add a title attribute to the li of a menu 2009-07-10 23:45:29 -07:00