stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-20 11:29:24 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,929 Commits 4 Branches 0 Tags
dd5471b8600a9a6efbfbfab81972db59e512493a
Commit Graph

2137 Commits

Author SHA1 Message Date
Bharat Mediratta
dd5471b860 Create and throw the exception, instead of logging. The theory behind 
exceptions is that they only need to be logged if they can't be caught
and handled.  If we don't throw it, then the error gets swallowed and
the code that errored out just blithely continues.
 2009-09-28 21:21:05 -07:00
Bharat Mediratta
a0a62a0992 Do a pass on the gallery::find_file and Gallery_View::{script,css} PHPdoc. 2009-09-28 19:30:34 -07:00
Tim Almdal
f9b351559c Merge branch 'master' of git@github.com:gallery/gallery3 2009-09-28 09:08:07 -07:00
Tim Almdal
28624bb8f1 Update the PHPDoc for gallery::find_file and convert Gallery_View::script/css to use gallery::find_file 2009-09-28 09:04:44 -07:00
Bharat Mediratta
a0d13cd324 Clean up upgrader for version 14. Put {} around table name, 
capitalize reserved words, use single quotes in the query to avoid
escaping the double quotes, remove table alias.
 2009-09-28 08:03:14 -07:00
Tim Almdal
ab5e680265 Clean up the task initialization for rebuild thumbs and resizes. 2009-09-27 20:31:56 -07:00
Tim Almdal
c97a88599e Change gallery installer to do a direct update to the database, preppending gallery_graphics:: to each of the defined rules operations 2009-09-27 17:55:48 -07:00
Tim Almdal
467b74c310 This path requires the upgrader to be run and applies the following changes: 
* moves the composite method back into core
* requires that the operation be fully qualified i.e. gallery_graphics::resize
* caches the graphics rules on each request
 2009-09-27 15:24:51 -07:00
Bharat Mediratta
0ab73cd1ad Fix some whitespace issues. 2009-09-27 11:35:03 -07:00
Bharat Mediratta
7432858420 Fix one more place in the installer where we referring to the old default 
theme names.

Update installer.sql
 2009-09-27 11:25:03 -07:00
jhilden
f5094ede3c minor improvements to simple uploader 
* removed CSS from the view to wind/css/screen.css
* started changing CSS classes/IDs to new prefix "g-"
* and more
 2009-09-26 13:28:10 -04:00
jhilden
21341d552f Merge branch 'master' of git@github.com:gallery/gallery3 2009-09-26 11:27:45 -04:00
jhilden
4345e96d1d first try at improving the upload user experience with the file selection button 2009-09-26 11:27:07 -04:00
Tim Almdal
e204e18b3c Refactor the graphic rules processing to accomplish 2 goals: First separate the grapics library from module supplied rules and secondly, allow for modules to provide new processing rules callbacks. graphics::generate will now look for <module_name>_graphics::<rule> methods. 2009-09-24 20:28:26 -07:00
Tim Almdal
cd240ebaad Refactored the rebuild_dirty_images handler to simplify the counting and end processing. It was getting all confused with trying to figure out the completed and remaining. Now on initiation it sets the total images that are dirty and then counts the completed until it equals the total, then exits. Fixes ticket #771 2009-09-24 20:06:14 -07:00
Tim Almdal
970158f4d9 Fix unit tests by updating the xss golden file and declaring gallery_error::error_handler as static 2009-09-24 16:59:33 -07:00
Tim Almdal
c51c76dcaa Fix Admin_View to look for the the variable active_admin_theme instead of active_site_theme. In addition check for the existence of THEMEPATH . instead of theme/ 2009-09-24 15:06:40 -07:00
Tim Almdal
59c1c36639 Hopefully the last 2 errant occurrences of default as it relates to theme names 2009-09-24 14:50:30 -07:00
Tim Almdal
8e16cee2c3 Forgot to change the defaults theme names on initial install... Duh 2009-09-24 14:24:43 -07:00
Tim Almdal
054a8dedac Oops, forgot to change the install version number to match the upgrade version number 2009-09-24 10:28:02 -07:00
Tim Almdal
d727716af7 Change the simple uploader dialog to use the new gallery::find_file api method. 2009-09-23 19:51:46 -07:00
Tim Almdal
8bab030883 Add a new api method gallery::find_file. This wraps the Kohana::find_file function, but allows the extension to supplied as part of the filename. Changed the Edit permission dialog to use the new api method to locate the icons from the active theme. 2009-09-23 19:45:23 -07:00
Tim Almdal
b038e9cbb4 set the version number to 13, so we will update the default themes in the gallery vars 2009-09-23 17:03:25 -07:00
Tim Almdal
65051a4bf7 Rename the default themes to wind and admin_wind. Change xss_data.txt file to reflect this move. Not completely moved yet, but the git st is rather large so lets commit this now as a base for the cleanup. 2009-09-23 15:06:17 -07:00
Tim Almdal
719b111219 Correct indentation 2009-09-23 14:38:38 -07:00
Tim Almdal
fed41eae6c Fix a typo 2009-09-23 12:04:26 -07:00
Tim Almdal
b79129e365 Clone the photo::get_edit_form to the movies helper and use it to generate the movie edit form. Fixes ticket #726. 2009-09-23 12:02:35 -07:00
Tim Almdal
bdb6b17bf5 Correct whitespace 2009-09-23 09:09:45 -07:00
Tim Almdal
faee4391a3 Remove a commented line I forgot to take out 2009-09-23 07:12:17 -07:00
Bharat Mediratta
91c99c9627 Simplify the "unchanged" status message. 2009-09-22 20:36:12 -07:00
Tim Almdal
28060d9dce Create a gallery error handler that traps php errors and rethrows them as Exceptions. This fixes ticket #763 2009-09-22 14:25:52 -07:00
Tim Almdal
1dc3f375bf Updated to Exifer r4477. Fixes ticket #763. 2009-09-22 12:35:40 -07:00
Tim Almdal
1e7a2f5808 Implement the updated version of gallery3-vendor/exifer which has gettext replaced with calls to the gallery t method to provide translation. Fixes ticket 672. 2009-09-22 11:09:04 -07:00
Tim Almdal
bec620487a Wrap the login form with a view in order to include a forgot password link. Fixes ticket #620 2009-09-22 09:48:24 -07:00
Tim Almdal
f1366d275e Issue an information message if the user clicks "Save Settings" indicating that the key was not changed as it as identical. This addresses the obscure issue raised in ticket #756 2009-09-22 08:46:07 -07:00
Tim Almdal
b310fab1f8 Change the link on the "Be first to comment" link to do a request to the server to get the comment add form. Fixes ticket #699. 2009-09-22 07:59:26 -07:00
Tim Almdal
bf93473de5 Revert "Change the exif module to respond to the gallery_ready event and check to see if gettext is installed. The 3rd party library used in the exif module expects gettext to be available. Rather than doing all the time use the gallery ready event to only do it when it might be needed. Fixes ticket #672" 
This reverts commit 33690a32bc.
 2009-09-22 06:56:28 -07:00
Bharat Mediratta
e5a78d39ec Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev 
Conflicts:
	modules/gallery/controllers/albums.php
 2009-09-21 21:29:13 -07:00
Bharat Mediratta
529ded3388 2nd attempt at gracefully dealing with sort columns that contain 
nulls.  This time around, do a query to determine whether or not the
sort column has nulls in it.  If it doesn't, then use our comparators
as before.

There are NULLs in the sort column, so we can't use MySQL comparators.
Fall back to iterating over every child row to get to the current one.
This can be wildly inefficient for really large albums, but it should
be a rare case that the user is sorting an album with null values in
the sort column.

Fixes #627
 2009-09-21 21:28:00 -07:00
Bharat Mediratta
123afc9542 Set children_count to 0, photos have no children. 2009-09-21 21:22:07 -07:00
Bharat Mediratta
88350c5b88 Update the next/previous item calculations to match what we do in photos.php 
Force the children_count to be zero, movies have no children.
Rename $photo to $movie everywhere.
 2009-09-21 21:21:52 -07:00
Bharat Mediratta
9e6be40e31 Add viewable() protection to children() and children_count() calls. 
This is not currently necessary (nor is it a security hole) because we
don't constrain permissions at the child level in the core, but it
makes our security audits easier and will enable the scenario where
somebody writes a module to add per-photo permissions.
 2009-09-21 20:47:55 -07:00
Tim Almdal
33690a32bc Change the exif module to respond to the gallery_ready event and check to see if gettext is installed. The 3rd party library used in the exif module expects gettext to be available. Rather than doing all the time use the gallery ready event to only do it when it might be needed. Fixes ticket #672 2009-09-21 13:33:45 -07:00
Bharat Mediratta
a6581ede0b Fix Item_Model::get_position() so that our sort is stable when the comparison 
row has a null value in the sort field.  Fix for #627

Note: this changes get_position() to take an Item_Model instead of an id!
 2009-09-21 11:35:27 -07:00
Tim Almdal
09f998e7a5 On the edit album form, add dirname and slug asa hidden fields, so that when the edits are being validated on input, the fields are found and can be referenced 2009-09-19 10:51:27 -07:00
Tim Almdal
cf89015a29 Change the fix for ticket #775 to always add the Add menu, but not add any items if the album directory is not writable. 2009-09-19 09:34:27 -07:00
Tim Almdal
4e6f2f1b4c Don't display the add menu if the underlying operating system directory is not writable. THis should fix ticket #775 2009-09-18 23:53:48 -07:00
Tim Almdal
be84c7be25 * Changed the close functionality so the page is reloaded when the dialog is closed. 
* Renamed the ServerAddCloseButton.
* Added Pause and Continue buttons. Now when add is clicked, A Pause button is shown,
  once the adding is complete, the add button is reshown andpause button is hidden.
  Clicking the pause button will hide it and show a continue button.
 2009-09-18 12:17:58 -07:00
Tim Almdal
15c3f0b1aa Refactor the server add javascript into a ui.gallery_server_add widget. 2009-09-17 21:26:55 -07:00
Andy Staudacher
2e23ae98c4 - Add theme->movie_menu() to whitelisted methods. 
- xss_data checkpoint
 2009-09-17 14:12:43 -07:00