Bharat Mediratta
cfc0f3d0c0
Minor test cleanup.
2010-01-18 22:51:40 -08:00
Bharat Mediratta
703882f4df
Update valid_parent() to disallow moving an item inside its own hierarchy.
...
Move move_to() inside save()
2010-01-18 22:50:50 -08:00
Bharat Mediratta
efa4e230da
in move_to(), move the lock to before we do any calculations so that we have the latest data.
2010-01-18 21:40:00 -08:00
Bharat Mediratta
b4e6834a28
Added move_album_fails_wrong_target_type_test()
2010-01-18 21:14:43 -08:00
Bharat Mediratta
677fb08002
Updated tests to match what the expected new API for moving items.
...
Now to move an item, you just change its parent_id.
2010-01-18 21:12:26 -08:00
Bharat Mediratta
38c13760af
Switch to using test::random_name() to avoid integer names.
...
Fix up rename_photo_test.
2010-01-18 20:14:09 -08:00
Bharat Mediratta
0e2f4a7a37
Fix renaming in save() by moving the actual rename action under
...
parent::save(). This is consistent with other changes because all
filesystem operations happen after the database change is committed.
Also, inline rename() since it's fairly simple now.
2010-01-18 20:13:46 -08:00
Bharat Mediratta
b93000c0ce
Kohana ticket #2504 is resolved, so this test is no longer necessary.
2010-01-18 17:20:12 -08:00
Bharat Mediratta
1cfee16e38
In valid_name, don't query on the id if it's null.
2010-01-18 13:09:58 -08:00
Bharat Mediratta
f492436317
Add random_name().
2010-01-18 13:03:59 -08:00
Bharat Mediratta
92ed5d45e6
In item_rename_fails_with_existing_name_test switch validate() to
...
save() now that Kohana ticket #2504 is resolved.
2010-01-18 12:56:49 -08:00
Bharat Mediratta
ebb909625c
Merge branch 'master' into bharat_dev
2010-01-18 12:54:26 -08:00
Bharat Mediratta
9384f987bb
Coerce some integers to strings now that ORM isn't typecasting anymore.
2010-01-18 12:52:52 -08:00
Bharat Mediratta
06cabecd76
Coerce some integers to strings now that ORM isn't typecasting anymore.
2010-01-18 12:49:58 -08:00
Bharat Mediratta
a9f07986f6
The root parent id is 0, not null (this deviation exposed by the new lack of typecasting in ORM).
2010-01-18 12:39:42 -08:00
Bharat Mediratta
cf236a228a
Don't assert_same() now that typecasting is gone from ORM.
2010-01-18 12:37:20 -08:00
Bharat Mediratta
cac4692510
Don't use rand() as the name. Now that ORM::load_types() is gone, it
...
won't get coerced to a string, and then we wind up comparing:
12345 != 12345-12321
In the old approach, they'd both be strings so they'd be inequal. But
in the new approach the first value is an integer (sinced it came from
rand()) so the second value is typecast to an integer which drops
everything after the - sign so they appear equal.
2010-01-18 12:35:26 -08:00
Bharat Mediratta
b27907fff7
Merge branch 'master' into kohana_update
2010-01-18 12:22:18 -08:00
Bharat Mediratta
51427d5404
Verified
2010-01-18 12:21:57 -08:00
Bharat Mediratta
284788d964
Switch from stdClass to arrays which works around issues caused in
...
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but
the solutions are equivalent so I'm not going to dig too far.
2010-01-18 12:08:39 -08:00
Bharat Mediratta
41a392611c
Change DENY and ALLOW to "0" and "1" to match the fact that ORM no
...
longer typecasts values as of http://dev.kohanaphp.com/issues/2459
2010-01-18 12:08:05 -08:00
Bharat Mediratta
4eafe97b48
Reload $item after removing view permissions.
2010-01-18 11:57:23 -08:00
Bharat Mediratta
0dc184e99f
Overload url::current() and url::merge() to make the current url XSS
...
safe. Add tests to make sure that it doesn't relapse with future
Kohana changes. Fixes ticket #983 .
Ref: http://gallery.menalto.com/node/93738
2010-01-18 11:10:37 -08:00
Bharat Mediratta
dc286cc2bd
Add a test to verify that bug #2504 is still around. When this test
...
starts failing, the bug is fixed and we can go fix our code that works
around it.
2010-01-18 09:00:14 -08:00
Bharat Mediratta
53735f6b16
Convert a $root to item::root() to fix a test.
2010-01-17 23:50:42 -08:00
Bharat Mediratta
31ecb009ba
Get rid of urls_are_rawurlencoded_test -- it's no longer necessary
...
since we can't have unsafe slugs.
Add basic_validation_test.
2010-01-17 23:47:16 -08:00
Bharat Mediratta
06541f0e2a
Fix item_rename_fails_with_existing_name_test() -- broken because of
...
http://dev.kohanaphp.com/issues/2504
2010-01-17 21:49:48 -08:00
Bharat Mediratta
710e472edc
Fix rename_album_test()
2010-01-17 21:03:15 -08:00
Bharat Mediratta
b35a3c8b81
Fix rename_photo_test().
2010-01-17 20:54:08 -08:00
Bharat Mediratta
9ddb961a91
Partially updated for model based validation.
2010-01-17 20:53:32 -08:00
Bharat Mediratta
6e73b08595
Mostly conver to model based validation. Not all tests pass yet.
2010-01-17 20:37:57 -08:00
Bharat Mediratta
f20fa2cfed
Change IdentityProvider::create_user() to take $email as well, since that's a required
...
parameter for the Gallery driver.
2010-01-17 20:37:25 -08:00
Bharat Mediratta
ab7be17b7f
Switch to model based validation approach.
2010-01-17 20:17:50 -08:00
Bharat Mediratta
7d9d40c7d6
Use test::random_photo_unsaved() instead.
2010-01-17 20:06:34 -08:00
Bharat Mediratta
dd5f08b703
Create xxx_unsaved() versions for the case where you want to tinker with the item before it gets saved.
2010-01-17 20:06:28 -08:00
Bharat Mediratta
c0d0142552
Updated for model based validation.
2010-01-17 20:03:18 -08:00
Bharat Mediratta
39bb08db28
Make set_data_file() chainable.
2010-01-17 20:02:30 -08:00
Bharat Mediratta
afb7decb00
Make it work with model based validation.
...
Refactor _get_proxy() out of setup() and into its own helper function.
2010-01-17 19:57:42 -08:00
Bharat Mediratta
c9fd8d751d
Add random_photo()
2010-01-17 19:57:24 -08:00
Bharat Mediratta
c5f9a466c8
Updated for model based validation.
2010-01-17 19:33:44 -08:00
Bharat Mediratta
c5c17eecc3
Updated for model based validation.
2010-01-17 19:32:05 -08:00
Bharat Mediratta
c863544ec3
Add validation for guest_email and guest_url.
2010-01-17 19:31:49 -08:00
Bharat Mediratta
f68862f4c9
Updated for model based validation.
2010-01-17 19:26:32 -08:00
Bharat Mediratta
53a17e3444
Add album title in random_album().
2010-01-17 19:26:22 -08:00
Bharat Mediratta
c13d5c3513
Helper class for common test methods (like creating albums, photos,
...
etc).
2010-01-17 19:24:48 -08:00
Bharat Mediratta
05e8d560e4
Refactor to work with model based validation.
...
While I'm at it, pull _make_comment() out of setup and only call it on
demand; this makes the tests run faster.
2010-01-17 18:10:32 -08:00
Bharat Mediratta
3ef22d9d1a
Add special output support for ORM_Validation_Exception
2010-01-17 18:09:31 -08:00
Bharat Mediratta
5162e35d49
Use an empty password for the guest user.
2010-01-17 17:54:14 -08:00
Bharat Mediratta
9e9c5397b7
Qualify the Bad Request output when the name is missing
2010-01-17 16:59:25 -08:00
Bharat Mediratta
4197ee39b9
Catch ORM_Validation_Exception and turn it into a 400 Bad Request with
...
appropriate error output.
2010-01-17 16:58:54 -08:00
Bharat Mediratta