stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-22 23:05:18 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,541 Commits 4 Branches 0 Tags
cf9e3db32e7c7f52e92fabc1afca63fdbf741b21
Commit Graph
52 Commits
Author SHA1 Message Date
Bharat Mediratta accce788d9 Fix a bug in set_version() where we were always forcing the value to 1. Oops! 2009-06-09 21:26:28 -07:00
Bharat Mediratta f55686c7ef Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-09 20:33:31 -07:00
Bharat Mediratta 00b528afac Cache the available module list in module::$available. 2009-06-09 20:32:37 -07:00
Bharat Mediratta 5e6c8894e2 Use a reference in available() to avoid crappy looking dereferencing. 2009-06-09 20:08:48 -07:00
Andy Staudacher 86a32d412f Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-09 19:49:58 -07:00
Andy Staudacher 7ccb65ea9e Fix for fetching l10n plural messages. Need to cast from stdclass to array(), as I18n expects all messages to be either string or array. 2009-06-09 19:49:06 -07:00
Bharat Mediratta e5d273e929 Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-09 19:00:22 -07:00
Bharat Mediratta d0b2544511 Check in /usr/local/bin for ffmpeg, and create the setting even if its 
empty (to make it easier for folks to change it in Admin > Settings >
Advanced)
 2009-06-09 18:59:53 -07:00
Tim Almdal 8189c1fc6b Removed extra whitespace 
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-06-09 21:45:57 +08:00
Tim Almdal f0ea6d532c Create a new method in MY_url.php "get_item_from_uri" which loads the item 
based on the uri.  Then use this helper method in logout.php to insure that
the guest user has access to the "continue" uri.  If they don't redirect to
the root album and let it deal with access issues.

Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-06-09 21:45:43 +08:00
Bharat Mediratta 1ecdb5ef0c Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-08 21:32:03 -07:00
Bharat Mediratta c7aafef852 Improve error handling support for corrupt images and report them 
appropriately in g2_import.
 2009-06-07 17:48:42 -07:00
Andy Staudacher b9ee6f7d18 Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-06 15:24:49 -07:00
Andy Staudacher 0e415dae9b Preliminary BiDi support (needs *a lot* of tweaking) 2009-06-06 15:24:14 -07:00
Chad Kieffer 7cdcb5179f Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-06 00:35:39 -06:00
Chad Kieffer c5425f42a4 Remove album view icon link, added album link to info module. This and breadcrumb should suffice. 2009-06-06 00:35:30 -06:00
Bharat Mediratta 3275401f69 change the version to beta 1 2009-06-05 17:44:36 -07:00
Bharat Mediratta 275c25eb56 Add the exception message to the trace string when there's a graphics 
failure.

Signed-off-by: Bharat Mediratta <bharat@menalto.com>
 2009-06-06 08:39:07 +08:00
unostar 710d13aece Correct locale and local translation 
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
 2009-06-06 01:26:41 +08:00
Bharat Mediratta 62a63676d4 Add Belarusian to the language list. 
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
 2009-06-06 01:26:24 +08:00
Bharat Mediratta 7612c8d404 Localize the 'Advanced' menu item 
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
 2009-06-06 01:26:22 +08:00
Bharat Mediratta c7f49fd1ec Skip over busted images when rebuilding. Change graphics::generate() 
to return true/false on whether or not it could rebuild the image
properly, then track the broke images in the task and ignore them.

Fixes ticket #344.
 2009-06-04 23:20:54 -07:00
Bharat Mediratta 12ef4272ae Work around a problem with the CGI sapi on urls that don't contain 
index.php (ie, /gallery3 instead of /gallery3/index.php) that causes
is to mis-route.
 2009-06-04 18:40:38 -07:00
Bharat Mediratta e5a0104769 Make sure the item is loaded in parse_url() before we use it. 2009-06-04 18:19:49 -07:00
Bharat Mediratta 5158a6f433 Add MY_num containing num::convert_to_bytes() which supports PHP's 
size shorthand, and convert the simple_uploader code to use it.
 2009-06-04 17:53:40 -07:00
Bharat Mediratta 8d9010cfe3 Let the Akismet module create the statistics menu, since it's the only 
one that uses it.  Perhaps this is not the best solution, but it's the
pragmatic one.
 2009-06-04 17:36:37 -07:00
Bharat Mediratta dd854379c2 Sanitize all data we return via json_encode() to guard against XSS and 
other data leaks.
 2009-06-03 17:08:23 -07:00
jhilden dde5fb96ee made "Add photos" its own site menu item 
* open for suggestions on the submenu item labels
* @bharat: not sure about the add photos menu item id in the dropdown case
 2009-06-02 19:31:11 -04:00
Tim Almdal d8eca7682d make cleanm static 2009-06-02 12:41:59 -07:00
Andy Staudacher 1cfed1fac1 Extend L10n client to provide UI for plural translation. 
Ticket 148.
 2009-06-02 00:43:04 -07:00
Bharat Mediratta 43abcd9386 Security pass over all controller code. Mostly adding CSRF checking 
and verifying user permissions, but there are several above-the-bar
changes:

1) Server add is now only available to admins.  This is a hard
   requirement because we have to limit server access (eg:
   server_add::children) to a user subset and the current permission
   model doesn't include that.  Easiest fix is to restrict to admins.
   Got rid of the server_add permission.

2) We now know check permissions at every level, which means in
   controllers AND in helpers.  This "belt and suspenders" approach will
   give us defense in depth in case we overlook it in one area.

3) We now do CSRF checking in every controller method that changes the
   code, in addition to the Forge auto-check.  Again, defense in depth
   and it makes scanning the code for security much simpler.

4) Moved Simple_Uploader_Controller::convert_filename_to_title to
   item:convert_filename_to_title

5) Fixed a bug in sending notification emails.

6) Fixed the Organize code to verify that you only have access to your
   own tasks.  In general, added permission checks to organize which had
   pretty much no validation code.

I did my best to verify every feature that I touched.
 2009-06-01 22:40:22 -07:00
Bharat Mediratta 1145b846ba Fix a place where I shouldn't have renamed "core" to "gallery", breaking maintenance mode. 2009-06-01 21:07:24 -07:00
Bharat Mediratta 181c97ef4b Relax the regex we use to extract the movie size so that it works with 
the new version of ffmpeg that I have on my dev box (ffmpeg
0.5-svn17737+3:0.svn20090303-1)
 2009-05-31 12:53:03 -07:00
Bharat Mediratta f9a741782d Switch to using html::specialchars() for cleaning. 2009-05-31 12:33:10 -07:00
Bharat Mediratta ad81861c33 First pass at an XSS security test, along with the "p" helper which 
can clean HTML output.
 2009-05-31 00:11:02 -07:00
Bharat Mediratta a5670d8d70 gate $can_edit and $can_add on whether or not we have an $item at all 
(fixes a bug where search doesn't render because it has no item).
 2009-05-30 17:14:17 -07:00
tim almdal f0104ee43b remove scaffolding code 2009-05-29 21:53:49 -07:00
Bharat Mediratta ce285b8feb Use the relative_path_cache to look up items which should be a faster 
query than using the level + the components.
 2009-05-29 21:23:08 -07:00
Bharat Mediratta cbec883d8a Don't show "edit permissions" for non-albums. 2009-05-29 20:59:34 -07:00
Bharat Mediratta 60d1bbc2d6 Move credits message into a variable, which can be changed in Admin > 
Settings > Advanced.  It's stored in the variable as an
internationalized string and localized at output time.
 2009-05-29 20:24:42 -07:00
Bharat Mediratta 381dd0574a Don't show the add photo/album options to users who don't have the 
permission.  This isn't a security hole, since they can't actually add
stuff.. but they can try and fail which is a bad user experience.

Also fix it up so that we show the option menu only if there's stuff
to show, and cache some of the permissions for performance (which I'm
guessing at-- didn't benchmark it).
 2009-05-29 17:53:33 -07:00
Bharat Mediratta 055e0a7dc5 Remove a completed @todo 2009-05-29 17:42:31 -07:00
Bharat Mediratta 356bac0db0 Restore calls to module::load_modules() after install/activate/deactivate/uninstall events. 2009-05-28 21:18:46 -07:00
Bharat Mediratta d088a41747 Load the gallery module in load_modules(), but put it at the end of 
the module list (to match its location in the cascading filesystem)
 2009-05-28 21:00:06 -07:00
Bharat Mediratta 7fd6fcaf9b Force modules/gallery to be at the end of the module load path, so 
that all other modules can override the core code.
 2009-05-28 17:46:17 -07:00
Bharat Mediratta df51ea7fa4 Fix broken html::script() and url::file() references to the newly 
moved gallery module.
 2009-05-28 00:06:38 -07:00
Bharat Mediratta 24dce5a85d Fix up another place where we were incorrectly referencing the gallery module. 2009-05-27 21:18:09 -07:00
Bharat Mediratta 23884f7968 Fix a typo in the class name 2009-05-27 19:59:34 -07:00
Bharat Mediratta 5e7cc75a29 Convert a few more references of APPPATH to MODPATH/gallery 2009-05-27 16:29:33 -07:00
Bharat Mediratta 28b09a3046 Show the scaffolding link if the controller is around. 2009-05-27 16:23:05 -07:00