Commit Graph

2232 Commits

Author SHA1 Message Date
Tim Almdal
aa85d27eab Initialize the slug field when doing the update tests 2009-10-23 09:52:03 -07:00
Tim Almdal
703f22abcb Only look for tests that are in the active modules. Update the controller golden file to reflect the current location of files. 2009-10-23 09:41:33 -07:00
Tim Almdal
2e998664d5 move controllers and views to the user module to make the Identity Provider refactor smaller 2009-10-23 09:23:02 -07:00
Tim Almdal
94cd07805d Change the gallery_unit test to only intall into the test environment, modules that are active in the non-test environment. 2009-10-23 07:49:14 -07:00
Tim Almdal
b3e175006c Move the filters that the File_Structure_Test use into a seperate file so other tests. can use them. Add a No_Direct_ORM_Access_Test to find all places that the user or group table are accessed outside of the user module. This test will fail at this point, as it in preparation for the IdentityProvider refactor. 2009-10-23 07:48:07 -07:00
Chad Kieffer
da73c0c25f Poor man's merge. Note to self, git pull before working. Next pound the steps to merge into your head. 2009-10-22 23:36:05 -06:00
Chad Kieffer
80c6bf789b Make g-inline more specific, replace universal selector with an li since this class will most often be used with order and unordered lists. Apply g-inline to the the login menu and footer credits. 2009-10-22 22:28:55 -06:00
Chad Kieffer
ba62fb4b0e Standardize message markup, make the update block status message translatable. 2009-10-22 22:06:36 -06:00
Chad Kieffer
e025abea41 Added confirmation message for block admin actions. 2009-10-20 23:37:03 -06:00
Chad Kieffer
093b209807 Removed console.log() debug output. 2009-10-20 23:22:16 -06:00
Chad Kieffer
055c410126 Fix block management UI. Block list height is now dynamically set based on the total number of available blocks which will grow without hardcoding CSS heights and setting the div to be scrollable. 2009-10-20 23:20:38 -06:00
Chad Kieffer
fbb8e92497 Added generic .g-message class to mark form validation messages. Minor form layout updates. 2009-10-20 22:35:39 -06:00
Chad Kieffer
5d66416b26 Minor tag admin style updates. 2009-10-20 21:34:47 -06:00
Chad Kieffer
1dd4e4a427 Update tag error messages to use g-action-status and g-message-block. Style g-error for short forms. 2009-10-20 20:56:14 -06:00
Chad Kieffer
ba2d4b923b Rollback tag admin to fix. Now functioning. 2009-10-20 20:20:48 -06:00
Chad Kieffer
b2d0b3ebbb Fix sidebar block admin layout. Don't hardcode block list height, use the equal_heights() function to set it. 2009-10-18 23:38:27 -06:00
Chad Kieffer
c2b32cc2b8 Resolve merge conflict. 2009-10-18 22:45:13 -06:00
Chad Kieffer
6a7db5bea1 Resolve merge conflict. 2009-10-18 20:39:31 -06:00
Chad Kieffer
47d4cd5cb4 Resolve tag module conflicts. 2009-10-18 20:32:33 -06:00
Chad Kieffer
5f56cbf997 Wrap all admin views in g-block and g-block content. This provides the means to visually separate the view's title and description from everything else. Primary admin view title should always be h1, and only one h1 per view. Removed some unused admin CSS id's. 2009-10-18 20:22:10 -06:00
Chad Kieffer
91ab6f161f Apply g-block and g-block-content, remove hover effect, alternate row color. 2009-10-18 18:01:42 -06:00
Chad Kieffer
8cd8fa2b99 Fixed add tag short form layout. 2009-10-18 10:53:18 -06:00
Chad Kieffer
c9ccc24618 Moved the short_form init function to gallery.common and made it jQuery plugin. Dropped gallery.form.js. Applied short forms to server_add and tag admin pages. Added tag.css to admin views. Added .g-wide {}. 2009-10-18 10:32:08 -06:00
Chad Kieffer
08a22f4a39 Add tag.css to tag admin page. 2009-10-17 21:59:53 -06:00
Chad Kieffer
6e4fe79217 White space fixes. 2009-10-17 16:40:55 -06:00
Chad Kieffer
ad0497a8d2 Drop our g-clearfix in favor of using jQuery UI's ui-helper-clearfix. 2009-10-17 12:58:31 -06:00
Chad Kieffer
b677eeb5ee Missed this in last commit. 2009-10-17 12:57:34 -06:00
Chad Kieffer
f2b6ec6637 Move tag css from theme to the module. Introduced generic .g-inline class for inline elements, including lists and forms. 2009-10-17 12:48:54 -06:00
Chad Kieffer
eb3e36f132 Apply g-dialog-link class directly to login link markup, not via jQuery. 2009-10-16 00:56:37 -06:00
Chad Kieffer
c876ec1f50 Apply g-short-form directly to short forms rather than via JS. Comment updates in ui.init.js. 2009-10-16 00:00:52 -06:00
Tim Almdal
f5dd8d487e Move all the edit/update forms for users and groups back to the user module. 2009-10-15 08:56:31 -07:00
Tim Almdal
0d5d4c81bc Move the ui for user adminsitration back to the user module. 2009-10-14 21:20:30 -07:00
Tim Almdal
8e1ab75530 Recreate group::lookup that somehow got removed. 2009-10-14 21:07:19 -07:00
Tim Almdal
b46346aab6 Optimize the creation of the language block 2009-10-13 13:56:44 -07:00
Tim Almdal
14e14003de refactor the user and group helpers into the gallery core module. 2 reason, first it makes sense that users and groups are a gallery requirement and belong in core. secondly, prepares the way for the Identity refactor. 2009-10-13 13:37:37 -07:00
Tim Almdal
2af4806011 Refactor the ui component of the user module into the gallery core module. 2009-10-13 13:19:17 -07:00
Tim Almdal
fcd1e79bac forgot to add a break statement when i pasted 2009-10-13 12:54:30 -07:00
Tim Almdal
1c313e9d2d Continue to refactor locale and gallery3 ui from the user module to the gallery module 2009-10-13 12:46:27 -07:00
Tim Almdal
f8eee90705 remove the unused private function user::_md5Salt() 2009-10-13 12:38:21 -07:00
Tim Almdal
2c711d8908 refactor locale related functionality out of the user module and into the gallery module. 2009-10-13 12:33:00 -07:00
Tim Almdal
53393a1446 Merge branch 'master' of git@github.com:gallery/gallery3 2009-10-09 01:28:17 -07:00
Bharat Mediratta
3fc1eb5842 Merge branch 'master' of git@github.com:gallery/gallery3 2009-10-13 10:39:25 -07:00
Bharat Mediratta
0a66ef9cc7 Don't allow users to change the file extension of photos/movies
If you can change the extension, then you can alter the way the server
handles the file, which is a security problem.  So for example, you
can change a .JPG to a .PHP and then if you put some malicious PHP
code in the EXIF data, you can get the server to execute
it. Vulnerability is low because only users who have edit permissions
could do this.

Fixes ticket #846
2009-10-13 10:36:50 -07:00
Bharat Mediratta
b6c1ba7ea6 Use SQL_CALC_FOUND_ROWS instead of doing the search twice, for better performance.
Fixes ticket #835, thanks Joe7!
2009-10-11 11:22:41 -07:00
Bharat Mediratta
bc63e4fcf9 Make the slug field required for all items.
Make the filename field required for photos/movies.
Fixes ticket #838
2009-10-11 11:16:07 -07:00
Tim Almdal
79b4b8bdc6 update the Access_Helper_Test to use the user::lookup_by_name API method. 2009-10-09 01:27:27 -07:00
Tim Almdal
1ee7d24766 Add support for the in filter to get_user_list and get_group_list. Convert the notifications to use user::get_user_list instead of accessing the table directly. 2009-10-09 01:27:26 -07:00
Tim Almdal
00ee91837f Convert direct lookups for the user table using ORM to using the user::lookup_by_name and user_lookup API methods.
Convert the Admin_User controller
Convert the login and password change controller
Change the item model to call user::lookup to get the owner.
On the log model, delete the relationship between the log and user table, and replace with a
call to user::lookup
(cherry picked from commit 194cc3b27a)
Create the get_user_list, lookup_by_name, lookup_by_hash and get_group_list api functions
2009-10-09 01:26:35 -07:00
Tim Almdal
f67bfd0992 Change the users.php controller so its no longer restful. The problem with our approach to restfulness is that it assumes that the resource will be found in the gallery database. It may well be there, but in the case of using plugable drivers for users management, there are no guarantees that it is in our database or it could be in a ldap directory. So it was just easier to remove the restfulness and just call user::lookup instead.
(cherry picked from commit b3211cb2a8)
2009-10-08 23:22:07 -07:00
Chad Kieffer
121fcab5c8 Replaced most clear fix hacks with generic class. 2009-10-07 00:46:02 -06:00