Commit Graph

267 Commits

Author SHA1 Message Date
Tim Almdal
c4e3604315 Strongly type the argument list to the model::validate method. 2010-01-29 14:04:27 -08:00
Tim Almdal
f943a2deef Don't show a link to the user profile for the guest user 2010-01-28 08:14:33 -08:00
Bharat Mediratta
bbe70119ef Localize validation messages. 2010-01-27 23:05:57 -08:00
Bharat Mediratta
31e4c21719 Localize error messages. 2010-01-27 23:03:47 -08:00
Bharat Mediratta
4b32a71afc Convert back to using ORM::factory(..., $id) instead of calling where(). 2010-01-27 22:34:11 -08:00
Bharat Mediratta
1606961153 Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev
Conflicts:
	modules/gallery/libraries/MY_ORM.php
2010-01-25 19:49:17 -08:00
Tim Almdal
7c06e21ec4 Refactor creating the user profile page content into the the event module. The show_user_profile is used to provide content to the user profile page. Add the list of the users comments to the profile page. 2010-01-24 15:27:33 -08:00
Tim Almdal
ed5b07b335 Create a user profile page that is used as a landing page when referencing a user in messages or pages.
Partial fix for ticket #889 and a fix for #931.
2010-01-23 21:38:01 -08:00
Bharat Mediratta
fecac4a859 Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev
Conflicts:
	modules/gallery/tests/xss_data.txt
2010-01-23 16:29:10 -08:00
Tim Almdal
603c3049a1 Treat identity providers just like other modules and use the admin_module to
install and switch to a different identity provider.
2010-01-22 09:39:29 -08:00
Bharat Mediratta
6dc88be6b6 Stop using MY_ORM::original(). 2010-01-20 22:50:47 -08:00
Bharat Mediratta
76da85a1a0 Extend Gallery_Unit_Test_Case instead of Unit_Test_Case. 2010-01-19 22:38:19 -08:00
Bharat Mediratta
c5f9a466c8 Updated for model based validation. 2010-01-17 19:33:44 -08:00
Bharat Mediratta
c5c17eecc3 Updated for model based validation. 2010-01-17 19:32:05 -08:00
Bharat Mediratta
c863544ec3 Add validation for guest_email and guest_url. 2010-01-17 19:31:49 -08:00
Bharat Mediratta
f68862f4c9 Updated for model based validation. 2010-01-17 19:26:32 -08:00
Bharat Mediratta
3789b85b7d Move rules down into validate() and improve valid_author(). 2010-01-17 12:19:24 -08:00
Bharat Mediratta
1c85cf6397 Convert comment code over to model based validation. 2010-01-16 22:27:07 -08:00
Bharat Mediratta
dcf4b5e71a Don't pass MY_ORM::original() to update event handlers, since after
parent::save() it'll be reset.  Clone it first.

This is an alternate fix for #978.
2010-01-16 00:13:28 -08:00
Tim Almdal
a11bf29507 Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any where
clauses and deletes all the entries in the table unless an array of id's are
passed as the parameter.  This fix used the Database_builder to specify any where
conditions. Thanks psvo for find the first one. :-)
2010-01-09 23:57:16 -08:00
Bharat Mediratta
31a545fa26 Add missing execute() call -- tests ftw! 2009-12-21 15:58:22 -08:00
Bharat Mediratta
bfcd99f3f2 Updated for K24 2009-12-21 11:30:34 -08:00
Bharat Mediratta
a6dbd25cf1 Update database queries. 2009-12-06 21:38:09 -08:00
Bharat Mediratta
96b00d6cfe Convert some more Database::instance() calls to db::build() form. 2009-11-26 21:14:54 -08:00
Bharat Mediratta
d036e2fc49 Convert another Database::instance() query over to using db::build() 2009-11-26 13:18:10 -08:00
Bharat Mediratta
dd2bca0224 Modify the expiration code to work with db::build() 2009-11-26 12:54:07 -08:00
Bharat Mediratta
1fd0e14359 Convert all DB where() calls to take 3 arguments.
Convert all open_paren() calls to and_open() or or_open() as appropriate.
2009-11-26 12:09:04 -08:00
Bharat Mediratta
0121bfd585 ORM::orderby -> ORM::order_by 2009-11-25 19:26:52 -08:00
Bharat Mediratta
f50dbd992d Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev
Conflicts:
	modules/gallery/controllers/rest.php
2009-11-25 13:40:47 -08:00
Bharat Mediratta
2e420522ec Preliminary work to cut over to Kohana 2.4
- Kohana::log() -> Kohana_Log::add()
- Kohana::config_XXX -> Kohana_Config::instance()->XXX
- Implement View::set_global in MY_View
- Updated Cache_Database_Driver to latest APIs
- ORM::$loaded -> ORM::loaded()
- Updated item::viewable() to use K2.4 parenthesization
2009-11-25 13:22:24 -08:00
Tim Almdal
4c3b9e363a Refactor the comment module as part of ticket: #917 "Remove Rest Controller"
* Remove the methods create, update, delete, get_edit_form as there are not used
* Change the return when a comment is created to return the html for the new comment.
  This saves a second get request to down load the comment.
2009-11-25 08:12:50 -08:00
Chad Kieffer
e232c39fe5 Rename g-pager to g-paginator after the recent pagination update. 2009-11-18 18:51:18 -07:00
Bharat Mediratta
1067e68292 Redesign the way that we consider page types to create buckets of page
types, and a subtype for specifics.  Currently the top level bucket

   collection, item, other

Here are the core subtypes so far:

   collection: album, search, tag
   item: movie, photo
   other: login, reset, comment-fragment, comment

It's legal to create new page_subtypes whenever you want.  Use the
appropriate page_type to get the coarse grain behavior that you want.
2009-11-17 14:04:45 -08:00
Bharat Mediratta
78b6da12aa Make sure that we have a valid resource from the server side before we
fetch its url.  Fixes ticket #888.
2009-11-16 14:57:24 -08:00
Andy Staudacher
b64729bfbe Fix ticket 890 (related to 879): Don't double-escape menu labels on the comment admin screen. 2009-11-15 19:46:12 -08:00
Bharat Mediratta
e0f4e6500d Use text::alternate() instead of hand-rolled even/odd code. 2009-11-15 19:34:44 -08:00
Bharat Mediratta
5a27ce7e8f Save/restore $_SERVER before/after tests to avoid contamination.
Fix albums/photos tests to make sure we're really getting the
  HTTP_REFERER back.
2009-11-15 19:10:56 -08:00
Bharat Mediratta
d12e3698e3 Call for_js() on all menu labels, since they're SafeStrings. Fixes ticket #879. 2009-11-13 09:29:00 -08:00
Tim Almdal
a5a8cfd1bc Re-generate the install.sql so that the keys of the block lists are an md5 hash of the module_name:block_id. Also change the packager so we delete the _cache variable for the module gallery not core. 2009-11-12 13:14:02 -08:00
Bharat Mediratta
4f8728029d Call render() on the $menu, since we no longer use its __string()
function to do implicit conversion.
2009-11-08 22:35:14 -08:00
Tim Almdal
45a7eb0248 Remove an extra trailing bracket. 2009-11-02 10:02:34 -08:00
Tim Almdal
376eb5673f Convert the event handlers for the "identity provider changed" and "user_deleted" events to use ORM or the Kohana query builder to build the database update calls instead of coding the sql directly. 2009-11-01 10:22:56 -08:00
Tim Almdal
488b67014b Revert "Cleanup typo and change what is passwed into the event. pass the group that the recaptch element should be attached to instead of the whole form. This allows the recaptch event to have no knowledge of the containing form."
Revert "Generalize the adding of the recaptcha form by changing the name of the event to recaptch_add.  This prevents us from having to keep modifying the recaptch module anytime we add a form that requires recaptcha."

This reverts commits e45ea9359d and bfafef95e8.
2009-10-31 16:26:20 -07:00
Tim Almdal
903b5f6f67 Add identity_change handlers to resolve the ownership issues of comments, subscription, items and tasks. 2009-10-31 14:23:05 -07:00
Tim Almdal
90465012d1 Patch to clean up loose ends when a user is deleted.
* For items and tasks the owner id is set to admin
* For notification subscriptions, the subscription is deleted
* For comments, I've extracted the user name, email and url and set the guest_name, guest_email and guest_url columns while setting the author_id to identity::guest()->id
Fix for ticket #777.
2009-10-30 14:23:57 -07:00
Tim Almdal
749d17ac16 Use the identity interface admin_user to retreive the admin user. 2009-10-29 11:18:35 -07:00
Tim Almdal
e45ea9359d Cleanup typo and change what is passwed into the event. pass the group that the recaptch element should be attached to instead of the whole form. This allows the recaptch event to have no knowledge of the containing form. 2009-10-29 09:27:44 -07:00
Tim Almdal
bfafef95e8 Generalize the adding of the recaptcha form by changing the name of the event to recaptch_add. This prevents us from having to keep modifying the recaptch module anytime we add a form that requires recaptcha. 2009-10-29 09:21:07 -07:00
Tim Almdal
7ea13b3869 Normalize capitalization ticket #596 2009-10-28 12:15:52 -07:00
Tim Almdal
6fb116c53b Merge branch 'master' into talmdal_dev 2009-10-26 06:24:51 -07:00