Commit Graph
1491 Commits
Author SHA1 Message Date
Andy Staudacher c38bee203b Add Faroese to the language list. Verified that it uses the default plural rules, thus no changes in Gallery_I18n.php or on the server side required. 2010-02-24 16:21:54 -08:00
Andy Staudacher 1d8862d957 Fix for ticket #1034: Fix db cache driver delete() call which was missed in a recent refactoring / fix. 2010-02-24 01:28:38 -08:00
Bharat Mediratta d4423eb349 Reset the active user to admin in all test cases where we change the
user to something else.
2010-02-23 13:50:57 -08:00
Bharat Mediratta de1785d9fa Merge branch 'master' of github.com:gallery/gallery3 2010-02-23 12:58:30 -08:00
Andy Staudacher 212da35cdc Fix Cache tests for recent Cache/Database.php driver fix.
Cache::delete($arg) allows for scalars and arrays, but Cache drivers' delete($arg) function always expects an array.
2010-02-23 12:48:03 -08:00
Bharat Mediratta 8ab580cec1 Verified 2010-02-23 11:50:39 -08:00
Bharat Mediratta 16bf1d18ad Merge branch 'master' of github.com:gallery/gallery3 2010-02-23 11:11:11 -08:00
Bharat Mediratta fb5503be09 Name this release "Santa Fe". Fixes ticket #683. 2010-02-23 11:10:32 -08:00
Andy Staudacher 6afc5ccf5c Fix translation cache for installations with 0 translations in the DB. 2010-02-23 10:02:27 -08:00
Andy Staudacher 6ce0132842 Fix for ticket #1027: Add index on cache key column.
(and fix the packager to truncate the cache table before packaging)
2010-02-22 00:30:54 -08:00
Andy Staudacher 95374070db Merge commit 'upstream/master' 2010-02-22 00:00:25 -08:00
Andy Staudacher 334cd2368d Performance improvement: Load all translations of a locale as one serialized array from the Cache.
Until now, we loaded hundreds of translation messages row by row, and unserializing one by one at bootstrap time. That amounted to a significant percentage of the complete request time. This approach is more than 10x faster.
2010-02-21 23:50:01 -08:00
Andy Staudacher 6591ea2577 Fix delete() function of DB based Cache driver. It expected a scalar key / tag value, but it was always an array of keys / tags.
(compare to system/libraries/Cache.php and the File.php driver)
2010-02-21 23:48:23 -08:00
Andy Staudacher 8e7eda9cc6 Fix progress bar / maintenance tasks for locales that use comma as decimal separator, such as German. 2010-02-21 23:23:48 -08:00
Andy Staudacher 6cbe0f78aa Revert "Fix Kohana's internal cache for Gallery's usage pattern."
This reverts commit 5ddd7c9677.
2010-02-21 21:07:55 -08:00
Andy Staudacher 5ddd7c9677 Fix Kohana's internal cache for Gallery's usage pattern.
Adds a core.internal_cache_read_only config variable to Kohana's internals.

Kohana's internal_cache for find_file wasn't working in Gallery because the cache would be emptied on each request after reading it from disk and before most lookups would run.
 1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery.
 2. Kohana::setup() loads find_file cache from disk.
 3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense).
 4. Request processing starts, and thus 80% of all Kohana::find_file() triggered  is_file() invocations start off with an empty find_file cache.

In the case of my small Gallery installation, we're talking about 3100 is_file() invocations per request with or without internal_cache enabled. With this fix, this number is down to 800 invocations.

The basic idea is that we treat the cache as read only and don't write any (possibly dirty) values to it in memory until we're sure that the include path won't change later on in the request processing. Once we know the list of active modules and themes, we can update core.modules and finally flip the read-only state of the cache and start writing to it.
2010-02-21 20:04:06 -08:00
Bharat Mediratta 9b7542b9f1 Add Menu::add_before() 2010-02-21 17:14:19 -08:00
Bharat Mediratta 5fbc472300 Fix the resize_url and file_url in as_restful_array() 2010-02-19 11:54:03 -08:00
Tim Almdal f062cc5e1a Merge branch 'master' of git@github.com:gallery/gallery3 2010-02-19 11:49:01 -08:00
Tim Almdal 10c0698949 Correct the view_fillsize permission to view_full. In addition, change the name of the field containing the url to the fullsize image to file_url instead of fullzie_url 2010-02-19 11:48:54 -08:00
Bharat Mediratta d388e4bb86 Refactor away the "display_all" construct in User_Profile_Controller.
"display_all" is too coarse, and we should be letting event handlers
make the appropriate decision on what to display and when.  This
duplicates some code, but it's now very clear in the event handlers
what's getting shown.

Throw a 404 if we try to view the user profile for a missing user.

The only feature change in this should be that we now display the
name, full name and website for a user to any other registered user,
which makes sense since these are typically public fields.

Don't show any of the edit buttons unless identity::is_writable()
2010-02-19 11:40:49 -08:00
Bharat Mediratta 643fffdba0 Add spaces around %name in the "create a file" text so that
double-clicking the token only selects that one word, not the word on
the line before (which happens on Chrome/Linux)
2010-02-19 09:49:05 -08:00
Chad Kieffer 3f021d3610 Merge branch 'master' of github.com:gallery/gallery3 2010-02-18 23:01:15 -07:00
Chad Kieffer 2846d81171 First pass at user profile formatting updates. Moved buttons to the top, simplified HTML and CSS. 2010-02-18 23:00:58 -07:00
Bharat Mediratta 4c63753044 Restore the user_profile.php change from reverted
4091219425 that had this comment in the
change: "Also fixed a UI bug: No longer showing the edit user buttons
to admins in the profile view (to be consistent with the requirements
in the controller)."
2010-02-18 16:33:57 -08:00
Bharat Mediratta 0d72daf3d2 Restore the gallery_installer change from reverted dcddc68f58
that casts $powered_by_string from SafeString to string.
2010-02-18 16:33:17 -08:00
Bharat Mediratta 7d98d4b7b9 Revert "Fix for ticket #491: Make user and group names translatable."
This reverts commit 4091219425.
2010-02-18 16:20:59 -08:00
Bharat Mediratta 99c131e845 Revert "Never assign a SafeString instance to a Model member (or hell will break loose)."
This reverts commit dcddc68f58.
2010-02-18 16:20:23 -08:00
Bharat Mediratta d3e07f8a97 Revert "Fix for ticket #1017: Handle the common case of t(html::clean($var)) by casting SafeString instances to string in translate()."
This reverts commit 4ca55a90ee.
2010-02-18 16:19:41 -08:00
Andy Staudacher 45910ffdc0 Improve setlocale() call, using some of G2's locale fallback code to match the platform's locale names. 2010-02-18 16:19:17 -08:00
Andy Staudacher 8f39e68449 Improve setlocale() call, using some of G2's locale fallback code to match the platform's locale names. 2010-02-18 14:43:18 -08:00
Andy Staudacher 4ca55a90ee Fix for ticket #1017: Handle the common case of t(html::clean($var)) by casting SafeString instances to string in translate(). 2010-02-16 23:54:39 -08:00
Andy Staudacher 5e25d2f7f1 Put focus on password field in reauthenticate dialog. 2010-02-15 14:27:48 -08:00
Andy Staudacher 6c89bb8878 Update of reviewed XSS audit data. 2010-02-15 13:51:32 -08:00
Andy Staudacher dcddc68f58 Never assign a SafeString instance to a Model member (or hell will break loose). 2010-02-15 13:12:38 -08:00
Tim Almdal a597b57210 return the absolute url not the relative for the full size, resize and thumb images. 2010-02-15 12:29:49 -08:00
Andy Staudacher 4091219425 Fix for ticket #491: Make user and group names translatable.
Also fixed a UI bug: No longer showing the edit user buttons to admins in the profile view (to be consistent with the requirements in the controller).
2010-02-14 19:26:34 -08:00
Andy Staudacher 667d65aea4 Fix for ticket 901: Wrap Gallery version string into bdo tag to override the BiDi algorithm. Also, properly marking the "Powere by" string for translation.
See: http://www.w3.org/International/tutorials/bidi-xhtml/#Slide0420
2010-02-14 18:33:38 -08:00
Andy Staudacher 30dcaaa236 Need to allow access to ::change_provider for CLI, to make packager work. 2010-02-14 18:33:10 -08:00
Andy Staudacher 0eb9b43a33 Enable session expiration. Currently, it's set to expire sessions after 7 days of inactivity. 2010-02-14 17:26:57 -08:00
Andy Staudacher 74471df777 Minor security tightening of IdentityProvider::change_provider(). 2010-02-14 16:12:18 -08:00
Tim Almdal 141595e709 Create an items REST collection requests that accepts a list of resource urls and returns the items associated with them. 2010-02-14 07:35:03 -08:00
Tim Almdal 897215689c Remove the dirty flags from the information returned from the rest request for an item. In addition, add links to the images. 2010-02-14 07:32:35 -08:00
Andy Staudacher 0f66db51ef Change JavaScript reauthentication check to check via XHR.
Benefit: Getting the real deadline this way, not interfering with an ongoing maintenance task.
2010-02-14 07:15:59 -08:00
Andy Staudacher 1a951cb7f6 HTML validation fix (<script>) 2010-02-14 07:15:58 -08:00
Andy Staudacher 2dad1d7cd1 Some HTML validation fixes (don't render empty <ul> lists, empty id attributes, use &amp; not &) 2010-02-14 07:15:57 -08:00
Andy Staudacher 8412aeb133 For consistency, use straight Kohana_404_Exception instead of the event system. 2010-02-14 07:15:57 -08:00
Bharat Mediratta e88e976fc4 Tighten up the text. 2010-02-12 13:49:14 -08:00
Andy Staudacher d53f6d0e05 Fix for tickets 1009 and 603: Show a themed error page to guests / registered users (not to admins though). And show a login form to guests for 404 (incl. insufficient view permissions) errors. 2010-02-12 16:40:44 -08:00
Bharat Mediratta ce71ea6aa7 Revert "1) Add a depth parameter to retrieving an item thru the rest api"
This reverts commit 3439671bcf.
2010-02-12 04:53:26 -08:00