Tim Almdal
8d1790a0b4
* Add a moveTo unit test
...
* Pass the module::event(..., $data) by reference to the handlers
2008-12-05 04:56:33 +00:00
Tim Almdal
6ea063bc4c
Tweak some issues with the moveTo Processing
2008-12-04 21:33:25 +00:00
Tim Almdal
0f103b1c06
Moving albums around with a drag and drop interface seems to work and preserve the left right pointers.
...
* changed _lock and _unlock to protected methods lock and lock respectively
* added a moveTo method on the Item_Model
* Corrected the hole closure on delete.
* added moveTo on the ORM_MTPP class
* Changed the rearrange javascript to do moves with ajax
2008-12-04 20:05:58 +00:00
Bharat Mediratta
9ba9f7bf27
Change the startup code to only put installed modules on the autoload
...
path. This breaks a bunch of places where we had hardcoded
dependencies, so guard all of those cases. Restructure
module::available() a bit and the way that we do install/uninstall in
the scaffolding.
2008-12-04 07:44:28 +00:00
Bharat Mediratta
bae905a4cb
Improvements to access helper.
...
o Rename access::remove_group() to access::delete_group() for
consistency.
o Wrote more unit tests
o Tests found a bug in access::remove_item() .. yay!
2008-12-04 06:40:35 +00:00
Tim Almdal
1ae3ed7e3b
Get rid of the rearrange helper as the code could be inlined
2008-12-04 06:36:14 +00:00
Bharat Mediratta
4d76351017
Fix indentation
2008-12-04 05:54:48 +00:00
Bharat Mediratta
375e7c675e
Implement ORM_MPTT::delete() properly.
...
Inline ORM_MPTT::_grow() for now
Rewrite ORM_MPTT tests to be domain specific; they no longer use album/photo helpers.
2008-12-04 05:47:05 +00:00
Bharat Mediratta
89a346c1e1
Rename Directory_Helper_Test to Dir_Helper_Test
2008-12-04 05:45:00 +00:00
Bharat Mediratta
24cbff29cc
Replace grow_test and constrict_test with add_hierarchy_test and
...
delete_hierarchy_test.
Our tests will be more robust if we test the public API and not the
internal private functions. If we get to the point where we have to
test the private functions, we should probably move those functions
into their own separate class with a public API.
2008-12-04 05:15:21 +00:00
Tim Almdal
5c095cbd78
Add unit tests to test growing and contracting the left and right pointers
...
Added a delete method to ORM_MPTT that contracts the tree when an item is deleted
2008-12-04 01:12:44 +00:00
Tim Almdal
9ae6acdc0a
Before deleting an item, save the path to the image in the var directory as once the item is deleted, the $item->file_path() is no longer valid.
2008-12-04 00:14:52 +00:00
Bharat Mediratta
e8cf2a3e67
Fix internationalized string.
2008-12-03 23:32:29 +00:00
Bharat Mediratta
ccee9854c2
Rename file::unlink() to dir::unlink(). This creates an API that is
...
clearer about its actions, otherwise we may accidentally blow away an
entire hierarchy when we think we're deleting a single file (there's a
reason why rm won't let you delete dirs that aren't empty!)
Name it "dir" instead of "directory" because apparently "directory" is
already reserved.
Move the delete call out of Items_Controller and into the model. The
model is responsible for keeping state integrity, not the controller.
2008-12-03 23:31:10 +00:00
Tim Almdal
76196be483
Remove @todo
2008-12-03 22:48:23 +00:00
Tim Almdal
7bb4b6029d
Add a MY_file class that extends the file helper by creating an unlink method that deletes a file or an album directory.
...
Modify Items_Controller::_delete to call this new helper method when deleting an item
2008-12-03 22:39:57 +00:00
Bharat Mediratta
d8511f2fde
Implement two tests
2008-12-03 19:10:23 +00:00
Bharat Mediratta
c3478675cd
Fix a bug where we weren't actually deleting permissions (hooray for unit tests!)
2008-12-03 19:09:56 +00:00
Tim Almdal
27a9c14d27
If the the post and get arrays don't contain a _method parameter, then use the request::method() to determine the actual request method (i.e. delete doesn't show up in either places)
2008-12-03 17:33:18 +00:00
Bharat Mediratta
efc6270295
Test stubs
2008-12-03 17:17:59 +00:00
Bharat Mediratta
f114814c03
Move the form html into the controller
2008-12-03 05:59:39 +00:00
Bharat Mediratta
39499cdf2e
Add /welcome/form/add/photos to give you the add photo form.
2008-12-03 05:40:59 +00:00
Bharat Mediratta
e03bb0f7c3
Re-enable access_cache propagation now that we've patched the MySQL driver.
2008-12-03 04:28:14 +00:00
Bharat Mediratta
718ac67a02
get rid of a stray space that was breaking the File_Structure_Test
2008-12-03 04:17:02 +00:00
Bharat Mediratta
c1886aab88
Temporarily disable some code to get tests to pass.
2008-12-03 04:05:24 +00:00
Bharat Mediratta
37758d15de
Drop the right tables at uninstall time
2008-12-03 03:43:50 +00:00
Bharat Mediratta
db5bc20500
Fix a bad copy/pasted comment
2008-12-03 03:18:43 +00:00
Tim Almdal
2e42a5ea8c
Remove the variable from inside _()
2008-12-02 21:37:06 +00:00
Tim Almdal
3953dde2c6
The rearrange module will now add an album if you drag the "new album" onto the album tree. I haven't had a chance to figure out why the form does get any styling or why a textarea is no included as a list item.
2008-12-02 21:25:15 +00:00
Bharat Mediratta
ea11562e32
Oops, this was missing from the last fix.
2008-12-02 04:54:37 +00:00
Bharat Mediratta
ae4c828b06
Fix a problem in _update_access_cache() where if the intent is
...
default, we weren't properly propagating ALLOW where necessary.
2008-12-02 04:38:45 +00:00
Bharat Mediratta
52e63e7f75
Tighten up ul.permissions
2008-12-01 23:48:07 +00:00
Bharat Mediratta
ed2cb2a86d
Fix profiler settings in the scaffolding
2008-12-01 10:40:40 +00:00
Bharat Mediratta
2eed685883
style the permission tree a little tighter
2008-12-01 10:27:36 +00:00
Bharat Mediratta
5c303aa07b
Add access::reset() so that you can specify your intent to use the
...
parent's permissions.
Update scaffolding to demonstrate that it works.
2008-12-01 09:57:03 +00:00
Bharat Mediratta
88a70cbc04
Clean up styles a bit to make it more obvious what's going on. Show
...
edit permissions too to demonstrate that we're doing something
different for the different type of permissions.
2008-12-01 09:02:46 +00:00
Bharat Mediratta
e3d7877d79
Add @todos
2008-12-01 09:01:10 +00:00
Bharat Mediratta
91c4bda1ec
Prototype access control model. There's much left to do, but it's a
...
working implementation.
2008-12-01 08:50:00 +00:00
Bharat Mediratta
6b03b798f3
Move rearrange HTML generation into welcome.php so that we gracefully
...
handle the case where the DB is not installed yet.
2008-11-30 21:39:23 +00:00
Bharat Mediratta
4271f7702a
Add access model (not fully baked yet).
...
Update scaffolding to allow addition of just albums (helpful for testing permissions)
2008-11-29 22:47:15 +00:00
Tim Almdal
7ae004f76f
The gui part of rearranging albums and photos on the welcome page. Haven't finished the ajax back end to actually do the move, but thought i'd put the gui up so people can play
2008-11-29 20:02:30 +00:00
Tim Almdal
70de32ebb4
Insure that the page and offset refere to valid items
2008-11-29 17:08:42 +00:00
Tim Almdal
4c2d4abb1c
Remove debugging statements
2008-11-28 21:55:26 +00:00
Tim Almdal
6a76d6f747
Dynamically create the list of available modules. This permits new modules to be added without having to update the config.php file
2008-11-28 21:22:34 +00:00
Bharat Mediratta
8b6ed6c477
Create module::event() which runs Gallery events. It works by
...
convention. To respond to the "photo_created" event in the gmaps
module, you create modules/gmaps/helpers/gmaps_event.php containing
class gmaps_event which has function photo_created.
Renamed all events from gallery.foo.bar to foo_bar
Updated tag module to use new convention.
2008-11-28 19:37:01 +00:00
Bharat Mediratta
89c4dadec2
Rename module::get_list() to module::installed()
2008-11-28 18:39:18 +00:00
Bharat Mediratta
4d71975f37
Add credits theme callback, point the powered-by link at GMC
2008-11-28 09:46:29 +00:00
Bharat Mediratta
2c86723942
Add an easy way to add a bunch of servers from the server side
2008-11-28 05:45:35 +00:00
Tim Almdal
3fa12655dd
Correct parameter on gallery.album.created event firing
2008-11-28 04:26:18 +00:00
Bharat Mediratta
1239e38e45
Move the form drawing code back into form.html.php -- I'm going to
...
take a shot at fixing it up in the view file so that it's mostly HTML,
not mostly PHP. If that fails, I'll move it back into a helper.
2008-11-28 03:09:18 +00:00
