since only gallery.common.js is modified.
Now that I understand the problem and the fix, I'm not sure I can explain why it
*used* to work with older jQuery...
- removed fake attr settings (possible compatibility issue with newer jQuery)
- replaced with extra class
- fixed formatting
- still doesn't work: addClass works, but hasClass always returns false when function runs again
json2.js -> json2-min.js ; jquery.localScroll.js -> jquery.localscroll.js
While this is irrelevant for Wind, changing the filenames back to what we used
to have ensures that we don't break contributed themes.
--HG--
rename : lib/jquery.localScroll.js => lib/jquery.localscroll.js
- jquery.js 1.9.1 (2013/02/04)
- jquery.cookie.js 1.3.1 (2013/01/30)
- jquery.scrollTo.js 1.4.5 (2012/12/14)
- jquery.localScroll.js 1.2.8b (2012/09/21)
Note: jquery.jeditable.js and jquery.MultiFile.js still removed, as they are no longer used.
- jQuery 1.90
- jQuery UI 1.10
- Superfish 1.5.1 (minus all plugins)
- jQuery Form 3.26.0-2013.01.28
Deleted all other jQuery plugins for now.
- Reworked autocomplete to use the latest jQuery code.
- Deleted references to $.browser.msie, no longer supported
- Basic CSS support for autocomplete - lots more work needed there
against UTF-7, and create a $.gallery_autocomplete variant of jQuery's
autocomplete that expects the first line to be a <meta> tag and
discards it. More complete fix for #1871.
So lets fix that up. But first undo the reverts:
93d1a8103e "Revert 'Move the contents of lib/gallery.common.css into themes/wind/css/screen.php and themes/admin_wind/css/screen.php. Most themers seem to copy the contents into their theme's screen.css anyway.'"
f14290f34f "Revert 'Clean up white space'"
ff8ee5bdfc "Revert 'Add some whitespace.'"
1) Prevent it from "bouncing" which happens when we queue up a lot of
open and close events. Stop any running animations before starting
new ones. This fixes#1340.
2) Prevent a bug that's not really visible to the user where we wind
up re-initializing a context menu over and over which results in us
binding tons of hover events. I don't think this causes any serious
damage, but it's probably not good.
The photo view page caches the dimensions of the full size and then
renders it in Javascript. But after rotation, those dimensions are no
longer valid. Create a new function on the items controller that
returns the appropriate dimensions, then add a hook on
$.gallery_replace_image and implement the hook on the photo view page
to have it make an async call to get the new dimensions.
Fixes ticket #1317
by the following rules:
1) An initial dialog or panel load can take either HTML or JSON, but
the mime type must accurately reflect its payload.
2) dialog form submits can handle a pure HTML response, but the mime
type must also be correct. This properly resolves the problem
where the reauth code gets a JSON response first from the reauth
code, and then an HTML response when you reauth and continue on to
a given form -- try it out with Admin > Settings > Advanced.
3) All JSON replies must set the mime type correctly. The json::reply
convenience function does this for us.
4) By default, any HTML content sent back in the JSON response should be
in the "html" field, no longer the "form" field.
The combination of these allows us to stop doing boilerplate code like
this in our controllers:
// Print our view, JSON encoded
json::reply(array("form" => (string) $view));
instead, controllers can just return HTML, eg:
// Print our view
print $view;
That's much more intuitive for developers.
