Commit Graph

3123 Commits

Author SHA1 Message Date
Bharat Mediratta
bb981bb7b6 Merge branch 'master' of git@github.com:/gallery/gallery3 2009-07-17 16:58:15 -07:00
Bharat Mediratta
e7c6861507 Don't send back the gzipped version if we're using
zlib.output_compression in PHP, since that means that the stream is
already compressed.  Fixes ticket 555.
2009-07-17 16:58:00 -07:00
Bharat Mediratta
cd907c2b42 Change model_cache::clear() API to clear everything. This prevents
old ORM relationships from hanging around, which was causing problems
when doing MPTT manipulations (resulting in incorrect permission
propagation-- very bad!)
2009-07-17 12:51:27 -07:00
Bharat Mediratta
8a6556b30b Fix a bug where moved items don't properly inherit permissions from
their new target.  After each move, recalculate the permissions for
the new parent's hierarchy.

Fixes ticket #552
2009-07-17 08:14:08 -07:00
Bharat Mediratta
0f766b149d Second non-trivial change to the event code. We now publish model
related events from within the model handling code.  The only
exception to this currently is item_created which is challenging
because we have to save the item using ORM_MPTT::add_to_parent()
before the object itself is fully set up.  When we get that down to
one call to save() we can publish that event from within the model
also.
2009-07-16 12:31:40 -07:00
Bharat Mediratta
43324fd12a Update golden file to match recent changes in event code. 2009-07-16 12:29:01 -07:00
Bharat Mediratta
5b3b675b6d Non-trivial changes to the event handling code:
1) The item_updated event no longer takes the old and new items.
   Instead we overload ORM to track the original data and make
   that available via the item.  This will allow us to move event
   publishing down into the API methods which in turn will give us
   more stability since we won't require each controller to remember
   to do it.

2) ORM class now tracks the original values.  It doesn't track
   the original relationships (no need for that, yet)

3) Added new events:
     item_deleted
     group_deleted
     user_deleted
2009-07-16 11:19:34 -07:00
Bharat Mediratta
2864aceb81 Add missing ) dropped in 8f9a943f. 2009-07-16 10:58:42 -07:00
Bharat Mediratta
ec634c91a6 Stripped the trailing ?> without changing whitespace. 2009-07-16 10:45:06 -07:00
Bharat Mediratta
2cd0d6389c Revert "Remove trailing ?>."
This reverts commit a333e01bd1.
2009-07-16 10:44:23 -07:00
Bharat Mediratta
a333e01bd1 Remove trailing ?>. 2009-07-16 10:32:18 -07:00
Bharat Mediratta
d9f3e0bc0e Remove spurious blank line at the top of the file introduced in 09c9b1a755 2009-07-16 10:27:18 -07:00
Bharat Mediratta
b46998e392 Update Xss_Security_Test to know about p::purify() and checkpoint the
golden file.
2009-07-16 10:24:10 -07:00
Bharat Mediratta
49f445ce15 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-16 10:20:46 -07:00
Kevin Nehls
85b0f58029 move fix for backslashes on windows outside of loop per bharat's suggestion
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-07-16 21:36:51 +08:00
Kevin Nehls
5cb2f42628 Fix backslashes in relative URLs of combined css files.
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-07-16 21:36:50 +08:00
Bharat Mediratta
39fa93eec7 Simpler solution for #545. Just don't show the form if the storage dir isn't set up yet 2009-07-15 21:06:42 -07:00
Bharat Mediratta
9b69dc8237 Revert "Fix for ticket #545."
This reverts commit d192f2f1bc.
2009-07-15 20:58:22 -07:00
Bharat Mediratta
3349525640 Revert "Fix for ticket #544."
This reverts commit f6973431b7.
2009-07-15 20:58:20 -07:00
Bharat Mediratta
1026054147 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-15 20:51:38 -07:00
Bharat Mediratta
c4fce2cc68 Remove a completed @todo. 2009-07-15 20:32:53 -07:00
Tim Almdal
f6973431b7 Fix for ticket #544.
* Separate the portion of get_db_info.html.php that displays the status
of the var directory into a separate view var_dir_status.html.php
* Change the processing to always generate the database information request
screen unless there is an environment error, the var directory is not writable
and the install was successful

Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-15 21:56:15 +08:00
Tim Almdal
d192f2f1bc Fix for ticket #545.
Changed get_db_info.html.php to not display the database information
request form until the var directory is successfully tested as
writable.  This prevents users from thinking they can enter the
database information prior to successfully accessing the var
directory.

Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-15 20:42:58 +08:00
Tim Almdal
2cba5d9395 Fix 542 by changing the wording from you to your, thanks Floridave
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-15 07:58:30 +08:00
Bharat Mediratta
7de339a676 Remove extra debug statements. 2009-07-14 16:10:37 -07:00
Bharat Mediratta
4720e45641 Don't use "else" clauses in upgrade() -- it prevents multiple version bumps at once. 2009-07-14 12:55:03 -07:00
Bharat Mediratta
c4a3093011 3rd attempt to fix localization messages. Last time around I didn't
dig deep enough, but now we form the complete message using t() style
semantics to replace % placeholders with __ style JS placeholders.
Also, stop appending the (completed) text to existing messages.. roll
it together.
2009-07-14 12:36:57 -07:00
Bharat Mediratta
768a1485e1 Remove references to missing organize_edit_drawer.png 2009-07-14 12:07:29 -07:00
Bharat Mediratta
8cfb067709 Revert "Remove the reference to organize.css is it is no longer used and is"
This reverts commit 31ffb82382.
2009-07-14 12:03:31 -07:00
Bharat Mediratta
c3f93957d7 Move the gallery version out of a module variable and into a constant
in the gallery helper.  This will let us bump the version without
having to bump the gallery module number.
2009-07-14 10:56:10 -07:00
Tim Almdal
cc05d279ea Update HTMLPurifier to version 4.4.0 2009-07-14 07:55:30 -07:00
Tim Almdal
94e33c821f Removed unnecessary contructor from the HTMLPurifier.php library class 2009-07-14 06:42:50 -07:00
Tim Almdal
be635df6d9 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-14 06:37:53 -07:00
Bharat Mediratta
2a40f48d65 Add /opt/bin as a binary path. 2009-07-14 06:36:48 -07:00
Bharat Mediratta
e2a9a1d284 Add quotes around all values that contain spaces in them, and add a
test to make sure that we continue to do so.

This makes sure that we don't have problems with 5.3 which treats the
literal "on" as a boolean.
2009-07-13 10:36:55 -07:00
Tim Almdal
021e6eccd0 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-13 07:11:02 -07:00
Bharat Mediratta
a944bf4259 Avoid using the bare word "on" in a value; it breaks PHP 5.3.
Fixes ticket #540.
2009-07-13 06:43:44 -07:00
Chad Kieffer
027f6b5221 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-12 22:54:04 -06:00
Chad Kieffer
ff0b66a1a4 Put owner's url into user link. Seems better than displaying email until we have something like a user profile page. 2009-07-12 22:53:47 -06:00
Chad Kieffer
50cd41655a Minor style tweaks. 2009-07-12 22:41:57 -06:00
Bharat Mediratta
9588e8604d Use %27 instead of &#039; (the latter is the wrong form of escaping for urls). 2009-07-12 20:08:02 -07:00
Tim Almdal
75be4ab2e6 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-12 12:37:01 -07:00
Tim Almdal
aa0209d6d3 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-11 23:11:55 -07:00
Shai Ben-Naphtali
30346ec842 Fixed indentation of commit 2760e119bbfc3e2d436c404de194dbeea738a735
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-12 14:11:15 +08:00
Shai Ben-Naphtali
245f4d39a7 This fixes ticket #513
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-12 14:11:14 +08:00
Shai Ben-Naphtali
1d7ed9e76b Fixed indentation of commit 2760e119bbfc3e2d436c404de194dbeea738a735
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-12 13:23:52 +08:00
Shai Ben-Naphtali
b0aab73364 This fixes ticket #513
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-07-12 13:23:51 +08:00
Chad Kieffer
872b5eed46 Merge branch 'master' of git@github.com:gallery/gallery3 2009-07-11 23:17:30 -06:00
Chad Kieffer
8bfcf09b4c Styled thumb menu, still needs script to set up interraction. 2009-07-11 23:14:26 -06:00
Bharat Mediratta
ac181d6227 Whitespace fixes. 2009-07-11 20:12:32 -07:00