Commit Graph

202 Commits

Author SHA1 Message Date
Tim Almdal
b8c034cb37 Reverted r18930. This is because in the media_rss module we don't generate a media rss feed link if we don't have an item. So if we go an throw a slideshow on there, it doesn't do anything because piclens can't find the feed to produce a slideshow.
You can put it back if you really want to.  It will probably make more sense when we have an alternative slide show taht can work with the children collection.
2008-11-27 22:21:16 +00:00
Bharat Mediratta
bb388af21a Add tag_top() button 2008-11-27 22:08:17 +00:00
Bharat Mediratta
8d4bd0c814 Update tests to reflect the fact that the admin group is gone.
Fix a bug in user::create(), found by the unit tests (hooray)!
2008-11-27 19:46:39 +00:00
Tim Almdal
bac4ff2046 1) Create a Theme_View class that combines the functionality of the Theme class with the View class.
2) Only define the form.html.php::DrawForm method once if there are multiple forms on the page (i.e. comments and add tags)
2008-11-27 16:19:07 +00:00
Bharat Mediratta
e183901dc3 Give the admin user actual admin privileges 2008-11-27 11:43:11 +00:00
Bharat Mediratta
34a286ae90 Add navigation_top() and navigation_bottom() insertion points
Move "My Gallery" navigation tab into the user module and only show it
if you're logged in
2008-11-27 11:33:45 +00:00
Bharat Mediratta
d909fc1070 Make tags look a little better. 2008-11-27 10:25:50 +00:00
Bharat Mediratta
c95c17b133 Centralize logging around installing/uninstalling modules. 2008-11-27 09:45:26 +00:00
Bharat Mediratta
3992dad486 Move form generation off into tag::get_add_form(). We can't use a controller to generate the form (it's incompatible with our REST model where controllers print stuff) 2008-11-27 06:25:21 +00:00
Bharat Mediratta
09b27ecf98 Remove stray trailing blank lines 2008-11-27 06:24:07 +00:00
Tim Almdal
27e64f1dc6 Move javascript from default theme to appropriate modules 2008-11-27 06:14:32 +00:00
Bharat Mediratta
d16790de0c Get rid of the placeholder "add tags here..." text, and clear the form
on submit.
2008-11-27 05:45:17 +00:00
Bharat Mediratta
72d16756b1 Refactor cloud generation into a helper so that we can call it from
Tags_Controller::_index().  This enables our Ajax code to reload the
tags block after we submit a new tag, so update the JS to do that
properly.
2008-11-27 05:37:20 +00:00
Bharat Mediratta
5447b83210 Clean up REST pattern in tags:
1) Generate the form in Tags_Controller::_form_add()
2) Process the form submit in Tags_Controller::_create()
3) Create the tag properly

This required me to limit our scope to adding one tag at a time, which
I think is fine if we're doing Ajax style tag addition.
2008-11-27 05:00:50 +00:00
Bharat Mediratta
480abae401 Fix indentation. 2008-11-27 04:31:12 +00:00
Tim Almdal
b4b72b284b We are now submitting the ajax tag add form to the server correctly and rehooking the ajaxForm 2008-11-27 01:48:01 +00:00
Tim Almdal
d881c91e0c Trying to add tags, but it doesn't work yet. For some reason that i can't figure out, the form never validates and I never get into the true branch of the if. I'm taking a break for awhile. 2008-11-27 00:26:04 +00:00
Bharat Mediratta
91b1c4cf39 Skip the tags block if there're no tags 2008-11-26 23:06:35 +00:00
Bharat Mediratta
974f9f7788 Add a new "tag" page type.
Create the concept of "page types" which let us specify the kind of
page that we're rendering in high level terms.  Currently there are
three page types: album, photo and tag.

The tag page type uses slightly different variables.  It has a $tag
but no $item.  Adjust all sidebar_block() functions to avoid printing
stuff that's dependent on the item if there is no item.

Simplify the tag code to stop trying to fake an item.

Update the theme slightly to use $item and $tag where appropriate
(notably, for making the <title> element).
2008-11-26 21:50:45 +00:00
Bharat Mediratta
9f37aaa1c2 Move Tag_Controller -> Tags_Controller to fit our REST pattern. 2008-11-26 20:40:04 +00:00
Bharat Mediratta
aa19a79e06 Clean up unnecessary comments, remove stray references to Comment_Controller 2008-11-26 20:33:06 +00:00
Tim Almdal
b3be74166c Breadcrumbs now look right for dynamic tag albums 2008-11-26 17:08:57 +00:00
Tim Almdal
e77fd34175 Duh, i have the count in the tag model... why do i need to do a query to count?
Added text to the description instead of return an empty string
2008-11-26 17:02:27 +00:00
Tim Almdal
af9a27216d Modify the tag model to behave like a virtual album. There are two outstanding issues that i still have to resolve. The first being there is no thumbnail for the root directory, so it doesn't look quite right. And secondly, the bread crumb shows the dynamic tag album as hot having a parent. I wanted it to be the root directory, but i will overcome :-) 2008-11-26 16:48:00 +00:00
Tim Almdal
dfd0281512 Remove test since the method to be tested was removed 2008-11-26 15:18:09 +00:00
Bharat Mediratta
39b6e84a57 Change sort_by_name to case insensitive sort. 2008-11-26 10:48:00 +00:00
Bharat Mediratta
98ee16ca49 Simplify tags code some more:
1) change buckets to be 1-7 not 0-6.. zero-based indicies don't make sense in the
   real world and are liable to confuse themers.

2) Change tag API to popular_tags($count) which just returns the popular tags.  Let
   the block code massage it into the right format for the view.

3) Move alphasort into the block code, simplify it and rename it to sort_by_name so
   that it's more descriptive

4) Do the bucketing in the view; this allows the themer to override it and create their
   own bucketing algorithm to go with the theme's CSS.

5) Don't create any temporary objects.
2008-11-26 10:27:13 +00:00
Bharat Mediratta
e1f39ac13f Re-enable code to drop view columns from the items table when deleting groups. 2008-11-26 09:38:39 +00:00
Bharat Mediratta
427dc7a0d1 Ignore errors from dropping view columns from the items table. 2008-11-26 09:34:31 +00:00
Tim Almdal
de56a33c9c Clean tag creation 2008-11-26 06:37:12 +00:00
Bharat Mediratta
18ce4a4c1f Actually call uninstall! 2008-11-26 05:43:43 +00:00
Bharat Mediratta
e31456af47 Remove stray 'filter' instances 2008-11-26 05:20:47 +00:00
Tim Almdal
03bf3a6af2 Remove the more or less links 2008-11-26 05:08:43 +00:00
Bharat Mediratta
9c60566197 Add support for marking users as "admin" 2008-11-26 04:54:43 +00:00
Bharat Mediratta
226df2a8f8 Add support in the scaffolding for adding users to groups, adding and
removing users and groups.
2008-11-26 04:45:43 +00:00
Bharat Mediratta
5ccb050413 group::create() and group::delete() now manage the view_## columns in
the items table.

Convert installer over to using new creation API.
2008-11-26 04:13:57 +00:00
Bharat Mediratta
5fce343ca4 Create user/group create/delete functions and have the scaffolding use them. 2008-11-26 03:34:39 +00:00
Tim Almdal
1ea0382f53 Moving right along on tags. Now the threshold for which tags can be changed. The default is to show all the tags (i.e. count >= the minimum frequency) by clicking on the "See Less" link, the tag cloud will not show the minimum frequency, so the number of tags shown is smaller.
The "See More" link works the opposite way.
2008-11-25 22:38:11 +00:00
Tim Almdal
e9e589e5eb Display tag block using data from the database 2008-11-25 18:54:04 +00:00
Tim Almdal
d554adc484 1) Changed how the test tags are generated to be able to create a better distribution
2) Added a new helper function "load_buckets" assign the class suffix to each tag
3) Created a unit test to test the load_buckets function
2008-11-25 18:14:52 +00:00
Tim Almdal
53f45b3079 Correct call to undefined uninstall_modules method. Should have been _uninstall_modules 2008-11-25 18:00:33 +00:00
Tim Almdal
38a260b1d7 Rename get_absolute_url to abs_current 2008-11-25 16:50:29 +00:00
Tim Almdal
102f0f566b Normalize atom url generation 2008-11-25 15:54:45 +00:00
Tim Almdal
2c20fed373 Dynamically locate modules to install for test 2008-11-25 15:01:17 +00:00
Tim Almdal
b2af9ed470 Modify the test controller to call tag_installer::install and uninstall
Created the first tag unit test
2008-11-25 07:05:03 +00:00
Tim Almdal
52206148a8 Fix tests 2008-11-25 06:41:11 +00:00
Bharat Mediratta
7ec579cede Simplify the API. We don't have a need to add multiple tags to
multiple items, so don't create a confusing API where we don't need
one.  The caller can just as easily loop over items and tags.

Use ORM::has() instead of manually looping over items, which would be
wildly inefficient on large installs.  Document that we're calling
ORM::has() a second time just so that we can update the count
correctly.
2008-11-25 04:23:45 +00:00
Bharat Mediratta
c725a0f16e Move comment listing into the comment module 2008-11-25 02:14:04 +00:00
Bharat Mediratta
1ad1846774 Oops, fix a typo causing us to treat an array like a string. 2008-11-25 01:58:19 +00:00
Bharat Mediratta
2c7893b48e Fix a bug in thumbnail_info where we were printing out the data instead of returning it 2008-11-25 01:35:42 +00:00