Commit Graph
4076 Commits
Author SHA1 Message Date
Bharat Mediratta b8124efbd8 Refactor generic error handling code. It still shows a pretty lame error message.
Add a comment explaining the TreeLoader preload hack.
2011-01-05 20:37:14 -08:00
Bharat Mediratta 28760daaef Improve IE grid compatibility by forcing a regular width/height for
thumbnails and using float: left.
2011-01-05 20:11:32 -08:00
Bharat Mediratta 372905bd13 Support moving an item before or after the target. 2011-01-05 02:00:40 -08:00
Bharat Mediratta c590f881eb single -> double quotes. 2011-01-05 01:25:17 -08:00
Bharat Mediratta 3a11e0d825 This was left out of 31652eae44. 2011-01-04 22:21:02 -08:00
Bharat Mediratta bd5e71ba6a More drag/drop tweaks.
- Fix a bug in the prior commit where we could no longer drag/drop in
  the thumb_data_view.
- Change the CSS class when dropping items in the tree panel to be a
  check box, not a plus symbol.
2011-01-04 22:20:24 -08:00
Bharat Mediratta 31652eae44 Drag/drop improvements:
- Restrict drag and drop to albums where the user has edit permissions.
- Use the existing TreeDropZone instead of making a new DropZone to take
  advantage of TreeDropZone features.
- Properly use dropConfig in TreePanel.
2011-01-04 22:00:30 -08:00
Bharat Mediratta b692d55ad4 Convert "\w-" in regexes to "\w\-" for compatibility with some versions
of Chrome 10.x.

references:
 http://www.sencha.com/forum/showthread.php?117836-3.3.1-Invalid-regular-expression
 http://code.google.com/p/v8/source/detail?r=5911
 http://trac.webkit.org/changeset/73594
 http://codereview.chromium.org/5703001/

This change has been reverted in Chrome, and the regex was fixed in ExtJS so
this patch should be short lived.
2011-01-04 11:50:25 -08:00
Bharat Mediratta caf454f326 Add missing images 2011-01-04 00:15:56 -08:00
Bharat Mediratta 51d66df192 Switch to using Ext.Element.mask for a custom busy message that looks
a little cleaner.
2011-01-04 00:15:05 -08:00
Bharat Mediratta 79f27ea1ec Remove a bunch of trailing commas from arrays to make IE happy. 2011-01-03 22:59:07 -08:00
Bharat Mediratta 3928058ba5 Fix a few small visual issues:
- Let the thumb data view scroll on drag/drop
- Switch the album panel to be a FitLayout and use a title and
  bbar instead of nested panels.
- Set the tree_panel width to be 200px to start.
2011-01-03 22:31:20 -08:00
Bharat Mediratta 0cd1ccfdc2 missing image 2011-01-03 21:45:37 -08:00
Bharat Mediratta 90852b1929 whitespace fix. 2011-01-03 21:23:21 -08:00
Bharat Mediratta 8e21dda195 Complete rewrite of the organize module in Javascript using the Sencha
JavaScript library.  It's got all the functionality from the Flash
version except it doesn't support creating new albums or uploading
photos.

Only tested in Chrome 10.0.x so far.
2011-01-03 20:24:21 -08:00
Bharat Mediratta 4a88210825 Follow on to cfaa62370e to fix indentation.
Fixes #1569.
2011-01-03 11:41:25 -08:00
Joe7andBharat Mediratta f364e8a96b Using array support introduced in 8295201adf948ea35f21f75801b7a8bf36c27569 2011-01-03 11:38:21 -08:00
Joe7andBharat Mediratta cfaa62370e Reimplemented Kohana 2.3's View::set_global() with array support.
Allows for cleaner code and fewer function calls.
2011-01-03 11:38:13 -08:00
Joe7andBharat Mediratta e6a5f39b91 case fix 2011-01-03 11:10:31 -08:00
Joe7andBharat Mediratta b26eff7f23 Bugfix: input validation validates description up to length of 65535 chars, but DB trimmed data over 2048 chars. Converting column into TEXT type.
Note: The effective maximum length of a VARCHAR in MySQL 5.0.3 and later is subject to the maximum row size (65,535 bytes, which is shared among all columns) and the character set used.
In contrast to CHAR, VARCHAR values are stored as a one-byte or two-byte length prefix plus data. The length prefix indicates the number of bytes in the value. A column uses one length byte if values require no more than 255 bytes, two length bytes if values may require more than 255 bytes.
2011-01-03 11:08:21 -08:00
Joe7andBharat Mediratta 7ce902d373 Removed accidental whitespace 2011-01-03 11:01:09 -08:00
Joe7andBharat Mediratta 336632fea0 Keep view counters of all item types accurate
Added common increment_view_count() func in item model for reuse
2011-01-03 11:01:02 -08:00
Bharat Mediratta a8b0254e4a Improve the solution for #1545 by sorting the settings menu properly
to be naturally ordered and case insensitive.
2010-12-29 17:31:28 -08:00
Bharat Mediratta 3e117fc2b4 Remove a stray comma at the end of a JSON array which was breakig IE. Fixes #1561. 2010-12-29 11:33:08 -08:00
Joe7andBharat Mediratta 17700b805f Coding style fixes: identation on line 48+removed trailing whitespaces, added spaces around =s 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 869bba5e13 Truncating table first againt collides when converting INDEX into Unique 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 440597356d Added changes to installer and upgrader scripts to support INSERT ON DUPLICATE KEY UPDATE SYNTAX in cache lib 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 66fd8c7518 Using ON DUPLICATE KEY UPDATE instead of SELECT+UPDATE/INSERT style method (that does 2 trips to Database server and is less optimal).
exists() method is not needed anymore thus got removed
2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta fda9250796 Added limit on select as for the outcome it doesn't matter if there are 20 rows or just 1. Is sufficient to return straight after reading 1 row. 2010-12-28 23:14:04 -08:00
Bharat Mediratta b42fcb9cda Use db::expr instead of "new Database_Expression". Resolves #1560. 2010-12-28 23:10:05 -08:00
Bharat Mediratta 9f3c6e4bee Update test to match change in Item_Model::as_restful_array made in
7e31f97b4c for #1536.
2010-12-28 22:00:25 -08:00
Bharat Mediratta 5d37d529b0 Update golden file to reflect the change in
c989981041 for #1520.
2010-12-28 21:56:31 -08:00
Bharat Mediratta d0e78fc5cf Fix capitalization to be sentence case. 2010-12-26 23:06:09 -08:00
dmolavi 2d4d613318 Correct image block plurality, fixes 1506 2010-12-25 16:09:42 -05:00
Bharat Mediratta 11df9f204f Added Croatian as hr_HR. Fixes #1514. 2010-12-24 01:10:17 -08:00
Bharat Mediratta b5ba61fc53 Create a way for controllers to exempty themselves from maintenance
mode and private gallery mode by setting the following constants in
the controller to true.

  ALLOW_MAINTENANCE_MODE
  ALLOW_PRIVATE_GALLERY

Fixes #1411 and the subsequent refactoring fixes #1551 as well.
2010-12-23 23:34:04 -08:00
Bharat Mediratta 2b83918efd Fix PHPDoc for composite(). 2010-12-23 23:16:30 -08:00
Bharat Mediratta 032e6fde5f Change MY_url::parse_url to use item::find_by_relative_url. 2010-12-21 20:47:14 -08:00
Bharat Mediratta 98fd1e9957 Implement item::find_by_relative_url with tests. 2010-12-21 20:47:07 -08:00
Bharat Mediratta c5ede5881b Updated to use the new item::find_by_path() API. 2010-12-21 19:36:23 -08:00
Bharat Mediratta d9299f3b3f Change item::find_by_path() to check the relative_path_cache first,
and only fall back the name/level comparison if there's no cached
entry.  Update tests accordingly.
2010-12-21 19:33:47 -08:00
Bharat Mediratta 2a08cbf76d Return an empty Item_Model when item::find_by_path fails 2010-12-21 16:58:54 -08:00
Bharat Mediratta f493130e59 Tighten up item::find_by_path slightly. Augment the tests to cover
special characters in the file name ("+" is an edge case differentiator
between rawurlencode and urlencode).
2010-12-21 16:55:01 -08:00
Bharat Mediratta c7096cc9eb Fix assertion order to be (expected,actual)
Change strinct concatenation to be variable interpolation to tighten it up.
2010-12-21 16:32:02 -08:00
Kriss AndstenandBharat Mediratta addd384bbd Minor changes to satisfy the G3 code standards. 2010-12-22 08:22:25 +08:00
Kriss AndstenandBharat Mediratta 48640005a4 Packaging + tests of Bharat's find_by_path routine. 2010-12-22 08:22:25 +08:00
Bharat Mediratta 612ddd7050 Warn admins after login if their PHP install has the
session.use_trans_sid feature enabled, since this will cause random
logouts.  Partial fix for #1316.
2010-12-18 11:55:04 -08:00
Bharat Mediratta dbb9b8b1c8 Sort the Admin > Settings menu instead of relying on module activation order.
Requires making Menu::get() return a reference.  Fixes #1545.
2010-12-17 22:19:46 -08:00
Bharat Mediratta e60edcdeba Include the root in the tree output. 2010-12-17 17:30:00 -08:00
Bharat Mediratta b6c202d572 Swap the order of the CSS and JS for performance. Fixes #1540. 2010-12-16 22:18:04 -08:00