in my last refactor):
1) Actually combine the JS (I was only combining the CSS)
2) Add line breaks between the files and comment them so that we can
find a specific file inside the blob.
3) Add an HTML comment to help developers figure out why they can't
find their CSS/JS.
doesn't fix the problem that we need to support multiple media types
(the original code had superfish using just "screen", and some other
deviations).
There's no code yet to support multiple media types, but it would not
be too difficult to create buckets based on media.
1) Create public javascript() and css() functions and turn __call()
into a private function to protect us against having some random
type show up in there. Otherwise anything you put in the 2nd
argument gets emitted in the header which is a security hole.
2) Fix a bug ("$key = $key[0]") which was breaking functionality.
Eliminate the hex check, it's not really necessary in the majority
case and doesn't hurt us in edge cases.
3) Convert some empty() calls to !, no need for a function call there.
4) Add phpDoc.
1) CSS files are added to the combined version by use of $theme->css() or $theme->css_theme() methods
2) url references in the css are converted to full paths as opposed to relative
3) @import statements in the css are resolved as well.
4) need to move the [if IE] statements into the css files so the will be honored in the browser. currently the ie fix css are always included.
Gallery_View base class from Theme_View and Admin_View.
1) Move all the theme specific jquery stuff from gallery_theme::head()
and admin_head() into the theme files. Use $theme->script() as
appropriate.
2) Get rid of the extra boolean on $theme->url() that we were using so
that we could call $theme->script($theme->url(...)) -- add
$theme->theme_script() instead (poorly named, but still clearer than
what we had before)
3) Fix the bug that combined scripts didn't work at all in the admin
theme.
4) Get rid of $theme->display() in favor of new View(...)
1) Drop the *_modified key, we don't really need it. The modification date is not
relevant to our browser caching strategy.
2) Fix multiple issues with the Expires header and just hardcode it to the biggest
possibly value for code clarity.
3) print the $content out directly instead of using fwrite
4) Minor cleanups in the installer.
1) Eliminate digibug_album.html
2) Get rid of the $(document).ready() in digibug.js and rename popUp() to
digibug_popup() then just make direct calls to digibug_popup() in the
menu urls.
1) Simplify the admin settings page to what most of our users
want. Eliminate basic_ and default_ ids. We just have company_id
and default_id. Advanced users can use advanced settings for now.
2) Fix security in print_photos (didn't get it right in my last commit)
3) Use the regular thumb and full urls if the images are publicly
available to reduce load on the proxy.
4) Simplify proxy expiration code.
5) Eliminate all specialized styles from the admin theme.
Bharat Mediratta
Andy Staudacher
Tim Almdal
jhilden
Chad Kieffer