Commit Graph
3812 Commits
Author SHA1 Message Date
Bharat Mediratta b562751fdb Don't expose members of an item that are not viewable by the end user.
This leaks item ids, but no other information about the item.  Fixes
ticket #1292.
2010-08-14 15:45:16 -07:00
Bharat Mediratta 50e3230d79 Add a key on access_caches.item_id. Without this, the Fix task query
to find missing access_caches is very slow.  Bump Gallery module to v34.
2010-08-14 15:10:07 -07:00
Bharat Mediratta d9f8c8a295 Rebuild access_caches rows if they're missing, as necessary. Fixes ticket #1289. 2010-08-14 14:56:28 -07:00
Bharat Mediratta 524554c65b Send back the content length of files. This fixes streaming movies. Fixes ticket #974. 2010-08-11 21:02:57 -07:00
Bharat Mediratta a94bb19798 Force the charset to UTF-8 when viewing the HTML form of REST output. 2010-08-09 23:01:47 -07:00
Bharat Mediratta 9de371e1b3 Use the data_rest implementation to proxy access to raw
thumb/resize/full data files when permissions are in play.
2010-08-09 22:55:58 -07:00
Bharat Mediratta 3c18762fda Change the way that this works. Now instead of sending back the image
metadata and the data itself JSON encoded, we just send back the raw
data with the right Content-Type.  This, combined with code in
Item_Model::as_restful_array() that swaps in /rest/data urls as
appropriate, means that the RESTful payload has consistent urls when
permissions are in play.
2010-08-09 22:54:57 -07:00
Bharat Mediratta f0d8aef0ea "Content-type" --> "Content-Type". 2010-08-09 22:51:14 -07:00
Bharat Mediratta d5dbd1677f "Server Add" -> "Server add"
(Sentence capitalization)
2010-08-09 21:22:54 -07:00
Bharat Mediratta 0ff81c7ded The root album's edit form doesn't have a name field, so don't count
on it being there in update().  Fixes ticket #1281.
2010-08-09 15:18:25 -07:00
Bharat Mediratta b6a5014047 Fix a pagination bug. Fixes ticket #1280. 2010-08-09 00:29:28 -07:00
Bharat Mediratta 541a084cc1 "REST api" --> "REST API". 2010-08-08 21:51:26 -07:00
Bharat Mediratta 0014745d4a Add a button to the user profile page to let you reset your REST API
key.  This is useful if you think it's been compromised in some way.
Fixes ticket #1226.
2010-08-08 21:49:30 -07:00
Bharat Mediratta 639d31a2c1 If the imported item from Gallery 2 has a preferred derivative with a
rotation, then rotate the imported image accordingly.  Fixes ticket #1274..
2010-08-08 21:17:16 -07:00
Tim Almdal 58bf479f4c Merge branch 'master' of git@github.com:gallery/gallery3 2010-08-08 17:29:29 -07:00
Tim Almdal 1ad1f9517f Fix for ticket #1279. In admin themes sanitize the theme name before checking that theme.info exists. 2010-08-08 17:29:22 -07:00
Bharat Mediratta acb1faaa59 Cache the group ids for a day to trade off performance for security updates.
Fixes ticket #1227.
2010-08-08 17:25:31 -07:00
Bharat Mediratta 6a8c1f5e85 whitespace fix. 2010-08-08 17:19:51 -07:00
Bharat Mediratta c3ad4b5374 Whitespace fix 2010-08-08 17:14:09 -07:00
Bharat Mediratta e85b345eda Visually separate the G2 comment's subject and body when we blend them
into the G3 comment body.  Fixes ticket #1269.
2010-08-08 17:10:00 -07:00
Bharat Mediratta bd541342b9 Add gallery stats in addition to platform stats. 2010-08-08 17:07:13 -07:00
Bharat Mediratta 2dda8e22a7 Use the gallery helper date/time functions wherever we format date
time for the browser.  Fixes ticket #1278.
2010-08-08 16:54:31 -07:00
Bharat Mediratta cdb6306d7e Backdate the created/updated dates for imported comments. Fixes ticket #1215. 2010-08-08 16:50:02 -07:00
Bharat Mediratta 8da37d595c Verified. 2010-08-08 15:25:21 -07:00
Bharat Mediratta e5a1da71ed Convert tabs to spaces to fix File_Structure_Test. 2010-08-08 15:05:55 -07:00
Bharat Mediratta f5b7e207c8 Verified. 2010-08-08 15:02:58 -07:00
Bharat Mediratta d6f5a8a8d1 Add JSONP support. You must specify &output=jsonp?callback=<js_function>
Fixes ticket #1205.
2010-08-08 15:02:24 -07:00
Bharat Mediratta 9b5e058dd3 We can always send back the header because Kohana buffers output. 2010-08-08 15:01:38 -07:00
Bharat Mediratta ab2e2d2d77 Add the $max_level param to all calls to _sanitize_for_dump() 2010-08-08 15:00:23 -07:00
Bharat Mediratta de4d858dc2 Add in the missing 'error' count. 2010-08-08 14:56:28 -07:00
Bharat Mediratta 371a2ff7d2 Adjust the vertical placement of the "Dang" message. 2010-08-08 13:39:27 -07:00
Bharat Mediratta 3c7dc6d7a6 Handle 404 exceptions specially to reduce spam in the log files. Fixes ticket #1228. 2010-08-08 12:46:26 -07:00
Bharat Mediratta ded9ed4df8 Create a registry of REST resources and call it "registry".. Pretty
simple, actually.  Fixes ticket #1173.
2010-08-08 11:35:36 -07:00
Bharat Mediratta a22cf8cf1c Handle "1" as a default order direction in G2. Why would we ever do that? Dunno.
Fixes ticket #1276.
2010-08-08 10:14:29 -07:00
Bharat Mediratta b7700d1eec Require the size parameter. Optional params are confusing. And be
robust in the face of a missing data file (movies and albums lack
resize, albums lack full size, some albums don't have a thumb if they
have no contents, etc)
2010-08-08 09:57:13 -07:00
Bharat Mediratta cc43c37a1c Add a sad face on the dang page. Just cause. 2010-08-08 02:06:50 -07:00
Bharat Mediratta 0d2237979a Make the error page more informative, and include platform information. 2010-08-08 01:48:09 -07:00
Bharat Mediratta 4e95ec843a Allow item_rest::put() to replace the current data file. Remove
data_rest::put() altogether; it's no longer necessary.
2010-08-08 01:12:43 -07:00
Bharat Mediratta 7f61f9754e Change file modes to 644. 2010-08-08 00:30:55 -07:00
Bharat Mediratta 20fd987296 A new REST resource that allows access to view and modify the actual
contents of the file, which enables REST viewers to see the actual
data which is useful when the files are privileged.  Currently it
returns the contents of the file in JSON encoded form, which may not
be the best.  Multipart/mime might be much better.

Fixes ticket #1224.
2010-08-07 22:33:01 -07:00
Bharat Mediratta dfb095a262 Add the ability to replace the source data file in Item_Model::save().
Refactor the rotate code in Quick_Controller to replace the data file,
and then have gallery_event::item_updated_data_file() pick up after
the change is saved, rebuild the image and handle album covers.  This
is much more portable than before and it will allow any mechanism (eg:
REST) to replace the source image.
2010-08-07 22:18:28 -07:00
Bharat Mediratta 1abf43d3f1 Add a max_level to _sanitize_for_dump() so that we don't blow the stack. 2010-08-07 22:06:57 -07:00
Bharat Mediratta c6ca77377f Whitespace fix. 2010-08-07 18:02:39 -07:00
Bharat Mediratta 779d91cca0 Add an index for left_ptr, since we use that in ORM_MPTT::parents()
which is on every album page.  Bump Gallery module version to 33.
2010-08-07 12:18:43 -07:00
Bharat Mediratta 16ae65464c Oops. Fix the upgrader path to add the weight column to the modules table. 2010-08-07 10:57:18 -07:00
Bharat Mediratta 1b2da1ff70 Add a "weight" column to the module table. This allows us to specify
module ordering, which is currently being done in the moduleorder
contrib module.

By default, the weight will be the same as the id of the row which
means that new modules will get added at the end of the list.  This is
covered in the upgrade case as well.

The one gotcha is that we need to make sure that we don't try to sort
by the weight column if the gallery module version is < 32, which is
something we haven't done before.

Fixes ticket #1272.
2010-08-06 20:19:00 -07:00
Bharat Mediratta 0fe44fe380 Use module::install and module::activate for the gallery module as
well; I've verified that it generates the same installer files.
2010-08-06 10:40:41 -07:00
Bharat Mediratta 8559cdb5b6 Add docs reflecting that we may skip some items that have invalid parent_ids 2010-08-04 21:30:48 -07:00
Bharat Mediratta 3492f1712d Fix the i18n error message for missing/incorrect password. Fixes ticket #1265. 2010-08-01 22:18:22 -07:00
Bharat Mediratta 3e8d683ce4 Use the login/html page for maintenance mode; we don't need the
maintenance controller/view anymore.  Fixes ticket #1267.
2010-08-01 22:09:02 -07:00