Commit Graph
1748 Commits
Author SHA1 Message Date
Bharat Mediratta adc4061125 Use better error messages in form validation. 2010-08-22 12:49:01 -07:00
Bharat Mediratta 04add75f6f Get rid of the move dialog and move option. Instead, replace it with
a call to Organize with the appropriate album open.  I have not yet
figured out how to get the SWF code to highlight the active image, but
that's coming.  Partial fix for #1204.
2010-08-22 00:27:24 -07:00
Bharat Mediratta c6a28a93dd Put up a warning and don't accept movie files if we don't have ffmpeg.
This fixes ticket #973.
2010-08-21 15:11:06 -07:00
Bharat Mediratta 4a01aaddc9 Verify that the ffmpeg path still exists by using file_exists(). This
is a lightweight way to catch the case where ffmpeg gets deleted.
Fixes ticket #1303.
2010-08-21 15:10:46 -07:00
Bharat Mediratta 7c1a716f01 Merge branch 'master' of github.com:gallery/gallery3 2010-08-21 14:06:51 -07:00
Bharat Mediratta 3e0b42573e Set the "secure" bit on cookies if we're using HTTPS. Fixes ticket #1217. 2010-08-21 14:06:30 -07:00
Tim AlmdalandBharat Mediratta 65801cf2e0 Fix a typo to the case correction. 2010-08-21 14:05:29 -07:00
Tim AlmdalandBharat Mediratta 33e76f5e33 Correct incorrect case on dialog title. 2010-08-21 14:05:29 -07:00
Tim Almdal 68b598d4fa Remove style information regarding the permission dialog from the gallery.css to the wind/screen.css. This should make it easier for themes to style the dialog. 2010-08-19 19:48:44 -07:00
Tim Almdal ea2808f48f Fix a typo to the case correction. 2010-08-16 22:03:23 -07:00
Tim Almdal de91d0fe4f Merge branch 'master' of git@github.com:gallery/gallery3 2010-08-16 21:54:40 -07:00
Tim Almdal 9592f2f2e6 Correct incorrect case on dialog title. 2010-08-16 21:54:32 -07:00
Bharat Mediratta ff1d8aea2f We use UTF-8 everywhere. Fixes ticket #1285. 2010-08-15 01:59:54 -07:00
Bharat Mediratta a1be33f6ab Verified. 2010-08-15 00:46:02 -07:00
Bharat Mediratta 6563ad1393 Return the right content type for album thumbnails (based on the album cover's mime type) 2010-08-14 22:00:53 -07:00
Bharat Mediratta dbe595f15e Always use the data resource to return thumbs, resizes and full sizes.
That way the client does not have to differentiate between RESTful
request types and raw request types.  If there's a public raw url,
return that as well.
2010-08-14 16:10:32 -07:00
Bharat Mediratta b562751fdb Don't expose members of an item that are not viewable by the end user.
This leaks item ids, but no other information about the item.  Fixes
ticket #1292.
2010-08-14 15:45:16 -07:00
Bharat Mediratta 50e3230d79 Add a key on access_caches.item_id. Without this, the Fix task query
to find missing access_caches is very slow.  Bump Gallery module to v34.
2010-08-14 15:10:07 -07:00
Bharat Mediratta d9f8c8a295 Rebuild access_caches rows if they're missing, as necessary. Fixes ticket #1289. 2010-08-14 14:56:28 -07:00
Bharat Mediratta 524554c65b Send back the content length of files. This fixes streaming movies. Fixes ticket #974. 2010-08-11 21:02:57 -07:00
Bharat Mediratta 9de371e1b3 Use the data_rest implementation to proxy access to raw
thumb/resize/full data files when permissions are in play.
2010-08-09 22:55:58 -07:00
Bharat Mediratta 3c18762fda Change the way that this works. Now instead of sending back the image
metadata and the data itself JSON encoded, we just send back the raw
data with the right Content-Type.  This, combined with code in
Item_Model::as_restful_array() that swaps in /rest/data urls as
appropriate, means that the RESTful payload has consistent urls when
permissions are in play.
2010-08-09 22:54:57 -07:00
Bharat Mediratta f0d8aef0ea "Content-type" --> "Content-Type". 2010-08-09 22:51:14 -07:00
Bharat Mediratta 0ff81c7ded The root album's edit form doesn't have a name field, so don't count
on it being there in update().  Fixes ticket #1281.
2010-08-09 15:18:25 -07:00
Tim Almdal 58bf479f4c Merge branch 'master' of git@github.com:gallery/gallery3 2010-08-08 17:29:29 -07:00
Tim Almdal 1ad1f9517f Fix for ticket #1279. In admin themes sanitize the theme name before checking that theme.info exists. 2010-08-08 17:29:22 -07:00
Bharat Mediratta acb1faaa59 Cache the group ids for a day to trade off performance for security updates.
Fixes ticket #1227.
2010-08-08 17:25:31 -07:00
Bharat Mediratta 6a8c1f5e85 whitespace fix. 2010-08-08 17:19:51 -07:00
Bharat Mediratta bd541342b9 Add gallery stats in addition to platform stats. 2010-08-08 17:07:13 -07:00
Bharat Mediratta 2dda8e22a7 Use the gallery helper date/time functions wherever we format date
time for the browser.  Fixes ticket #1278.
2010-08-08 16:54:31 -07:00
Bharat Mediratta 8da37d595c Verified. 2010-08-08 15:25:21 -07:00
Bharat Mediratta f5b7e207c8 Verified. 2010-08-08 15:02:58 -07:00
Bharat Mediratta 9b5e058dd3 We can always send back the header because Kohana buffers output. 2010-08-08 15:01:38 -07:00
Bharat Mediratta ab2e2d2d77 Add the $max_level param to all calls to _sanitize_for_dump() 2010-08-08 15:00:23 -07:00
Bharat Mediratta 371a2ff7d2 Adjust the vertical placement of the "Dang" message. 2010-08-08 13:39:27 -07:00
Bharat Mediratta 3c7dc6d7a6 Handle 404 exceptions specially to reduce spam in the log files. Fixes ticket #1228. 2010-08-08 12:46:26 -07:00
Bharat Mediratta b7700d1eec Require the size parameter. Optional params are confusing. And be
robust in the face of a missing data file (movies and albums lack
resize, albums lack full size, some albums don't have a thumb if they
have no contents, etc)
2010-08-08 09:57:13 -07:00
Bharat Mediratta cc43c37a1c Add a sad face on the dang page. Just cause. 2010-08-08 02:06:50 -07:00
Bharat Mediratta 0d2237979a Make the error page more informative, and include platform information. 2010-08-08 01:48:09 -07:00
Bharat Mediratta 4e95ec843a Allow item_rest::put() to replace the current data file. Remove
data_rest::put() altogether; it's no longer necessary.
2010-08-08 01:12:43 -07:00
Bharat Mediratta 7f61f9754e Change file modes to 644. 2010-08-08 00:30:55 -07:00
Bharat Mediratta 20fd987296 A new REST resource that allows access to view and modify the actual
contents of the file, which enables REST viewers to see the actual
data which is useful when the files are privileged.  Currently it
returns the contents of the file in JSON encoded form, which may not
be the best.  Multipart/mime might be much better.

Fixes ticket #1224.
2010-08-07 22:33:01 -07:00
Bharat Mediratta dfb095a262 Add the ability to replace the source data file in Item_Model::save().
Refactor the rotate code in Quick_Controller to replace the data file,
and then have gallery_event::item_updated_data_file() pick up after
the change is saved, rebuild the image and handle album covers.  This
is much more portable than before and it will allow any mechanism (eg:
REST) to replace the source image.
2010-08-07 22:18:28 -07:00
Bharat Mediratta 1abf43d3f1 Add a max_level to _sanitize_for_dump() so that we don't blow the stack. 2010-08-07 22:06:57 -07:00
Bharat Mediratta c6ca77377f Whitespace fix. 2010-08-07 18:02:39 -07:00
Bharat Mediratta 779d91cca0 Add an index for left_ptr, since we use that in ORM_MPTT::parents()
which is on every album page.  Bump Gallery module version to 33.
2010-08-07 12:18:43 -07:00
Bharat Mediratta 16ae65464c Oops. Fix the upgrader path to add the weight column to the modules table. 2010-08-07 10:57:18 -07:00
Bharat Mediratta 1b2da1ff70 Add a "weight" column to the module table. This allows us to specify
module ordering, which is currently being done in the moduleorder
contrib module.

By default, the weight will be the same as the id of the row which
means that new modules will get added at the end of the list.  This is
covered in the upgrade case as well.

The one gotcha is that we need to make sure that we don't try to sort
by the weight column if the gallery module version is < 32, which is
something we haven't done before.

Fixes ticket #1272.
2010-08-06 20:19:00 -07:00
Bharat Mediratta 0fe44fe380 Use module::install and module::activate for the gallery module as
well; I've verified that it generates the same installer files.
2010-08-06 10:40:41 -07:00
Bharat Mediratta 8559cdb5b6 Add docs reflecting that we may skip some items that have invalid parent_ids 2010-08-04 21:30:48 -07:00