Commit Graph
2330 Commits
Author SHA1 Message Date
Bharat Mediratta ad81861c33 First pass at an XSS security test, along with the "p" helper which
can clean HTML output.
2009-05-31 00:11:02 -07:00
Bharat Mediratta 1848390897 Convert single quotes to double quotes 2009-05-31 00:10:12 -07:00
Bharat Mediratta a5670d8d70 gate $can_edit and $can_add on whether or not we have an $item at all
(fixes a bug where search doesn't render because it has no item).
2009-05-30 17:14:17 -07:00
Bharat Mediratta 3b3531cbb8 Add a / to the end of TMPPATH to match other paths. 2009-05-30 15:34:03 -07:00
Bharat Mediratta 1559539993 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-30 01:45:29 -07:00
tim almdal 120088140c Move the code that was in the scaffolding to package the initial mySql database and var directory to a seperate standalone file in the installer. This will save the current database environment and restore it when the packaging is complete 2009-05-29 23:34:24 -07:00
Bharat Mediratta f660eb55aa Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-29 22:28:48 -07:00
tim almdal f0104ee43b remove scaffolding code 2009-05-29 21:53:49 -07:00
Bharat Mediratta ce285b8feb Use the relative_path_cache to look up items which should be a faster
query than using the level + the components.
2009-05-29 21:23:08 -07:00
Bharat Mediratta cbec883d8a Don't show "edit permissions" for non-albums. 2009-05-29 20:59:34 -07:00
Bharat Mediratta 60d1bbc2d6 Move credits message into a variable, which can be changed in Admin >
Settings > Advanced.  It's stored in the variable as an
internationalized string and localized at output time.
2009-05-29 20:24:42 -07:00
Bharat Mediratta 994830f611 Fix the code to specify which columns its inserting into. Without
that it's fragile, and I broke it when I sorted the columns
alphabetically a day or two ago.
2009-05-29 18:04:54 -07:00
Bharat Mediratta 2925a1c797 Require "add" permission to show the add form. 2009-05-29 17:54:20 -07:00
Bharat Mediratta 381dd0574a Don't show the add photo/album options to users who don't have the
permission.  This isn't a security hole, since they can't actually add
stuff.. but they can try and fail which is a bad user experience.

Also fix it up so that we show the option menu only if there's stuff
to show, and cache some of the permissions for performance (which I'm
guessing at-- didn't benchmark it).
2009-05-29 17:53:33 -07:00
Bharat Mediratta 055e0a7dc5 Remove a completed @todo 2009-05-29 17:42:31 -07:00
Bharat Mediratta 34da188e81 Revert test code inserted in 88a3d43ba9
which showed stack traces to non-admins.
2009-05-29 17:40:23 -07:00
Bharat Mediratta b0cb3c7402 Update Kohana to r4374 2009-05-29 12:00:49 -07:00
Bharat Mediratta 0097803efc Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 21:42:18 -07:00
Bharat Mediratta 356bac0db0 Restore calls to module::load_modules() after install/activate/deactivate/uninstall events. 2009-05-28 21:18:46 -07:00
Bharat Mediratta c4c70c537d Tweak path slightly 2009-05-28 21:18:31 -07:00
Bharat Mediratta 73f348b29e Protect get() against missing records. 2009-05-28 21:07:47 -07:00
Bharat Mediratta d088a41747 Load the gallery module in load_modules(), but put it at the end of
the module list (to match its location in the cascading filesystem)
2009-05-28 21:00:06 -07:00
Bharat Mediratta 20a2d9f9a8 Reset the cascading file path properly before reinstalling. 2009-05-28 20:59:23 -07:00
Bharat Mediratta 3da5ee2f4c Print out exception traces for most errors 2009-05-28 18:21:39 -07:00
Bharat Mediratta 7fd6fcaf9b Force modules/gallery to be at the end of the module load path, so
that all other modules can override the core code.
2009-05-28 17:46:17 -07:00
Bharat Mediratta d8f2c9f9f7 Revert "Change Kohana::include_path() to put APPPATH (core) at the end of the"
This reverts commit 7e37055408.

No longer necessary now that we're putting all the code into
modules/gallery, which we can force to be at the end of the module
path.
2009-05-28 17:42:06 -07:00
Bharat Mediratta f56e095aeb Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 02:36:36 -07:00
Bharat Mediratta 1a095fffe5 Prepend all code files we copy from Gallery2 and put into var with our
code preamble for security.

Update File_Structure_Test::code_files_start_with_preamble_test to
check all the php files in var, too.
2009-05-28 02:19:53 -07:00
Bharat Mediratta c8aa9ed440 Update tests to reflect cache-buster param on thumbnail urls. 2009-05-28 01:58:41 -07:00
Bharat Mediratta 534b8525ce Rename Core_Installer_Test -> Gallery_Installer_Test to match the
change from application -> modules/gallery.
2009-05-28 01:55:42 -07:00
Bharat Mediratta 8c3135ef72 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 01:46:19 -07:00
Bharat Mediratta 6fdc84f5de Get rid of entire gallery2 session id param from the urls that we use to alert
users about images that failed to import.
2009-05-28 01:45:39 -07:00
Bharat Mediratta c1e55e9593 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-28 00:49:41 -07:00
Bharat Mediratta 8d2782ad1d Flush the model cache as appropriate every time we call ORM::save().
Fixes ticket #301
2009-05-28 00:45:00 -07:00
Bharat Mediratta ebb0761b8d Label the tag input field according to the item type.
Fixes ticket #176.
2009-05-28 00:32:24 -07:00
Bharat Mediratta df51ea7fa4 Fix broken html::script() and url::file() references to the newly
moved gallery module.
2009-05-28 00:06:38 -07:00
Bharat Mediratta 1988d77039 Remove unnecessary (and broken) <form/> 2009-05-28 00:06:09 -07:00
Bharat Mediratta 93053cf831 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-27 23:15:09 -07:00
Bharat Mediratta 3870892018 Commit an egregious hack to work around the fact that both Gallery 2
and Gallery 3 have a class named Gallery.  Clone a subset of the
Gallery 2 files and munge them so that we can rename the Galery 2
version to G2_Gallery.

Also, update the disclaimer in Admin > Settings > Gallery 2 Import.
2009-05-27 22:57:38 -07:00
Bharat Mediratta 24dce5a85d Fix up another place where we were incorrectly referencing the gallery module. 2009-05-27 21:18:09 -07:00
Bharat Mediratta 993eecfee6 Rename index.local.php to local.php so that tab completion on i<tab> works.
Makes running tests easier.

Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-05-28 12:10:29 +08:00
Bharat Mediratta f64824b35c Remove extra line from a bad merge
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-05-28 12:10:29 +08:00
Bharat Mediratta 567c911fa3 Rename index.local.php to local.php so that tab completion on i<tab> works.
Makes running tests easier.
2009-05-27 21:05:35 -07:00
Bharat Mediratta 66b406ebcf Remove extra line from a bad merge 2009-05-27 20:40:44 -07:00
Bharat Mediratta bb8feb0318 Merge branch 'master' of git@github.com:gallery/gallery3 2009-05-27 20:39:07 -07:00
Bharat MedirattaandGallery Role Account bc9aeb4625 Normalize root update time in the installer
Rebuild install.sql

Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:12 +08:00
Bharat MedirattaandGallery Role Account 4dfe93d664 Fix a typo in the class name
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:11 +08:00
Bharat MedirattaandGallery Role Account 50ca9b9306 Manually updated to change 'core' to 'gallery'
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:11 +08:00
Bharat MedirattaandGallery Role Account c8f849b38f Convert a few more references of APPPATH to MODPATH/gallery
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:10 +08:00
Bharat MedirattaandGallery Role Account f89424bc85 Show the scaffolding link if the controller is around.
Signed-off-by: Gallery Role Account <gallery@menalto.com>
2009-05-28 11:07:10 +08:00