stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-06-06 03:29:28 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
4,899 Commits 4 Branches 0 Tags
ab7be17b7fae9dbff42a77cb5eff85cf0c8d824d
Commit Graph

2914 Commits

Author SHA1 Message Date
Bharat Mediratta
ab7be17b7f Switch to model based validation approach. 2010-01-17 20:17:50 -08:00
Bharat Mediratta
7d9d40c7d6 Use test::random_photo_unsaved() instead. 2010-01-17 20:06:34 -08:00
Bharat Mediratta
dd5f08b703 Create xxx_unsaved() versions for the case where you want to tinker with the item before it gets saved. 2010-01-17 20:06:28 -08:00
Bharat Mediratta
c0d0142552 Updated for model based validation. 2010-01-17 20:03:18 -08:00
Bharat Mediratta
39bb08db28 Make set_data_file() chainable. 2010-01-17 20:02:30 -08:00
Bharat Mediratta
afb7decb00 Make it work with model based validation. 
Refactor _get_proxy() out of setup() and into its own helper function.
 2010-01-17 19:57:42 -08:00
Bharat Mediratta
c9fd8d751d Add random_photo() 2010-01-17 19:57:24 -08:00
Bharat Mediratta
c5f9a466c8 Updated for model based validation. 2010-01-17 19:33:44 -08:00
Bharat Mediratta
c5c17eecc3 Updated for model based validation. 2010-01-17 19:32:05 -08:00
Bharat Mediratta
c863544ec3 Add validation for guest_email and guest_url. 2010-01-17 19:31:49 -08:00
Bharat Mediratta
f68862f4c9 Updated for model based validation. 2010-01-17 19:26:32 -08:00
Bharat Mediratta
53a17e3444 Add album title in random_album(). 2010-01-17 19:26:22 -08:00
Bharat Mediratta
c13d5c3513 Helper class for common test methods (like creating albums, photos, 
etc).
 2010-01-17 19:24:48 -08:00
Bharat Mediratta
05e8d560e4 Refactor to work with model based validation. 
While I'm at it, pull _make_comment() out of setup and only call it on
demand; this makes the tests run faster.
 2010-01-17 18:10:32 -08:00
Bharat Mediratta
3ef22d9d1a Add special output support for ORM_Validation_Exception 2010-01-17 18:09:31 -08:00
Bharat Mediratta
5162e35d49 Use an empty password for the guest user. 2010-01-17 17:54:14 -08:00
Bharat Mediratta
9e9c5397b7 Qualify the Bad Request output when the name is missing 2010-01-17 16:59:25 -08:00
Bharat Mediratta
4197ee39b9 Catch ORM_Validation_Exception and turn it into a 400 Bad Request with 
appropriate error output.
 2010-01-17 16:58:54 -08:00
Bharat Mediratta
afb3fa71b9 Get rid of internal_only designation -- it's too hard to enforce cleanly. 2010-01-17 16:58:47 -08:00
Bharat Mediratta
fafa7f277f Remove a @todo. 2010-01-17 16:55:48 -08:00
Bharat Mediratta
bb79a1455a Remove unnecessary comment. 2010-01-17 16:55:11 -08:00
Bharat Mediratta
f70130b820 Special case output for ORM_Validation_Exceptions 2010-01-17 13:30:06 -08:00
Bharat Mediratta
f0a290fc76 If we call original() and there's no $original yet, then consider this 
to be the original.  That should be safe because we're already
guarding __set, __unset and save.
 2010-01-17 13:29:36 -08:00
Bharat Mediratta
cfb27dde02 Adjust installers to work with model based validation. 2010-01-17 13:28:24 -08:00
Bharat Mediratta
9488684220 Move model rules down into their validate() function for consistency. 
Change "in_use" error to "conflict" for consistency.
 2010-01-17 12:30:24 -08:00
Bharat Mediratta
3789b85b7d Move rules down into validate() and improve valid_author(). 2010-01-17 12:19:24 -08:00
Bharat Mediratta
4f8c98a7bc Move rules entirely down into validate() so that we can be more 
sophisticated but keep all our rules in one place.

Add rules for most fields.
 2010-01-17 12:13:25 -08:00
Bharat Mediratta
5c49c041e7 Use "(string) $form" instead of "$form->__toString()" 2010-01-16 22:42:02 -08:00
Bharat Mediratta
1c85cf6397 Convert comment code over to model based validation. 2010-01-16 22:27:07 -08:00
Bharat Mediratta
39ad9fa9a0 Get rid of add_rules_from() -- it's no longer necessary now that we're doing model based validation. 2010-01-16 21:25:17 -08:00
Bharat Mediratta
4a2d5bc9e2 Convert Users_Controller to model based validation. 2010-01-16 21:24:18 -08:00
Bharat Mediratta
6a4dda9bde Convert Admin_Users_Controller, User_Model and Group_Model to use 
model based validation.
 2010-01-16 21:15:12 -08:00
Bharat Mediratta
a691dcc63c Convert Admin_Users::add_user() to use model based validation. Get 
the rules and business logic out of the form and user::create(), and
move it into User_Model::save().
 2010-01-16 19:58:55 -08:00
Bharat Mediratta
fdcb4a1f32 PHPdoc. 2010-01-16 18:16:47 -08:00
Bharat Mediratta
a5aacfa4a6 Don't forget to save when we make insignificant chagnes only. 2010-01-16 18:10:40 -08:00
Bharat Mediratta
7f20f66079 Whitespace. 2010-01-16 18:00:02 -08:00
Bharat Mediratta
ff728b3ccd Whitespace. 2010-01-16 17:51:57 -08:00
Bharat Mediratta
8ce11ac970 Convert Movies_Controller::update() over to model based validation. 2010-01-16 12:07:36 -08:00
Bharat Mediratta
efdb73cb98 Make movie creation use model based validation. Move movie related 
logic from movie::create() into Item_Model
 2010-01-16 12:00:50 -08:00
Bharat Mediratta
b5a6a6a5d5 Oops, log::failure() doesn't exist. Use log::error(). 2010-01-16 11:44:21 -08:00
Bharat Mediratta
5a8449f16d Convert Photos_Controller::update() to use model based validation. 2010-01-16 11:12:27 -08:00
Bharat Mediratta
9f6dba7238 Check for illegal extensions in valid_name() 
Fix a bug where we were not calling valid_data_file correctly.
 2010-01-16 11:12:19 -08:00
Bharat Mediratta
bf085a1a17 Convert photo uploading over to the new model based validation 
approach.

- Rearrange Simple_Uploader_Controller::add_photo() to validate
  the form early in the process, and switch to using model based
  validation.

- Move thumbnail generation into gallery_event::item_created() so
  that it's decoupled from the model.

- Delete photo::create() and move all of its logic into
  Item_Model::save().

- Add Item_Model::$data_file to track the data file associated
  with new movies and photos.

- Do some cleanup on the validation callbacks -- it turns out the
  2nd argument is the field name not the value.
 2010-01-16 00:51:31 -08:00
Bharat Mediratta
d7eb102312 Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev 2010-01-16 00:19:47 -08:00
Bharat Mediratta
2c2c77ea39 Remove debug code. 2010-01-16 00:19:35 -08:00
Bharat Mediratta
434d351b2f Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev 
Conflicts:
	modules/gallery/models/item.php
 2010-01-16 00:15:23 -08:00
Bharat Mediratta
dcf4b5e71a Don't pass MY_ORM::original() to update event handlers, since after 
parent::save() it'll be reset.  Clone it first.

This is an alternate fix for #978.
 2010-01-16 00:13:28 -08:00
Bharat Mediratta
9f03d36d6e Don't use MY_ORM::original() here since the values may not have 
changed since the last save.  Instead, use the original ORM passed in.
 2010-01-16 00:10:55 -08:00
Bharat Mediratta
00c73a4b07 Revert "Fix for ticket #978. Don't reset the original property as part of the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." 
This reverts commit daeaca110d.
 2010-01-15 23:53:43 -08:00
Bharat Mediratta
99073c3e20 Revert "Did the old commit then save trick" 
This reverts commit e41ad23a8e.
 2010-01-15 23:53:35 -08:00