stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-31 04:00:56 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,070 Commits 4 Branches 0 Tags
aa0209d6d3d8535b9bbaaaa6664aa5769ab5f8a6
Commit Graph
299 Commits
Author SHA1 Message Date
Shai Ben-NaphtaliandTim Almdal 1d7ed9e76b Fixed indentation of commit 2760e119bbfc3e2d436c404de194dbeea738a735 
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-07-12 13:23:52 +08:00
Shai Ben-NaphtaliandTim Almdal b0aab73364 This fixes ticket #513 
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
 2009-07-12 13:23:51 +08:00
Bharat Mediratta 214d977f4d Don't close the dialog window after we successfully complete an 
action.  The expectation is that we're going to reload the page (or
redirect to a new url).  If we close the dialog, then we can trigger
the onhover for items we've just deleted causing errors.

Simplify the API while we're at it by getting rid of the no-longer-used
on_success argument to openDialog()

This fixes #528.
 2009-07-11 06:51:21 -07:00
Bharat Mediratta 4d0099e716 Fix a bug where we're referring to $photo when we just uploaded a 
$movie, that causes the simpler uploader to throw an error for all
movies.
 2009-07-11 06:24:10 -07:00
Bharat Mediratta 6b013060aa Fix style: space after ) before {. 2009-07-11 06:15:44 -07:00
Bharat Mediratta ecc7d881e3 Fix bug introduced in e0e450d90f where 
it got rid of the 'img' var which is used when we set the click action
on buttons.

Partial fix for #528.
 2009-07-11 05:52:50 -07:00
Bharat Mediratta 6281ed03d5 Turn off extended inserts when creating install.sql so that it's 
easier to see what's changed.
 2009-07-11 05:36:31 -07:00
Tim Almdal 4132d6c55e Put quotes around the href param (href="#") 2009-07-11 15:47:04 -07:00
Tim Almdal f1b2a14f4f Add a title attribute to the li of a menu 2009-07-10 23:45:29 -07:00
Chad Kieffer e0e450d90f Position gItem and gPhoto relative, then position quick and thumb menus as absolute within them. Moved css from quick.js to quick.css. 2009-07-11 00:40:57 -06:00
Tim Almdal fe6320ef4c Fix for ticket #341. 
Change the wording for the sort order from "Default" to "Order Added"
 2009-07-10 18:11:12 -07:00
Tim Almdal f887fd32a4 Forgot to add this file when change "Done"'s to "Close"'s 2009-07-10 14:19:33 -07:00
Tim Almdal 15bb52a776 Change the word "Done" to "Close" to make translations easier 2009-07-10 14:12:13 -07:00
Tim Almdal 09c9b1a755 Added the upload::required validation in order to insure that failed uploads 
are not treated as successful.
Log any exceptions to the Kohana log and return the error message
 2009-07-10 11:35:28 -07:00
Bharat Mediratta 86a7b15d20 Compact all menus. This fixes the problem that the new [Options] 
thumb menu shows up when it has nothing in it.
 2009-07-10 10:39:59 -07:00
Bharat Mediratta 12796ec2ca Create a new [options] submenu under the thumb menu, and move the 
Digibug print button into it.  Right now, it doesn't display properly.
 2009-07-10 08:20:00 -07:00
Bharat Mediratta 74d4a4c0fd Merge branch 'master' of git@github.com:/gallery/gallery3 2009-07-07 21:20:37 -07:00
Tim Almdal 6ac5238b83 Add task logging to the "Update Search Index" task 2009-07-08 09:27:37 -07:00
Tim Almdal ac797e609c Add task logging to the Update translations 2009-07-08 09:08:15 -07:00
Tim Almdal 9f00e734ed Added the button formatting to the other links on the Admin Maintenance page. 2009-07-08 08:26:14 -07:00
Tim Almdal 47fbb56fa2 Added task logging to the Rebuild Images task. 2009-07-08 08:22:40 -07:00
Tim Almdal 2852161ca3 Provide some clarity on the action links by formating them as buttons on 
the Maintenance Tasks admin page.
 2009-07-07 21:49:54 -07:00
Tim Almdal 5d9e334fe6 Added a wee bit of phpDoc. 
Changed the name of the method get_task_log to get_log
Changed the default name of the file when the log is downloaded to
gallery3_task_log.txt
 2009-07-07 12:49:21 -07:00
Tim Almdal b0cd0a52be Allow the task::log method to take an array of lines and change g2_import.php 
helper to use this approach.
 2009-07-07 12:10:50 -07:00
Tim Almdal b59e94e7dc Change references to Gallery 2 and Gallery 3 to consistently refer to 
Gallery n as opposed any variants of this.
 2009-07-07 07:32:36 -07:00
Tim Almdal 493fb27825 Cleanup remove task processing. Change Task_Model::delete to call parent::delete 
instead of parent::save. :-) Also change admin_maintenance_controller to delete
via looping over all of the completed tasks and delete individually, so we can
delete the associated cache entries at the same time.
 2009-07-06 22:20:04 -07:00
Bharat Mediratta 30aa065013 Don't use jQuery in the error page, it interferes with the jquery lib 
in the outer page when we load it in a dialog context.
 2009-07-06 12:41:54 -07:00
Tim Almdal 6dbd36d1cc Always log the task completion status message 2009-07-06 10:29:55 -07:00
Tim Almdal f381927ec6 Catch exceptions that are thrown within the task and log them to the task log 
and then set the task to done, the state to error and the status message set
to the Exception Message.
 2009-07-06 07:39:36 -07:00
Tim Almdal 04f02b49c5 Add task logging functionality. When a task runs, it creates a log that is 
stored in the persistant cache for 30 days.  On the admin_maintenance page
there is a new link for completed tasks "browse log".  Clicking this will
open a dialog box that has the the contents of the log displayed.

The user can then view the log and close the dialog, or press the save button
to download the log to their local machine.
 2009-07-05 17:38:49 -07:00
Tim Almdal 0f9bfbdd57 Use TMPPATH in the purifier config instead of var/tmp 2009-07-04 09:10:03 -07:00
Tim Almdal d6648c0aff Fix for ticket #477. Use nl2br method when rendering comment::text and 
item::description.  In addition add p::clean or p::purify to places that
xss cleaning had missed (i.e. rss feeds)
 2009-07-04 08:17:12 -07:00
Tim Almdal 54ffea2419 Split the clean method into two clean and purify. clean is a light weight 
approach using html::specialchars and purify uses HTMLPurifier to intelligently
cleanse the output fields. Use purifier for text and title fields where it is
likely that a user would enter html to format their data.
 2009-07-03 21:44:10 -07:00
Andy Staudacher a633c134b7 Ticket 104: Adding "Copy sourc text" button to l10n UI (usability / productivity improvement) 2009-07-03 16:14:05 -07:00
Andy Staudacher fb472da0ba Ignore lib/ folders in l10n_scanner task. 
1. Because it makes sense.
2. As a quick fix - For some reason it wouldn't work properly anymore now with the HTMLPurifier lib
 2009-07-03 16:11:17 -07:00
Andy Staudacher bafbe5a2d2 Fix for ticket 510: i18n fixes - localize module / theme name in some status messages 2009-07-03 14:58:33 -07:00
Tim Almdal f6d847739a Update the source so the third party code passes the File Structure Test 2009-07-03 14:18:45 -07:00
Tim Almdal 8d5900f639 Fix for ticket #400: Add HTMLPurifier to gallery3 and change p::clean() to call HTMLPurifier->purify() 2009-07-03 12:56:59 -07:00
Tim Almdal b6e5bf6eaa Fix for ticket #400: Add HTMLPurifier to gallery3 and change p::clean() to call HTMLPurifier->purify() 2009-07-03 12:56:29 -07:00
Bharat Mediratta 715d714ade Merge branch 'master' of git@github.com:/gallery/gallery3 2009-07-03 09:26:31 -07:00
Bharat Mediratta bd1b2f4147 Merge branch 'master' of git@github.com:/gallery/gallery3 2009-07-03 04:48:54 -07:00
Bharat Mediratta eb5538d135 Merge branch 'master' of git@github.com:/gallery/gallery3 
Conflicts:
	modules/server_add/controllers/admin_server_add.php
 2009-07-02 18:00:22 -07:00
Tim Almdal a13ddfea8f Suppress the filesize error if the thumbnail is not found so we can get 
an EMPTY_INPUT_FILE exception which we can then log and continue.
 2009-07-02 07:53:24 -07:00
Bharat Mediratta c60d7f431d ORM::Factory -> ORM::factory 2009-07-02 04:37:03 -07:00
Bharat Mediratta a674170bf7 2 fixes: 
1) Include the url in the cache key so that if the Gallery moves, we
   don't use old cached entries.

2) Use the relative path to files in the comments that we embed in our
   files so that we don't leak local paths.
 2009-07-01 22:55:43 -07:00
Bharat Mediratta 8f9a943f55 Fix a bunch of XSS vulnerabilities turned up by manual inspection 
using the checklist in ticket #385.
 2009-07-01 17:57:39 -07:00
Bharat Mediratta 132bd8306e Re-add Session::abort_save(). It was reverted as part of the earlier 
change, but this is the part that we want to keep.
 2009-06-30 20:51:02 -07:00
Bharat Mediratta 666c807fcc Revert "Add Session::abort_save() to Kohana." 
Obsoleted by upstream fix.

This reverts commit 06f066164f.
 2009-06-30 20:47:51 -07:00
Bharat Mediratta d8e776cc88 Checkpoint. 2009-06-30 19:12:46 -07:00
Bharat Mediratta 5e8e3ab6b5 Rejigger the way we handle "done" status in the upgrader. Now we 
present the done box if you're done and let you get rid of it if you
want.  It's not beautiful, by any means, but it gives you an easy link
back to your Gallery when you're finished.

Fixes ticket #479.
 2009-06-30 18:28:55 -07:00