Commit Graph

4686 Commits

Author SHA1 Message Date
Bharat Mediratta
3b0baa8271 Replay change from Romain DE LISEZ to change the state column to be a varchar 2009-06-23 13:45:16 -07:00
Bharat Mediratta
e49c4a2459 Upgrade to version 2 and change the state column to a varchar for
Postgres compatibility.
2009-06-23 13:40:23 -07:00
Bharat Mediratta
bfca0c7903 Refactor the install/upgrade code to be more flexible.
Add xxx_installer::upgrade($version) method so that upgrade stanzas
are separate from install stanzas.  In the old code, to do an upgrade
meant that you had to re-evolve everything from the initial install
because we'd step through each version's changes.  But what we really
want is for the initial install to start off in the perfect initial
state, and the upgrades to do the work behind the scenes.  So now the
install() function gets things set up properly the first time, and the
upgrade() function does any work to catch you up to the latest code.
See gallery_installer.php for a good example.
2009-06-23 12:00:49 -07:00
Bharat Mediratta
342d5e1186 Order log entries by id as well so that multiple events in the same
second are still shown in descending order.
2009-06-23 11:53:38 -07:00
Tim Almdal
8f443cef3e This change implements the print_proxy method. This method allows a 1 time
security bypass for the remote print processor to retrieve the fullsize image.
2009-06-23 06:06:33 -07:00
Tim Almdal
3824f2b52f Extract the html for the Print button on the album page into a seperate view 2009-06-23 05:26:44 -07:00
Romain LE DISEZ
de28b0350e Use an integer because the code store 0 and 1. It
improves compatiblity with PgSQL.
The right way is to use a BOOLEAN and code with
booleans. The values would be :
 - FALSE => deny
 - TRUE  => allow
 - NULL  => unknow
2009-06-23 10:14:38 +02:00
Romain LE DISEZ
d601ab93be Value stored in comment.state is not 15 char length.
Use a VARCHAR instead of a CHAR. It improves compatibility
with PgSQL.
2009-06-23 10:12:09 +02:00
Romain LE DISEZ
c80d2da0a9 Remove an useless ORDER BY.
It improves compatibility with PgSQL.
2009-06-23 10:09:46 +02:00
Romain LE DISEZ
2e6a1d6fdc SQL is case insensitive 2009-06-23 10:08:55 +02:00
Romain LE DISEZ
04f34516f8 Improve compatibility with other RDBMS 2009-06-23 10:05:15 +02:00
Tim Almdal
58d5624e40 This commit moves a little further along the path:
1) moves the print button from the quick pane to thumb_bottom
2) Creates an entry into the proxy table
2009-06-22 21:51:22 -07:00
Tim Almdal
34ff60a039 Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-22 15:03:28 -07:00
Bharat Mediratta
ec61cd5031 Fix css indentation 2009-06-22 14:20:28 -07:00
Bharat Mediratta
d8fe96d70b Update version comparison to match latest gallery module version 2009-06-22 13:48:19 -07:00
Bharat Mediratta
a5eb5e3e80 Updated 2009-06-22 13:25:46 -07:00
Tim Almdal
e3457f8dba Remove debugging output that was overlooked
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-22 21:27:47 +08:00
Tim Almdal
6b552fb07c Remove debugging output that was overlooked 2009-06-22 06:27:31 -07:00
Tim Almdal
fa4bb5b7ac Change the quick pan from static to dynamic. This allows modules to add buttons to the
quick pane.  The quick pane is now divided into 4 sections: left, center, right and
additional.  Additional items appear in the drop down box.  Buttons are not sorted
within the groupings.

In addition, the quick pane will overflow onto the "additional" dropdown if there is not
enough room to display all the buttons.

The use case is the digibug printing module needed to add a button to the quick pane, and
I don't like putting code into core that says if module is active... That's another one
of those code smells :-)

Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-22 21:08:35 +08:00
Tim Almdal
05f8659a7f Fix preamble so tests pass 2009-06-22 06:03:55 -07:00
Tim Almdal
f981484a80 Add a digibug printing button to the quick pane 2009-06-22 05:52:47 -07:00
Tim Almdal
ee8887045e Change the quick pan from static to dynamic. This allows modules to add buttons to the
quick pane.  The quick pane is now divided into 4 sections: left, center, right and
additional.  Additional items appear in the drop down box.  Buttons are not sorted
within the groupings.

In addition, the quick pane will overflow onto the "additional" dropdown if there is not
enough room to display all the buttons.

The use case is the digibug printing module needed to add a button to the quick pane, and
I don't like putting code into core that says if module is active... That's another one
of those code smells :-)
2009-06-22 05:46:40 -07:00
Tim Almdal
284fea0870 Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-21 18:21:00 -07:00
Bharat Mediratta
06f066164f Add Session::abort_save() to Kohana.
Filed upstream as: http://dev.kohanaphp.com/issues/1801
2009-06-21 15:09:32 -07:00
Tim Almdal
39cf3c2b04 The start of the digibug printing module. The first cut at the administration
panels.  <Caution:> This is still a work in progress.
2009-06-21 08:52:26 -07:00
Bharat Mediratta
1fa05d2f39 Updated to Exifer r4107 2009-06-20 21:41:09 -07:00
Bharat Mediratta
8383ea9827 Keywords in G2 are free form. So we don't know what our user used as a separator. Try to
be smart about it.  If we see a comma or a semicolon, expect the keywords to be separated
by that delimeter.  Otherwise, use space as the delimiter.

Fixes ticket #446
2009-06-20 16:55:09 -07:00
Bharat Mediratta
ef7f1d07b2 Center the "all done" dialog. Use Jquery and externalize the CSS (I was being
too conservative before).  Fixes ticket #413.
2009-06-20 12:09:49 -07:00
Bharat Mediratta
acd54fefda Fix a bug in gallery_installer where on an initial install we were
only implementing schema version 1.  This caused install.sql to be
populated from version 1 which meant that after install you'd have to
run the upgrader.  No harm done, and the pattern is fixed for the
future.

Alphabetize the tables so it's easier to find stuff.
2009-06-20 01:24:21 -07:00
Bharat Mediratta
b72d0db7be More minor facelift for the admin/g2_import page. 2009-06-19 15:56:55 -07:00
Bharat Mediratta
feab9cfc34 Give the admin/g2_import page a facelift. 2009-06-19 13:47:38 -07:00
Bharat Mediratta
b3226d7cbb Improve the task dialog
1) Put a "starting up..." message before there's any feedback from the server
2) show the title of the task in the dialog.
2009-06-19 13:25:42 -07:00
Bharat Mediratta
6029c2bf7a Catch exceptions from tag::add() that can be caused by character
encoding issues resulting from embedded keywords in encodings we can't
decipher.  This can lead to weird truncation issues which in turn can
lead to multiple tags getting truncated to the same value in MySQL
which leads to mysql complaining that we're adding a duplicate tag.
2009-06-19 12:03:35 -07:00
Bharat Mediratta
b999b35d24 Swap the order of two lines to make the debug output have the right data. 2009-06-19 10:30:59 -07:00
Bharat Mediratta
cdb4052b52 Add an id to the exif link anchor. 2009-06-19 09:58:36 -07:00
Andy Staudacher
b6290b45cf Fix format of source message in l10n client (adding a newline between plural forms) 2009-06-18 12:44:05 -07:00
Andy Staudacher
5ef6db85fb Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-18 12:36:06 -07:00
Andy Staudacher
926eab7168 Fix plural messages in l10n scanner - Bad typo lead to basically breaking all plural ("other") forms. 2009-06-18 12:35:07 -07:00
Bharat Mediratta
d54900032f Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-18 12:25:20 -07:00
Bharat Mediratta
cdb02c10a4 Make an attempt to catch all situations where loading an item from G2
returns an error, and log them appropriately.  This should fix a slew
of import failures from corrupt G2 installs.
2009-06-18 12:24:33 -07:00
Andy Staudacher
d7e6c71ede Fix l10n messages (malformed html) 2009-06-18 01:47:29 -07:00
Andy Staudacher
06f37b5a53 Fix/remove unnecessary escaping of double quotes in l10n scanner. 2009-06-18 01:42:59 -07:00
Bharat Mediratta
34dd08e150 Merge branch 'master' of git://github.com/unostar/gallery3 2009-06-17 21:52:00 -07:00
Tim Almdal
a6a9b256ae Correct the "inappropriate intimacy" smell that bharat's refined senses pick up 2009-06-17 13:34:18 -07:00
Tim Almdal
5b767b6443 Fix for ticket #366
Move the creation of the setting menu back to gallery_menu::admin, now that
there is a mechanism to remove empty menu items
2009-06-17 06:42:31 -07:00
Tim Almdal
fbefdd5556 Fix for ticket #366
1) Stored the menu element type in the menu element
2) Scanned the menu before display removing any empty sub menus.
Went with the removal approach because there will more users than developers
2009-06-17 06:14:36 -07:00
unostar
753ce3e025 Add "custom_translations" instruction to captcha form builder to add possibility to localize and customize form. 2009-06-17 01:26:47 -07:00
Bharat Mediratta
1a911d4b5c Fix a bug that was overwriting the quick-pane HTML causing the quick
panes not to appear.  Oops.  Bug was introduced in the rss refactor:
1b656be713

Signed-off-by:  <unostar@danalan.info>
2009-06-17 15:26:33 +08:00
Bharat Mediratta
2531f67990 Merge branch 'master' of git@github.com:gallery/gallery3 2009-06-16 23:51:39 -07:00
Bharat Mediratta
5eeb6296a1 Fix a bug that was overwriting the quick-pane HTML causing the quick
panes not to appear.  Oops.  Bug was introduced in the rss refactor:
1b656be713
2009-06-16 23:51:18 -07:00