Commit Graph
2269 Commits
Author SHA1 Message Date
Bharat Mediratta 53a2652fd6 Create url::merge_querystring() which merges a query string into an
existing url.  Fixes #1537.
2010-12-16 20:36:00 -08:00
Bharat Mediratta b9e11a6f93 Don't show the "can't find ffmpeg" message to non-admins. Fixes #1528. 2010-12-15 15:16:00 -08:00
Bharat Mediratta cd48b89f31 Consolidate all the random code into a random helper that offers:
random::hash()
  random::string()
  random::percent()
  random::int()

So that we don't have lots of different ways to get random values all
over the code.  Follow-on to #1527.
2010-12-15 14:57:00 -08:00
Bharat Mediratta 45c63f4d11 Use mt_rand() instead of rand() since it provides better portability.
Fixes #1527.
2010-12-15 12:48:56 -08:00
Bharat Mediratta 6fb0eb4e97 Follow on to d2be26e407 to update the
unit tests to reflect the proper type filtering for #1503.
2010-12-15 12:24:31 -08:00
Bharat Mediratta ff4c930338 Clean up golden file as a follow-on to
3c523bcac6 for #1499.
2010-12-15 12:08:56 -08:00
Bharat Mediratta 18470a6001 Clean up xss golden file as a follow-on to
945e79b171 for #1478.
2010-12-15 12:07:02 -08:00
Bharat Mediratta f8890be62b Follow on to d2be26e407 to convert tabs to spaces. 2010-12-15 11:57:46 -08:00
Bharat Mediratta a0b7d397dd Amend db00958cee by extending the system
user_agents.php instead of replacing it.  This lets us avoid having to
reformat the file to get File_Structure_Test to pass and will let us
take advantage of further improvements ot the Kohana version of the file.
Additional fix for #1436.
2010-12-15 11:44:29 -08:00
Bharat Mediratta 79740a2c77 Move photo/movie file extension validation into the model. Fixes #1524. 2010-12-14 21:19:25 -08:00
Bharat Mediratta 5fb5d10e5a Delete the temporary "user" value from the session when upconverting
the admin account post-install.  Fixes #1511.
2010-11-28 12:18:08 -08:00
Bharat Mediratta eb010554ff Replace self::func() with <helper_name>::func() for all public APIs
and constants to make overloading easier.  Fixes #1510.
2010-11-28 11:27:25 -08:00
Bharat Mediratta 76b6daefaa Clean up phpDoc on get() a little more 2010-11-27 20:42:53 -08:00
Bharat Mediratta f91819441c Tighten up the phpDoc for get(). 2010-11-27 19:48:16 -08:00
Kriss AndstenandBharat Mediratta d2be26e407 Slightly more invasive version, but cleaner on the eyes. 2010-11-28 11:44:23 +08:00
Kriss AndstenandBharat Mediratta 2ed83fcd95 Patch from ticket 1503, making rest/items behaviour consisten with rest/item behaviour. 2010-11-28 11:44:23 +08:00
Bharat Mediratta 5f4ab7fd76 Shuffle up the way we figure out which image to rebuild next so that
multiple concurrent tasks actually work in parallel and don't stomp
on each other.  Fixes #1498.
2010-11-21 13:03:02 -08:00
Bharat Mediratta 12b77c7ef4 Move the sys_getloadavg() call into the template since that's what we're doing for other similar calls 2010-11-20 20:54:16 -08:00
Bharat Mediratta 13cc0087ec I don't run these, I doubt anybody does. Deleting 2010-11-20 20:43:18 -08:00
Bharat Mediratta dd2b815ab2 Add Bengali (bn_BD). 2010-11-18 21:33:30 -08:00
Bharat Mediratta c1573d8ef2 Use sys_getloadavg() instead of reading /proc/loadavg. Fixes #1491. 2010-11-18 13:09:10 -08:00
Bharat Mediratta 8d030cea64 Fix a bug where simultaneous deletes of the same item can result in it
deleting the first item row in the database.  The root issue is a bug
in Kohana that's addressed in dca9b5f3fc
but in this change we deal with the fact that reloading an item can
result in an instance of the item that's unloaded.  In those cases, we
should just ignore it and move on.  Fixes #1489.
2010-11-18 09:52:40 -08:00
Tim Almdal 86790d4464 Return the admin check as part of the block structure as opposed to printing
it directly to the output.  I had problems with the admin check messing up the
AJAX calls on the module update page.  And it went away after this fix.
2010-11-09 21:08:14 -08:00
Bharat Mediratta e87c502ede Tie the image cachebuster to the file mtime instead of
Item_Model::$updated since we want the url to be stable whenever
possible.  Fixes #1482.
2010-11-09 12:48:07 -08:00
Bharat Mediratta dae8354491 Updated item::random_query() PHPdoc to include example usage 2010-11-08 19:52:43 -08:00
Bharat Mediratta 945e79b171 Add a pure javascript mechanism for filtering advanced properties. Partial fix for #1478. 2010-11-08 13:51:51 -08:00
Bharat Mediratta 853a3acc9b Implement module::clear_all_vars($module_name)
Also switch from using ORM to Database_Builder for the SQL because it's
cleaner, and clean up the test.  Fixes #1479.
2010-11-08 11:45:14 -08:00
Bharat Mediratta 359a081f15 Add Malay as 'Bahasa Melayu' 2010-11-07 22:08:20 -08:00
Bharat Mediratta d503513eca Create item_before_create and item_before_update events, and make
Item_Model::data_file public.  This allows us to intercept and tweak
data files before saving the model which enables the max_size module.
2010-11-06 21:54:28 -07:00
Bharat Mediratta f01fad1cd0 Deal in integers when doing aspect ratio operations. Fixes #1470. 2010-10-31 12:21:06 -07:00
Bharat Mediratta dff1a53696 All modules should be named Xxx_Core for extensibility. Fixes #1458. 2010-10-25 21:05:31 -07:00
Bharat Mediratta 4dc451629c Allow access to the rest module when the gallery is wholly private. Fixes ticket #1452. 2010-10-24 17:03:40 -07:00
Bharat Mediratta db00958cee Add MJ12bot and Speedy Spider to the robot list. 2010-10-11 21:06:00 -07:00
Bharat Mediratta c4454f1f07 Copy system/config/user_agents.php over to gallery/config so that we can add to the list 2010-10-11 21:05:39 -07:00
Bharat Mediratta 84731437a7 Identify robots and don't let them save sessions. 2010-10-09 16:24:58 -07:00
Bharat Mediratta 349071f501 Change version to "3.0+ (git)". 2010-10-07 22:16:18 -07:00
Bharat Mediratta 4b4a2f8d8d Set the version to 3.0 final (woot!). 2010-10-04 23:55:19 -07:00
Bharat Mediratta 3c40476b34 Not sure why digibug::close_window() changed in the listing, but it looks fine here. 2010-10-04 23:42:07 -07:00
Bharat Mediratta df378fcca8 Don't wrap the action in url::site() -- form::open() will do that for us. Fixes #1417. 2010-10-03 22:10:05 -07:00
Bharat Mediratta a153ca0829 Detect the case where there are no more broken images and skip to the end. Fixes #1414. 2010-10-02 17:04:37 -07:00
Bharat Mediratta 161bbb9ba3 Proxy the BasicAuth authentication header in htaccess_works() so that
if the entire Gallery is behind BasicAuth we share the same
credentials as the browser.  Fixes #1413.
2010-10-02 16:44:31 -07:00
Bharat Mediratta 62f1bb06a2 Set the User-Agent field to "Gallery3" by default. Fixes #1408. 2010-10-02 13:46:47 -07:00
Bharat Mediratta c0022dc3c3 Fix a bug in the way we set the mime type for protected image renders.
Also whitelist the digibug controller so that it's accessible when the
gallery is private, and don't expire old proxies right away since
Digibug may request the full size multiple times for different preview
operations.

Fixes ticket #1410.
2010-10-01 21:45:45 -07:00
Bharat Mediratta 86981c5afb Use the "loading" image from themes/wind since it's no longer in gallery3/lib. 2010-10-01 21:09:14 -07:00
Bharat Mediratta f84782d620 Stop caching all module variables in the vars table using the
name=_cache row.  If that overflows, it will cause us to be unable to
load variables, and we can't recover from that.

Instead, use the Cache table.  Bump the gallery module to v40.  Fixes
ticket #1405.
2010-09-29 20:47:43 -07:00
Bharat Mediratta ef8751468b Base64 encode the data result if the encoding param is set to "base64".
Fixes #1400.
2010-09-25 13:27:35 -07:00
Bharat Mediratta 85637a0826 Fix a bug introduced recently in
f84c4a6192 where we were generating bad
SQL.  If we're checking for a conflict on a new item, the id is null
and we were doing a comparison that resulted in "id <> NULL" which
won't work -- in that case we need "id IS NOT NULL".

Fixes #1393.
2010-09-23 20:45:27 -07:00
Bharat Mediratta 790bf4e871 Prioritize using the value in graphics_toolkit_path over the standard
path so that if you change that value in Admin > Settings > Advanced
we prefer it over other paths (which may be restricted by
open_basedir).  Fixes #1395.
2010-09-22 21:35:49 -07:00
Bharat Mediratta fad1f05203 The Kohana folks removed the cache cleanup code back in
http://dev.kohanaframework.org/projects/kohana2/repository/revisions/4605

So now our cache entries don't expire.  For now, do cache expiration
whenever we render Admin > Maintenance, since that's the type of place
that users will go when they want their cache to expire anyway.
2010-09-18 17:46:28 -07:00
Bharat Mediratta 8135429430 Checkpoint. 2010-09-17 13:39:48 -07:00