Commit Graph
2269 Commits
Author SHA1 Message Date
mamouneyyaandBharat Mediratta 5931cc872d proposed fix for ticket #1664 2011-04-02 15:59:54 -07:00
Bharat Mediratta fa6f233603 Centralize our encoding code into a new helpers and use
mb_convert_encoding if possible.  Build on the work in
c791ae96d5 by momo-i.  Fixes #1660.
2011-03-27 11:31:34 -07:00
Bharat Mediratta 06d1a5221c Merge branch 'master' of git://github.com/ckieffer/gallery3 2011-03-27 11:20:10 -07:00
Bharat Mediratta dc21cf36b6 Change the $thumb_proportions variable to be a theme callback which
takes an item as an argument.  This will let us figure out proportions
in the case where a module has defined custom thumbnail sizes.
2011-03-20 10:25:59 -07:00
Bharat Mediratta 3fd7debd2f Fix a bug where the placeholder %hide-url didn't match the variable in the assoc. array. Follow on for #1624 2011-03-15 00:53:35 -07:00
Bharat Mediratta c38d4695a0 Add missing phpDoc for the extra Item_Model argument to graphics calls
and make the param optional.  #1646.
2011-03-05 15:46:04 -08:00
Bharat Mediratta 5ff6409a08 Merge branch 'master' of git://github.com/colings/gallery3 2011-03-05 15:31:16 -08:00
Chad Kieffer e90493aab3 Translate user Web Site label. Link web site on user profile page. 2011-03-02 21:11:49 -07:00
colings ca47b887f5 Added extra arg to gallery_graphics calls and updated users 2011-02-23 20:31:07 -06:00
colings 68edb2454d Added 'item' to parameters passed to graphics rules 2011-02-21 15:40:58 -06:00
colings d759d47ef9 Merge remote branch 'upstream/master' 2011-02-13 10:46:43 -06:00
Bharat Mediratta 8437a85ac8 AUTO_CHECK_INTERVAL --> upgrade_checker::AUTO_CHECK_INTERVAL
Fixes #1624
2011-01-29 08:37:12 -08:00
Bharat Mediratta bc49680938 Update XSS golden file 2011-01-21 23:09:27 -08:00
Bharat Mediratta 423daa52d5 Update copyright to 2011. 2011-01-21 23:01:06 -08:00
Bharat Mediratta 08c41f2976 Add "html_attributes" theme callback to allow modules to inject attributes into
the <html> element, including things like namespaces.   Fixes #1615.
2011-01-21 00:07:00 -08:00
Bharat Mediratta 56e6cb998f Change the [x] close box to "(remind me later)". #1605. 2011-01-17 21:37:51 -08:00
Bharat Mediratta 83bf1d767b Fix typo: upgrade_check -> upgrade_checker
#1605.
2011-01-17 21:18:24 -08:00
Bharat Mediratta 20ae106c22 Display a message in the "Check for Gallery upgrades" block when
there's a newer version available, even if the user has dismissed the
site status message.  #1605.
2011-01-17 21:16:43 -08:00
Bharat Mediratta 45caba09f8 Move the code that clears the upgrade_check site status message to the
upgrader so that it's cleared any time we run an upgrade.  Part of
2011-01-17 20:03:11 -08:00
Bharat Mediratta 76411d7d6d Rename BUILD_NUMBER to .build_number so it's not so loud. 2011-01-17 17:34:19 -08:00
Bharat Mediratta 29be21bb0d Add BUILD_NUMBER to the security check in .htaccess
Change BUILD_NUMBER to be .ini format and add a big "do not edit" comment.
2011-01-17 17:27:16 -08:00
Bharat Mediratta 14ae5d8544 Update version checking code to expect "branch_" as the prefix for
all branch related lines.  For #1605.
2011-01-17 17:07:32 -08:00
Bharat Mediratta 66bb496b6c If the logged in user is an admin and it's been more than 7 days since
the last check and auto upgrade checking is enabled, fire off an XHR
to check for a possible upgrade.  Finishes off #1605.
2011-01-16 23:14:57 -08:00
Bharat Mediratta 167f635a6c Add arguments to random::int() to match mt_rand(). Follow on to cd48b89f31
for #1527.
2011-01-16 23:06:19 -08:00
Bharat Mediratta 70abfb2a20 Upgrade checking code is now here, along with a bump of the Gallery
module to v46.  There's a new block in the admin dashboard which
controls whether automatic checking happens, and lets you check
immediately.  If a newer version is detected, a site status message
appears for admins providing upgrade instructions.

Automatic checking is not yet implemented (even though the UI claims
that it exists).  This is all for #1605.
2011-01-16 22:16:09 -08:00
Bharat Mediratta 84d576606d Change the value column of the messages table from a varchar(255) to a
text.  Fixes #1612.
2011-01-16 21:46:03 -08:00
Bharat Mediratta b78b109018 Fix indentation. 2011-01-16 17:10:30 -08:00
Bharat Mediratta ac44e9c930 First step in setting up version checking.
We now have two types of packages (release, git).  Instead of using
constants, we now have gallery::version_string() which returns the
current version string.  If you're on a release package, then the
version string looks like:

  3.0 (Santa Fe)

If you're on a git package, then the version string looks like this:

  3.0.1 (branch 3.0.x build 3)

We track the build number in a new file in the gallery3 root called
BUILD_NUMBER which we will update periodically with the latest
build number for each branch.
2011-01-16 16:58:58 -08:00
Joe7andBharat Mediratta 0020f87d6a Fixed paging for albums ordered by random.
MySql has problems when comparing float values against -seemingly same- float input, see http://dev.mysql.com/doc/refman/5.0/en/problems-with-float.html for details.
Fixes #1610
2011-01-16 16:58:58 -08:00
Bharat Mediratta 44da46abd4 Golden file updates for xss and controller authentication. 2011-01-15 15:11:37 -08:00
Bharat Mediratta f0dd16efc4 Revive the code from Cache_Driver::exists and put it into a helper
function in the test so that we can keep our tests functioning.
Follow on to 66fd8c7518 for #1559.
2011-01-15 14:59:25 -08:00
Bharat Mediratta ee13b934f4 Fix all the head() and admin_head() theme callbacks to return the
results of the $theme->css() and $theme->script() calls.  This handles
the case where combining scripts/css returns HTML instead of putting
it in the queue for combination.  Fixes #1611.
2011-01-15 13:14:43 -08:00
Bharat Mediratta 376f09c4e1 Reorganize the url() function out from in the middle of the script/css combining functions. 2011-01-15 12:47:15 -08:00
Bharat Mediratta 09d34696a1 Update comments to annotate what data is where during the process.
Follow-on for #1518.
2011-01-11 17:54:33 -08:00
Bharat Mediratta e3df9c1611 Merge branch 'Ticket#1518' of git://github.com/Joe7/gallery3 2011-01-11 17:53:16 -08:00
Bharat Mediratta ee53744aa7 Two improvements to Joe's fix for #1504:
1) Trap all exceptions, eg dns or connectivity issues and
   report back in the form (but put the stack trace in the logs)
2) Rename "noconn" to "no_connection"
2011-01-11 16:59:57 -08:00
Bharat Mediratta f80b5959f1 Merge branch 'Ticket#1504' of git://github.com/Joe7/gallery3 2011-01-11 15:38:03 -08:00
Bharat Mediratta 92db7f4218 Update some comments. 2011-01-11 15:24:40 -08:00
Bharat Mediratta 252aba9eae Merge branch 'fix-viewable2_master' of git://github.com/BigMadWolf/gallery3 2011-01-11 15:17:05 -08:00
Joe7 049f2af1c9 Returning 2 flags from l10n_client::validate_api_key(), 1 to reflect if connection was built up properly (just a boolean, not distuingishing between reasons in case of a failure), the other to reflect API validating success status.
Using this presenting a slightly more meaningfull error msg to user in case the connection would fail.
Fixes Ticket #1504
2011-01-12 00:05:11 +01:00
Joe7 7f6d87166d Removed check as input value is compared against dataset of validated values, and request is only processed further in case of a match. => this is unnecessary 2011-01-11 23:16:05 +01:00
Bharat Mediratta 84e08a6283 Don't resize if the target size is the same as the original. Fixes #1602. 2011-01-11 01:04:10 -08:00
Bharat Mediratta 5ac49d497f Create new APIs for allowing themers to control what CSS/JS get
combined and when.  Backwards compatible in that old themes will work,
but their CSS/JS will no longer be combined unless they make some
changes.  Fixes #1600.
2011-01-10 22:20:12 -08:00
Bharat Mediratta 23eaec7063 Stop using "which" to find binaries. Create system::find_binary()
which traverses the $PATH and returns any executable binary of the
appropriate name that it can find.  Fixes #1555.
2011-01-10 15:49:15 -08:00
Bharat Mediratta d557b2a63e Allow File_Proxy_Controller to run in private gallery mode since it
does all the right permission checks.  This prevents a hotlink to a
private photo in a private gallery from kicking the user out to a
login page.  Fixes #1594.
2011-01-10 14:50:30 -08:00
Bharat Mediratta bd6bd029a7 Fix up the version detecting regex for GraphicsMagick and don't crash
if the regex doesn't return properly.  Follow on to
3ec0ba956d for ticket #1595.
2011-01-10 14:04:15 -08:00
Bharat Mediratta 20ba7b6bee Merge branch 'graphics/detect_toolkits()_refactoring' of git://github.com/Joe7/gallery3 2011-01-10 13:54:20 -08:00
colings 02a349f68a Merge remote branch 'upstream/master' 2011-01-09 11:43:45 -06:00
Jérémy Subtil 24c0b69847 Fixed item controllers so that any item position is computed correctly, when some other items belonging to the same parent album are not viewable.
Changed depracated calls to item_Model::get_position() to item::get_position().
2011-01-09 12:14:46 +01:00
Jérémy Subtil 0d7e951aa5 Moved item_Model::get_position() method to the Item helper. It now calls the viewable() method on every query. 2011-01-09 12:14:46 +01:00