Commit Graph
1018 Commits
Author SHA1 Message Date
Bharat Mediratta f3ba69c1d6 Make sure that helper functions are all static. Add new
File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php
2009-01-14 04:12:02 +00:00
Tim Almdal 383ec9c22c Initialize the model_cache:: as an array and use sub arrays to maintain the cache 2009-01-14 03:22:17 +00:00
Tim Almdal 7305026fd8 make model_cache::get() a static function 2009-01-14 02:34:39 +00:00
Bharat Mediratta ca36a04f28 Fix preamble 2009-01-14 01:20:42 +00:00
Tim Almdal c9e6b1ef44 Correct the initial value get active blocks 2009-01-14 00:22:17 +00:00
Tim Almdal 7043d17040 Since module_Core is static the methods, get_var, set_var, etc should be static 2009-01-14 00:09:33 +00:00
Chris Kelly 1fb85dfac5 moved graphics toolkit logo images to g3. approval to redistribute from each project is in my email archives if this comes up in the future 2009-01-13 14:58:02 +00:00
Bharat Mediratta 074cbd860d Call 'site' themes 'Gallery' themes since site means less to users. Fix swapped messages 2009-01-13 11:00:46 +00:00
Bharat Mediratta 38ddf559f0 Put up a nice message if there are no other themes available to
choose.
2009-01-13 10:57:38 +00:00
Bharat Mediratta 35a529cd86 Change admin/themes to show both styles of themes side by side. This
eliminates the menu, which is kind of clunky.

While I'm at it, let's call the "regular" themes a "site theme" so we
have "site" and "admin" themes.
2009-01-13 10:53:06 +00:00
Chad Kieffer 5f17ae4f02 Update quick edit markup, styles, js. One step towards jquery ui theme. 2009-01-13 06:20:35 +00:00
Bharat Mediratta 16bebdca06 Make the admin/graphics UI mimic admin/themes with a single selected
toolkit above, and other available ones below.
2009-01-13 04:56:29 +00:00
Bharat Mediratta 03e31ed5cc Fix indentation. 2009-01-13 04:10:50 +00:00
Bharat Mediratta a17b137f95 Update translations to put anchors directly into the translation. 2009-01-13 04:09:29 +00:00
Bharat Mediratta 1341d13ca5 Reverse the last change; forgot that {$key} is treated specially
inside a string.  We could do "{{{$key}}}" but that's misleading.
2009-01-13 04:02:41 +00:00
Bharat Mediratta 174ea7cc9a Use variable interpolation to reduce code size 2009-01-13 03:53:31 +00:00
Bharat Mediratta ff6791f576 Models should be named in adjective_noun form to make pluralizatoin
more intuitive.

Renamed Translations_Incoming to Incoming_Translation to suit.
2009-01-13 01:05:11 +00:00
Bharat Mediratta c5f77510a7 Refactor dashboard block handling out into a dashboard helper so that
module installers don't have to know the grotty details of how it works.
2009-01-12 08:51:54 +00:00
Bharat Mediratta bc421a615a Implement deleting dashboard blocks.
* Refactor blocks so that they have a separate id vs css_id.  This way
  we can have a unique identifier for each visual block.

* Store blocks with a random id as their unique identifier

* Add Admin_Dashboard::remove_block() and modify
  themes/admin_default/views/block.html.php to call it when you click the
  remove box.
2009-01-12 08:26:38 +00:00
Chad Kieffer ce6d7b8d37 Keep CSS selector attribute definitions alphabetized. 2009-01-12 08:24:23 +00:00
Chad Kieffer 8a79d328ed Minor markup cleanup. 2009-01-12 08:20:39 +00:00
Chad Kieffer 42e635bff0 Theme admin refinement. Make more room to show the preview by enlarging the iframe and removing the heading above it. 2009-01-12 07:57:13 +00:00
Bharat Mediratta ae73ef3d57 Updated for new Form_Submit API.
OLD:
  $form->submit("Foo")  -->  <input type="submit" value="Foo">

New:
  $form->submit("foo_button")->("Foo") --> <input type="submit" name="foo_button" value="Foo">

Mostly we don't care what the button is so we leave the name blank.
2009-01-12 07:50:04 +00:00
Bharat Mediratta b19729435c Dashboard blocks are now data driven, and you can add new blocks to
both the sidebar and the center content area from a dropdown at the
top of the dashboard sidebar.
2009-01-12 07:39:53 +00:00
Bharat Mediratta ef303bde3e Gallery version now lives in a variable 2009-01-12 07:39:02 +00:00
Bharat Mediratta 11fb04cdde Only the admin dashboard has a sidebar now.
admin.html.php looks for $sidebar and renders the page appropriately
if one exists.  But only admin_dashboard has one currently.
2009-01-12 04:04:55 +00:00
Bharat Mediratta 70b9608275 Fix up the colors and background images for rows in gAdminMaintenance. 2009-01-11 22:56:52 +00:00
Bharat Mediratta b98f498ed6 Change admin/graphics to avoid using radio buttons. Instead, when you
hover over a toolkit it changes color and your cursor becomes a
pointer.  Clicking changes the toolkit.
2009-01-11 22:14:44 +00:00
Bharat Mediratta 46b976819d Deleted unused MY_Form_Radio 2009-01-11 21:36:24 +00:00
Bharat Mediratta 713ef05b0f Site menu restructure:
* Add 'Scaffold' link to make it more obvious what's going on there
* 'Home' link now goes to albums/1
* 'Admin' is now pushed to the far right.
2009-01-11 21:35:17 +00:00
Bharat Mediratta d387b31d18 Merge the site admin menu in under the regular Admin menu. 2009-01-11 18:58:00 +00:00
Andy Staudacher 6510fae661 Remove path normalization, the current normalization code didn't go far enough anyway. 2009-01-11 05:28:48 +00:00
Andy Staudacher 5e0d0f546a MySQL strict fix for Item_Model test. Set all fields that have no default value. 2009-01-11 05:19:09 +00:00
Andy Staudacher 4757126acc Fix ORM MPTT tests for MySQL strict mode (can't omit Iten type in inserts, it doesn't have a default value). 2009-01-11 05:09:06 +00:00
Andy Staudacher 9406e80c90 Fix Access_Helper tests for MySQL strict mode (can't omit Iten type in inserts, it doesn't have a default value). 2009-01-11 03:28:57 +00:00
Bharat Mediratta 01666c5579 Fix all file structure issues (tabs, bad preambles, etc).
Note: installer/install.php is now on the "direct access" list.
2009-01-11 02:27:00 +00:00
Bharat Mediratta afb90768b4 Remove stray blank line, convert single to double quotes. 2009-01-11 02:06:36 +00:00
Bharat Mediratta 6c2aef1b4a Fix windows-style line endings. 2009-01-11 02:03:42 +00:00
Bharat Mediratta 7f52500cf9 Allow .txt.php views 2009-01-11 02:02:43 +00:00
Bharat Mediratta 4312563e8b Reset module_names / modules early in load_modules() so that unit test framework can dump the loaded modules after switching databases even if the modules table doesn't exist yet 2009-01-11 01:57:41 +00:00
Bharat Mediratta 0033887ba8 Rework the way we do theme selection. Show the currently active theme
and then thumbnails for all the other available themes.  If you select
one of the other available themes, it gives you a preview pane where
you can look at either the main page or the site admin page with the
new theme, then choose to activate it if you like it.
2009-01-11 00:24:39 +00:00
Bharat Mediratta 2f9eae867c Let admins override the theme with a query param 2009-01-11 00:19:00 +00:00
Felix Rabinovich 5ee03eb9c8 Save individual theme values 2009-01-10 22:36:06 +00:00
Felix Rabinovich 705c55fb79 Submit theme values 2009-01-10 22:04:49 +00:00
Felix Rabinovich 72e9d20f3c Display theme details 2009-01-10 19:41:43 +00:00
Bharat Mediratta 3385105842 Markup cleanup. It's more semantic now, but it doesn't look quite as nice (yet). 2009-01-10 19:19:36 +00:00
Bharat Mediratta a2dbbf32ab style cleanup. 2009-01-10 19:10:52 +00:00
Felix Rabinovich 006f18dc7a Split themes into two tabs for regular and admin themes 2009-01-10 08:00:43 +00:00
Bharat Mediratta 9b90b4b0cd Use the theme's avatar as the default if Gravatar doesn't have one. 2009-01-10 06:18:35 +00:00
Bharat Mediratta a7feeb576f Big set of changes to comments, with related changes to akismet and
user modules.

* Don't delete vars when we delete a module.  This makes
  reinstalling a module a lot easier.

* Add user::lookup() as the preferred way to load a user, so that
  other modules don't delve into the user module (that'd be a
  problem when we swap out user modules)

* Notify site admins if Akismet is not fully configured

* Bundle all server variables into the comment so that if/when we
  re-check the comment, we are not using the server info from the
  site admin's request.

* Update Akismet to grab request context data from the comment

* Pre-seed comment fields if we have a logged in user.  Update
  comment::create() API to clarify it for this.

* Delete comment::update(), that's a controller function.

* Add url to User_Model

* Add author_name() author_email() and author_url() to
  Comment_Model.  It'll return the appropriate values depending
  on whether the comment was left by a logged in user or a guest.

* Use resetForm() instead of clearForm() when we reload the
  comment form after ajax submit, this way we preserve the
  pre-seeded values.

* In the user profile page, ignore blank passwords.
2009-01-10 00:34:23 +00:00