Commit Graph
50 Commits
Author SHA1 Message Date
Chad Parry 97c3ded2ba Better validation for uploaded files, especially where third-party modules might make a mistake.
Squashed commit of the following:

commit f2336a5aaa
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 18 21:56:10 2011 -0600

    Behave reasonably if the image cannot be resized.

commit e06b20738d
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 18 21:10:08 2011 -0600

    Adding an image representing a broken thumbnail.
    This image was derived from the equivalent Gallery2 icon. It uses the same washed-out gray color scheme as the Gallery3 missing_movie icon.

commit 4e3964527b
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 18 20:30:28 2011 -0600

    Initialize legal file arrays correctly.

commit e9862d8fbc
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 18 20:20:19 2011 -0600

    Correction for the merge conflict markers I accidentally committed.

commit 5e62d327a8
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 18 20:17:36 2011 -0600

    Expand the legal_file events to include separate photo and movie events, and to support MIME types.

commit f0bfd1fef0
Merge: 72f3fc4 db73413
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 18 19:49:25 2011 -0600

    Merge branch 'master' of https://github.com/gallery/gallery3 into rawphoto

    Conflicts:
    	modules/gallery/helpers/system.php
    	modules/gallery/tests/System_Helper_Test.php

commit db734130c5
Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater@menalto.com>
Date:   Mon May 16 21:38:07 2011 -0700

    Automated update of .build_number to 153 for branch master
    Last update: 9aeb824aa1 (1 commits ago)

commit 8549ba30ca
Author: Chad Kieffer <ckieffer@gmail.com>
Date:   Mon May 16 22:37:09 2011 -0600

    Stop IE 9 album grid craziness. Thanks floridave. Fixes #1430.

commit 9aeb824aa1
Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater@menalto.com>
Date:   Sun May 8 11:43:38 2011 -0700

    Automated update of .build_number to 152 for branch master
    Last update: 7c80e6ef84 (1 commits ago)

commit 57f7e42a12
Author: Bharat Mediratta <bharat@menalto.com>
Date:   Sun May 8 11:42:40 2011 -0700

    Add the item id to the print_proxy line so that we have a little more info
    about what the original was, and extend the timeout to 90 days from 10.
    Fixes #1733.

commit 7c80e6ef84
Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater@menalto.com>
Date:   Fri May 6 11:48:43 2011 -0700

    Automated update of .build_number to 151 for branch master
    Last update: 5d09cbff04 (1 commits ago)

commit 80dda6f64f
Merge: 5d09cbf 46da011
Author: Bharat Mediratta <bharat@menalto.com>
Date:   Fri May 6 11:48:13 2011 -0700

    Merge pull request #52 from chadparry/tempnam

    Fixes #1732

commit 5d09cbff04
Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater@menalto.com>
Date:   Thu May 5 21:53:39 2011 -0700

    Automated update of .build_number to 150 for branch master
    Last update: 011eaa6480 (1 commits ago)

commit d5a31ceede
Author: Tim Almdal <tnalmdal@shaw.ca>
Date:   Thu May 5 21:53:10 2011 -0700

    Fix for ticket 1275. Do the same checking as Kohana uses and don't worry about calling the utf8_encode routine.
    Corrected the error messages and also added a check to insure the XML Parser extension is loaded as we still need the utf8_encode function from it.

commit 011eaa6480
Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater@menalto.com>
Date:   Thu May 5 14:53:06 2011 -0700

    Automated update of .build_number to 149 for branch master
    Last update: 05ecfda36b (1 commits ago)

commit 5bae21864f
Author: Bharat Mediratta <bharat@menalto.com>
Date:   Thu May 5 14:52:47 2011 -0700

    Follow-on to 6f916e49d5 -- don't make
    database calls if Gallery isn't installed, else we fail to bounce the
    user to the installer on fresh packages.  #1637.

commit 46da011bf6
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 4 17:51:00 2011 -0600

    Remove a newline I accidentally introduced.

commit 5c6c71ffcd
Merge: d2331bf 05ecfda
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 4 17:49:42 2011 -0600

    Merge branch 'master' into tempnam

commit d2331bf434
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 4 17:48:25 2011 -0600

    Simplified the temp_filename implementation and removed the mocks.

commit 72f3fc46f6
Author: Chad Parry <github@chad.parry.org>
Date:   Wed May 4 17:22:15 2011 -0600

    Avoid "self::" because Kohana can't override it.

commit 05ecfda36b
Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater@menalto.com>
Date:   Mon May 2 21:38:50 2011 -0700

    Automated update of .build_number to 148 for branch master
    Last update: 97400b7815 (2 commits ago)

commit 229bfc5c7c
Author: Bharat Mediratta <bharat@menalto.com>
Date:   Mon May 2 21:37:04 2011 -0700

    Track and redirect core.DownloadItem requests properly.  This can
    happen if the G2 was imported with rewrite on, so the g2_url in the
    g2_map table has a shortened url, but then rewrite is disabled and the
    .htaccess mod_rewrite rules are sending over a &g2_view=core.DownloadItem
    request.  Fixes #1728.

commit 68370b92f5
Author: Bharat Mediratta <bharat@menalto.com>
Date:   Mon May 2 21:36:17 2011 -0700

    Map the G2 album highlight thumbnail derivative id to the G3 album's
    thumbnail.  Fixes #1729.

commit 13dbd3515b
Merge: f0f094c 97400b7
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 20:33:02 2011 -0600

    Merge branch 'master' of https://github.com/gallery/gallery3 into rawphoto

commit f0f094c3f7
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 20:22:49 2011 -0600

    Explain the conditional rename in item::save() with a comment.

commit 1b3a6b85c1
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 18:29:34 2011 -0600

    Improve the comment explaining why the data_file extension is important.

commit c3e8c1e3b5
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 18:12:56 2011 -0600

    The data_file field is public, so we don't need to supply an accessor method.

commit 0e844766ba
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 16:40:55 2011 -0600

    Change the signature of system::tempnam to something more appropriate for Gallery.

commit 5c9a3b3f39
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 23 21:19:47 2011 -0600

    Create a tempnam substitute that safely creates files with a given extension.

commit 2375a02e2c
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 16:40:55 2011 -0600

    Change the signature of system::tempnam to something more appropriate for Gallery.

commit a8ca9dcf9e
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 16:10:06 2011 -0600

    Change the name of the extensions helper to legal_file.

commit 7e61a01a96
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 30 16:08:49 2011 -0600

    Change the name of the extensions helper to legal_file.

commit 4c2b2ebd3f
Author: Chad Parry <github@chad.parry.org>
Date:   Wed Apr 27 20:52:35 2011 -0600

    Remove a newline at the end of the file that I accidentally introduced.

commit 6d564f185e
Merge: 7ff485f 4060640
Author: Chad Parry <github@chad.parry.org>
Date:   Wed Apr 27 20:35:58 2011 -0600

    Merge branch 'master' of https://github.com/gallery/gallery3 into rawphoto

commit 7ff485fa48
Author: Chad Parry <github@chad.parry.org>
Date:   Wed Apr 27 20:29:06 2011 -0600

    Move the extensions helpers out of the Kohana system directory and into their own Gallery Extensions class.

commit 26585fed03
Merge: 809567f c8f90e8
Author: Chad Parry <github@chad.parry.org>
Date:   Sun Apr 24 08:28:39 2011 -0600

    Merge branch 'master' of https://github.com/gallery/gallery3 into rawphoto

commit 809567f128
Author: Chad Parry <github@chad.parry.org>
Date:   Sun Apr 24 08:10:04 2011 -0600

    Expose the data file field.

commit fcb06bf175
Author: Chad Parry <github@chad.parry.org>
Date:   Sun Apr 24 00:45:12 2011 -0600

    Don't assign to the item->name field if the name is unchanged, because the save method will crash.

commit c6ef706d70
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 23 22:55:59 2011 -0600

    Preserve old data files long enough for them to be available to event handlers.

commit 0d6a3a3cfc
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 23 21:19:47 2011 -0600

    Create a tempnam substitute that safely creates files with a given extension.

commit e149cf7238
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 23 16:39:25 2011 -0600

    Support data files that change their extension and MIME type.

commit 6702104f57
Author: Chad Parry <github@chad.parry.org>
Date:   Sat Apr 23 16:35:00 2011 -0600

    Resolve an infinite recursion that happens when the path caches are updated during saving.

commit 944cb72eea
Merge: 567522b 5af74d4
Author: Chad Parry <github@chad.parry.org>
Date:   Fri Apr 22 14:10:42 2011 -0600

    Merge remote branch 'origin/master' into rawphoto

commit 567522bfa0
Author: Chad Parry <github@chad.parry.org>
Date:   Thu Apr 21 20:12:32 2011 -0600

    Add an event for when a new graphics toolkit is chosen.

commit 31ba081b79
Author: Chad Parry <github@chad.parry.org>
Date:   Thu Apr 21 02:06:53 2011 -0600

    Add an event that will collect all valid filename extensions.
2011-05-18 22:01:51 -06:00
Bharat Mediratta 423daa52d5 Update copyright to 2011. 2011-01-21 23:01:06 -08:00
Bharat Mediratta 6ac82bc6b7 Detect safe_mode and abort the install. Fixes #1534. 2010-12-16 11:33:41 -08:00
Bharat Mediratta 45c63f4d11 Use mt_rand() instead of rand() since it provides better portability.
Fixes #1527.
2010-12-15 12:48:56 -08:00
Bharat Mediratta 97a5656296 Check for the PHP Ctype extension. Fixes ticket #1474. 2010-11-08 11:09:06 -08:00
Bharat Mediratta c31e9f1188 Add a check for short_open_tag 2010-06-06 19:06:24 -07:00
Bharat Mediratta a63b0e8e8b Whitespace fixes 2010-06-06 19:04:15 -07:00
Bharat Mediratta c3c2b45280 Update the copyright to 2010. It's only 3 months into the year :-) 2010-03-03 10:15:34 -08:00
Andy Staudacher 824087416a Avoid PHP warnings when the DB host string has no port. 2010-02-14 17:07:31 -08:00
Tim Almdal 7778d4c050 Provide an error message when the sql in installer::empty_db fails. Also change the show tables not to specify a database as it will use the database in the active connection. Fixes ticket #963. 2010-01-06 10:11:03 -08:00
Bharat Mediratta 8cf0348e6c Make sure that we have the mbstring extension. 2009-12-29 11:36:52 -08:00
Tim Almdal 393896a701 Initialize the database config with the port number if it is specified. Also set it up so the mysqli constructor will split it into host and port for the call to the mysqli constructor. Fixes ticket: #780 2009-11-12 14:42:37 -08:00
Tim Almdal 86681eebf7 Move the check_environment into the installer helper and call it from the command line installer as well as the web installer. 2009-09-17 07:29:37 -07:00
Bharat Mediratta 3dd40bf97c Trim the input line to get rid of carriage returns on Windows. Fixes
ticket #740.  Thanks to jankoprowski!
2009-09-10 21:22:46 -07:00
Bharat Mediratta b8053c9ddf Rename "after_installer" to "welcome_message" in the code to make it
clearer what its purpose is.  Add some spacing in the theme for it
so that it's less cramped.
2009-09-10 21:10:20 -07:00
Bharat Mediratta 064038a24f Escape backslashes (\) in the $salt in create_admin() as they will
interfere with our hand rolled UPDATE statement.  Big thanks to
paulepanter.
2009-09-01 21:13:03 -07:00
Bharat Mediratta b3cac5c173 Suppress errors to mysql_connect(). We had this before, but it
appears to have been accidentally removed in 177a854d
2009-08-31 21:26:14 -07:00
Bharat Mediratta e4eedadcbb Add back mysql_fetch_object() call that I accidentally removed in my
rush to catch a plane.
2009-08-30 21:12:35 -07:00
Bharat Mediratta 31dcdcc6ad Remove unnecessary cleverness in stripping off the hyphen for mysql
version checks that was causing problems in the case where there's no
hyphen.  version_compare handles hypens fine.
2009-08-30 15:18:20 -07:00
Bharat Mediratta fd954fe86e Print out the version of MySQL that we found along with our error
message, which should resolve http://gallery.menalto.com/node/90646
2009-08-30 13:43:29 -07:00
Tim Almdal 1ce8643b80 Fix for #440. Basically add a check that the mysql version is > 5.0.0.
It was felt that actually listing the requirements might be overwhelming
to novice users.
2009-08-28 15:17:07 -07:00
Bharat Mediratta 177a854dbb Move the mysql_xxx() override function definitions inside
installer::connect(), otherwise they're defined before we call
check_environment, then we think we have mysql_query when we really
don't.
2009-06-28 19:23:19 -07:00
Bharat Mediratta 52ac0e7172 Remap mysql_xx() functions to their mysqli counterparts if the mysql
extension is unavailable.  Fixes ticket #393.
2009-06-13 17:06:34 -07:00
bharat c96b81db65 Fix a warning 2009-06-01 00:22:21 -04:00
Bharat Mediratta 994830f611 Fix the code to specify which columns its inserting into. Without
that it's fragile, and I broke it when I sorted the columns
alphabetically a day or two ago.
2009-05-29 18:04:54 -07:00
Bharat Mediratta 88a3d43ba9 Update all references to the core application to now point to the
gallery module.  This type of mass update is prone to some small bugs.
2009-05-27 16:17:29 -07:00
Bharat Mediratta baa220186e Suppress some warnings 2009-05-13 22:34:54 +00:00
Bharat Mediratta 5495037a3d Gee it's May already. Update copyright to 2009. 2009-05-13 20:04:58 +00:00
Bharat Mediratta 7008bfb5c3 Warn the user if they're attemping to reinstall into a database that
already has Gallery 3 tables.  Otherwise, permit it to continue.

We key this off of the existence of the g3_items table.  Theoretically
it's possible that the g3_items table is gone but other tables are
still there, which could mess things up.  I'm not going to worry about
that for now.

Fixes ticket #175
2009-05-13 00:32:19 +00:00
Bharat Mediratta 198297e0d4 Instead of putting after_install in the url, put it in the session.
This helps us to make sure that we only see the welcome message once.
2009-03-09 00:03:04 +00:00
Bharat Mediratta 72c7fed975 Log the user in as admin after running the web installer, and give
them a nice "Welcome to Gallery 3" dialog.  The text in there needs a
little work but it's a start.

In the process, re-build the install.sql using the scaffolding code.
2009-03-08 21:21:09 +00:00
Tim Almdal c04ff8e02f Change the pattern to identify tables that need prefix substitution to
mirror the drupal pattern of using braces {}.
2009-02-28 06:37:28 +00:00
Tim Almdal 0b9fe18a6b Both the command line and web installer installer now supports
creating tables with a table prefix.
There are still some queries that haven't been converted, so don't
start using prefixes yet.  However, if you do, you can login and
modify the user profile.
2009-02-27 19:26:21 +00:00
Bharat Mediratta 82ccbba124 Move private key generation into the installer so that we're not
generating it lazily.
2009-02-17 07:03:40 +00:00
Bharat Mediratta 6c59a19677 Get rid of InstallException and handle exceptions from create_admin()
properly.
2009-02-15 09:14:03 +00:00
Bharat Mediratta 8384cac5e3 Deal gracefully with bad mysql connection and database information. 2009-01-20 04:56:10 +00:00
Bharat Mediratta 681197a265 Web based installer. It's still got some rough edges, but you can now
do a complete CLI or web based install.
2009-01-20 00:54:02 +00:00
Bharat Mediratta d51955c8ef Pull the environment check out into a separate web page to simplify
the CLI installer.  Put a link to it in the footer of every web
install page.  Don't allow users to run it if Gallery 3 is already
installed.
2009-01-19 20:20:10 +00:00
Bharat Mediratta f5997a02e0 Incremental additions to the web installer. This is getting messy,
going to pause here and do some refactoring.
2009-01-19 19:05:22 +00:00
Bharat Mediratta bb73a2d896 Replace mysql_create_db with a mysql_query() call as recommended by the PHP manual. 2009-01-19 18:16:25 +00:00
Bharat Mediratta ebd811415a Stub of the web based installer. 2009-01-19 09:19:07 +00:00
Bharat Mediratta 31d6f18d56 implement already_installed() 2009-01-19 08:59:50 +00:00
Bharat Mediratta 7b4502ac6b setup_varpath() -> setup_var() 2009-01-19 08:51:26 +00:00
Bharat Mediratta ff19e4cfe8 Remove the prefix arg, we don't support it yet. 2009-01-19 07:48:48 +00:00
Bharat Mediratta 7c6ceae4b5 mysql_create_db() might not exist 2009-01-19 07:33:40 +00:00
Bharat Mediratta 0f8685fc9f Use mysqli_init() instead of mysqli() as our detector. 2009-01-19 05:21:37 +00:00
Bharat Mediratta 46d010e89d Simplification pass over the installer:
- Flattened the directory structure
- Greatly simplified structure in installer; it now only reports environmental
  checks that fail.  Simplified code that prints exceptions.  Use only mysql
  calls for the installer, but select mysqli automatically if it's available.
  Drop the response file; that's easily replicated with flag support
- Create a random password for the admin user
- Delete unused controllers
- Invert the form of the database config template to be mostly non-PHP
  with just a few PHP calls
2009-01-19 03:31:13 +00:00
Bharat Mediratta ad71e4263e Replace exec("mysql") call with directy mysql() calls. 2009-01-19 00:16:52 +00:00
Bharat Mediratta 631a7883ee Get rid of the driver libaries. Use mysql calls directly in the
installer for now.  If we detect mysqli, we can always use that as a
driver instead, but we don't require it for the installer.
2009-01-19 00:14:28 +00:00
Bharat Mediratta becc212209 Move installer.php out of helpers and get rid of helpers. 2009-01-18 23:59:19 +00:00