stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-03 05:31:16 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,129 Commits 4 Branches 0 Tags
8d030cea64c0e5934e4dbf5fc56fab87c7e253bb
Commit Graph
1848 Commits
Author SHA1 Message Date
Bharat Mediratta 8d030cea64 Fix a bug where simultaneous deletes of the same item can result in it 
deleting the first item row in the database.  The root issue is a bug
in Kohana that's addressed in dca9b5f3fc
but in this change we deal with the fact that reloading an item can
result in an instance of the item that's unloaded.  In those cases, we
should just ignore it and move on.  Fixes #1489.
 2010-11-18 09:52:40 -08:00
Tim Almdal 86790d4464 Return the admin check as part of the block structure as opposed to printing 
it directly to the output.  I had problems with the admin check messing up the
AJAX calls on the module update page.  And it went away after this fix.
 2010-11-09 21:08:14 -08:00
Bharat Mediratta e87c502ede Tie the image cachebuster to the file mtime instead of 
Item_Model::$updated since we want the url to be stable whenever
possible.  Fixes #1482.
 2010-11-09 12:48:07 -08:00
Bharat Mediratta dae8354491 Updated item::random_query() PHPdoc to include example usage 2010-11-08 19:52:43 -08:00
Bharat Mediratta 945e79b171 Add a pure javascript mechanism for filtering advanced properties. Partial fix for #1478. 2010-11-08 13:51:51 -08:00
Bharat Mediratta 853a3acc9b Implement module::clear_all_vars($module_name) 
Also switch from using ORM to Database_Builder for the SQL because it's
cleaner, and clean up the test.  Fixes #1479.
 2010-11-08 11:45:14 -08:00
Bharat Mediratta 359a081f15 Add Malay as 'Bahasa Melayu' 2010-11-07 22:08:20 -08:00
Bharat Mediratta d503513eca Create item_before_create and item_before_update events, and make 
Item_Model::data_file public.  This allows us to intercept and tweak
data files before saving the model which enables the max_size module.
 2010-11-06 21:54:28 -07:00
Bharat Mediratta f01fad1cd0 Deal in integers when doing aspect ratio operations. Fixes #1470. 2010-10-31 12:21:06 -07:00
Bharat Mediratta dff1a53696 All modules should be named Xxx_Core for extensibility. Fixes #1458. 2010-10-25 21:05:31 -07:00
Bharat Mediratta 4dc451629c Allow access to the rest module when the gallery is wholly private. Fixes ticket #1452. 2010-10-24 17:03:40 -07:00
Bharat Mediratta db00958cee Add MJ12bot and Speedy Spider to the robot list. 2010-10-11 21:06:00 -07:00
Bharat Mediratta c4454f1f07 Copy system/config/user_agents.php over to gallery/config so that we can add to the list 2010-10-11 21:05:39 -07:00
Bharat Mediratta 84731437a7 Identify robots and don't let them save sessions. 2010-10-09 16:24:58 -07:00
Bharat Mediratta 349071f501 Change version to "3.0+ (git)". 2010-10-07 22:16:18 -07:00
Bharat Mediratta 4b4a2f8d8d Set the version to 3.0 final (woot!). 2010-10-04 23:55:19 -07:00
Bharat Mediratta 3c40476b34 Not sure why digibug::close_window() changed in the listing, but it looks fine here. 2010-10-04 23:42:07 -07:00
Bharat Mediratta df378fcca8 Don't wrap the action in url::site() -- form::open() will do that for us. Fixes #1417. 2010-10-03 22:10:05 -07:00
Bharat Mediratta a153ca0829 Detect the case where there are no more broken images and skip to the end. Fixes #1414. 2010-10-02 17:04:37 -07:00
Bharat Mediratta 161bbb9ba3 Proxy the BasicAuth authentication header in htaccess_works() so that 
if the entire Gallery is behind BasicAuth we share the same
credentials as the browser.  Fixes #1413.
 2010-10-02 16:44:31 -07:00
Bharat Mediratta 62f1bb06a2 Set the User-Agent field to "Gallery3" by default. Fixes #1408. 2010-10-02 13:46:47 -07:00
Bharat Mediratta c0022dc3c3 Fix a bug in the way we set the mime type for protected image renders. 
Also whitelist the digibug controller so that it's accessible when the
gallery is private, and don't expire old proxies right away since
Digibug may request the full size multiple times for different preview
operations.

Fixes ticket #1410.
 2010-10-01 21:45:45 -07:00
Bharat Mediratta 86981c5afb Use the "loading" image from themes/wind since it's no longer in gallery3/lib. 2010-10-01 21:09:14 -07:00
Bharat Mediratta f84782d620 Stop caching all module variables in the vars table using the 
name=_cache row.  If that overflows, it will cause us to be unable to
load variables, and we can't recover from that.

Instead, use the Cache table.  Bump the gallery module to v40.  Fixes
ticket #1405.
 2010-09-29 20:47:43 -07:00
Bharat Mediratta ef8751468b Base64 encode the data result if the encoding param is set to "base64". 
Fixes #1400.
 2010-09-25 13:27:35 -07:00
Bharat Mediratta 85637a0826 Fix a bug introduced recently in 
f84c4a6192 where we were generating bad
SQL.  If we're checking for a conflict on a new item, the id is null
and we were doing a comparison that resulted in "id <> NULL" which
won't work -- in that case we need "id IS NOT NULL".

Fixes #1393.
 2010-09-23 20:45:27 -07:00
Bharat Mediratta 790bf4e871 Prioritize using the value in graphics_toolkit_path over the standard 
path so that if you change that value in Admin > Settings > Advanced
we prefer it over other paths (which may be restricted by
open_basedir).  Fixes #1395.
 2010-09-22 21:35:49 -07:00
Bharat Mediratta fad1f05203 The Kohana folks removed the cache cleanup code back in 
http://dev.kohanaframework.org/projects/kohana2/repository/revisions/4605

So now our cache entries don't expire.  For now, do cache expiration
whenever we render Admin > Maintenance, since that's the type of place
that users will go when they want their cache to expire anyway.
 2010-09-18 17:46:28 -07:00
Bharat Mediratta 8135429430 Checkpoint. 2010-09-17 13:39:48 -07:00
Bharat Mediratta 3e1743b21f Add a module variable containing extra paths to search for binaries. 
Fixes ticket #1384.
 2010-09-16 20:43:48 -07:00
Bharat Mediratta 64dfccc4ed Preserve the image extension on the temp file that we create for 
rotating images.  Some versions of GD won't work if we don't do this.
Fixes ticket #1375.
 2010-09-16 20:04:22 -07:00
Bharat Mediratta de2f9baeee Add a link to 
http://codex.gallery2.org/Gallery3:Choosing_A_Graphics_Toolkit to help
users choose a graphics toolkit.  Fixes ticket #1372.
 2010-09-16 19:34:42 -07:00
Bharat Mediratta 5e316f78c6 Restrict viewing user profile pages to registered users only, but 
provide a "show_user_profiles_to" setting to allow admins to open it
up to everybody (choices there are "registered_users", "admin_users"
or "everybody").  Fixes ticket #1378.
 2010-09-16 15:17:00 -07:00
Bharat Mediratta 70f15c6662 Add ability to sort albums by name. Fixes ticket #1377. 2010-09-14 19:51:43 -07:00
Bharat Mediratta 4b8d6beb5e Report the graphics toolkit in the platform block. 2010-09-14 19:40:54 -07:00
Bharat Mediratta 1a0d76c43e When moving a single item, just copy its permissions from its parent 
album.  This is totally legal since an items permissions must be the
same as its parent's, and it's much faster for large installs where
a complete recalculation can be very costly.  Should fix #1360.
 2010-09-13 22:23:09 -07:00
Bharat Mediratta 19750cb0d5 When deleting items, choose the first *viewable* peer as the album 
cover.  Normally, all items are equally viewable, but in our unit
tests we occasionally have the scenario where peers have different
viewability settings which is internally consistent although only
possible if you set the fields manually.
 2010-09-13 22:02:19 -07:00
Bharat Mediratta b08bf26d2d Ignore the private gallery settings if we're in the cli SAPI. It 
breaks the upgrader.  Fixes #1361, thanks to Romain LE DISEZ.
 2010-09-12 14:34:49 -07:00
Bharat Mediratta a98841613a LOWER() the slug and name in the find_dupes functions since DISTINCT 
is case sensitive, but our dupe validation is not.  Fixes ticket #1367.
 2010-09-12 14:30:25 -07:00
Bharat Mediratta 19034d140e Rename the class to Item_Model_Core so that it can be overloaded. 
Related to ticket #1368.
 2010-09-12 13:35:50 -07:00
Bharat Mediratta f84c4a6192 Uniqify the name and slug when we move an item to a new location with 
a conflict.  This fixes #1364.
 2010-09-11 23:37:12 -07:00
Bharat Mediratta b4fb11f8d5 Only call $theme->item() if we're in a non admin theme. 2010-09-11 21:40:57 -07:00
Bharat Mediratta bfd92ac6f2 Use $theme->item() instead of $theme->item, otherwise 
isset($theme->item) may return true even when we don't have an actual
Item_Model in there.
 2010-09-11 21:38:46 -07:00
Bharat Mediratta 14ae1fde25 Use the actual csrf token, not the placeholder (url::site doesn't 
replace that).  Fixes ticket #1361
 2010-09-11 10:41:47 -07:00
Bharat Mediratta 34a71e7cd3 Verified. 2010-09-11 01:48:44 -07:00
Bharat Mediratta 509b647c65 upgrader/index does not require CSRF 2010-09-11 01:48:26 -07:00
Bharat Mediratta 67f45cfa78 Add CSRF protection to the upgrader. And update the CLI output so 
that it tells you which modules failed to upgrade properly.  Fixes
ticket #1359.
 2010-09-11 01:46:45 -07:00
Bharat Mediratta 5892712b23 If the user is not an admin, don't 403 -- instead just redirect them 
to the root album.  Fixes ticket #1356.
 2010-09-10 23:01:47 -07:00
Bharat Mediratta cbb6967405 Detect out-of-date modules and put up a message for site admins. 
Fixes ticket #1353.
 2010-09-08 20:59:40 -07:00
Bharat Mediratta 391a90e3ce Detect when a module fails to upgrade properly and put up an 
informative message to help the user know that she needs to get a
newer copy of the module.  Fixes ticket #1189.
 2010-09-08 20:36:22 -07:00